From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBF6BC54E67 for ; Wed, 27 Mar 2024 21:31:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 031506B008C; Wed, 27 Mar 2024 17:31:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EAC266B0092; Wed, 27 Mar 2024 17:31:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4CB26B0095; Wed, 27 Mar 2024 17:31:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B865A6B008C for ; Wed, 27 Mar 2024 17:31:38 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7C4A9403F1 for ; Wed, 27 Mar 2024 21:31:38 +0000 (UTC) X-FDA: 81944115876.06.4B1DFE1 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf16.hostedemail.com (Postfix) with ESMTP id A4CA4180012 for ; Wed, 27 Mar 2024 21:31:36 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Da1UU3X1; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of 3N5AEZgcKCKAYUANCHUGOOGLE.COMLINUX-MMKVACK.ORG@flex--yuanchu.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3N5AEZgcKCKAYUANCHUGOOGLE.COMLINUX-MMKVACK.ORG@flex--yuanchu.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711575096; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LB+v0i5rcgoLcT2egvPDfe+7I6p18e+cGMfRHtt3nUw=; b=3pCEinTpyjJ+5oYpZN5E1+cJSJL9f8I23z8H5TRPaoDt0o2KAiDMKC8hlr3iIpeIxXAamu gGNCgMzjCEIO1jYU/FaqlNv1OROyT5X7lAE8KiOzyioozyLGotMTHQKzryBPZzbo1h/Xpt sc6+jtQ+lDd8GC1l2OO0J3J0gfKrfBc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Da1UU3X1; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of 3N5AEZgcKCKAYUANCHUGOOGLE.COMLINUX-MMKVACK.ORG@flex--yuanchu.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3N5AEZgcKCKAYUANCHUGOOGLE.COMLINUX-MMKVACK.ORG@flex--yuanchu.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711575096; a=rsa-sha256; cv=none; b=UMvtZyfYujNDMyLEXrtCsg5fDlNRb8GUWMmkzOKLdQ8nKq3sNIzzKoBeONKIqbDsv7RXw7 OPN/8OCnqN+oEST7BnzDTJ4XDzbqKT8+OWzRzHLhU+5YJPR28DPnav3xvRiGNkXjmVDYyc Pdfe+KDDPlQQGphblRdZLBO8FM/MAOU= Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-dbe9e13775aso414374276.1 for ; Wed, 27 Mar 2024 14:31:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711575096; x=1712179896; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=LB+v0i5rcgoLcT2egvPDfe+7I6p18e+cGMfRHtt3nUw=; b=Da1UU3X1ZXg2HQa9Pu1KpcmoNY5tO5DkUPl1NzYtsFsiY0M8DCtJALCB2eeRcJ4rXR o3Hr/ra1C95s6jMbBvd/8VLFW+hTjvCm3ipW9lkzz54pGUxijsUK5PQfmpbH9YWn72vr RmMkcFKSs8fVadQ2o/lmm4sLAgpPO++3GTNx1+qM61RlH79CNLGx+Yr0yGI11WrxTiKq ymPxcofS2cPqK9/LhrqY+XEC+Y9xu0lRXcAQwhTQDCiQCE4t1C0/qQFW8FdOBlybCaNa OizKxyYlQYhn5jOyF3UYSXkkcTkFbanh3WfrU33tybSVSbuUHmLR6PcYvQmG4dFefpmq KaMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711575096; x=1712179896; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LB+v0i5rcgoLcT2egvPDfe+7I6p18e+cGMfRHtt3nUw=; b=DHev35QKlk9d1DOWPX7aDQ9AK9VGdWm9uN4vBTSGHHikVHpfyRaRCU9mVJrY8LrjAz D4F7JcOIYEyVQV3JDYQEZ19PuT4RXxykhWGapSP5dYF/pBxYgms1p5nRKUGBKPU7MBBH 0d2jn2BPYDISdAfTQpCq+GeF3DHs9sXzhAlXS1n1GygBrxVuqccPpDcvNsekJK27MP6B W7L6TBc3XW4Gv2TYlWS02bPy3JPoutJlYPKJqiNWPi+Cm/bmkkUXQws/MVLqTCG4jZ7v X/7NcZ7m/TpzIW62Nuv71NFJdpDoApTAnh+6Rn1Ox9e9mb8aj2lF02X7GFG7BYRgXKoJ wZqw== X-Forwarded-Encrypted: i=1; AJvYcCXXsxvCAjPjm/HqcEjySlDqrviUEdp6xVUsHW4iOpgJ9/ReDXO4LJJTfg0g4zH2+lJaocTqC8HereDiQnqyqwkDuIU= X-Gm-Message-State: AOJu0YyMhczYZXttt277mOIy11TSqJ/kQEv7/EttlHnO3AhpMKN9ilzr QQPpWxBOzJ0EDqvxQP9YdGzNyz3DkwtVaN1Rt2DZ+ue01gmMrSyT/R1o42rdxbfc/pJMxS/RTFT zU15S5A== X-Google-Smtp-Source: AGHT+IHMceXyiMQRNVP1E9sG9l7GvMJZx9fuMZnRf4fjgo+ewu4QirMYVr1TGSmtvsHYoxnOh9k/JVnZeT/d X-Received: from yuanchu-desktop.svl.corp.google.com ([2620:15c:2a3:200:6df3:ef42:a58e:a6b1]) (user=yuanchu job=sendgmr) by 2002:a05:6902:2183:b0:dc6:53c3:bcbd with SMTP id dl3-20020a056902218300b00dc653c3bcbdmr314870ybb.7.1711575095837; Wed, 27 Mar 2024 14:31:35 -0700 (PDT) Date: Wed, 27 Mar 2024 14:31:03 -0700 In-Reply-To: <20240327213108.2384666-1-yuanchu@google.com> Mime-Version: 1.0 References: <20240327213108.2384666-1-yuanchu@google.com> X-Mailer: git-send-email 2.44.0.396.g6e790dbe36-goog Message-ID: <20240327213108.2384666-5-yuanchu@google.com> Subject: [RFC PATCH v3 4/8] mm: report workingset during memory pressure driven scanning From: Yuanchu Xie To: David Hildenbrand , "Aneesh Kumar K.V" , Khalid Aziz , Henry Huang , Yu Zhao , Dan Williams , Gregory Price , Huang Ying Cc: Wei Xu , David Rientjes , Greg Kroah-Hartman , "Rafael J. Wysocki" , Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Shuah Khan , Yosry Ahmed , Matthew Wilcox , Sudarshan Rajagopalan , Kairui Song , "Michael S. Tsirkin" , Vasily Averin , Nhat Pham , Miaohe Lin , Qi Zheng , Abel Wu , "Vishal Moola (Oracle)" , Kefeng Wang , Yuanchu Xie , linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A4CA4180012 X-Stat-Signature: zp9dxdo63at7pa6qd3aqbmnfsgx87hxb X-HE-Tag: 1711575096-304731 X-HE-Meta: U2FsdGVkX1/WQ0x0Hb807UcxqrIH2X+96SRoN8kx1IB/WZX7UlcyRV5uFJwzlAlMaC80gzjFPlDwtzgK7QQaeV8GBtRHKfiGabiP3euJxVf+zPqZgnhk6FH38ebHc8+7Gk0TYrDDs1Zez/oKA5OdVCejIfweHAOQ0jg+cucfjKvZRwmrATOrzBhc+JlnWiwH2gUo0qyQJ+tjFY2QGKAQmW5wg5sU53vfWIjVhD9S7I3HfkR4TGBeFfhU/4rrm3LAdCvzbV6TAK8MuKuiIvjhsu7CvC2rBt53k3PsdTFcOpsHRc7gBgNpkRLB/FZcXtcTlVNKqv/rCOo5dXrnm2raiY8fFhogaCQDfPCo9V79KYFtXnoRslEd7/W8B0yKHiDs9GYg4ZDUonuAC3L282ONJdJ4w39CUMeK/64lfdI9D7F+QAoCgozcanMvieeZ9J2+BHhjGtXxvfRB/4u8uC+fpYABJTDBKnlyu2PUBMAt5CUHcaLyAkTFKWI9JjpX6xkCPlmvsg1mjXrcu3etr+j9cS0gdrNYmFPq9DRUYS4onEWjW9w4VTZqTdkFgo5KY7vubFlg49QOHZ3Y2z0q3tDcjoyn9F9mirHA4ukCvx9EYK8Yiu0V5CxFDMHOIB/qJ4SO6vH5A7OjfuVxa9uzv71mjDe/ewce5ne7v8U9i/vm6fBoP7FE9Eehv+b0AxpPt8flEImFGAMMX2siWAS2DDG8dRQB5o9SVQTwV9v3Few+ooRhnNOimdW/roKTKJoEF/mc0Mpc6ieHrvl3Jhe8NoAttYnQ5c/fYvRx6XGFQNsdODJT9TffERe+onZtz2wNXY3V7FDOCrZw3RyQPngWa4AXNpXlLTszn9b7Ayn/P5cENeJa8Dz3C1FBMQ2Tvd3uWXsh9UDp1pPUW4BNCjEJteHe81NYrWEVSGC3A9oBNGdKilHBJxnGqDcnGNvmJnZNIX4Sh/U5bXl+UiwKfPKWdpY WmZbfzrc f52usUOQpGP2GbWwYp4sjYKTTIn8igN+KCaZuNuvZnONaXwxP7/eD+S/5uDCjJIauc1pdrgYebgmSYhGr15AWLPPSVqXdLjPlPEv6gDX6tLgWZ2aadNolJq0XWrWD+dmB7O0z10RIHcOzEA9juCqGOraTx6PBlg8goC4OSqRIHzkq+ojKtkpTclRVM5xFC+3i0ohl47I18Nu3JRscTwoh2rNYgkr+B3Wo6VHFjSglDd/fZ7kwDAZEScYU3fx+G8JOJ53HsGy10z2vDuFbVxBwDlA/GDEyZN6cO1AHYJChgXbO1LFPGAnGc5IBXZQ1ZiYaeMelmp39k1Umay28dJ+Onk600ElZcin0Yxa/Zsuky9s23RsQwwMqHYw/gpGSA+Gm5hPomNi1rABPrq42X1Mz2Q66sSueiIeQzqi/EQEn54PwyMYRx8RjeXklM2Yv7trXukSyW4c74dBGOsSelYibGHnKcahAy8NTBEtA+9PpWFbBEDBfJY4G8zTnQdzrdXgWqSORsxvnnAz0x9mS73mApvGJzH/QvoAisZxohSyeqYb89VhsDuTiWykRJP10gBz6gaJBZ9Ze17Z3BH0gjtrCh00wpzb2uZwTgldf+NJ9Y40BfTucxSlpqteeAsWSZ9AkZsuyBCTpWzhbnOfc+ihAx83Kjg5PaFZMfeHVbxBse0s9+NfL0IhFxkX2dw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When a node reaches its low watermarks and wakes up kswapd, notify all userspace programs waiting on the workingset page age histogram of the memory pressure, so a userspace agent can read the workingset report in time and make policy decisions, such as logging, oom-killing, or migration. Sysfs interface: /sys/devices/system/node/nodeX/workingset_report/report_threshold time in milliseconds that specifies how often the userspace agent can be notified for node memory pressure. Signed-off-by: Yuanchu Xie --- include/linux/workingset_report.h | 4 +++ mm/internal.h | 6 +++++ mm/vmscan.c | 44 +++++++++++++++++++++++++++++++ mm/workingset_report.c | 39 +++++++++++++++++++++++++++ 4 files changed, 93 insertions(+) diff --git a/include/linux/workingset_report.h b/include/linux/workingset_report.h index 23d2ae747a31..589d240d6251 100644 --- a/include/linux/workingset_report.h +++ b/include/linux/workingset_report.h @@ -35,7 +35,11 @@ struct wsr_page_age_histo { }; struct wsr_state { + unsigned long report_threshold; unsigned long refresh_interval; + + struct kernfs_node *page_age_sys_file; + /* breakdown of workingset by page age */ struct mutex page_age_lock; struct wsr_page_age_histo *page_age; diff --git a/mm/internal.h b/mm/internal.h index 151f09c6983e..36480c7ac0dd 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -209,8 +209,14 @@ extern void reclaim_throttle(pg_data_t *pgdat, enum vmscan_throttle_state reason /* * in mm/wsr.c */ +void notify_workingset(struct mem_cgroup *memcg, struct pglist_data *pgdat); /* Requires wsr->page_age_lock held */ void wsr_refresh_scan(struct lruvec *lruvec, unsigned long refresh_interval); +#else +static inline void notify_workingset(struct mem_cgroup *memcg, + struct pglist_data *pgdat) +{ +} #endif /* diff --git a/mm/vmscan.c b/mm/vmscan.c index 5f04a04f5261..c6acd5265b3f 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2535,6 +2535,15 @@ static bool can_age_anon_pages(struct pglist_data *pgdat, return can_demote(pgdat->node_id, sc); } +#ifdef CONFIG_WORKINGSET_REPORT +static void try_to_report_workingset(struct pglist_data *pgdat, struct scan_control *sc); +#else +static inline void try_to_report_workingset(struct pglist_data *pgdat, + struct scan_control *sc) +{ +} +#endif + #ifdef CONFIG_LRU_GEN #ifdef CONFIG_LRU_GEN_ENABLED @@ -3936,6 +3945,8 @@ static void lru_gen_age_node(struct pglist_data *pgdat, struct scan_control *sc) if (!min_ttl || sc->order || sc->priority == DEF_PRIORITY) return; + try_to_report_workingset(pgdat, sc); + memcg = mem_cgroup_iter(NULL, NULL, NULL); do { struct lruvec *lruvec = mem_cgroup_lruvec(memcg, pgdat); @@ -5650,6 +5661,36 @@ void wsr_refresh_scan(struct lruvec *lruvec, unsigned long refresh_interval) } } } + +static void try_to_report_workingset(struct pglist_data *pgdat, + struct scan_control *sc) +{ + struct mem_cgroup *memcg = sc->target_mem_cgroup; + struct wsr_state *wsr = &mem_cgroup_lruvec(memcg, pgdat)->wsr; + unsigned long threshold = READ_ONCE(wsr->report_threshold); + + if (sc->priority == DEF_PRIORITY) + return; + + if (!threshold) + return; + + if (!mutex_trylock(&wsr->page_age_lock)) + return; + + if (!wsr->page_age) { + mutex_unlock(&wsr->page_age_lock); + return; + } + + if (time_is_after_jiffies(wsr->page_age->timestamp + threshold)) { + mutex_unlock(&wsr->page_age_lock); + return; + } + + mutex_unlock(&wsr->page_age_lock); + notify_workingset(memcg, pgdat); +} #endif /* CONFIG_WORKINGSET_REPORT */ #else /* !CONFIG_LRU_GEN */ @@ -6177,6 +6218,9 @@ static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc) if (zone->zone_pgdat == last_pgdat) continue; last_pgdat = zone->zone_pgdat; + + if (!sc->proactive) + try_to_report_workingset(zone->zone_pgdat, sc); shrink_node(zone->zone_pgdat, sc); } diff --git a/mm/workingset_report.c b/mm/workingset_report.c index 370e7d355604..3ed3b0e8f8ad 100644 --- a/mm/workingset_report.c +++ b/mm/workingset_report.c @@ -269,6 +269,33 @@ static struct wsr_state *kobj_to_wsr(struct kobject *kobj) return &mem_cgroup_lruvec(NULL, kobj_to_pgdat(kobj))->wsr; } +static ssize_t report_threshold_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + struct wsr_state *wsr = kobj_to_wsr(kobj); + unsigned int threshold = READ_ONCE(wsr->report_threshold); + + return sysfs_emit(buf, "%u\n", jiffies_to_msecs(threshold)); +} + +static ssize_t report_threshold_store(struct kobject *kobj, + struct kobj_attribute *attr, + const char *buf, size_t len) +{ + unsigned int threshold; + struct wsr_state *wsr = kobj_to_wsr(kobj); + + if (kstrtouint(buf, 0, &threshold)) + return -EINVAL; + + WRITE_ONCE(wsr->report_threshold, msecs_to_jiffies(threshold)); + + return len; +} + +static struct kobj_attribute report_threshold_attr = + __ATTR_RW(report_threshold); + static ssize_t refresh_interval_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf) { @@ -412,6 +439,7 @@ static ssize_t page_age_show(struct kobject *kobj, struct kobj_attribute *attr, static struct kobj_attribute page_age_attr = __ATTR_RO(page_age); static struct attribute *workingset_report_attrs[] = { + &report_threshold_attr.attr, &refresh_interval_attr.attr, &page_age_intervals_attr.attr, &page_age_attr.attr, @@ -437,6 +465,9 @@ void wsr_register_node(struct node *node) pr_warn("WSR failed to created group"); return; } + + wsr->page_age_sys_file = + kernfs_walk_and_get(kobj->sd, "workingset_report/page_age"); } EXPORT_SYMBOL_GPL(wsr_register_node); @@ -450,6 +481,14 @@ void wsr_unregister_node(struct node *node) wsr = kobj_to_wsr(kobj); sysfs_remove_group(kobj, &workingset_report_attr_group); + kernfs_put(wsr->page_age_sys_file); wsr_destroy(mem_cgroup_lruvec(NULL, kobj_to_pgdat(kobj))); } EXPORT_SYMBOL_GPL(wsr_unregister_node); + +void notify_workingset(struct mem_cgroup *memcg, struct pglist_data *pgdat) +{ + struct wsr_state *wsr = &mem_cgroup_lruvec(memcg, pgdat)->wsr; + + kernfs_notify(wsr->page_age_sys_file); +} -- 2.44.0.396.g6e790dbe36-goog