From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01C85C54E67 for ; Wed, 27 Mar 2024 21:31:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 621716B0083; Wed, 27 Mar 2024 17:31:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D2CE6B0085; Wed, 27 Mar 2024 17:31:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 424D76B0088; Wed, 27 Mar 2024 17:31:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 23AAF6B0083 for ; Wed, 27 Mar 2024 17:31:33 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D32B11A0403 for ; Wed, 27 Mar 2024 21:31:32 +0000 (UTC) X-FDA: 81944115624.22.75D5250 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf11.hostedemail.com (Postfix) with ESMTP id 0AF1040014 for ; Wed, 27 Mar 2024 21:31:30 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=SOR3vBJW; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of 3MpAEZgcKCJsTP5I7CPBJJBG9.7JHGDIPS-HHFQ57F.JMB@flex--yuanchu.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3MpAEZgcKCJsTP5I7CPBJJBG9.7JHGDIPS-HHFQ57F.JMB@flex--yuanchu.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711575091; a=rsa-sha256; cv=none; b=BadnB7G/+XhcZpAgd9pyG9Y/Jnoyd2o1tqchzo4iuQs8tto4ylHmHrfgWklPmjNR6UK2nN pRpGWyIvKkh2qWm2pF3+aNTUD7WxF+hdjTiNgMwwZyyE4ygqH7bVVkUxxwQBHI5Y4K22Na b7fkimJTMy5O3pEpDEOZIb1QqJriM9g= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=SOR3vBJW; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of 3MpAEZgcKCJsTP5I7CPBJJBG9.7JHGDIPS-HHFQ57F.JMB@flex--yuanchu.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3MpAEZgcKCJsTP5I7CPBJJBG9.7JHGDIPS-HHFQ57F.JMB@flex--yuanchu.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711575091; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J7Eobqr0LFBQ4KWjEX1Ii2cj/j9a00dqkQu19UHFfuM=; b=Vl2iQ4YgN4x9SUu1dqhsRCUhlMSyVaYZskL7COc9M2i0npS3dc7GQA/8l/7/dghQB153L3 K0utfPwffZYVYMHHs4xgqEhrC1JeDmc02HibeM2V1stja31HH5j80cmxrAK2gWWKW6ym1l dlfNlkeHqFxrHP9Qc4/GaqTq9KMqSQ0= Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-dd169dd4183so335757276.3 for ; Wed, 27 Mar 2024 14:31:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711575090; x=1712179890; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=J7Eobqr0LFBQ4KWjEX1Ii2cj/j9a00dqkQu19UHFfuM=; b=SOR3vBJW9rtlPwMVHg101mgYQM9mOBR+twEIaPoVHUIjOUYLGHXotjHmYaHWIFiKKi hbVqX0RNnbtiPA/9qVDYNoguFFxx+2vngI8QiY/gBBYSUvYTCVE55b9abCuxfHORiEBc GRz/QdYspWT+nZXnLmwRy2tQjFv0tLguz7GG4bLQI8ziT3C8MNTUc7F1TP30HzedtbbJ hA1ER+bTfgVEkbky9XmtD/+fUUGReJtTzLNLfXpB4WAcQO/Yeo3ocOb/WCctZUNqBW2u Y0a9G0zJd+m4T/L6xfe6fe5NRxM315e9DM0TsAQIcvwp5CkGgaUG2EdB3bGzASnNthWS 7e4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711575090; x=1712179890; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=J7Eobqr0LFBQ4KWjEX1Ii2cj/j9a00dqkQu19UHFfuM=; b=f5hnETj9hrZZS+omxr4hey61ogq9nuBTo7Q5ViiWF1QFQY1n39qABKV4VctnD1cM4C AQzG7m+/aXOyF4sSaFKJnbCmniAvmx4Ehg+RlRkok5H1KaF227W91Fz+Zw0k3M6Eqb3q xUYC7jQdK/tuyvrD6NbLJkIUlJA+GYKL5D0n0yUAtNMbMFr1YgagsuSB4ARUg2jX9oFo sPz7UZ1L/63i7Sz5ujZxZRt+W0TdBWFLp2+pM7L5nPQIqqi4w/HJxb2gb28a4i5ISldW 9DysZ4YPRAe+HpjAnJpo/ekSh+9D5pn2NXtP0jXIsEE2jKVeOsiPgCGQCVwm9PlWQ0DJ 28/g== X-Forwarded-Encrypted: i=1; AJvYcCVm7DkqUuBDv955XCPc0EO7SV0cyai1WO0nObiuDaON8BjnBn08ptKr79B489877KqZ9t2goYt5ZNHyAcVM0mx+OVQ= X-Gm-Message-State: AOJu0YzisSxIWAipsVF2u4TIRwEKFMW9CPvE9hgi93AIxAoV+KMOzHvK QYvDValsSnhsxSoTZyKMMYrbgyMrz+a0eabB00RF8+URP/WCHqMoQhHhvdu/4I3aPVXx2x02QOW R4uHumA== X-Google-Smtp-Source: AGHT+IEtjKFm0aB/GkGE7TLyxEpzw6bgXLiicKkfzUR/Ki0/1kiBkWenomFbSpLy63KHaGIYhCLu0OSP/VuU X-Received: from yuanchu-desktop.svl.corp.google.com ([2620:15c:2a3:200:6df3:ef42:a58e:a6b1]) (user=yuanchu job=sendgmr) by 2002:a05:6902:2311:b0:dbe:d0a9:2be8 with SMTP id do17-20020a056902231100b00dbed0a92be8mr116972ybb.0.1711575090119; Wed, 27 Mar 2024 14:31:30 -0700 (PDT) Date: Wed, 27 Mar 2024 14:31:00 -0700 In-Reply-To: <20240327213108.2384666-1-yuanchu@google.com> Mime-Version: 1.0 References: <20240327213108.2384666-1-yuanchu@google.com> X-Mailer: git-send-email 2.44.0.396.g6e790dbe36-goog Message-ID: <20240327213108.2384666-2-yuanchu@google.com> Subject: [RFC PATCH v3 1/8] mm: multi-gen LRU: ignore non-leaf pmd_young for force_scan=true From: Yuanchu Xie To: David Hildenbrand , "Aneesh Kumar K.V" , Khalid Aziz , Henry Huang , Yu Zhao , Dan Williams , Gregory Price , Huang Ying Cc: Wei Xu , David Rientjes , Greg Kroah-Hartman , "Rafael J. Wysocki" , Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Shuah Khan , Yosry Ahmed , Matthew Wilcox , Sudarshan Rajagopalan , Kairui Song , "Michael S. Tsirkin" , Vasily Averin , Nhat Pham , Miaohe Lin , Qi Zheng , Abel Wu , "Vishal Moola (Oracle)" , Kefeng Wang , Yuanchu Xie , linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0AF1040014 X-Stat-Signature: 9fbnj1auhfa4jesap5fdyiz75t9qkbia X-HE-Tag: 1711575090-162338 X-HE-Meta: U2FsdGVkX18wdF69okWJLDc741SdyKXtbgO/J/5EITEvLgMHRnmFmusxQfK6gbBL0fWIEhXC75uFB+GKle6ULF65tPKuFBMwwEEBD3dHTT0vjAlPbA08p3gVmbXoEQXdGlCl5Au0i6rQkeHDcyPJ4ttI4kuygfEN96y7u3oEjJqjVCXtayUKAx4QcRZyw01kY2UMiUK2Y/LA+UdkEeeqekWNDgwZ1E2wTDi4TK9ZZk2DureBN3v8OWZzfb7o1B9LM0elDuozXwJiykHxRu0mWvGx2u4cdC7h8UpWz6KdLlE+bpYxeFC5JfV/3ivHuJTxZySE56d9CQOUo8Qf4AWzmYyM3PVKa+3GjUL2J1L3Jt+r97JDFGAKz9b5Ihe9Vxw3g4KEuZiAWV/J0fmuQG9XWoF5l6KNHpOwcK5tuYXKX+aTT1IktsKNg8/cVsdHgI3fcwyyZofKV4cqTT4hWWM49Oq1r714VUlaMz0XUUmbuGLBuZ5mAz0bxkzHR9cMWgUHYnd3dq7OlgjBC0jpMwEtm86F2S7qfZS3qwcK8umxtDKixLXzS6MB7E7bdio4lcD2vAQJ5EU3wKzT3707pVh85rmTVA1ECFKg7CYZdKUA2NFUpp4aomG/fxwPwvbdY/DRLBnbJirZIpKPN/pBtQytSaqJrvqwA+0r5O8ywfckEOMmtcWGOjr6x5KOxmt8DsVbFnuW6Y7frbo3hPqnvrp47AzY8Ks7sH148yEYngLS8Q0eCnFCG2PRtHbuHTTR8S0BrjW1auNJ1Ii4gGtUyBjN1qaiqkGyvNCRE4dz367qflmOYzZaRfTyZjeF/vkIw3RRq2WrIRui8kYew2KNeEkRqOwkA9EpgheWWvViXPooQAl4z4Lk5L4dRseNr8sVKsl1wRjtCnc0zeiVosKZjP6GNr2NFrf6MDDF57PicqyH9vOtn4HQSMln6BUyfYEpyTAOI1tq1VUir0C53OEFcPi RsP7gbFi exFEOwViT42l1jgjoR/RbSO8UeEMECoz9G5CrAKXSLUfXOyu1HeTqdB7EW+cq77T/w4es3rdEh3YeuNKZWQyQHewhktBsw40Ghq9VHmKnj4jT2nfQC9y0ZP+PgdtUtMdSWvtG86NnEVsgPIHTk+WpKLdVGFPk1wUOB60m8t8Y33mYiKvruizgpBNskPG/izksf9pCbO5M8IUNNIRRCld0bQ6dPQ1MYnq2zC89q1VNbe/LnUkNpl6WybIN7Ee6j/dDMz2bThTwDCdl1oFfupdO6gzickqQmhm0rsHS5BK6Wi2kdGrJ3u3PN3h42qvCaxxcVCiXdS/jWbvS/cYQugNI55HIcsrkiE0Xyg+DfN6T98yzXqFAVjfuR2nkMUOtqVxT7SId+YKjpCo0iZoLiA+aY0B+vTji+wHlDDw7W7JFfjRfy4t+DspUgNJyv2I9w699vbMoxKk1Uz249YDowg2+WVKIDVXKU0DpeVOlajUp9vx9NB0XNlJemZ6dA6UprTnTD3QiPUhE/gG5os/J/uFf5YskaIK4O2a/AHBhIO5vDwbfd2xR7LZG45vbpkzzrWgYqv8PovGF4oBg+EbkkmlU+b1/84tXnVfigsvF8VDmJtAwKdBlGixdt+k/5z3bUPelYmqbIC2RsSfHVh4Zb9U5QY0f78mfE3eWbrPUE4w8r3lcYoNea3FwtACu3QIvgzh2HSJ7kVCGknhdNOp+Edr7VCToVgdfKiieUt0OhdXCA5vg3Ic= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When non-leaf pmd accessed bits are available, MGLRU page table walks can clear the accessed bit and promptly ignore the accessed bit on the pte because it's on a different node, so the walk does not update the generation of said page. When the next scan comes around on the right node, the non-leaf pmd accessed bit might remain cleared and the pte accessed bits won't be checked. While this is sufficient for reclaim-driven aging, where the goal is to select a reasonably cold page, the access can be missed when aging proactively for measuring the working set size of a node/memcg. Since force_scan disables various other optimizations, we check force_scan to ignore the non-leaf pmd accessed bit. Signed-off-by: Yuanchu Xie --- mm/vmscan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 4f9c854ce6cc..1a7c7d537db6 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3522,7 +3522,7 @@ static void walk_pmd_range(pud_t *pud, unsigned long start, unsigned long end, walk->mm_stats[MM_NONLEAF_TOTAL]++; - if (should_clear_pmd_young()) { + if (!walk->force_scan && should_clear_pmd_young()) { if (!pmd_young(val)) continue; -- 2.44.0.396.g6e790dbe36-goog