From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62AACC54E67 for ; Wed, 27 Mar 2024 07:27:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13CC76B009B; Wed, 27 Mar 2024 03:27:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0EC3F6B009C; Wed, 27 Mar 2024 03:27:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC6DE6B009D; Wed, 27 Mar 2024 03:27:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DDC356B009B for ; Wed, 27 Mar 2024 03:27:35 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id ADF71C06D2 for ; Wed, 27 Mar 2024 07:27:35 +0000 (UTC) X-FDA: 81941988870.24.AFDD3AD Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by imf10.hostedemail.com (Postfix) with ESMTP id D63E0C000C for ; Wed, 27 Mar 2024 07:27:33 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=ealf6GAL; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf10.hostedemail.com: domain of horenchuang@bytedance.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=horenchuang@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711524453; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fvdqGcDUWp3D4k7+aVnVSTSeWYL78OJhC3HPSf53QMU=; b=baNGshJL3r09AYXP9VWGjA49aIR1MZumtS1sHOTC6q684cn4LmVb3plkAZq1vvayJdj8Jk aCodKseAmGBiw+5QCD31/E0aO12FXp0XXeQ77lFkOCK3ucPxHF2xL6vq8ZA91sF3iEIlD9 7pkOP8cFRfe2Uqk71K/PYNcgs7Rj1UY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=ealf6GAL; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf10.hostedemail.com: domain of horenchuang@bytedance.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=horenchuang@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711524453; a=rsa-sha256; cv=none; b=FXMWAvfnJiBw/5L6Rn6escGdc9+KAEwMouPI+LQOP87xFbTO7653lfIg1roJrVkNRPlxSB 8qLxWtJapay6JzBAoL58SUNygBnFANgHBeCkAjbcJpxkZHSnr3vqXCao584QqfdjaVYWO2 po9VNJpt9lmvtyvnuyPUt3Prlb+GqEI= Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-43107ccd7b9so40709581cf.3 for ; Wed, 27 Mar 2024 00:27:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1711524453; x=1712129253; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fvdqGcDUWp3D4k7+aVnVSTSeWYL78OJhC3HPSf53QMU=; b=ealf6GAL+RaGO61IPnzHpNkiB39wCm4Lvvp+n4s5ACIfrWgr5pmWvoDp9P3Hybd/fk 0FxF/w026P3lYsKRFnr+I1JM/7y66l0mYh/ph4HEKUPcBjc3v7RBPKMEBPl5nVwd0qCP IadGKJsbMn59mk34IU36Wic6VrNRT2yxyabHpFAvY6V+efpX6zUrrNG+2lklrJM4+FFN GQ1AeZsqHwKIxxs6DvcZOuv51mCWBerGcCx4VQJIMBLjlxKaZ7YnDN+Nrpc7wMiNRp0C SfkjhqQZAfglmiHLA/VsLIW07oOoenwaIg2hEVGTMyP72QceXEYBBzBDODgI4fpekt01 8HDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711524453; x=1712129253; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fvdqGcDUWp3D4k7+aVnVSTSeWYL78OJhC3HPSf53QMU=; b=Hpa0D3we3rxl3/tgoN1T24+4P7IJIglr6lKriOUwk1mQNDe41KxBqRuoFtEqhuPEtr +JYVYEEeZ3SzRAYc3JQmyGJbJ0Yx0VQ4vjDFl7772IpemynotEfwsbmv42bc/+AK00TB X9ksWFwYU/l1yWOVdhM1cO6LOmGkdpuSmRvlCgSWwE2StHLWq8m/+Q8vA9GTfDHn3sIg kbmnMx4VBQ6/u1AZ9RTsGHN6dWAAjV48Sms1A/6Al9D0owIFDeA0pGMM7QIcW2UxE81t 0cpFaSRtSME2POPgbxLek8oFpHwp5xV5ISJRxYHyocBwaTCbhddXxzFRWp5sdpzWGqZf oJ5Q== X-Forwarded-Encrypted: i=1; AJvYcCW/0ODbPYMGC3F41BgJ40gESBuZMbrp3n2HP2TJ6FdAMvQEM2dBDwUm1xfUzQArmNefy2HLBDMvOR5tCMuYaYhdve8= X-Gm-Message-State: AOJu0Yxog87/SnXvm3OO82FDy9kx0wSa/GJELbq+d4rerKzwJ1iGXl/D W9rhn890jjUWMT4Fv06QHDIXoWrWjC7+0CDQhICWtvHVoaGHXO6MOUdSW9gR+wP+SIoxG1SMqW+ WO6I= X-Google-Smtp-Source: AGHT+IEI0M9d2AyKg0jvWeTlX5tpwHLQC2KlAkAsKe2cbEUuq+AjdA4mRWp3a2a6xzEVmFSqeoe/8g== X-Received: by 2002:a05:622a:1450:b0:431:7c7f:411c with SMTP id v16-20020a05622a145000b004317c7f411cmr1553361qtx.49.1711524452825; Wed, 27 Mar 2024 00:27:32 -0700 (PDT) Received: from n231-228-171.byted.org ([130.44.212.102]) by smtp.gmail.com with ESMTPSA id bq15-20020a05622a1c0f00b00431604af3c1sm2383555qtb.20.2024.03.27.00.27.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 00:27:32 -0700 (PDT) From: "Ho-Ren (Jack) Chuang" To: "Huang, Ying" , "Gregory Price" , aneesh.kumar@linux.ibm.com, mhocko@suse.com, tj@kernel.org, john@jagalactic.com, "Eishan Mirakhur" , "Vinicius Tavares Petrucci" , "Ravis OpenSrc" , "Alistair Popple" , "Srinivasulu Thanneeru" , Dan Williams , Vishal Verma , Dave Jiang , Andrew Morton , nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: "Ho-Ren (Jack) Chuang" , "Ho-Ren (Jack) Chuang" , "Ho-Ren (Jack) Chuang" , qemu-devel@nongnu.org Subject: [PATCH v6 1/2] memory tier: dax/kmem: introduce an abstract layer for finding, allocating, and putting memory types Date: Wed, 27 Mar 2024 07:27:27 +0000 Message-Id: <20240327072729.3381685-2-horenchuang@bytedance.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20240327072729.3381685-1-horenchuang@bytedance.com> References: <20240327072729.3381685-1-horenchuang@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: cdixtunmyz6x91shaxeuyyrunf8hksu1 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D63E0C000C X-HE-Tag: 1711524453-92613 X-HE-Meta: U2FsdGVkX1/Ag20Z61zb0/Ht/FWAUEX1eh596aiGj561+cDdFZQX671jR0nz1Z7GCWtfnNLwfzbfNeJ3NDMBN9MPrCf14p0ukLBs8qLnpAnoeU2sTi40p0aRqbTj4iRXLTRMBmzqzHjISKwXLnSztNXj+3IF0iLRAfXCtt/LakDTChjw2nTJL8/vtnekMgRkQw9COn7PFrZwyAKzNmjvsvJbrsFNq5gOZSUEWIgmbUEWfAkb5Jng2JFYYVO0weqp71PJDO7PKIOWuVqzmm0dczXCAMQVera+4Gn8BcJXFJ6/yGoJP+n3oIsgbgKT7uNczD16yEfUlXO6CbEpUQWR5RWkWueE9BLFBLum6HR3ee54eImGCZASwzErr/pVjXJvC4sSxJ3aJNpYsjADUGqjttrj6K1LoKUQo3gZr4g4hZCTA3qSgdBBfWluZqiQkerxW/dbhTlXIN62iwr3n8yqNF7vdcByFBNfYmmH4T/clLiewNGqYklmD1ZgFHARu2zhzBbBTRuvthPa4sCl45jTGE8yNXLqBOEV23komFKcI+3WhAbNpUTQxs+5Kel6UKFGih1TC0cypo78meFtSHL/vLjAQJ4En30KUFyqSFH9+ABYlooiW50WzCg/9BZ9PR5/M0fFIKsM5d+RZ2KzQzblfMZqePPwdMLMyWipVGKO5e/fFZCttoD+AoW58Gz4RtjQp0EiD1QfrXzyy0Z0wmvW7a8wPamkwDWZj7QkOV9xD8qUhqo0UBEXvr5IRI8Xr1tT41MHJrCzfCqBaI7/HnzfzLahEBD3XsmUkUkgmysqUPDd1p87nkKGneLZB3yeBMj+TK1FMGI9QHUwycMjiUC8iPdmOf07CtHQxh69iBr9VWwgBSn6MUhrYsXoskC2zYHMIdZMkUKA3VH3LA91Lk3Qs0fhj34EOFdrVSX6FBL0ReR3ZEOSh32IF4Sh8ksPzT9NDn2yb440pR3WWDGlTx2 Ug56RH8H TWq0NMwstR7bQQ2h+81vtciZYButgFzTIOBGg1DgbT0cFVeppaLpfyFIDC5E0zb+sxuUvxon8mxrwzwRWWeZv1Mne+DDpkYZBrQnmPbcJoE12Qb0NhH0/eL5p01zXQ3PtMvE8t9T65p8n95tGLLCQ60km93CibZCRbtmQFmapMhnXyWJg/WelQ40n+Ur3WsPKbNUXTXGkAGyrv9dy2BTb8LYNS8qUgo0kxSdPmjt465QUcd0mA+bMqbvdcxBDDtZn/xTApib26koFWdPCgKQe5gPgELzcjwiNDaov6HeNCQpNVVttGFDt6NgSNLwMwx2Lg7lUttMiXMLjg4HV62bAe1HoiRH5AhMqkKWlKX8T90DWR4cCx8c/gXta5Dmv5SQiTaQmyLUhqmkmjzJjL6l1ulvHvu9efWR46Teu4y+3khVRh53qRq8dVDrJPOjWb6x0dpL4bXvF05cb4aZQZhO09rNgezhegDVWj9W8kXxWLoRtMo4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Since different memory devices require finding, allocating, and putting memory types, these common steps are abstracted in this patch, enhancing the scalability and conciseness of the code. Signed-off-by: Ho-Ren (Jack) Chuang --- drivers/dax/kmem.c | 20 ++------------------ include/linux/memory-tiers.h | 13 +++++++++++++ mm/memory-tiers.c | 32 ++++++++++++++++++++++++++++++++ 3 files changed, 47 insertions(+), 18 deletions(-) diff --git a/drivers/dax/kmem.c b/drivers/dax/kmem.c index 42ee360cf4e3..01399e5b53b2 100644 --- a/drivers/dax/kmem.c +++ b/drivers/dax/kmem.c @@ -55,21 +55,10 @@ static LIST_HEAD(kmem_memory_types); static struct memory_dev_type *kmem_find_alloc_memory_type(int adist) { - bool found = false; struct memory_dev_type *mtype; mutex_lock(&kmem_memory_type_lock); - list_for_each_entry(mtype, &kmem_memory_types, list) { - if (mtype->adistance == adist) { - found = true; - break; - } - } - if (!found) { - mtype = alloc_memory_type(adist); - if (!IS_ERR(mtype)) - list_add(&mtype->list, &kmem_memory_types); - } + mtype = mt_find_alloc_memory_type(adist, &kmem_memory_types); mutex_unlock(&kmem_memory_type_lock); return mtype; @@ -77,13 +66,8 @@ static struct memory_dev_type *kmem_find_alloc_memory_type(int adist) static void kmem_put_memory_types(void) { - struct memory_dev_type *mtype, *mtn; - mutex_lock(&kmem_memory_type_lock); - list_for_each_entry_safe(mtype, mtn, &kmem_memory_types, list) { - list_del(&mtype->list); - put_memory_type(mtype); - } + mt_put_memory_types(&kmem_memory_types); mutex_unlock(&kmem_memory_type_lock); } diff --git a/include/linux/memory-tiers.h b/include/linux/memory-tiers.h index 69e781900082..a44c03c2ba3a 100644 --- a/include/linux/memory-tiers.h +++ b/include/linux/memory-tiers.h @@ -48,6 +48,9 @@ int mt_calc_adistance(int node, int *adist); int mt_set_default_dram_perf(int nid, struct access_coordinate *perf, const char *source); int mt_perf_to_adistance(struct access_coordinate *perf, int *adist); +struct memory_dev_type *mt_find_alloc_memory_type(int adist, + struct list_head *memory_types); +void mt_put_memory_types(struct list_head *memory_types); #ifdef CONFIG_MIGRATION int next_demotion_node(int node); void node_get_allowed_targets(pg_data_t *pgdat, nodemask_t *targets); @@ -136,5 +139,15 @@ static inline int mt_perf_to_adistance(struct access_coordinate *perf, int *adis { return -EIO; } + +struct memory_dev_type *mt_find_alloc_memory_type(int adist, struct list_head *memory_types) +{ + return NULL; +} + +void mt_put_memory_types(struct list_head *memory_types) +{ + +} #endif /* CONFIG_NUMA */ #endif /* _LINUX_MEMORY_TIERS_H */ diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c index 0537664620e5..974af10cfdd8 100644 --- a/mm/memory-tiers.c +++ b/mm/memory-tiers.c @@ -623,6 +623,38 @@ void clear_node_memory_type(int node, struct memory_dev_type *memtype) } EXPORT_SYMBOL_GPL(clear_node_memory_type); +struct memory_dev_type *mt_find_alloc_memory_type(int adist, struct list_head *memory_types) +{ + bool found = false; + struct memory_dev_type *mtype; + + list_for_each_entry(mtype, memory_types, list) { + if (mtype->adistance == adist) { + found = true; + break; + } + } + if (!found) { + mtype = alloc_memory_type(adist); + if (!IS_ERR(mtype)) + list_add(&mtype->list, memory_types); + } + + return mtype; +} +EXPORT_SYMBOL_GPL(mt_find_alloc_memory_type); + +void mt_put_memory_types(struct list_head *memory_types) +{ + struct memory_dev_type *mtype, *mtn; + + list_for_each_entry_safe(mtype, mtn, memory_types, list) { + list_del(&mtype->list); + put_memory_type(mtype); + } +} +EXPORT_SYMBOL_GPL(mt_put_memory_types); + static void dump_hmem_attrs(struct access_coordinate *coord, const char *prefix) { pr_info( -- Ho-Ren (Jack) Chuang