From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45DAAC54E67 for ; Wed, 27 Mar 2024 04:16:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4777C6B0082; Wed, 27 Mar 2024 00:16:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 400066B0083; Wed, 27 Mar 2024 00:16:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B68C6B0085; Wed, 27 Mar 2024 00:16:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 069856B0082 for ; Wed, 27 Mar 2024 00:16:55 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8AB704060A for ; Wed, 27 Mar 2024 04:16:54 +0000 (UTC) X-FDA: 81941508348.13.972CC85 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) by imf22.hostedemail.com (Postfix) with ESMTP id B90FEC0009 for ; Wed, 27 Mar 2024 04:16:52 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=A+fHo3NH; spf=pass (imf22.hostedemail.com: domain of horenchuang@bytedance.com designates 209.85.222.177 as permitted sender) smtp.mailfrom=horenchuang@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711513012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fvdqGcDUWp3D4k7+aVnVSTSeWYL78OJhC3HPSf53QMU=; b=ljhcQmlJOqdUvfiZOcUWBjU4EeAx6uwfvH4zc+46GP1jjE49ttniahwsosoAtTDBw8iLg7 izT1O3nABpr9A91xWMbwQqXX+ZfGvrFTfIaTbXfrbh5MVfo4o1AuRBz0oBn9xxN4ZhNQj5 Y66C3BRgPxbEIjFWOHn6RA4r1d2uAhk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=A+fHo3NH; spf=pass (imf22.hostedemail.com: domain of horenchuang@bytedance.com designates 209.85.222.177 as permitted sender) smtp.mailfrom=horenchuang@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711513012; a=rsa-sha256; cv=none; b=LXwgznOgNBkywSPOwi/x/ejq+8soGej5rhUKUZzfJEeQZJTRvy/25PFb4l0e13VlXaWEcR WFGWso0bxiW7IK8G17URDy10PLGZkNjcRcpvSwSY7pMTqSr9bE5b+eCI5D3mYY0zB6g061 gMjUcxh1f1tZjl7H84eT2UVbeO7FO+4= Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-789fb1f80f5so417790585a.3 for ; Tue, 26 Mar 2024 21:16:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1711513011; x=1712117811; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fvdqGcDUWp3D4k7+aVnVSTSeWYL78OJhC3HPSf53QMU=; b=A+fHo3NH8WaWEjyu7VZf/WF66zzCibNDBDv+ykANPF25ZgNox3gq85uoC1v9GSDwqY qfeMTBtAz1UhcaOYLJRVzz9Z+IP+PPpVjIjLH+WSqcqh3h8sm4K0Ipe01rfBXOvOh1TA JVD/mw63+rldshl8RJ9NzugTfubL45DHnRANt6clhqLZLzyMLlE6aL4KbhRwn2BERDBN Mr1xPrvcrmzH3fEmjU2MofSz68hsFvXCtN6WIaxl8Ot2b7xhy0ZRyTAyzGhM0K4Vogw4 YSXF+gRXyfWi1r6+dbEFK3W8HnKdVwHwjnvwhanFRpUHr9xOnKFIS1uKQyPOzA1+DoeP pz4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711513011; x=1712117811; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fvdqGcDUWp3D4k7+aVnVSTSeWYL78OJhC3HPSf53QMU=; b=OBzBoi/KegPMNpRLIZ53fic1Cy3GjN/FWp+nKCQQtwLEwaP9R5xpXoo4Otpm/bKnqQ NoImnENB9mlbqEFghb0S9k6+O4MtzmqMhZ74k3WSRsF+HQb+pzXazHCyMzML2QCAmYaw 2hgBWDiZqegUYV7jNxHxcFH/PyWfQ/LMF+syRj/0AgW3c2VXXhPYpHj+s2h7dCYLz5S/ 9YPWiTpHxe6bvcwK3CGmk1ZHrULs6H3gSq1yXHsZ07EjMwcqWsY7pwOUAbflQfPC2FtE QGsdaq1RpjdBExOxi5p5jn6XQrTWXlvoIyGwAoGxAU4Oirx7nyI9meEfVsXnKiWO47Wk SKFg== X-Forwarded-Encrypted: i=1; AJvYcCWNK3OKvlMstLfEhaYwD4oAffiNwCp4EuC2oi0YhlVcFm9Z9RxFSPNz2hKlCekJaH76fOiuhdWJ+Jr30DYP4/l2D2o= X-Gm-Message-State: AOJu0YxzBy7EUDs1eBuijgAuD8ThWlnTON78ArzWrR9JzaM8TtX1fg5I pyUka7y17x1FaC/zgBdx+voqGWJ802e0XQv8C2M59DCKLSUzWcED4hnlzTlZU/0= X-Google-Smtp-Source: AGHT+IEbcnIkX9F1+noiNxXN//yadPNJj9nh7BFrHLgyTMaUxP9qk1B63nH9uusK6y5BVegm9808jg== X-Received: by 2002:a05:622a:507:b0:431:30e6:6eec with SMTP id l7-20020a05622a050700b0043130e66eecmr90754qtx.24.1711513011567; Tue, 26 Mar 2024 21:16:51 -0700 (PDT) Received: from n231-228-171.byted.org ([147.160.184.93]) by smtp.gmail.com with ESMTPSA id hb11-20020a05622a2b4b00b0043123c8b6a6sm4370696qtb.4.2024.03.26.21.16.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 21:16:51 -0700 (PDT) From: "Ho-Ren (Jack) Chuang" To: "Huang, Ying" , "Gregory Price" , aneesh.kumar@linux.ibm.com, mhocko@suse.com, tj@kernel.org, john@jagalactic.com, "Eishan Mirakhur" , "Vinicius Tavares Petrucci" , "Ravis OpenSrc" , "Alistair Popple" , "Srinivasulu Thanneeru" , Dan Williams , Vishal Verma , Dave Jiang , Andrew Morton , nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: "Ho-Ren (Jack) Chuang" , "Ho-Ren (Jack) Chuang" , "Ho-Ren (Jack) Chuang" , qemu-devel@nongnu.org Subject: [PATCH v5 1/2] memory tier: dax/kmem: introduce an abstract layer for finding, allocating, and putting memory types Date: Wed, 27 Mar 2024 04:16:45 +0000 Message-Id: <20240327041646.3258110-2-horenchuang@bytedance.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20240327041646.3258110-1-horenchuang@bytedance.com> References: <20240327041646.3258110-1-horenchuang@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: B90FEC0009 X-Rspam-User: X-Stat-Signature: akdmros5rewi9c3n6sds7gwr7ru679cp X-Rspamd-Server: rspam01 X-HE-Tag: 1711513012-751835 X-HE-Meta: U2FsdGVkX1+gXNGKrGo+Grv8Q2JMRh4A8NSFkNocpNzTu1QFW2VROad5uY7hjkHzCNwDdLFXdSdt/CTMQfvcKqJTYjbaex2aHl0qDH5CEIlA4bbZnDXJeyMOEACBgW8v+9Rq6KBuHyTmfLLFBDoOSFTLrAdQRPSa3HHoqNrVaVNp4WgYfpW2qAUsjWZytjRDDetmtsgq0Ti6NGjYpB5raUHrhXMxngOgYnZbeSt78UIcDqZAs0u8yqhcAGjwehfGx1ez8ayq2UAzU4LT/nDovNat8z/+n+eUU0cwG4UGvktt1JpbghvQlfV+IEhMBGaBgLi3v3akxtowzy59iCG0+jtOSd7Mf6Ok13Wb671UwGtpErX5pbVssa5Uu5bDDi92IRyfSLWukZOrqEPelZT4/zFWjf/bXAfxCbHMQbpHjv5oqbLgq2MmA6kwpSA+CdbawfoeNvnPOMBJbxbn++/SH0xz0zlBseDB6dm05yEMUlEiuU0vInU5vj37JpixVDJdELmSQVVx+WMtM/oH6QC0gyz79V0BC3QFAo+bcOpb/p4YNBOwCZn071W0hGMQeSq2SEl5q+VEGvCpCnNVjm6fqIOXql5bA2c+wBFvbJ//xgnHSgmVGPXZ6rBSIds15iQAqdNdtkSMUdaE3vxmeIXzx0ahJccKUO/0opHIZvVmo73JfJyGz8pemv3hVFC39vTrm0vTiHteg3iVwHeKiyIhyK0JuRnreng3yJSvtzGq1cZmHF0J6qh8yi7WX0oRTp9KhB+0W/fH5xrNPvU2oEbzuG/JCTeu248SYmZt1UpmbjyLgsI7Kv+8zcG6cGwmDzTibsznzSbYqiYtId6O8fyRrET8UHZUIMuNH5Vg41YxoULQKNqHN3+jPBTTs7xZuqBddhWx3jJNboL0JhCYLy8cmAaD8+vitflMgJdgRS80qmmQc7GhnogVEX3xTgHiYn609nbLQS2Oyy59Rd2mG4w WTweK2Uv z60xmGe468/Vyd9vn3FHd/0Qcs3Hn6GU/3OinBi5Sjv0SVZZuVFCXO2xrpMF9xP8i6EzPk4pg31MUwXBKKOm+7trMrt4fXWP1/EnYC+1Y5PWsdjX46lLKfz4BTlcRRizVBL88VHq8LUzGcRsQAdE/1uYcYf3BjFTPTZDxcK33qQhobJSH9H3aCuTlAfFQzQFglmERQVKitKMXpcruW0r9Iw3OBLvQipbucLa82EEIqexHR8dimAIE3vEBbBA1dGu2k6ELEwG5qZXEndcR+5F+gjk1+oOIhNkrkMSfF/QT7oJLc20+bgzlbPLqKcvzIUd6NcSs2FF9Nw6yET5NngJr7BAPfSr2/AYVZKpN4qWbv9WqWI5n/yuKrVX+/YRSuU+ClmFNuKLiqub62vvFegmqDlr1U0uevsZuGfQSpcruQC95/qAJXMXoZgseISDARRWQieGoObyZBjQmj2CL4O5NnpgvXlZS3vOD54O0Otug+TgapGQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Since different memory devices require finding, allocating, and putting memory types, these common steps are abstracted in this patch, enhancing the scalability and conciseness of the code. Signed-off-by: Ho-Ren (Jack) Chuang --- drivers/dax/kmem.c | 20 ++------------------ include/linux/memory-tiers.h | 13 +++++++++++++ mm/memory-tiers.c | 32 ++++++++++++++++++++++++++++++++ 3 files changed, 47 insertions(+), 18 deletions(-) diff --git a/drivers/dax/kmem.c b/drivers/dax/kmem.c index 42ee360cf4e3..01399e5b53b2 100644 --- a/drivers/dax/kmem.c +++ b/drivers/dax/kmem.c @@ -55,21 +55,10 @@ static LIST_HEAD(kmem_memory_types); static struct memory_dev_type *kmem_find_alloc_memory_type(int adist) { - bool found = false; struct memory_dev_type *mtype; mutex_lock(&kmem_memory_type_lock); - list_for_each_entry(mtype, &kmem_memory_types, list) { - if (mtype->adistance == adist) { - found = true; - break; - } - } - if (!found) { - mtype = alloc_memory_type(adist); - if (!IS_ERR(mtype)) - list_add(&mtype->list, &kmem_memory_types); - } + mtype = mt_find_alloc_memory_type(adist, &kmem_memory_types); mutex_unlock(&kmem_memory_type_lock); return mtype; @@ -77,13 +66,8 @@ static struct memory_dev_type *kmem_find_alloc_memory_type(int adist) static void kmem_put_memory_types(void) { - struct memory_dev_type *mtype, *mtn; - mutex_lock(&kmem_memory_type_lock); - list_for_each_entry_safe(mtype, mtn, &kmem_memory_types, list) { - list_del(&mtype->list); - put_memory_type(mtype); - } + mt_put_memory_types(&kmem_memory_types); mutex_unlock(&kmem_memory_type_lock); } diff --git a/include/linux/memory-tiers.h b/include/linux/memory-tiers.h index 69e781900082..a44c03c2ba3a 100644 --- a/include/linux/memory-tiers.h +++ b/include/linux/memory-tiers.h @@ -48,6 +48,9 @@ int mt_calc_adistance(int node, int *adist); int mt_set_default_dram_perf(int nid, struct access_coordinate *perf, const char *source); int mt_perf_to_adistance(struct access_coordinate *perf, int *adist); +struct memory_dev_type *mt_find_alloc_memory_type(int adist, + struct list_head *memory_types); +void mt_put_memory_types(struct list_head *memory_types); #ifdef CONFIG_MIGRATION int next_demotion_node(int node); void node_get_allowed_targets(pg_data_t *pgdat, nodemask_t *targets); @@ -136,5 +139,15 @@ static inline int mt_perf_to_adistance(struct access_coordinate *perf, int *adis { return -EIO; } + +struct memory_dev_type *mt_find_alloc_memory_type(int adist, struct list_head *memory_types) +{ + return NULL; +} + +void mt_put_memory_types(struct list_head *memory_types) +{ + +} #endif /* CONFIG_NUMA */ #endif /* _LINUX_MEMORY_TIERS_H */ diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c index 0537664620e5..974af10cfdd8 100644 --- a/mm/memory-tiers.c +++ b/mm/memory-tiers.c @@ -623,6 +623,38 @@ void clear_node_memory_type(int node, struct memory_dev_type *memtype) } EXPORT_SYMBOL_GPL(clear_node_memory_type); +struct memory_dev_type *mt_find_alloc_memory_type(int adist, struct list_head *memory_types) +{ + bool found = false; + struct memory_dev_type *mtype; + + list_for_each_entry(mtype, memory_types, list) { + if (mtype->adistance == adist) { + found = true; + break; + } + } + if (!found) { + mtype = alloc_memory_type(adist); + if (!IS_ERR(mtype)) + list_add(&mtype->list, memory_types); + } + + return mtype; +} +EXPORT_SYMBOL_GPL(mt_find_alloc_memory_type); + +void mt_put_memory_types(struct list_head *memory_types) +{ + struct memory_dev_type *mtype, *mtn; + + list_for_each_entry_safe(mtype, mtn, memory_types, list) { + list_del(&mtype->list); + put_memory_type(mtype); + } +} +EXPORT_SYMBOL_GPL(mt_put_memory_types); + static void dump_hmem_attrs(struct access_coordinate *coord, const char *prefix) { pr_info( -- Ho-Ren (Jack) Chuang