From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34E02C54E67 for ; Wed, 27 Mar 2024 10:33:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A5C06B0083; Wed, 27 Mar 2024 06:33:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6548C6B0085; Wed, 27 Mar 2024 06:33:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 542D26B0087; Wed, 27 Mar 2024 06:33:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3819F6B0083 for ; Wed, 27 Mar 2024 06:33:50 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E56C8A0F10 for ; Wed, 27 Mar 2024 10:33:49 +0000 (UTC) X-FDA: 81942458178.03.0F3A5EC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 615931C0002 for ; Wed, 27 Mar 2024 10:33:48 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RXm571xa; spf=pass (imf21.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711535628; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=Ax4qfRb3siluItmy+PN/odyREYmUacwgx4YUb1KbbqA=; b=jvlY+gN8Qot7FBA5S57VccfMSQpfKa8wQpO/5Jd59rikGiGf25oMXwGrBPvMKwsfe/9coO KelzQ4bAt0zvcxjXTi+roSMzS7ZAaLoi0ZwEeDXvnxt4bZMXPMSlbKhFl4tcax1JXuJJtd Lz6huUFIDQB3jI70X3NAi0N+tVdsUP8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711535628; a=rsa-sha256; cv=none; b=NaOG7cWQZmNxt4MJCjOMAVovsDJLQz7Pg4+0naUw0mrpXecC36OTrLo7qoB5wl/XsZla8P Ep+QuKPHBj/rsuway7dwzSDtsepBHbU2/q4TBW/z3SFEZxD5A0o6QAGZEtUkOFb6WJFtUl TtvRlLm9BcD31MkezykThMtn++nWIj4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RXm571xa; spf=pass (imf21.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 54EEF6126C; Wed, 27 Mar 2024 10:33:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16A00C433F1; Wed, 27 Mar 2024 10:33:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711535627; bh=X4s13pQiIMlSxWNycUMvGwb++iXPjn4geNOGBsGcK/Q=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=RXm571xaFkDpoQNyMD2OrM6Ff4PbI5oyxwIrSn6rh6oTAuAVcMCggPEuRb2mgCuIv bhNqVRdfaSUyuJvby8XWBnNTa24NpwoV4BQ7Kl1htTkkG04CA5T6Sh48JonEsQiZAV RigkbGK1bm1IIn1DB6W7IR7SQvCU7ZAPGxvk6/snkBoZpw7bDCYNWSftJOtqL4kvAO uY5qQehIIb8W9lLjLISE6w78aPCS+aa71c3stOnGl5bPsAnhmCgdSQXaUB9gTy4Aht jUbAIeeoLZE88ztSmt7l2W/jANxPOnvJ/HtGEEMcM4bJV5bO7930qOpcKvwrFsfqsU DOfbLOTRqk+Ow== Date: Wed, 27 Mar 2024 11:33:41 +0100 From: Christian Brauner To: tjackson9431@gmail.com, "Darrick J. Wong" Cc: fstests@vger.kernel.org, Seth Forshee , kernel test robot , Dave Chinner , Taylor Jackson , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , linux-fsdevel@vger.kernel.org, xfs Subject: Re: [PATCH 2/2] vfs/idmapped_mounts.c: Change mount_setattr expected output Message-ID: <20240327-baubeginn-wahljahr-f4ee7484ec48@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240326-mount-setattr-test-v1-2-c061b040d0f7@gmail.com> <20240326152228.GC6379@frogsfrogsfrogs> X-Stat-Signature: gnqg9nnxjmobhy5n5fnibd4atr8fug45 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 615931C0002 X-Rspam-User: X-HE-Tag: 1711535628-540171 X-HE-Meta: U2FsdGVkX1/oEjqyvhTdC8/LQhGnABfZNWidJA4IapY89uE4RsxhzIX3nE2ekUqxBRc9MXuWKZhMK6QbW47ge/v8lRdL4/l7gcL38bHjds0RdwxT+CeAyBjdeM60tQUxw83Ngq3ScOTuYNulxXgxqIqiIWPuC/6iTK+Mx4R7cBmhVwHUB7I67A8yDWyrcN9FZ4O5yUGcX2W5ihn4uTLYC6dNf406PCzzPT7sVc4tmLw1k+cvL0GB3TUXByT/HGydxD8Cgcw+KZ77BJUVTovaHSPj0zTDTbVqOmhj2AuN8DJbwsNqjSPV8DPO1qVR5dYrV7phAFO1aM3xuw7pIE/G7reoEuRNou9KIiW/JuNB8CE/refAQxoIaIB9stR1hLIMacJ4g66kH6aLQfqPbGVvobKuAUdJV+7IeBMAG1Slc6iZMqrXOUNattdhPCBnX+evwCuOieO1z45AFSCa1XrwMIV3gOee4IUwtz0x+z08YmKGak5JWO+WwR3nMuUVwsVadf69eq1mwcUoDHhveKHE1hc2/dwd0WBp3Uz4bHeO4DU4cS3BXSf2uwcNW8FvDjI54NWbz8FAU7V9R5idMC3hSqJ92ATEPWzyn1/ZLAWZJQHdYnFFp6E0M5ejwRyDupUFsUIkcjRaErCvCEWSpeQI9I0lwQn9ieC/N5236Eb1iorBrpS+XEcr0IP0vuZHzzcTgwQkMIx4Vhlcuor5ixtOR4HKkcNtmjSQdqOFaC5GZtnohfPpCWMrSiLOCkz7+UeIlghMSymZ/mxZlljuY1EeloO5lBkX28aroCLyhYn8WmbwVCAbSSbzVFacbKdjLKwpQoFmJB9pm94jyVYLsJH9da2q/IbKSBcmtm0OVFMKSqQbfZTY9H+5R7MQjcbI6J0/Jvrqh/H/6Td4sWBau540oK78CNEOPFYAY8k+ZKRB7hEG9NCSjnvCuQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 26, 2024 at 08:33:52PM +0000, Taylor Jackson via B4 Relay wrote: > From: Taylor Jackson > > In kernel commit dacfd001eaf2 (“fs/mnt_idmapping.c: Return -EINVAL > when no map is written”), the behavior of mount_setattr changed to > return EINVAL when attempting to create an idmapped mount when using > a user namespace with no mappings. The following commit updates the test > to expect no mount to be created in that case. And since no mount is created, > this commit also removes the check for overflow IDs because it does not make > sense to check for overflow IDs for a mount that was not created. > > Signed-off-by: Taylor Jackson > --- Thanks for fixing this! Reviewed-by: Christian Brauner > src/vfs/idmapped-mounts.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/src/vfs/idmapped-mounts.c b/src/vfs/idmapped-mounts.c > index 34052ca3..f4dfc3f3 100644 > --- a/src/vfs/idmapped-mounts.c > +++ b/src/vfs/idmapped-mounts.c > @@ -6667,7 +6667,7 @@ static int nested_userns(const struct vfstest_info *info) > } > > if (sys_mount_setattr(fd_open_tree_level4, "", AT_EMPTY_PATH, > - &attr_level4, sizeof(attr_level4))) { > + &attr_level4, sizeof(attr_level4)) != -1 || errno != EINVAL) { > log_stderr("failure: sys_mount_setattr"); > goto out; > } > @@ -6706,11 +6706,6 @@ static int nested_userns(const struct vfstest_info *info) > log_stderr("failure: check ownership %s", file); > goto out; > } > - > - if (!expected_uid_gid(fd_open_tree_level4, file, 0, info->t_overflowuid, info->t_overflowgid)) { > - log_stderr("failure: check ownership %s", file); > - goto out; > - } > } > > /* Verify that ownership looks correct for callers in the first userns. */ > > -- > 2.34.1 > > On Tue, Mar 26, 2024 at 08:22:28AM -0700, Darrick J. Wong wrote: > On Tue, Mar 26, 2024 at 12:43:27PM +0100, Christian Brauner wrote: > > On Mon, Mar 25, 2024 at 09:58:09AM -0700, Darrick J. Wong wrote: > > > On Tue, Feb 20, 2024 at 09:57:30AM +0100, Christian Brauner wrote: > > > > On Mon, Feb 19, 2024 at 02:55:42PM +0800, kernel test robot wrote: > > > > > > > > > > > > > > > Hello, > > > > > > > > > > kernel test robot noticed "xfstests.generic.645.fail" on: > > > > > > > > > > commit: b4291c7fd9e550b91b10c3d7787b9bf5be38de67 ("fs/mnt_idmapping.c: Return -EINVAL when no map is written") > > > > > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master > > > > > > > > The test needs to be updated. We now explicitly fail when no map is > > > > written. > > > > > > Has there been any progress on updating generic/645? 6.9-rc1 is out, > > > and Dave and I have both noticed this regressing. > > > > Iirc, Taylor wanted to fix this but it seems that hasn't happened yet. > > I'll ping again and if nothing's happened until tomorrow I'll send a > > patch. > > Ok, glad to hear that this is still on your radar. Thank you for > following up! @Darrick, Taylor sent fixes for this now (I've took the liberty to respond to both mails combined.).