From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82BBBC54E67 for ; Tue, 26 Mar 2024 15:37:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CA7D6B009B; Tue, 26 Mar 2024 11:37:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17BA26B009C; Tue, 26 Mar 2024 11:37:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01E9E6B009E; Tue, 26 Mar 2024 11:37:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E12C86B009B for ; Tue, 26 Mar 2024 11:37:32 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BDC4D1A0A5A for ; Tue, 26 Mar 2024 15:37:32 +0000 (UTC) X-FDA: 81939594744.28.81DB08D Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf24.hostedemail.com (Postfix) with ESMTP id A58CF180005 for ; Tue, 26 Mar 2024 15:37:30 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Kc4USQE7; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711467451; a=rsa-sha256; cv=none; b=VOIfoeYpar3Gvn/CTgahGk0aGapDhc75HB2WY1lCjDkB5wVk/ywEJ9R7eopt7Hy6KrYN1T KNX1m9G3X35IkEiF4lywQ+A1szSOQcFfRySYY6D1+Tmfx2uISPCFOFx9ftPobFpZdGq9PC Gcm46BY+LZ9yutlPKcQEKfHl6/FZDck= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Kc4USQE7; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711467451; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=81fQKwEJA+hlzgOLJEAJ85+s1sN4nH0Cn4/OgM1cHNo=; b=NpttzjtPq0ZdskgwaqPtmaVqmSrwvFGLSi+6u8jYWGoR13KtRA3c+d70n5zPjSKYVSvGKF FizMYThFpRbD+VyrsoRmRubBHvz1m3KiZI2yqsC1bJJDdtMFEsnafPhAhyW4rPbcUOmoYj iio3iqvluoNcTWiYH1zobwyQmYGP1Dw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 36E94CE1F8A; Tue, 26 Mar 2024 15:37:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9198AC43394; Tue, 26 Mar 2024 15:37:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711467446; bh=Bl+BYidMPD6QYSFEUn9nKPp7BsOGv1w8t/Y35xkpOsU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Kc4USQE7pWStzRH38MPjUVOniBdEq5uyWMoUbz0gTjBmUbZKyomc3+N1bbVG9vdyk fESewTVbd3oBlMBpODGuKsQ7U0RrznUbpvGESpnHLrYY95vSEWQgt7tVJvhjBJ5E9g 3U26IABZk/FvcbeOquNy1outnQxgYWJuJWEBjmsSiX5gN1vhK5A0AJdM+uF62HcZkt JM7Tmgbuh6+MlC7ySVap9O8c3uC1wgzwI2PHxvXCVL2g4cWD4KJDkHSxqCr0Hcrt2+ 5gjlARL8ooO+2pygBvdaL3daFfodtBbnJhsxwceWyyF1QkNhpCg/CRUxGVwPWvAfgK I+vFRiBXWES0g== From: SeongJae Park To: Suren Baghdasaryan Cc: SeongJae Park , akpm@linux-foundation.org, sfr@canb.auug.org.au, kent.overstreet@linux.dev, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, linux-mm@kvack.org, linux-um@lists.infradead.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] arch/um: fix forward declaration for vmalloc Date: Tue, 26 Mar 2024 08:37:24 -0700 Message-Id: <20240326153724.89126-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240326073750.726636-1-surenb@google.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A58CF180005 X-Stat-Signature: x8f5t8xzmcmcpuebki8xupdh8a7rr1ha X-HE-Tag: 1711467450-484393 X-HE-Meta: U2FsdGVkX19ecO+egkU1TuKEMgxArI+qAiYMvu3wRxi0EuDceTxzWgHNjkHuUlPtvoiCuShE8N9FOPILF2zWej7Ed351sL5Kdyp0Uj3Laovi6I5iD+a+Af+LE49jVsdd28/x0zgfgLS/9rtHxj/dapo9TkN0qreNE2Ws1QQrmeBcIijhCDi2d9XWg0gx+Q75pz8PVXpftJmdSqWXV0SEla2e1sAyYTIKWh+N/rjsUzyvQwIeb0j8CAUf9UXjubMjFKojdj5bsZ7vXMb9+gCw7jEsQCxp9JrA6gFqU14CV1dCXDXc8ou+SYyqtUbSr5ifdMLt76yRCHQE7GVk7dkVIsbcojUYQZWbVTrlkdqheIzymvwDjX7QaY8lQezchkq6Oh7S9qNLRPT+0eeijSi6agId9N49eLBrkOsCT1tiwbSd+tsa0GihaPsLPJK39tOddi21AkWkvdYkfuT2IhmM41IxAimEBZdy0+MLI3VTkYXZcRE68jh9sSGxxdgrDcfsDAmv147lfUrtQ46ZQyWbUmi2gDOLEKZM6O2Webpgva6yjb8Y3YUdqVsmy4So5zzHreyGJ0wOEelKbCVM+ajYTQNOASYL33PPMMGJv9LORnVESpyHGEfwQrXS2NjyZdUuoY+LzLC89Qjnyd44WIHByGnrmd0bInt+tVtj4iI8p/NyeJa6UtVoBAolLMT8/2nNWGQ4Z6bR5LDYFsKAr6zyQF9ae0/g4QBPIh/5hfHfWvzaUd3Bbt5Gw28Vt81HIA1DxSWoUlxRcB8lYsqpqKne1VoCVrZIfH6Dn3HZS3D9K8+1JOQFjet4Isjjs4wBZ7KLIGhfBCeRnVgFlJo64sPusPPUKxpUAAIocqWMgalYAFZaMWNYKqUUuA4pFDSxGzvfqY99krkMsTOu/Y8PSDse8hmLvaWeCbP5BjVv3boeM3l13gGrzBTjZisFrzP3vvW4Vo3lcVGVj4M1mttJZfH sB1Mo5J+ VUMRkn0eOy8DDtAI2QoXLb3K2JPYcERUi9t+C9eDMdYfvXpITRkaF9wkdjD/usZdcYwifo1Zqj0PYhVP2LjmJ4lskXE01Z6WK/9DYuUHO7Xc4VBWKHHH+ErWze4jrNQVEiPjx0NVnFQvEiVK8b0eR2JMr3kv0d9gutVTcXaers22HEDgN6DULOlQXYIuAPozZCOadAKw/SH5aQ88AQ0IDzV3GZ3UAmWGnDFfZJk56s7Lf+1VbQ9JwV8gkG0dcgH0dQ0tr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 26 Mar 2024 00:37:50 -0700 Suren Baghdasaryan wrote: > Patch [1] replaced vmalloc() function with a new definition but it did > not adjust the forward declaration used in UML architecture. Change it > to act as before. > Note that this prevents the vmalloc() allocations in __wrap_malloc() > from being accounted. If accounting here is critical, we will have > to remove this forward declaration and include vmalloc.h, however > that would pull in more dependencies and would require introducing more > architecture-specific headers, like asm/bug.h, asm/rwonce.h, etc. > This is likely the reason why this forward declaration was introduced > in the first place. > > [1] https://lore.kernel.org/all/20240321163705.3067592-31-surenb@google.com/ > > Fixes: 576477564ede ("mm: vmalloc: enable memory allocation profiling") > Reported-by: SeongJae Park > Signed-off-by: Suren Baghdasaryan Thank you for this fix, Suren. I confirmed that this patch fixes the issue I reported. Closes: https://lore.kernel.org/all/20240323180506.195396-1-sj@kernel.org/ Tested-by: SeongJae Park Thanks, SJ > --- > arch/um/include/shared/um_malloc.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/um/include/shared/um_malloc.h b/arch/um/include/shared/um_malloc.h > index 13da93284c2c..bf503658f08e 100644 > --- a/arch/um/include/shared/um_malloc.h > +++ b/arch/um/include/shared/um_malloc.h > @@ -11,7 +11,8 @@ > extern void *uml_kmalloc(int size, int flags); > extern void kfree(const void *ptr); > > -extern void *vmalloc(unsigned long size); > +extern void *vmalloc_noprof(unsigned long size); > +#define vmalloc(...) vmalloc_noprof(__VA_ARGS__) > extern void vfree(void *ptr); > > #endif /* __UM_MALLOC_H__ */ > -- > 2.44.0.396.g6e790dbe36-goog