From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75B03C54E67 for ; Tue, 26 Mar 2024 20:27:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D57E26B008C; Tue, 26 Mar 2024 16:27:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D07E66B0092; Tue, 26 Mar 2024 16:27:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCFF66B0093; Tue, 26 Mar 2024 16:27:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A99B76B008C for ; Tue, 26 Mar 2024 16:27:30 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5A70780472 for ; Tue, 26 Mar 2024 20:27:30 +0000 (UTC) X-FDA: 81940325460.27.2AD2CCB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id 6B3D3180016 for ; Tue, 26 Mar 2024 20:27:28 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=NpetpB26; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711484848; a=rsa-sha256; cv=none; b=Obw8y31Fkceb6qXVPeqvuZajndbFHy4bTeEFW8Yd8CpyhQ1PhjdBFRQASmc6kGnR57J5g5 TQHoLfUkBRpm9bdFgVAstG39sbKDopXZWZ8uW/LDRr54IyyWgxst5W/nexapF7IzoE1eED ZKUloqwxKNKEojt5IgQwRiklSFRekzo= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=NpetpB26; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711484848; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TM8yQ9QyFzi5QxUwkAfctOGoes45jiRy2j5+NoahEAU=; b=RYEtkzVfsqs3JqrExUu+CADRMbRoOnFDjU4PZWjv/UE81T4nhjaF39lALyXqwBvx78Ne8z S68qAjtJ8vknshV/3/6PrwIrIjQsGhXp3z2BmCN0HIlskNSDvlzFAJ51FkWOSm7g2tZt7N W1XRSSXeQy9k/93FSNY87RITUU1UWTA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 845336137C; Tue, 26 Mar 2024 20:27:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0F54C433C7; Tue, 26 Mar 2024 20:27:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1711484847; bh=RMc55HDt1Iu9wEhlfvQPgk2yHzSGgjRT7fuSwVCTZQ0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NpetpB26CHhvYKzvBW/oKi5wtOnub6rL5aP+YF9Y6dCvsmN12zKb5dHIZ5CfCYKcn mhpXZyqvSxsBryWoD/L3dVJ01wZpPDe2ffb+0OvtOWbu8EvYvgn6fD5h7/2417uMPL RI0ydEygACM/q2kOjDEnIbOri4aJ/Y/b5mxPbfOs= Date: Tue, 26 Mar 2024 13:27:26 -0700 From: Andrew Morton To: peterx@redhat.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, SeongJae Park , Jason Gunthorpe , Mike Rapoport , Matthew Wilcox , kernel test robot Subject: Re: [PATCH] mm/arch: Provide pud_pfn() fallback Message-Id: <20240326132726.67e82559a928ac1636c8050c@linux-foundation.org> In-Reply-To: <20240323151643.1047281-1-peterx@redhat.com> References: <20240323151643.1047281-1-peterx@redhat.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 6B3D3180016 X-Stat-Signature: yuuoabxant141m17njffcwe36neqeh53 X-Rspam-User: X-HE-Tag: 1711484848-500163 X-HE-Meta: U2FsdGVkX19Nc/Syx1HovO1hkEIgP0e4RK8Id4pF9aLSoTm/jsgLqnAWEwE9m0ESlawu1wIqWgLV8MBMzJz0aecjoqPUSCPXeX63BXDc5PR79KtcQGtJoza4B+z+beVoiDEN3AIAkzZTtaAOcVpbB5duFMZbEl94swxTm1cDoOISDGRqk2cD8xUtgHguB7+1w18jNrllefMSTtGKdfA5NKutKTVOcBvsTskHCdqhu5tQE9bM99KkspPDGQBFdu/vpN1ZJZN573xCzGPCQfTpvYM7P3oNCP/68OgOzG2NQKzJ0fmnDbNq9Ate++AqfQgwV8AP0bkKQ3mxc8DQc3da9+LKHnEWOFqaYpi2JcjaXK/VU/fA8Q7ohIZTSpPSTDHW9N7ncm4F/6Zob7cNxvmYFmzAd3U2+r43gC1hSZGd0KR2sc/8RgVpMdZWBEy7nBEs0iU7u4g22l9V7vTQa5Nl4oO/j1aH5Yyn5UQbYhsmXF5ssSqeH1vidVTeGn2ALX28FE54y8yoIjchg8UMfnYKccU0rpNRiQ4VPGRsvbgouupCWOVevl/MDwBP9b6K4CqErk8PHrhrCYoWGHsO/4WjmdcK7tw21wgbU8+3HymIzsSp/nX7wdptq6Jm3iqSrU/MwwAurYD6Md8FR3Z+FjSlfi6Crj0KnqXPCz9j8ush995lAyRATs9tQn8/DkZfpsD52CT0FO+N6V2E3s/K2z0SFvDTN4cNp7DEvX99Cz//OE6DKdhHqfqqady839b8a/sWgwpvedEpk5mwOHj6X6cis4KPREzyyMPAi/NEqnCEOdytUrUmvNM9kPhqNmqeIBb7jxhAkBVkkGLL06cRDv+xJrc6zXlpASr0F074K/gWFnvnTWB3KReD8bzeZPlCc+qOdDfL3uVqnnMa7Yr1gpA5ctCytyWBxGuqyFz1hUnKz/qwBT/DchZFlqTgoXsLqO1mChpF9adCRYw5ydIbGFQ YgBtBD1n ez8Qi2SuDfaU/+QswhLI9/krxIEnFPFgKheJD8wsxa1Fc2OuiOmJEdUF7Lf0CMc2yc5X82T0BNj4v4tOLC6rioBU9Q2RvNhpUnkvEpE0BmD9HVG0WqV4wfe62x/d9jWTpWvJA3jz98F121vGg60x+yIS0hRVtPXthz/gZyBbfBSpSsYRyd+WpnDAFOXdhZiRLC2JnLL6aHn5W+fOT04P653soDPvZXUFfw9s1NMehbo4oqtRy6bD+1ZI2vAZQY3iekVxjGl9Z1QqDbnSfgINu3jcHxOxI7FArU2aVCgqQkbE2+0w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 23 Mar 2024 11:16:43 -0400 peterx@redhat.com wrote: > From: Peter Xu > > The comment in the code explains the reasons. We took a different approach > comparing to pmd_pfn() by providing a fallback function. > > Another option is to provide some lower level config options (compare to > HUGETLB_PAGE or THP) to identify which layer an arch can support for such > huge mappings. However that can be an overkill. > > ... > > If we care about per-commit build errors (and if it is ever feasible to > reorder), we can move this patch to be before the patch "mm/gup: handle > huge pud for follow_pud_mask()" in mm-unstable to unbreak build on that > commit. I temporarily disabled that whole series a few days ago. Because of multiple build issues, iirc. Let's make that permanent. Please redo the whole series against mm-unstable and resend?