From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3486FCD1280 for ; Tue, 26 Mar 2024 12:35:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BCBAC6B0095; Tue, 26 Mar 2024 08:35:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B7BF76B0096; Tue, 26 Mar 2024 08:35:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A466F6B0098; Tue, 26 Mar 2024 08:35:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 915A26B0095 for ; Tue, 26 Mar 2024 08:35:12 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 76449A0B09 for ; Tue, 26 Mar 2024 12:35:12 +0000 (UTC) X-FDA: 81939135264.03.F88E706 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf11.hostedemail.com (Postfix) with ESMTP id 17B5E40014 for ; Tue, 26 Mar 2024 12:35:09 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=TOjiO3pZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Cf2J6aND; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=TOjiO3pZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Cf2J6aND; spf=pass (imf11.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711456510; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+3ellU7x8YCGXwJKrWV7ABao9PNb+LN/5kUyZ33fOdU=; b=mhVcIP6p1mJBYj5p/nlscyrc9BfidvJfgs4Tllff4SyNix4HF6oZ9GnuPVXhrfVFWlhCVx rP0BQpqJzmcBswPwkHpBNd718S5EyTp2EI5OxKbSkRWrNb0e60HisCd7ZB1tF9faiq0SQu lT/7AyD4CymgQplff9LtH2uka8j//Ds= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711456510; a=rsa-sha256; cv=none; b=YEcsAz192+1yVqt6U5r6uMu1vkWxzPuoJFmgPjb7LST2NhkV6a0i04IWNmEbhBgU2cCwUk Mc0uq06CA6i6H2owao4FLRl50AIDS1c0d5Ow9qj+JfPodDzRtDLyQQyzHV7+q2wHtMN3z+ 1sP6IuuRqTEokQiwGkbkTC1tg5zM3MU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=TOjiO3pZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Cf2J6aND; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=TOjiO3pZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Cf2J6aND; spf=pass (imf11.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 51F1437BB6; Tue, 26 Mar 2024 12:35:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1711456508; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+3ellU7x8YCGXwJKrWV7ABao9PNb+LN/5kUyZ33fOdU=; b=TOjiO3pZ1crf51dWW9qEqm/7Qco0XAPmiXC/Q2MOoBhN/zSb6ifMGYO2eNZ1Ow+wTTvMpx rqZ2izBEtN0RcZLrKf5jObCFxSP49r6CiXvB4qYkt1F7DhPYD8fvBxJrrCnYi8o3WjNWp0 bc9WNfoxnK0PqBzIiRl61fVcOpC18Vc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1711456508; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+3ellU7x8YCGXwJKrWV7ABao9PNb+LN/5kUyZ33fOdU=; b=Cf2J6aNDRK974IYzCsXFSg2GicFhQKNW/aQwjt/pbsGVC4kDbBu10WSPBYxYw0LBS8BcPz TJcMfPcDyHyLdADg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1711456508; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+3ellU7x8YCGXwJKrWV7ABao9PNb+LN/5kUyZ33fOdU=; b=TOjiO3pZ1crf51dWW9qEqm/7Qco0XAPmiXC/Q2MOoBhN/zSb6ifMGYO2eNZ1Ow+wTTvMpx rqZ2izBEtN0RcZLrKf5jObCFxSP49r6CiXvB4qYkt1F7DhPYD8fvBxJrrCnYi8o3WjNWp0 bc9WNfoxnK0PqBzIiRl61fVcOpC18Vc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1711456508; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+3ellU7x8YCGXwJKrWV7ABao9PNb+LN/5kUyZ33fOdU=; b=Cf2J6aNDRK974IYzCsXFSg2GicFhQKNW/aQwjt/pbsGVC4kDbBu10WSPBYxYw0LBS8BcPz TJcMfPcDyHyLdADg== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 429AD13215; Tue, 26 Mar 2024 12:35:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id pW89EPzAAmZ7LAAAn2gu4w (envelope-from ); Tue, 26 Mar 2024 12:35:08 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id E7A62A0812; Tue, 26 Mar 2024 13:35:03 +0100 (CET) Date: Tue, 26 Mar 2024 13:35:03 +0100 From: Jan Kara To: Kemeng Shi Cc: akpm@linux-foundation.org, tj@kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, willy@infradead.org, bfoster@redhat.com, jack@suse.cz, dsterba@suse.com, mjguzik@gmail.com, dhowells@redhat.com, peterz@infradead.org Subject: Re: [PATCH 6/6] writeback: remove unneeded GDTC_INIT_NO_WB Message-ID: <20240326123503.kxyxg75xr7wk3ux3@quack3> References: <20240320110222.6564-1-shikemeng@huaweicloud.com> <20240320110222.6564-7-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240320110222.6564-7-shikemeng@huaweicloud.com> X-Stat-Signature: 6kshd591mri9zy1twe85ca4aamexe3of X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 17B5E40014 X-Rspam-User: X-HE-Tag: 1711456509-173790 X-HE-Meta: U2FsdGVkX1+K5UhalZePPv9Dw4Ss9sUQFQdyEquRnFxIN0+X8JHxV7Ysqfn03x0uHf7PwDZ9K4EL9XvEJhekw5KHta0CG42HURbtgoBho7N6wAHymjXTbo78aRQt0kVwR1ZxYpceXdQav4FqRjXv08+Uk3c3lIb8gZinROyjERM+zVP/xXKCIXuudZUMRJrsXqmRc9F9YBHgHGzy+WaihJF7hphe/mhQ8GgGjiRZYzOWa4mFwkPx5hzelonqus/KjoNUF5HAPOAVq7rIztvIgtV+asveIAYqpMbKs2kGBsOiuCylo0sMhVX7HZHMTnLedexqX65Q+qWViS919DciXLVStNxb9Ckt58jExcz4uhG+L08DCL9FkT9uPJS7mEi9rZ3wE0Fl4WLnTwmZP0uU4yi80ab4uj9/IujhedMZLFc744EkSZui+WMrWu2X8UPPTd4gHRsJ5fCeOjiaQOzV/nuGhC93+gs5nWyEqx2I6NtZDzVQHS1vRuvstqUxcwRQNTULSe7wlX6KkxOEQmW015CZ+dMF+gxDsgZtSnbVLkeB1xihfQELuCIz9Ww8DtInUHIYIJQLZf4tTDfRnUU9JT723WAnff+lvTi9EA2XNjPnQOygJGcjGhU3ZAZajm7a6FzLX26Ti5kZXYm6dHxPAps7PncflV0hYzQuir9cuhVFZNX+ijJK1qiyMUdv5rNyJA2HzYE35flxjquYTLcVOuzgw+EHCl/R4cLKqZZIEsp6yFBdy02l+XMBOp55Sm0/wR/WDeG/6fIAFgGpwr7Ii4XYti2wqsch0husrygCLy3A9kUdac5HfMZJv5emVwD8MwhVIQSeDrgRtHNF+5ZQ4RA15+IPTbJnt2NazRLBawJMveBvZfS/IsfSfdptqolBagVKQ3ggbcaAX3o7NW8nhcDgwWJTGSr1eF6dFp/OGOOwJNFUw8Ff4uovRu+8xM9M1gXKg0rmY68Vt043Y7O ywzjcn/P 2FeUCSWsbxzlQ8ToAsjaoTNJCoRnJ8yQ9rOKQ+B3XUhNNMOP3xc2lgshAZ5C3Xqb3roJB6qaVntBEIA41r4uVWJESVnb0ErnP4SbnsitnxFyCSJMQiQvjFIfL0rxapzfQKlq9RrGEkyW1ixCIUvIR5Kd8qWQrSKIZvPuWv4lxmOdDzdH+caX2yXG4I8Q1iIuT7SbO+r0U0VUsIBpGGNbBBes4o45I5xyxH3pU9waAnlPOqtN1uSNNVY2ApXjTnqD0U/XS4YdTjnknEtC4THgfYpkW1UymEuhRkwBWgVRhkzZFZIKiUdFzMFETJYBvqFAwPyW6iyTaA7d6wpgOcW/SJqSxRoc7ut3yCGdlEcUI4nKGDCfLnUgjgNKU/YcPsqk1/SN1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 20-03-24 19:02:22, Kemeng Shi wrote: > We never use gdtc->dom set with GDTC_INIT_NO_WB, just remove unneeded > GDTC_INIT_NO_WB > > Signed-off-by: Kemeng Shi Please no, this leaves a trap for the future. If anything, I'd teach GDTC_INIT() that 'wb' can be NULL and replace GDTC_INIT_NO_WB with GDTC_INIT(NULL). Honza > --- > mm/page-writeback.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > index 481b6bf34c21..09b2b0754cc5 100644 > --- a/mm/page-writeback.c > +++ b/mm/page-writeback.c > @@ -154,8 +154,6 @@ struct dirty_throttle_control { > .dom = &global_wb_domain, \ > .wb_completions = &(__wb)->completions > > -#define GDTC_INIT_NO_WB .dom = &global_wb_domain > - > #define MDTC_INIT(__wb, __gdtc) .wb = (__wb), \ > .dom = mem_cgroup_wb_domain(__wb), \ > .wb_completions = &(__wb)->memcg_completions, \ > @@ -210,7 +208,6 @@ static void wb_min_max_ratio(struct bdi_writeback *wb, > > #define GDTC_INIT(__wb) .wb = (__wb), \ > .wb_completions = &(__wb)->completions > -#define GDTC_INIT_NO_WB > #define MDTC_INIT(__wb, __gdtc) > > static bool mdtc_valid(struct dirty_throttle_control *dtc) > @@ -438,7 +435,7 @@ static void domain_dirty_limits(struct dirty_throttle_control *dtc) > */ > void global_dirty_limits(unsigned long *pbackground, unsigned long *pdirty) > { > - struct dirty_throttle_control gdtc = { GDTC_INIT_NO_WB }; > + struct dirty_throttle_control gdtc = { }; > > gdtc.avail = global_dirtyable_memory(); > domain_dirty_limits(&gdtc); > @@ -895,7 +892,7 @@ unsigned long wb_calc_thresh(struct bdi_writeback *wb, unsigned long thresh) > > unsigned long wb_calc_cg_thresh(struct bdi_writeback *wb) > { > - struct dirty_throttle_control gdtc = { GDTC_INIT_NO_WB }; > + struct dirty_throttle_control gdtc = { }; > struct dirty_throttle_control mdtc = { MDTC_INIT(wb, &gdtc) }; > unsigned long filepages, headroom, writeback; > > -- > 2.30.0 > -- Jan Kara SUSE Labs, CR