From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2D18CD11DD for ; Tue, 26 Mar 2024 12:27:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 510D16B0085; Tue, 26 Mar 2024 08:27:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BD646B0087; Tue, 26 Mar 2024 08:27:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3859E6B0088; Tue, 26 Mar 2024 08:27:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 29A616B0085 for ; Tue, 26 Mar 2024 08:27:06 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BD16D14014F for ; Tue, 26 Mar 2024 12:27:05 +0000 (UTC) X-FDA: 81939114810.06.1F185F6 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf02.hostedemail.com (Postfix) with ESMTP id 8327B8000B for ; Tue, 26 Mar 2024 12:27:03 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=D+o9bill; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZvTfHubG; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=D+o9bill; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZvTfHubG; dmarc=none; spf=pass (imf02.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711456023; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o+FQk8Pfj6cNE8lfvdU6/qaSkPWg47A6HFY6eoUrykg=; b=aL8bKLCRjygYLFNOpO+UbZ2RtQ+vwtJsPDqcfzVaEtAa6Ttmt4iYX0wBawzbvsnMGjUqcP t2hhHLVk90ncYpK2s4Crf7Y2DSDpsE8hIYGcAjSIGSs/ZRHzgAU0s1isizxA3+wJNx/HWX S7wmsmKUTV0iYir+QDxAn5KPLh4zUVc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=D+o9bill; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZvTfHubG; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=D+o9bill; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZvTfHubG; dmarc=none; spf=pass (imf02.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711456023; a=rsa-sha256; cv=none; b=YgNcT1ezjAFFK7gv2UCpVtndwv8grUb/YS7SCPx3F+VUNQaYFmzBjPLc2I0UVKFZ2lDlT9 P5SW2OdGAn2GP9+ei7U2rt/p/Jqfp71HvBvaABrYs1VAcys6ad1ra3Twmqb/X0aofGQpLu 9BC75pWdlnXP+n00tr98WgBT6909eCM= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 04A8037B8F; Tue, 26 Mar 2024 12:27:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1711456022; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o+FQk8Pfj6cNE8lfvdU6/qaSkPWg47A6HFY6eoUrykg=; b=D+o9billZjoMb/3DAYk8EBB31dPuuDphmyr2L+GWn7WHdwMKOVYPHni2IO1Rw3nWFgc8MP wUrfV6KU4HFYM8p785OVesLYyXLPXC+u5DsZCLnZZMpBEmCFDUkblIyKpu78m+j4yuh/CD x1RgJNHlAgTiXmCAFPnGl81QtTH8Mmg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1711456022; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o+FQk8Pfj6cNE8lfvdU6/qaSkPWg47A6HFY6eoUrykg=; b=ZvTfHubGqrrgvVGEZTBZZycn4bhL8WQ4uuoiaUU2nuB2P7HV4ZZ6qR82ofs9HA9C2ZyelO z4ZrUUzG0RMHNeCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1711456022; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o+FQk8Pfj6cNE8lfvdU6/qaSkPWg47A6HFY6eoUrykg=; b=D+o9billZjoMb/3DAYk8EBB31dPuuDphmyr2L+GWn7WHdwMKOVYPHni2IO1Rw3nWFgc8MP wUrfV6KU4HFYM8p785OVesLYyXLPXC+u5DsZCLnZZMpBEmCFDUkblIyKpu78m+j4yuh/CD x1RgJNHlAgTiXmCAFPnGl81QtTH8Mmg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1711456022; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o+FQk8Pfj6cNE8lfvdU6/qaSkPWg47A6HFY6eoUrykg=; b=ZvTfHubGqrrgvVGEZTBZZycn4bhL8WQ4uuoiaUU2nuB2P7HV4ZZ6qR82ofs9HA9C2ZyelO z4ZrUUzG0RMHNeCw== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id EF6C113215; Tue, 26 Mar 2024 12:27:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id rT5yOhW/AmbDKgAAn2gu4w (envelope-from ); Tue, 26 Mar 2024 12:27:01 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id B0080A0812; Tue, 26 Mar 2024 13:27:01 +0100 (CET) Date: Tue, 26 Mar 2024 13:27:01 +0100 From: Jan Kara To: Kemeng Shi Cc: akpm@linux-foundation.org, tj@kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, willy@infradead.org, bfoster@redhat.com, jack@suse.cz, dsterba@suse.com, mjguzik@gmail.com, dhowells@redhat.com, peterz@infradead.org Subject: Re: [PATCH 5/6] writeback: rename nr_reclaimable to nr_dirty in balance_dirty_pages Message-ID: <20240326122701.e32op43zxuowjvgj@quack3> References: <20240320110222.6564-1-shikemeng@huaweicloud.com> <20240320110222.6564-6-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240320110222.6564-6-shikemeng@huaweicloud.com> X-Rspamd-Queue-Id: 8327B8000B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: tpub8rfashnujsikuttbfugybo9p9xcn X-HE-Tag: 1711456023-814609 X-HE-Meta: U2FsdGVkX1/fvUIL5sIwli2Z2e22v+/CJsY0NJjL8gi2Xm0urdQem/vgvl1uyjW7DbdXMkSaWAMnn9bThyqFVESGQey0QSt/4ThwEzuGvAl/d2MQ10AQrG/ZXgseC0+Ya55Xp9LWEErMAWWDZG9xSWNzaQYINrW3IeJ9ibjKl6UcuQJPU1wH4qrUjoJOJFHbTw3erVkQb9ICVJSe2YKjnyFjnyeV4iAQ6qo2iibDb2/Zv/3W5Kzcl9RbQmuJ3LMOP6EITeDSceWIpqOVrGsX+jgOQujGkKOkdmSk58w93MoMiOBrg0fPwpSGBKuoZ3ul/pXxPdHwgtZIX0Hvza8cJdNXHAee0mxM9bCEOaRXHaU4CcxfgKBhGc9aezwJOiD7TQaIYQGLDHpnotWdJxewu84fenrupJ0AUFguHeQuBSRet4al565dMKp2ARkd+7+6pS7LMDtauDk/EZrTRoPqUOvudjZOwUkDPNC/ZtdqpX3CgLXy7hnLblPO+I7IftOU27cUliwTjqBUTAJRnZYsP30Lik6R9noUAhQiT8v++hrYNZbfnI8Y2M2kYuWXl1MCm6eYumm1nhSGG7QYiemjg40I9zA9cKLbfLuVqHVIAS9TcyUVT3025p9+d0P17Hq0JCi4pAG9+JMZSYzvE/i448aV5RqYmiBFcaH54pZk04ShA6xvxf/zYsjw3Thqb4NXjVFm+9eiUuwmH0NMFnQtN5aEagnKqI9BN1voxtf+fuX95qFbFOBTfPJM5gSar0dzb4a41iElLgS7ZIwL68gOP5yvdPZK2WAcqiQDjL3fcRB9bvmOldQe5Ilq37ColmuCOoswzwAevBZ4gTwhlyLbD49A0mSLqdZ6yrKQK+nINoIBj6A3ItfH6WaBLNbBLQmyCSoX5lhHy9kx4jfB1abJ84AqnGOhZWWNWpGtJRkKRwv7nuyKrH0Uzwf50ip9at2lAqxPJlbiR0eTQVR1MOh jBlIZ5hd 4cY+AiFhL6S04TVCGm0HuITZGyZ6ROrBYxSncKZa5JjR/1nn1eAatzDHsq06930AdJS5vePkodm5eZDdwYouqAp9oCJ1+Tg2C6howhuTuRXs5joWHnJ3CySCBe+9KgpY5WnzGX7WcsP5SLR6MJyCI3BdmipLVlg3ecMB6PZq8M65x0LQE/mPlTqJ7iwnIdc5SpzIAT9S71cIULBJB4FKhfsFLLn+o5vIRDTgZanwEBLPi8pCfyFnzcqrOLFSI4tdsOBukL0xXFlPOBgJ0c+SiUsQRgxs1a5cG8XJ+QUIpkXeXaug6Q2w2mQRYf815+SITepJN0JV4WZ0znyFf6mv2DmafrcKcMXfWPrzzu9VVRK9CdtM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 20-03-24 19:02:21, Kemeng Shi wrote: > Commit 8d92890bd6b85 ("mm/writeback: discard NR_UNSTABLE_NFS, use > NR_WRITEBACK instead") removed NR_UNSTABLE_NFS and nr_reclaimable > only contains dirty page now. > Rename nr_reclaimable to nr_dirty properly. > > Signed-off-by: Kemeng Shi Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > mm/page-writeback.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > index ba1b6b5ae5d6..481b6bf34c21 100644 > --- a/mm/page-writeback.c > +++ b/mm/page-writeback.c > @@ -1695,7 +1695,7 @@ static int balance_dirty_pages(struct bdi_writeback *wb, > struct dirty_throttle_control * const mdtc = mdtc_valid(&mdtc_stor) ? > &mdtc_stor : NULL; > struct dirty_throttle_control *sdtc; > - unsigned long nr_reclaimable; /* = file_dirty */ > + unsigned long nr_dirty; > long period; > long pause; > long max_pause; > @@ -1716,9 +1716,9 @@ static int balance_dirty_pages(struct bdi_writeback *wb, > unsigned long m_thresh = 0; > unsigned long m_bg_thresh = 0; > > - nr_reclaimable = global_node_page_state(NR_FILE_DIRTY); > + nr_dirty = global_node_page_state(NR_FILE_DIRTY); > gdtc->avail = global_dirtyable_memory(); > - gdtc->dirty = nr_reclaimable + global_node_page_state(NR_WRITEBACK); > + gdtc->dirty = nr_dirty + global_node_page_state(NR_WRITEBACK); > > domain_dirty_limits(gdtc); > > @@ -1769,7 +1769,7 @@ static int balance_dirty_pages(struct bdi_writeback *wb, > * In normal mode, we start background writeout at the lower > * background_thresh, to keep the amount of dirty memory low. > */ > - if (!laptop_mode && nr_reclaimable > gdtc->bg_thresh && > + if (!laptop_mode && nr_dirty > gdtc->bg_thresh && > !writeback_in_progress(wb)) > wb_start_background_writeback(wb); > > -- > 2.30.0 > -- Jan Kara SUSE Labs, CR