From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76FCACD11DD for ; Tue, 26 Mar 2024 12:24:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04F626B0082; Tue, 26 Mar 2024 08:24:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F41646B0083; Tue, 26 Mar 2024 08:24:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E093A6B0085; Tue, 26 Mar 2024 08:24:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D0E266B0082 for ; Tue, 26 Mar 2024 08:24:31 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9E5E3A0ADE for ; Tue, 26 Mar 2024 12:24:31 +0000 (UTC) X-FDA: 81939108342.27.6D821F2 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf17.hostedemail.com (Postfix) with ESMTP id 30F1F40016 for ; Tue, 26 Mar 2024 12:24:28 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ERuFtmQQ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9LI5XNpv; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ce56UmHG; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DBH4hFPy; dmarc=none; spf=pass (imf17.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711455869; a=rsa-sha256; cv=none; b=7q+XIiuHOPjcLaA5WbBxLvgCaet8JcsOT4C1UumgaGGuvhtIjjfc0duem+io1xwlUZFKX5 /V8IKiKtmJl2OMRaWWrv6hyMVCP6pFKm0fCCXMCS4hWU0BJcmo40ivGaTocRboSpCe3msn 28zYfEObdVffdjkXHTtXsQ/vtqoxXCA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ERuFtmQQ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9LI5XNpv; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ce56UmHG; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DBH4hFPy; dmarc=none; spf=pass (imf17.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711455869; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=klBdcsaCF0MeM1RozflWzamTx/k4KEI7GZvYP/2DRRU=; b=Md8ddxupTGGeudqbevj2ZTR+wx+lT1SpffqAizaQrQK+P13NqoJqeJUlE3Zkmr8R/Cl3BA jja9eGa8a/Caz5FZUqdszMNNk1uBnl5rMaPQnzWrhDha08GNtglfbx7Y/qmzAzBrmq7GxY zDmINKj0oFQZvHLjBwMYl8ZQ1ZWwt/g= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id ECA415D588; Tue, 26 Mar 2024 12:24:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1711455866; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=klBdcsaCF0MeM1RozflWzamTx/k4KEI7GZvYP/2DRRU=; b=ERuFtmQQZvi6FYnPRp+1QGAias/5wPP5CGDZbCJZYjIqhllnVXtIaPzbEldhME9fUMA2Fz F0GDuZioRQX079tlQ1I9Q+FlRtW//cXDwNekp+BcdtjJWs9bSRAzOhyilKD681xo+eu9yg QBsqfeVlc1i4Fje/3yI7TPYkWWi/8Kk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1711455866; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=klBdcsaCF0MeM1RozflWzamTx/k4KEI7GZvYP/2DRRU=; b=9LI5XNpv3YexlfZZb2Oi5AkiKETAIQBWlqa3l6QmHJQ5xTQnbl3frmLMIYme5aGCyUYdAZ Ao7ikofaO2oV8yBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1711455865; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=klBdcsaCF0MeM1RozflWzamTx/k4KEI7GZvYP/2DRRU=; b=ce56UmHGTJ8B91Z86yv1n9IVbL/izh3/GacrHy+GKIHsNJ3JHEF/poLw81VH6ZBRrZ9MS6 Stli8MRGdTyrK8h0WbHJdeWVfdBo4VQGRepfbeNAxM1Mg6k4BkxN+ed0CrK7PlOWENvjvG GalrnONrvEGo5yNhItZFbsqmq0TMxXU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1711455865; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=klBdcsaCF0MeM1RozflWzamTx/k4KEI7GZvYP/2DRRU=; b=DBH4hFPyCiRqgG/D7x7eopyTIwjkszYl8XO7pygIkgJKuJh0CcOg/tVQxmhtT8mpg3eY8l ILpVhuaWuXzSvoCA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id D63BB13215; Tue, 26 Mar 2024 12:24:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id MhYLNHm+AmY/KgAAn2gu4w (envelope-from ); Tue, 26 Mar 2024 12:24:25 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 6EAE4A0812; Tue, 26 Mar 2024 13:24:21 +0100 (CET) Date: Tue, 26 Mar 2024 13:24:21 +0100 From: Jan Kara To: Kemeng Shi Cc: akpm@linux-foundation.org, tj@kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, willy@infradead.org, bfoster@redhat.com, jack@suse.cz, dsterba@suse.com, mjguzik@gmail.com, dhowells@redhat.com, peterz@infradead.org Subject: Re: [PATCH 2/6] writeback: support retrieving per group debug writeback stats of bdi Message-ID: <20240326122421.dofl35cdtgaojt26@quack3> References: <20240320110222.6564-1-shikemeng@huaweicloud.com> <20240320110222.6564-3-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240320110222.6564-3-shikemeng@huaweicloud.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 30F1F40016 X-Stat-Signature: aq5ns3rbsp7dokyhrhck6zeur81jecxz X-HE-Tag: 1711455868-406352 X-HE-Meta: U2FsdGVkX1/n5hQL0VDRA+gUAzuyEN2Tk6HXuxYeRWO44bleIeTTRh6itGdYbJxqMo0WmETJv/ZfIrcow9tZYO9TBh0OUEgBCCvVJIF+G3D/AQqvrO1Dw9gGM+gah9dl9QrgNRBwzcMuv/iMEkN4qEay+jDv/es94DzqYiTcK1UXBqA/ThsQq2P/Ea7NwqHuW/AIQSHj57xUcS9/RRyNsnwyw1JKB5otwgBCrsglKJZdkp3rTx8WexDF7tAMdZqcpiwKDgFCHCHOMHYHj63YshK3BeJDgNGhzQ/juJf7lVbx4DNXbEoKUPKFzk+Lix1Y910y9BxRm+jz6dGA6WZwXW/pSlznar3RBscdXwiADUsDoWGlA8JEGy5KgdqHEE3VW7GE8FcanHEFKDlg2JbeTOkiRWpubHQgV8zDB/TsvAJgKEcg2kUc0ZOaNRXiqkm0M1jG0CJqUtLW9PAdHeSn3C20Od6y+6wzDhT7F1CRZ49+ZBF72uoK4AbHJ841TBRMtB2VhrQ3+gjU1OnUbYha5goiylZUBVPJoCquamV7fQYPfnnfWMukBjB5JPCmuAXyUwoEPf+XGqW76BlJnsqMtAJTRCM0Cf/fLmEPYEFDry5ZVIyd5FXYPci5qWSdzJo5YJOfS+GGuzuT/otK3+XcUe16GoJ+NRvT5gGSJa6Cs80EESDJti71TYtUsvDE/atQDf0TgU6/Vf7LXKU88YKsNpKsinYONKiVKRl9earffbb5qvCK7hoi7dGJbhA/+AEPFZOnaEMThoPtyNVqJvXtICy+3M9zx45dwqSp3VRuTVW2OslK7nOU0gSBJVsXL8ktvVG7pWeEyMXgXl7qrw5DZIeAYRkCcHHpVApL7mdb19bm+Wl5F6cngXSYS0B9t/+aEmZVuMreBR0PStqrqmyIhDAEuGNCZ8Us+CdqH3urmBDTHOpDX2vPxqXWzrLfyHG2v5ebfnVd0CGgk69ACXD D70SNEFK wMxNw+f6iijz9VL3OeZJlv+JSbD4qDAKrW8Dly5rpaV345pYMc2AL5N11V/mFz0G7OrQNDQ+eTGMtHEc8eWiMTxgFEj0spa7ED9zyq0qyoF/owDpw0pxcuAxTydg2z2KhR0wCtGuQGEpEHkmbGwD/cJMMRIabGOIOVrqEcVh17sK9LVOuiiiJ4X2hILpL/i2ypwzfmlisynlqdLarY5sEjmBXuUYrS1gofQs4WJtEIMhYSpsy1xSHk5MAEp1umTK8EknWiOjzwzDCB4dqtJ6qCnlQ0hq2V++aasDrSLIzirQsqOSyH/Wyuc4f5vd+qtrXycEzyNpzuKP0CG/utsoMYpjJXQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 20-03-24 19:02:18, Kemeng Shi wrote: > Add /sys/kernel/debug/bdi/xxx/wb_stats to show per group writeback stats > of bdi. > > Signed-off-by: Kemeng Shi ... > +unsigned long wb_calc_cg_thresh(struct bdi_writeback *wb) > +{ > + struct dirty_throttle_control gdtc = { GDTC_INIT_NO_WB }; > + struct dirty_throttle_control mdtc = { MDTC_INIT(wb, &gdtc) }; > + unsigned long filepages, headroom, writeback; > + > + gdtc.avail = global_dirtyable_memory(); > + gdtc.dirty = global_node_page_state(NR_FILE_DIRTY) + > + global_node_page_state(NR_WRITEBACK); > + > + mem_cgroup_wb_stats(wb, &filepages, &headroom, > + &mdtc.dirty, &writeback); > + mdtc.dirty += writeback; > + mdtc_calc_avail(&mdtc, filepages, headroom); > + domain_dirty_limits(&mdtc); > + > + return __wb_calc_thresh(&mdtc, mdtc.thresh); > +} I kind of wish we didn't replicate this logic from balance_dirty_pages() and wb_over_bg_thresh() into yet another place. But the refactoring would be kind of difficult. So OK. Honza -- Jan Kara SUSE Labs, CR