From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 569ADC54E58 for ; Tue, 26 Mar 2024 07:49:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2A666B0098; Tue, 26 Mar 2024 03:49:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DDA5C6B0099; Tue, 26 Mar 2024 03:49:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA2816B009A; Tue, 26 Mar 2024 03:49:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B98386B0098 for ; Tue, 26 Mar 2024 03:49:05 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 952D840A0E for ; Tue, 26 Mar 2024 07:49:05 +0000 (UTC) X-FDA: 81938414250.08.BB878E0 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf20.hostedemail.com (Postfix) with ESMTP id 3D8D01C0015 for ; Tue, 26 Mar 2024 07:49:03 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="VUwNUj/N"; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf20.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711439343; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gEPa7TSHFvR3AVvnHhrhHVYWL2THauofyr9s2yjVDOM=; b=D15gxx5Tt93uxsSI36j2j+PU3cDtlcA2lpHoSrIMnl2m/v0sdEUuQHdCCGr0Qofh/zAB1m X1jMEIaNn/gToxI57BpFnIU7zyhktcWy3BtgQGAzB77nX1HSbjVOh87nLr7R1aCT3QZ4b6 ZZ8gL7gUDsbDOctOb70M0RWPn0T/jjo= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="VUwNUj/N"; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf20.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711439343; a=rsa-sha256; cv=none; b=M+5AJm6q1r1c5IF9QRw10dUBRHoDgl9nxgIwftb1VvWprlzgTa91hApwueW80hAphTPCEa uMOf6K9gQ+IrZ7ehIXiTnHHEZ7Hyl9QfyUEX+yJ9MgQZrGCQ10JBv0ovPEeZ1UNpqDZmLU vLpnPUf6wQ9B0hNR3LMuni9pypmtH8g= Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 42Q6tssI023504; Tue, 26 Mar 2024 07:48:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=gEPa7TSHFvR3AVvnHhrhHVYWL2THauofyr9s2yjVDOM=; b=VUwNUj/N5mbbkhipigbjGgBOJhfgThMtm3ITv1mwe8Ht8ljQ+PwCF+tW3pZR23oZjH1/ er/ZlFE3Ik7jEf/fn6BVuAYerDeJJSSKXLw30inF4SX0d0iiEKjy2FeYnHQu8F10LnkZ cnGqAiYX9s8wvC+fRSHZFBZjs25ovQDkaA/o3fTxPT4DBPp+IfvkH33HAy8pySgSJz8L lrXSGThL1xVtZzJbIn0Oo5a1bDIc8yRf+e5Jtxf63WbR2sMooVGgZ8qVyrpBtu4N6FjW ZylyD2sKSmd82wRpQ+BUuULwYwsrTd+GJOmscuJDEXNkgJK41zQ1CBHuqxZmskv2Os3w QA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3x3kytrspm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Mar 2024 07:48:54 +0000 Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 42Q7msRU010276; Tue, 26 Mar 2024 07:48:54 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3x3kytrspg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Mar 2024 07:48:54 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 42Q5Odxj013343; Tue, 26 Mar 2024 07:48:53 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3x29t0ek5e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Mar 2024 07:48:52 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 42Q7mm6k41288032 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Mar 2024 07:48:51 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D6C0720063; Tue, 26 Mar 2024 07:48:48 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 910AA20040; Tue, 26 Mar 2024 07:48:48 +0000 (GMT) Received: from osiris (unknown [9.152.212.60]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 26 Mar 2024 07:48:48 +0000 (GMT) Date: Tue, 26 Mar 2024 08:48:46 +0100 From: Heiko Carstens To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , Dave Chinner , Guenter Roeck , Oleksiy Avramchenko Subject: Re: [PATCH 1/1] mm: vmalloc: Bail out early in find_vmap_area() if vmap is not init Message-ID: <20240326074846.6078-D-hca@linux.ibm.com> References: <20240323141544.4150-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240323141544.4150-1-urezki@gmail.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: l-95GC7tIB-ygz7mEZ1DT2Lo93O7U3I3 X-Proofpoint-ORIG-GUID: HwrjB5_E5SYPjSoAcbidYfviQtVuDYhn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-26_04,2024-03-21_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 clxscore=1015 phishscore=0 impostorscore=0 mlxscore=0 malwarescore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 mlxlogscore=638 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2403210000 definitions=main-2403260052 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3D8D01C0015 X-Stat-Signature: f3deoajqxhn4n8r7pmdi7y16zdxwp1fh X-HE-Tag: 1711439343-59066 X-HE-Meta: U2FsdGVkX1+Eyrha7l8x0UIt9AdYObJNk0A33kgwsGXDpryjlXfTOb+egSHj+JUGbXEnO8R3b7VvRoeqIkS+gDe6/xBQ3USNcUhldzMIDZAOjpvI6kwMab1P0/c8hTyu5WvT2NOaLfHtWvNeOGnVnVqjF5SAjJQqBZdWJn45lCwHLIWvpZGYL7dq3Wq14E/KlnxQAH4gC8lZXhbB0yUpqUwxQ8WYfXBetDhZupCGOMxhc0f0UQ/+epDxggU+bLbeNDB544BmD/6gLLP2tkzgAOLZlgRf5ZXFImhfjCr0Bbx/gxRRS/fB3g71/HGYJBPtogEwk1EJz3PmbXv4nJK7UWhHf+49YQoNQTQtJoqR3vZ3gZ3CUcVAcs43VMpuJD3GnLBdt/uccuNPSgzjaxL9s4qMSuGg4/iEVksq0IkNWSJxZzylWHZEqK5lunADx3hIDwkFp88JH14MnDFY485iBv9dL1iwwIp6JMOxRGVO2qjoA71wFaSJIqqoaAUCblX6gKL750mS21yM5vlpNkU2VbZRr0BXdTRAp8HJymDb0yrVNOeavXbRorCldelTJT/kRbUtKvcVrNq1LHGl7V+xFGb2ioJNUjldYOE9Siebv6qdnGHD4FqNyyz1YVe0bIuFQjJBnquJvcR8BK/YZViF5ssdTqGVVbEnyP2tOO4/Hr82doeGqM67Kr583X8fyypLaVLHZMGUYMGsrQEpG1gXwZsDBlA6wqq2tRRATy3iNTXSuzeAQHB5qFT3jtv3PFlrTmqLdla7XF6WvFM7uAgQORCFoKsE/tbbaZOu/7nO4b3pr4piWoj8oomlqGCEZIu2X5A61QnQ43gdeffXMvMw+boEPFY08Nl6XjZ5Bb7LoUWNXqUj7cYwXfm1SrxWL3urNiU7iKVu0E/Gsg+6qEcMWcLXn7MzNf2kw/gJ0L5vB+gmwO1wZuZYjdlRaIcOfnRF2BDCqZpfnLI9x7g6/4/ 7OQULZUm OeyYk0yzQr/3jsfe9Oh26DxgFRF2+sK6YziO66+HJAXCm8go89o4Fsj51YYKf5m+0gXYcSHbtQd3xdLdwtoaNK4w1lJxH5UFOoTo5qgfi6Epj8HB7bt/gEoUChWapfjvTjV8KP7K7eyRxORmiGwd3Faqib6AYYdlrYLRj/uJB9IlatZUlq302aEm14UkFnxS9sxoG5kpXX9ipjAAF2II6nbNt5gW8F3H+DEvH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Mar 23, 2024 at 03:15:44PM +0100, Uladzislau Rezki (Sony) wrote: > During the boot the s390 system triggers "spinlock bad magic" messages > if the spinlock debugging is enabled: ... > Some background. It worked before because the lock that is in question > was statically defined and initialized. As of now, the locks and data > structures are initialized in the vmalloc_init() function. > > To address that issue add the check whether the "vmap_initialized" > variable is set, if not find_vmap_area() bails out on entry returning NULL. > > Fixes: 72210662c5a2 ("mm: vmalloc: offload free_vmap_area_lock lock") > Signed-off-by: Uladzislau Rezki (Sony) > --- > mm/vmalloc.c | 3 +++ > 1 file changed, 3 insertions(+) Thanks for fixing this, and FWIW: Acked-by: Heiko Carstens