From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0B3DC54E58 for ; Tue, 26 Mar 2024 07:47:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B7176B0092; Tue, 26 Mar 2024 03:47:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 266DE6B0093; Tue, 26 Mar 2024 03:47:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 107BE6B0095; Tue, 26 Mar 2024 03:47:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F21AE6B0092 for ; Tue, 26 Mar 2024 03:47:21 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BEFD4C02B1 for ; Tue, 26 Mar 2024 07:47:21 +0000 (UTC) X-FDA: 81938409882.04.EBC4632 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf12.hostedemail.com (Postfix) with ESMTP id 60C3D40003 for ; Tue, 26 Mar 2024 07:47:19 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=INdaDbHP; spf=pass (imf12.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711439239; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eh6YWin4ixIRlQKZhkJaK+gt1fOR8Sruq8BTre+DvX4=; b=B9Cjnb0YPVgGDdHX4nwHXwDfUfgBjenabt8AVCTSD/z9Oz5poFpf99MVorY82ae3H4Q29C LO8w8/iS+42cS7TKQiAhU99A9DnwyzPPQg+pmInrC2alchhjiuv80vEXHE8bAAV0lzlmZV KoKoLBWzqqi8Gqjh78uGkRIXCZz1zOg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711439239; a=rsa-sha256; cv=none; b=oj0DA7ASPPZ8ejJEgzZIZ/SIgXXAglZxv5qvwtIXS7U3yGZ7Sn9DuSNgM075umHuyXHwFG PfR8xy1o/c0XdawOErv3+3ZHizadthLL5SiH1MmFkq4Rlgvf0dPh49J2QAEZkQEpRTfx66 7sDE0leooEcoroBxbrgdkkmSGU0WWkE= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=INdaDbHP; spf=pass (imf12.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 42Q5CR5f028966; Tue, 26 Mar 2024 07:47:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=eh6YWin4ixIRlQKZhkJaK+gt1fOR8Sruq8BTre+DvX4=; b=INdaDbHPtQmyBuX1tZ1m1DYNfH2BxAXTDyvYkZfi8dJywOagtoEhhMkvPV1PvyRVn1hL Wqyow3rpDF/kDRel7qV1BQprSuXOTJg3hO7hhR9f7K5vYAsYlIEumyIVvvldX4E6QbXm Jwe/yZG/ysPYV54qp8MWPEKg69KxHVDsUxa6MN+jn8mowsc35QftvpCkJzi3qzwGOaSd wivFdkI18icHFlE6zXRUCqvne2mSw0EAwgAW/9ILbwCgiROirB1C6GP398jp4X7ScHgi 5t9rTUuoazqaj4wJdnCZz0SfDIowbnzCcldHnrWj/1h0cLkHV8YjI99P6rx7UoRGYN7S Qw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3x3r0nrcr9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Mar 2024 07:47:05 +0000 Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 42Q7l4nS012588; Tue, 26 Mar 2024 07:47:05 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3x3r0nrcr4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Mar 2024 07:47:04 +0000 Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 42Q54JOd003767; Tue, 26 Mar 2024 07:47:03 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3x2c42nve8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Mar 2024 07:47:03 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 42Q7kwd253019068 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Mar 2024 07:47:00 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 820542004D; Tue, 26 Mar 2024 07:46:58 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3F3B82004B; Tue, 26 Mar 2024 07:46:58 +0000 (GMT) Received: from osiris (unknown [9.152.212.60]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 26 Mar 2024 07:46:58 +0000 (GMT) Date: Tue, 26 Mar 2024 08:46:56 +0100 From: Heiko Carstens To: Qi Zheng Cc: akpm@linux-foundation.org, vishal.moola@gmail.com, hughd@google.com, david@redhat.com, rppt@kernel.org, willy@infradead.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christian Borntraeger , Janosch Frank , Claudio Imbrenda , kvm@vger.kernel.org, linux-s390@vger.kernel.org, Alexander Gordeev , Vasily Gorbik Subject: Re: [PATCH v2 3/3] s390: supplement for ptdesc conversion Message-ID: <20240326074656.6078-C-hca@linux.ibm.com> References: <04beaf3255056ffe131a5ea595736066c1e84756.1709541697.git.zhengqi.arch@bytedance.com> <20240305072154.26168-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240305072154.26168-1-zhengqi.arch@bytedance.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: ju8ifvxWc2aeJahBllXnpXcsnT2z65ij X-Proofpoint-GUID: IArssar9KmfzzvMUCAa5e8JZkKunr0L3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-26_04,2024-03-21_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 malwarescore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 suspectscore=0 mlxscore=0 mlxlogscore=292 phishscore=0 bulkscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2403210000 definitions=main-2403260052 X-Rspamd-Queue-Id: 60C3D40003 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: utje4dqhcr7k3idttioosar47c66jdph X-HE-Tag: 1711439239-717838 X-HE-Meta: U2FsdGVkX1+7XtkWhMC3yDjEg8MMWE6r7DF3aPUtKtvvFO8sRIKtiV3IQQrEfUbXidmJC+dEKGBFQlTw3fIzohyv4mM+wrXHvYeYdAekcaelaEpSG5MADwQV0tsVX5UgUnEtJxz68TkAI/F9Cd9Ph65t/L769jhXHqFzD6Hkc9BYuJ1xVT8KPaZInKr3MsFK+wZJgpyr4HtT9Py/wK42OWaoICgQJ92okUZe4V+f8z3PvUSdCEh4vQ85CNrESCPNLxOrOhnviVh60M5GLqthFQnovlTsG3Q+BD6Tdv9tn0yhXgALzC3Ab2uocf+zAxao5UdzzOOqTPqf3ES/QZJkKbxtOXS4y//EuTr+5EyPjTeEXQEUkUHl2Zxhm5qxIl1UGiitCW6IZ5iYXr3xrplLiCtDQRN6jFO1Tja6sLx5mQP7+WHtEEVPNAdnzcOc+GMzfqBAgtU7KmANO8IDTo3oQyxXmhayL97fISLC8S7INgvqymhI/OTlv17fh4xPzXk4RlvySMIwNC+FDWYpvcheca1DvhwCsiYtSBVRqMnIAVoRGoqNfG6XvyMJ+Px5o0BHsfAfw8xyy1KuUEw+OudoSitSNIG+uux6HYjW+nCrzFI+TNXK3ZaBqRw0wJ6BmzwwHzFTFyguyfVhe4LgWrbQUS9BfMUd/haEV7LWc3OFC4X2JrzRVtIWB0YTx+m2euTUb+8e9hQ09Qxs50Br7yK/Pu5J3A1tHI9KyoflFcWG4nOVUVunFlz0rDpPzAnAp0KQaiV/m/4EjENcAj+bV+cJFIrMLLGZV4v2oR0dGzaDjuBcZ870qNhTQo+kq20FWSMi+AW8uby30Li3b1+Vyhj/yyjhqRJz11NMgmvzdD/Or+mlE6K7IXCWrlm3H7I8opSOTQ8or5994KC2wwgu7Egmh1HH5apU3Oq2NWCg070QUVVlIxk+QSWe/HsEmS28ybJt2iSH8z4GB3evfQX+rEM cVA+l+dD O8u2fwMEcSYglbSs5q0yQs4/VNL4ln9MrrLN7FVaKegGzUf049pu4UXPDrJpPfXCVXl57E8iZaiGKKhHPUDzL04nrPEfJBd92OOK75cXkZwjRt/oLMZuf0rZY4XOad9pTlnM4XbZ1I1yajAMCRoHzzZyEWpXJ1oUiHALgZCGB18aLrD//3DMiw4gEjUFD7+KgpLf/wg1R26I76wpynVBg1rqxVfNVN2SZeTPMjbcaWWKBHtcnNATJcd9TCTHIjbQRJDUYLoNqmGKpn/iQaSITkHabux7+FomVSowA3qbGknH/0nVbk0H89mycs3/O5e5wv2XnQ+2QE2zWq98Ms8vLq+VTDWS2dk+MrmO0/Q4TrNkNVrc+BF0YlT3y8IkIy+mNiKNSmRMldURF2igbp7Y/utw2euC13q9nhm3z9ii0XhtruxMB5aGjp3yVNvQJzamvb2a0XP0fRQ2yLQ0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 05, 2024 at 03:21:54PM +0800, Qi Zheng wrote: > After commit 6326c26c1514 ("s390: convert various pgalloc functions to use > ptdescs"), there are still some positions that use page->{lru, index} > instead of ptdesc->{pt_list, pt_index}. In order to make the use of > ptdesc->{pt_list, pt_index} clearer, it would be better to convert them > as well. > > Signed-off-by: Qi Zheng > Cc: Christian Borntraeger > Cc: Janosch Frank > Cc: Claudio Imbrenda > Cc: David Hildenbrand > Cc: kvm@vger.kernel.org > Cc: linux-s390@vger.kernel.org > --- > v1 -> v2: fix build failure (cross compilation successful) > > arch/s390/include/asm/pgalloc.h | 4 ++-- > arch/s390/mm/gmap.c | 38 +++++++++++++++++---------------- > arch/s390/mm/pgalloc.c | 8 +++---- > 3 files changed, 26 insertions(+), 24 deletions(-) Same here: Christian, Janosch, or Claudio, please have a look and provide an ACK if this is ok with you.