From: Baoquan He <bhe@redhat.com>
To: linux-mm@kvack.org
Cc: akpm@linux-foundation.org, rppt@kernel.org, mgorman@suse.de,
Baoquan He <bhe@redhat.com>
Subject: [PATCH 5/7] mm/mm_init.c: remove the outdated code comment above deferred_grow_zone()
Date: Tue, 26 Mar 2024 14:11:31 +0800 [thread overview]
Message-ID: <20240326061134.1055295-6-bhe@redhat.com> (raw)
In-Reply-To: <20240326061134.1055295-1-bhe@redhat.com>
The noinline attribute has been taken off in commit 9420f89db2dd ("mm:
move most of core MM initialization to mm/mm_init.c"). So remove the
unneeded code comment above deferred_grow_zone().
And also remove the unneeded bracket in deferred_init_pages().
Signed-off-by: Baoquan He <bhe@redhat.com>
---
mm/mm_init.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/mm/mm_init.c b/mm/mm_init.c
index cbdb49cdd2ce..cc24e7958c0c 100644
--- a/mm/mm_init.c
+++ b/mm/mm_init.c
@@ -2006,7 +2006,7 @@ static unsigned long __init deferred_init_pages(struct zone *zone,
__init_single_page(page, pfn, zid, nid);
nr_pages++;
}
- return (nr_pages);
+ return nr_pages;
}
/*
@@ -2208,10 +2208,6 @@ static int __init deferred_init_memmap(void *data)
* Return true when zone was grown, otherwise return false. We return true even
* when we grow less than requested, to let the caller decide if there are
* enough pages to satisfy the allocation.
- *
- * Note: We use noinline because this function is needed only during boot, and
- * it is called from a __ref function _deferred_grow_zone. This way we are
- * making sure that it is not inlined into permanent text section.
*/
bool __init deferred_grow_zone(struct zone *zone, unsigned int order)
{
--
2.41.0
next prev parent reply other threads:[~2024-03-26 6:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 6:11 [PATCH 0/7] mm/init: minor clean up and improvement Baoquan He
2024-03-26 6:11 ` [PATCH 1/7] mm: move array mem_section init code out of memory_present() Baoquan He
2024-04-02 8:19 ` Mike Rapoport
2024-04-04 1:38 ` Baoquan He
2024-03-26 6:11 ` [PATCH 2/7] mm/init: remove the unnecessary special treatment for memory-less node Baoquan He
2024-04-02 8:32 ` Mike Rapoport
2024-04-04 3:23 ` Baoquan He
2024-04-09 15:40 ` Mike Rapoport
2024-04-10 3:38 ` Baoquan He
2024-04-10 3:35 ` [PATCH v2 " Baoquan He
2024-03-26 6:11 ` [PATCH 3/7] mm: make __absent_pages_in_range() as static Baoquan He
2024-04-02 8:29 ` Mike Rapoport
2024-03-26 6:11 ` [PATCH 4/7] mm/page_alloc.c: remove unneeded codes in !NUMA version of build_zonelists() Baoquan He
2024-03-27 12:06 ` [PATCH v2 " Baoquan He
2024-03-26 6:11 ` Baoquan He [this message]
2024-04-02 8:30 ` [PATCH 5/7] mm/mm_init.c: remove the outdated code comment above deferred_grow_zone() Mike Rapoport
2024-03-26 6:11 ` [PATCH 6/7] mm/page_alloc.c: don't show protection in zone's ->lowmem_reserve[] for empty zone Baoquan He
2024-03-26 6:11 ` [PATCH 7/7] mm/page_alloc.c: change the array-length to MIGRATE_PCPTYPES Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240326061134.1055295-6-bhe@redhat.com \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox