From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To: Helge Deller <deller@gmx.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Yajun Deng <yajun.deng@linux.dev>,
vbabka@suse.cz, lstoakes@gmail.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 RESEND] mm/mmap: convert all mas except mas_detach to vma iterator
Date: Mon, 25 Mar 2024 16:26:48 -0400 [thread overview]
Message-ID: <20240325202648.ogekznob5vsayd6k@revolver> (raw)
In-Reply-To: <5dc6860f-df05-457c-8b78-067f276e423b@gmx.de>
* Helge Deller <deller@gmx.de> [240325 16:24]:
> On 3/25/24 19:53, Andrew Morton wrote:
> > On Mon, 25 Mar 2024 14:32:58 +0800 Yajun Deng <yajun.deng@linux.dev> wrote:
> >
> > > There are two types of iterators mas and vmi in the current code. If the
> > > maple tree comes from the mm structure, we can use the vma iterator. Avoid
> > > using mas directly as possible.
> > >
> > > Keep using mas for the mt_detach tree, since it doesn't come from the mm
> > > structure.
> > >
> > > Remove as many uses of mas as possible, but we will still have a few that
> > > must be passed through in unmap_vmas() and free_pgtables().
> > >
> > > Also introduce vma_iter_reset, vma_iter_{prev, next}_range_limit and
> > > vma_iter_area_{lowest, highest} helper functions for using the vma
> > > interator.
> > >
> >
> > I assume Liam's earlier request still applies?
> >
> > : Helge,
> > :
> > : Yajun has changed code that affects parisc with this patch, which hasn't
> > : been tested.
> > : ...
> > : Can you make sure that the expand_upwards() still functions on parisc?
>
> Oh, I didn't noticed that request earlier.
> Anyway, I now tested this patch on top of 6.9-rc1, and the kernel still
> boots up nicely on parisc and as such expand_upwards() seem to work as before.
> So, you may add:
>
> Tested-by: Helge Deller <deller@gmx.de> # parisc
Thanks Helge!
Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
prev parent reply other threads:[~2024-03-25 20:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 6:32 Yajun Deng
2024-03-25 18:53 ` Andrew Morton
[not found] ` <5dc6860f-df05-457c-8b78-067f276e423b@gmx.de>
2024-03-25 20:26 ` Liam R. Howlett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240325202648.ogekznob5vsayd6k@revolver \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=deller@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=vbabka@suse.cz \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox