From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB878C54E64 for ; Mon, 25 Mar 2024 23:14:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B0076B0089; Mon, 25 Mar 2024 19:14:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 460F66B008A; Mon, 25 Mar 2024 19:14:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 328536B0092; Mon, 25 Mar 2024 19:14:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1FA916B0089 for ; Mon, 25 Mar 2024 19:14:01 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E0DE1160665 for ; Mon, 25 Mar 2024 23:14:00 +0000 (UTC) X-FDA: 81937116240.27.7EFBE64 Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) by imf28.hostedemail.com (Postfix) with ESMTP id 25829C000F for ; Mon, 25 Mar 2024 23:13:58 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=hfYuXdaS; spf=pass (imf28.hostedemail.com: domain of keescook@chromium.org designates 209.85.160.46 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711408439; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YTiIah+56OL95MvLxsoMlL16NsHmbf/z1NDz1O3yUIE=; b=J/aVHL+rh4MgwQwrY5gQhvC0CXGjoce4y4tdt4n+S/6a5JlFXarVIKRE5en9GVwTu0fekk /JKwhECq7eDn2e35leepHb96I8PHk40ChUOySP1OCBFAS6dqqNdRdDlESSvhkbMcWxKEDw QfngtyA9HjFfQVOVUwHy05OsMtcUkNc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711408439; a=rsa-sha256; cv=none; b=pwnxQpj3WIDi6mX05/+p4+cs+9Z6YKJswzeH5ZG2BZ43zTANloAd7a2Xmntym94hwIz9W8 FNZmhtE7v8V1bUZdzy9btax2+OWjrnE8DwtW3aan5LaKy0iqXe6bn6XFdju/d2EzyrIfys qgeXRYcx2X2Lmn1k6+hYgP4sVU7oosY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=hfYuXdaS; spf=pass (imf28.hostedemail.com: domain of keescook@chromium.org designates 209.85.160.46 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-229a90b7aa9so2284472fac.1 for ; Mon, 25 Mar 2024 16:13:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1711408438; x=1712013238; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YTiIah+56OL95MvLxsoMlL16NsHmbf/z1NDz1O3yUIE=; b=hfYuXdaSBxQggk91ZcoqB/6yx1TOlTQtOnbQJNkB+hF35wjhJQSqdG3R77d6pKtvSn FPk3m5JkmasToTncoPDhbQ5UJYI0Wm9Q6GOD/OLViiDcRAm2RAq25DRU+7ZDP5wzlImk 0RmqzyB7i5a6ZIEGjvmzrEwPjvbMLXy15hD+k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711408438; x=1712013238; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YTiIah+56OL95MvLxsoMlL16NsHmbf/z1NDz1O3yUIE=; b=GD93mk6vRGLpDWZsckktTkP0mGqnhICLyRpPQSa/pfQbHPsFjKaZfKFEh93nnvLeJa f8jgVQC56Sd/aykq1ASRozyX8jwgfVVsMJ9YE+vF7NZ2Y6ssbAzySBDmhHlqVDtLmpkB y1+EelMjmc4vQsFhlBn8/I+drDKqxI0jSVK2orxQQa3Hd+8BYDZMc3/5IrlCt4qUqwkV EcBH0+YrLu08DN2LGkSgb1pfp8xWsa1KgOtwepdFvXlJiUUg/cM7P6mc/twNBjpeqsIT kylNSHE+rx/uFLIEXSQzYoXxFtcco4gMQUcSuduOTpu8YnNusUXUQy0ohCQFQ/HbRldw S9iA== X-Forwarded-Encrypted: i=1; AJvYcCUvoRUMD1aTwkskPmrULniR5fIXN31VQNbaNdyjGetVOOEQ1Egr7y4zBmA0vxrqc4hXQ9cnfdn+SzhczcxLPNZuIf8= X-Gm-Message-State: AOJu0Yzvj8lCSLoBqAADde+t4QQ/FADWvZ4VATM/CV/eyejXT1CKn4Gd IcJ5zoykjMK/uxmjNxXFviU3HRCCrzhk9sMTc/7hMKgkcxYVilJ0ICd8Pbo39A== X-Google-Smtp-Source: AGHT+IGtyD4P4iqpqDllYpprt5vrEviS5VJKJGKD5uIFgXBnta+btyjjzK1a/0Cds/Qxz+YmqTU1tA== X-Received: by 2002:a05:6871:554:b0:229:b0bb:3017 with SMTP id t20-20020a056871055400b00229b0bb3017mr7943491oal.59.1711408438066; Mon, 25 Mar 2024 16:13:58 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id c29-20020a056a00009d00b006eabaf689edsm27328pfj.113.2024.03.25.16.13.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 16:13:57 -0700 (PDT) Date: Mon, 25 Mar 2024 16:13:56 -0700 From: Kees Cook To: Kent Overstreet Cc: Vlastimil Babka , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, "GONG, Ruiqi" , Xiu Jianfeng , Suren Baghdasaryan , Jann Horn , Matteo Rizzo , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2 4/9] slab: Introduce kmem_buckets_create() Message-ID: <202403251609.1F681B5D@keescook> References: <20240305100933.it.923-kees@kernel.org> <20240305101026.694758-4-keescook@chromium.org> <202403251327.C15C1E61A@keescook> <67tgebii42rwneeyqekmxxqo2bzgyysdqggciuew27bc3gbrkg@5ceqjmiaxvyu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <67tgebii42rwneeyqekmxxqo2bzgyysdqggciuew27bc3gbrkg@5ceqjmiaxvyu> X-Rspamd-Queue-Id: 25829C000F X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: wq4pq1a7e5d764hgn8nk5pork6ymqwzs X-HE-Tag: 1711408438-871944 X-HE-Meta: U2FsdGVkX1/azosidZvI4C8dk/wV3JNnWc0Jy7ddL8KnCjXEEMl7k60NJxkm+h/3pgd2ZDNInZx9RHHNA6nSbviY4tpoHGgVYZibFN+tJNRuVbR0BqVZcofq12IF0fGqFG9zfhheOIxwG5CYtYg8yaEPDoi67MDzDbnR9L9mP7/iSmSlL8tXMdZz1kCgTzIPQJGBn6hSprXRM8GMWIigAXEDpVZW43lb9J3vek2psiQ1wieIAyZ8Rh53i6Uw4hrdi38G9an94NQn48brAJJD3iXeoiHEJQAPkNdHNqEIce68tyopwIsCxyuMZvymnUmR0utXBKV0BvxAMInqOne5LBzvUoEKdqaUEEc5tvPl71ZvyMpv98N/zusW/ceKFON3CsXHQT10eSdnfOjDd1z2Zn4SArZTCS+x7UyJe3uzNhH6R5kUu4a0qXozLk2jzX3aW1/rYz10NZAYsTd81Tntu57w7pmyHOoBqf/DWh8Qje2KRKMn7E6X+LOO9H8gN/8DfSnO29SqoW3rpnNubbJUVI+Z2pYmY3aMA64KDP/1emXHJtUp2rq2z7GeAsjRK1kddt4ZVsefOLqvfbB4DKJXarCfbUrZ1rXBDAcNR0Uva1RI8ky8avB0NEZrRd0FC7Mkk/v1Bk6eOj1nkF1x6jR84jJ5KTm26QptpK+1d7rp0tVnMYsvK+fNiVDxInIGWV3PZ/ET0obbM6Ia6etBSb/NRr/WAPTXxk++OLBowfDaT8BjhbRew1ZZ7dlZt+2vrRUZlPx24UTn6ARzNuEPS+Or/fVboowgP6NDnJdgrXaOebeFZnCp+d/VTJic7mQlUOAAaboxhq6GQkCGg3bCXnk8Kd+OB3/ShgC1b1bznn6GaQ17e3PtWQYOVyMNjlqAwA0VMzU90RFxA2sgcBvwfmmdJRRj0OnDWrCHU8sfGGr3gjAX1rDosrLT2OwYWgMKyRaOZp1k47rD9eDUuiz05iL GuNPk4k3 gz+VQSRiROQJUWBWi3khS0cLg4Iy5BxxREQpE1l+NljXLEPsFDEudJMiv1ba9eDiX/myD6oIk9cfUf5uOo2Tvw/YxSmpXAT6HxD0TYemJMGktryHKO8sCvhh3ZdpTUrPVXMw3WYp/T2CLUkAT+I7pHI1qSGsstIbNke/PV/XLTjLo0ENqks72/qzwP/T+w9W54mvDPsoGirP8ICXoKfo5AGnSWZ4z2LAkt/kzqP8ttlNJqBm06oaTCPPW7gLayz1Fr9GR0F6GlKu1X+gNYwVHY0DkE1RVp/r1ZwmKn7bZ4wKjbvCRrt7VCAr42T1l8J1iAYoqLpCewM0CGmDLh1C3+5L1ce3xBDsajtqoaV3QF5EcAFsr2hQHFn9ee+oVv0FleQaceY4pYmoG8vkVdOahsNmhZVJx+VgWc4E4Tu5cwyXTWOMGj4HPo2kC3GJo2Awo1IoEC/POCHF0JuHmuTlVXBV6QA8LRweHYDTkiWfCmbwskLp8Av/dZ7T0CKnvH7PpFqU/h/BLLaboDY0Mvh5Hzk7BG9MjFvJC30IwBcinaBdfxcbIbnhkBKTbjZUqbswjNu66/lcduEX/BeZq9jH29FsE1W5xPXYwg4a+N2UMX7i1GyU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000048, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 25, 2024 at 05:49:49PM -0400, Kent Overstreet wrote: > The codetags are in their own dedicated elf sections already, so if you > put the kmem_buckets in the codetag the entire elf section can be > discarded if it's not in use. Gotcha. Yeah, sounds good. Once codetags and this series land, I can start working on making the per-site series. > "usercopy window"? You're now annotating which data can be copied to > userspace? Hm? Yes. That's been there for over 7 years. :) It's just that it was only meaningful for kmem_cache_create() users, since the proposed GFP_USERCOPY for kmalloc() never landed[1]. -Kees [1] https://lore.kernel.org/lkml/1497915397-93805-23-git-send-email-keescook@chromium.org/ -- Kees Cook