From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72B65C54E58 for ; Mon, 25 Mar 2024 18:53:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA0346B0082; Mon, 25 Mar 2024 14:53:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C509B6B0087; Mon, 25 Mar 2024 14:53:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3EA36B0088; Mon, 25 Mar 2024 14:53:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A22666B0082 for ; Mon, 25 Mar 2024 14:53:15 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 75D34A0B78 for ; Mon, 25 Mar 2024 18:53:15 +0000 (UTC) X-FDA: 81936459150.24.31FFDD9 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf06.hostedemail.com (Postfix) with ESMTP id 4FB32180006 for ; Mon, 25 Mar 2024 18:53:12 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Q9g5y6xu; dmarc=none; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711392793; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3sIb1HoAhmHvLODu/AKdrc4JD1AkmvAmfT71EXdaP8M=; b=NKaTWPhUAlDaZK9OvCeqiBewyZzfX3eL0EaaYt7InKiqNwYKie4xxvtHQUN3jEz90d+rYV MTLKjPhFEUishGnmdKRQgamsm6gsKXHxKkgYpyw2axXpyCqsgBJ0n6PoVo2Skj6EfYnUJB oHNJLHio4yEX7Yd83e+kRwVzkeiK2UI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Q9g5y6xu; dmarc=none; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711392793; a=rsa-sha256; cv=none; b=OKPzMsLZS6fXHDny/1cx7whoQukM34OUBC9lrLwuwKWmWqPt5Sxe8GvxZc5GvoCu5olOPr y4VhO+ERK9O5uC09gkitE3ahhB0OYoqHJBt1asJRXpL0WQDUDT8PlSgyVSx74pUk8NHkHj mT5Is5Jc6zN5JXx1X4baJ83UnQA1uWQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 60CE4CE1C8D; Mon, 25 Mar 2024 18:53:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68596C43394; Mon, 25 Mar 2024 18:53:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1711392789; bh=hR9UJe32aZ/pMA7yh2LGZsAJ2lJT5ALVWGf+CC7hfDo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Q9g5y6xuMwEftgqfh1bq3/Ph3Ud+vrX5q4vxSmJDvBvTl7EZl5EKO4aQ67VzxtVl7 1B1mxve0S8vb3y68vHymsitx0gVaBrBWktwohEk+HPZ5yNLewQjTj0aVn1ZIQlaK1e yH6Qw5PxoX7Ff8ubgyN7r3+1AptaDdqP66jWQu0Q= Date: Mon, 25 Mar 2024 11:53:08 -0700 From: Andrew Morton To: Yajun Deng Cc: Liam.Howlett@oracle.com, vbabka@suse.cz, lstoakes@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Helge Deller Subject: Re: [PATCH v2 RESEND] mm/mmap: convert all mas except mas_detach to vma iterator Message-Id: <20240325115308.f6344233a27f1633f642f888@linux-foundation.org> In-Reply-To: <20240325063258.1437618-1-yajun.deng@linux.dev> References: <20240325063258.1437618-1-yajun.deng@linux.dev> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4FB32180006 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ri9n66w8hmcuizp1co3o6hxoqpafy1w6 X-HE-Tag: 1711392792-85195 X-HE-Meta: U2FsdGVkX1+8bNbpERhRQdRNFvVYvbSCyEG3ZYQ3X40ROubZZQxYMAdmnCYDzkyb0cHbkVqwSTboMlBtPjy7PrrKydnszeaeeUCInpkZ8+ds8G84gb6gp/i1TM3Huaf9gOy3CCDHwFQ+W59ZlAi469HgPFfNL3sH+7aSKdiKgRALPeIWPS/8WQ4sXrYZ9sz4WKIkcj3SGR7OKJBFDOWwF1ZeM/A6qS8lwIGMJd2dl9p9LwEJoLhF83oXDVqguovz5V33Wqs3yQX6zJMzq2eV0J30n9SV+AZaxk2vPdOeHT0sg5ORpbeWLKettXU2plrTv+GxAhjlCIS4q0YGLC3OwfuEhG8ZZt0xpFPde93MHoQcJp3GuCgSDmxNfM0ikPVsX+xnK+mWUbd8QR46rwPZxUJ6HfnvGTMjnD4NZ+GERLwRu1e+5XOmdSOu5ZRmUoHymiNIuecmVOaJwNga66EVqRWbn03cEaDHweQ3+LpipbPsyz1lxe/ZFFRcBO7pKIQLcahc/mLp2sb5jjJko/f0hADVnQmGU71kmAXPUb/aNS3afLDposfzQRLZYMSUhVOOyxlDLyCpl+f4G4CCBM6YnM5BAxwaEW6HDKcOhaPxEfkQmP+jKC7Qu+jEkIgYLzpZFOoHZk5qAT2uUlRiUnUeUa5G0RGAkFAz/jeWXozl3Snxf77G8HfMIivyjahYLc/iWg+ZBrT6XldLuVaypE1eK2Wt3Hole4s5QIUOjtHLnQgZAQ7QSnsRQbOHWuknx7pzoDp/79ZxEfMvK9185zUxR1ZkphXT1TSNZ4Zt70rJ/mnuSV6DdlE0H5vCAtYnSvaoUZSIQou1JXu7OYhmps8a9MPy/ONRAVQrBfODRyERZtojToSC4ckDL3vJylHbKXd/9IxRbWKact6uZWQs0jQ8waeH0QF7h5jLGeBjtWVR4agx5Il6aROrFknd9V1/LQJ8WdXGfe8nBCrAvNeZD1K GDjg1FOe CIEmwlWaUPmIAiSbhv26yG6VmGSA64HOnlbrx14PBzypgQBGx8UMEo8XgE7/4NCtgpp98JzStGf2kwtkncDtlWSZvJ/VpAG6ou0AdXAWGLh7nK+A06VJAWazIHWJHcfoM66iNYquCW+7e8FZ4ZvQGbL6Z+vFKBAsjSD0Kwq9d6GACnNNUujYdr93IZpA6ySZnUmKO3RiqJFF4aEtLMg+I83eUq2CB6GCpfZXbvNBuBxHs7i5XGnyWEw+3jsKMsbRIiLO14snan0EimrLCMwhIC/HE1bI3zrE7Qn0tTjmdteG0Q1w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.026964, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 25 Mar 2024 14:32:58 +0800 Yajun Deng wrote: > There are two types of iterators mas and vmi in the current code. If the > maple tree comes from the mm structure, we can use the vma iterator. Avoid > using mas directly as possible. > > Keep using mas for the mt_detach tree, since it doesn't come from the mm > structure. > > Remove as many uses of mas as possible, but we will still have a few that > must be passed through in unmap_vmas() and free_pgtables(). > > Also introduce vma_iter_reset, vma_iter_{prev, next}_range_limit and > vma_iter_area_{lowest, highest} helper functions for using the vma > interator. > I assume Liam's earlier request still applies? : Helge, : : Yajun has changed code that affects parisc with this patch, which hasn't : been tested. : : ... : : Can you make sure that the expand_upwards() still functions on parisc?