From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5F02C47DD9 for ; Fri, 22 Mar 2024 07:04:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FB836B0083; Fri, 22 Mar 2024 03:04:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0834E6B0087; Fri, 22 Mar 2024 03:04:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E182C6B0089; Fri, 22 Mar 2024 03:04:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CC1906B0087 for ; Fri, 22 Mar 2024 03:04:11 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 69D3E802AC for ; Fri, 22 Mar 2024 07:04:11 +0000 (UTC) X-FDA: 81923785902.09.0ABBFBE Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) by imf26.hostedemail.com (Postfix) with ESMTP id 8622F140006 for ; Fri, 22 Mar 2024 07:04:09 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=MlhRDkbv; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf26.hostedemail.com: domain of horenchuang@bytedance.com designates 209.85.210.43 as permitted sender) smtp.mailfrom=horenchuang@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711091049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fvdqGcDUWp3D4k7+aVnVSTSeWYL78OJhC3HPSf53QMU=; b=qCmJY2P5sWY995OJWuSnDozcZmyxynJtfmVFepJUnO2KaeyEvWdXMoUu4/dMosy8ofoytN 6nY8ofLLft5uzkKADE3WSwvDv7mYPeCwBsu+4fjE1gOh/4zdwf/CRaVZUZ2IG/v42ejnuk irCuGk+TFxiAZjE2HnV7JpEbbB7WM0o= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=MlhRDkbv; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf26.hostedemail.com: domain of horenchuang@bytedance.com designates 209.85.210.43 as permitted sender) smtp.mailfrom=horenchuang@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711091049; a=rsa-sha256; cv=none; b=2iVYVg3HU67KkNsEPrJ/BfSTaRIdEek5HbLD+G980NqIZgZ31UgR5jIbDho0yko0vZI+wS krDhUEziPa5jppb0Uvt29AGJTWwC6mE7ZhYeqwSYnzVsMH3ZD2nDzX284w38JpSxK+qrIr utkFcihtr+s6c1hjkTmiuYaVhCLbu9A= Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-6e6b01c3dc3so921080a34.2 for ; Fri, 22 Mar 2024 00:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1711091048; x=1711695848; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fvdqGcDUWp3D4k7+aVnVSTSeWYL78OJhC3HPSf53QMU=; b=MlhRDkbvJLFY7FDMjMTTpKpITg4sYlb1tH9wL9fw+msrJtOJMeXAHCVvjbrtJSZeq9 w4FjoWBuYrsbkcsWCuQrqYq8Hh6+pEdZ4k6JoICcf9nuF7vCUWR6uuNQPcFCXCbPNOcc Qk9whYUy+IGBAB4Tgpb2oc1ZthixiJQYdAGvszGn/z8Ygjf4lkyVyxY5U2ZzPox5G5kl VcJV1eQ4L0u3R4dNaHcDQ54wnIk8vYphvWLwVeShz0J+EKpzb5Xbeb5fRNEqhYtjTK/K y/MDilfKhzxhgMQ6fQeKD7ppUwxsNs6V2mevsqcIxoSNUqKM1ovoqFtn1i9+oIuueOnI 0WoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711091048; x=1711695848; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fvdqGcDUWp3D4k7+aVnVSTSeWYL78OJhC3HPSf53QMU=; b=Y3Hxsejcaz6QznGimEwygPVAsUSp9crTtyccCH7AJy9WYrctbnGMU1902fu2xuIyR+ h80XsIan4e6lPpDtqWie54HCkQoabPwTbFQLRZlaNgJH7LO20f0j1L475YErZLukkPXN WP1I8rzHYwn2+xXwOTIV4fJMcNYN9F4lPdBikTa6lVlEiW9PqVh667y3iSUQzA8YKdmq 7c7fGUnW6A7royZSA2RzrJPBWLipP7ueTb3wYCYmJTWJ6pYRU3buGZOkwUt0cEAZn7B3 gDwqwp3xyjOLa0/y99bgLtgb4AwbebThi7T4o1BAyuQdGdUsKmVLNtUKAduhGlCGOsYi 2ILA== X-Forwarded-Encrypted: i=1; AJvYcCVg0r9jlkPdVhW3RUmGM2gmHyuE/L3kHBOFvUUBUjnYtxmxNBK61jlAQILRmOBjBax4PxAtivBVtdBEVxXAV1FE54w= X-Gm-Message-State: AOJu0Yxf8WO22QMgMDsUT1sZPu9WBIxCB4yjM+7kXYz/iny4HSxL3Gmh mL4N8pJOs5akDXBCzuWdP3xrmRk66Sul1d0y1AV9IGxOfW5+5P2YXrbXxePlIbE= X-Google-Smtp-Source: AGHT+IExMx82G1L/gVZ6jXrs/MSYhc9K/oqB/ubjzqHOlRbMAoe/h5NMx7SZB1F0B8mlmh4A9A/ppg== X-Received: by 2002:a9d:6e90:0:b0:6e6:a66e:842e with SMTP id a16-20020a9d6e90000000b006e6a66e842emr1756946otr.21.1711091048480; Fri, 22 Mar 2024 00:04:08 -0700 (PDT) Received: from n231-228-171.byted.org ([130.44.215.108]) by smtp.gmail.com with ESMTPSA id k1-20020ae9f101000000b00789fc794dbesm553974qkg.45.2024.03.22.00.04.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 00:04:08 -0700 (PDT) From: "Ho-Ren (Jack) Chuang" To: "Huang, Ying" , "Gregory Price" , aneesh.kumar@linux.ibm.com, mhocko@suse.com, tj@kernel.org, john@jagalactic.com, "Eishan Mirakhur" , "Vinicius Tavares Petrucci" , "Ravis OpenSrc" , "Alistair Popple" , "Srinivasulu Thanneeru" , Dan Williams , Vishal Verma , Dave Jiang , Andrew Morton , nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: "Ho-Ren (Jack) Chuang" , "Ho-Ren (Jack) Chuang" , "Ho-Ren (Jack) Chuang" , qemu-devel@nongnu.org Subject: [PATCH v4 1/2] memory tier: dax/kmem: introduce an abstract layer for finding, allocating, and putting memory types Date: Fri, 22 Mar 2024 07:03:54 +0000 Message-Id: <20240322070356.315922-2-horenchuang@bytedance.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20240322070356.315922-1-horenchuang@bytedance.com> References: <20240322070356.315922-1-horenchuang@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8622F140006 X-Stat-Signature: rmpwftznd4uoj9mnbpkpskms6p1zb7zz X-HE-Tag: 1711091049-57820 X-HE-Meta: U2FsdGVkX1+ZyeQt932iG0g7Cd9I4pScKfHiA9C/4QLfhLtiNMOS/NYEX1tyoXtvxj9xqZkyeZyJcR84aDVvfw7EJRKebwk7YnYFy99K1sb1Am9Dji3PYTvyswLF9ClaebQpnh2Vgj+/SWVwsmdBX9SyYVnbcUvbl9JpU3VHFAKOaz+ZQeMsPHr7TpfEicXpUnQzAjpsKrs4/bN3rEotjOCi0KrrhGlOdmri0Mo6NE62knC0waq6eG25ia0t4JYcwT8NnONvVfxfNzHe/Q36jrbu1H5YJ9f0EpzsrhIYWKRh8LN/XCHgr2IDVgM50F238Q7m9qWvuHZ6vgG1wRWoEubhnvtbY7rIcQl58VQ4FnFKgh9OwkrWQFhylB/fAz7DrYYdL9V7H/9b/MDY2GZ2dzC7lB1fSVzi3e4E/cVEap9uggLdhXV2qRCxUmInX6OKTErvY6bwMmBJHbNRO9uTXGwgLMXt2baZd/FtalBB6G4W9LFlzF0RxqIngLCcv/OgFHTKoE8Uc05xuSoOWWrpVyCSG/wkGLClYltGLPk3ewoZnTkaIcXZ5tQj+ko5B8ADuxzF3gWrgxYEw4/dbu9imqxOz2wKBcR+enLtDZeHNp0mIH+KyjwYjjIU9lSZYrjvIDcQjXPD3l+YUdRZ5GJzc+UiPX+8UWUGLsAcbM70Cu1NLk7UFvdOAZ2Ve25QB5LxX2N0+pTRv2EIT1zsCGvp9/gLCBRexjIFtkH5IVI1fxQxO729a2eFauu5Wc/m0m9BFRDs5HcPBt02Ov0jWq6XVZ4RkUzYcCVaQ9OwFQEMJdzWbSoX849WXtKC99cX3KC7Txtflraz5ODc05n6Q+qpFJST5uho7yPCDTw1VcgGvz46K9yocAKQmZjOluAP8ux4hvBGnFeNACyTcfZeu4PxATHd08sLd6pWgBHaon8eojSxkAM8uEALdsjaJXy1wXDQmcIoHbELXITcDXisX0z iR9yCdIU KeiF0Gz5EejZFa//w/5C+/uIVF3uUcD146ERi0bnFAF3Lpbegf3BvP4fgMBBldPuDi5XgRV+4ufVfG3PInYZLDr/2hXarwIY3FdrwWsjkYf0NeqB0KSZ5kZreqGdsftpJy9e0t2jrVlPzE8R/uiLDOOZfTS8vr0jgsdmmPwkZFAZ83t+rB8VlBSu9vX/Y9OQbAUIyDFlJtozDdqqAmhcc/1Vmv6/6G01BImTvEFT0i8uQxuMUCltLk2UAhlzAlBm5Md0wQZAm6/a5G0IqI9YAVWx/8xV2oFQjzjENi2rk3wT0TQGq0uwQFzggJVDRYS6zk3u5ErVyOMmdt5L6VnPTw4s+2WYBcuCeqBYGWUKBvvRbG5Y2qzvK8+zmXFhvw5H+7m+kGhRkSOiZqAqEoGzXbRZMXkHMmrm0LCDvrREccv4I3NHu7QchMN79VoLW0JPQ1uS6V2ChjxMQt7IGsk3dvai6Xf/geXBa/XuTSjPnlvrLmeQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Since different memory devices require finding, allocating, and putting memory types, these common steps are abstracted in this patch, enhancing the scalability and conciseness of the code. Signed-off-by: Ho-Ren (Jack) Chuang --- drivers/dax/kmem.c | 20 ++------------------ include/linux/memory-tiers.h | 13 +++++++++++++ mm/memory-tiers.c | 32 ++++++++++++++++++++++++++++++++ 3 files changed, 47 insertions(+), 18 deletions(-) diff --git a/drivers/dax/kmem.c b/drivers/dax/kmem.c index 42ee360cf4e3..01399e5b53b2 100644 --- a/drivers/dax/kmem.c +++ b/drivers/dax/kmem.c @@ -55,21 +55,10 @@ static LIST_HEAD(kmem_memory_types); static struct memory_dev_type *kmem_find_alloc_memory_type(int adist) { - bool found = false; struct memory_dev_type *mtype; mutex_lock(&kmem_memory_type_lock); - list_for_each_entry(mtype, &kmem_memory_types, list) { - if (mtype->adistance == adist) { - found = true; - break; - } - } - if (!found) { - mtype = alloc_memory_type(adist); - if (!IS_ERR(mtype)) - list_add(&mtype->list, &kmem_memory_types); - } + mtype = mt_find_alloc_memory_type(adist, &kmem_memory_types); mutex_unlock(&kmem_memory_type_lock); return mtype; @@ -77,13 +66,8 @@ static struct memory_dev_type *kmem_find_alloc_memory_type(int adist) static void kmem_put_memory_types(void) { - struct memory_dev_type *mtype, *mtn; - mutex_lock(&kmem_memory_type_lock); - list_for_each_entry_safe(mtype, mtn, &kmem_memory_types, list) { - list_del(&mtype->list); - put_memory_type(mtype); - } + mt_put_memory_types(&kmem_memory_types); mutex_unlock(&kmem_memory_type_lock); } diff --git a/include/linux/memory-tiers.h b/include/linux/memory-tiers.h index 69e781900082..a44c03c2ba3a 100644 --- a/include/linux/memory-tiers.h +++ b/include/linux/memory-tiers.h @@ -48,6 +48,9 @@ int mt_calc_adistance(int node, int *adist); int mt_set_default_dram_perf(int nid, struct access_coordinate *perf, const char *source); int mt_perf_to_adistance(struct access_coordinate *perf, int *adist); +struct memory_dev_type *mt_find_alloc_memory_type(int adist, + struct list_head *memory_types); +void mt_put_memory_types(struct list_head *memory_types); #ifdef CONFIG_MIGRATION int next_demotion_node(int node); void node_get_allowed_targets(pg_data_t *pgdat, nodemask_t *targets); @@ -136,5 +139,15 @@ static inline int mt_perf_to_adistance(struct access_coordinate *perf, int *adis { return -EIO; } + +struct memory_dev_type *mt_find_alloc_memory_type(int adist, struct list_head *memory_types) +{ + return NULL; +} + +void mt_put_memory_types(struct list_head *memory_types) +{ + +} #endif /* CONFIG_NUMA */ #endif /* _LINUX_MEMORY_TIERS_H */ diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c index 0537664620e5..974af10cfdd8 100644 --- a/mm/memory-tiers.c +++ b/mm/memory-tiers.c @@ -623,6 +623,38 @@ void clear_node_memory_type(int node, struct memory_dev_type *memtype) } EXPORT_SYMBOL_GPL(clear_node_memory_type); +struct memory_dev_type *mt_find_alloc_memory_type(int adist, struct list_head *memory_types) +{ + bool found = false; + struct memory_dev_type *mtype; + + list_for_each_entry(mtype, memory_types, list) { + if (mtype->adistance == adist) { + found = true; + break; + } + } + if (!found) { + mtype = alloc_memory_type(adist); + if (!IS_ERR(mtype)) + list_add(&mtype->list, memory_types); + } + + return mtype; +} +EXPORT_SYMBOL_GPL(mt_find_alloc_memory_type); + +void mt_put_memory_types(struct list_head *memory_types) +{ + struct memory_dev_type *mtype, *mtn; + + list_for_each_entry_safe(mtype, mtn, memory_types, list) { + list_del(&mtype->list); + put_memory_type(mtype); + } +} +EXPORT_SYMBOL_GPL(mt_put_memory_types); + static void dump_hmem_attrs(struct access_coordinate *coord, const char *prefix) { pr_info( -- Ho-Ren (Jack) Chuang