From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E21A1C54E58 for ; Thu, 21 Mar 2024 18:58:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70DE16B0082; Thu, 21 Mar 2024 14:58:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BDFD6B0088; Thu, 21 Mar 2024 14:58:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AEA06B008A; Thu, 21 Mar 2024 14:58:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4A3806B0082 for ; Thu, 21 Mar 2024 14:58:09 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 17B9C120136 for ; Thu, 21 Mar 2024 18:58:09 +0000 (UTC) X-FDA: 81921956298.15.8B24FE7 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by imf17.hostedemail.com (Postfix) with ESMTP id E3F0740009 for ; Thu, 21 Mar 2024 18:58:06 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=3ZDiqJ4x; spf=pass (imf17.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.174 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711047487; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j1RSbdCHe2fKV0Yk4hs6rwghyLM721fWE3T8qG0MI14=; b=V+KMVRgpslbAov/xL1kLUMHqkrsjcvhCaLnTFMEfkmu/xA7gQPBfoizPOTzZjn8H8vE9iy KhX4tmMQwsvAdSSNL+KEt27R1qiyjofirXD0YuntXu7sAIff7AAL6l43xR41UACwPRa/we A3wJgL1oeHwhHbXS3WDipf37z/sazIU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=3ZDiqJ4x; spf=pass (imf17.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.174 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711047487; a=rsa-sha256; cv=none; b=icuYYb1egJkB5AruiVjiDAgpKvl5y1UKf96pGrX4uWZWsAfTWjchTykWN7qJoE8+DSgpxq By2TezIxhPkbs/8U9RKop3mlkICahsGPZOjOEuoAnWBXKzYylgerf/6Uv7INtszk3uSXGC EqtMHg+xdzkWvxBZnbQnmMbcW2nAkaA= Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-789e4a4d3a5so90259385a.1 for ; Thu, 21 Mar 2024 11:58:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1711047486; x=1711652286; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=j1RSbdCHe2fKV0Yk4hs6rwghyLM721fWE3T8qG0MI14=; b=3ZDiqJ4xzLQpE9y5nUEAKch9ZaHH+UUbEPmK1t+57uvoqHgB/H6FdJ5mIxB8sxbdkF JBxBj4WM8PWeKYix8WYFdnpVgsfct9R+Tn7dgx6ENuiCDaAfu9jsfmHTa9cLQ21XY7Og vZTcVlTPjnNTr3xH4S4iswnVhEGX5X191ACJliX/q3aIqZ7eYvL++Mpm9qisA/gYaPlU 9fD0JwRn0y9TKIrIAk+oXxxFBcNU7TofaGOh+N1XGApf7zFRRRRvi6Oix3Fdppw8GOgf rn2T1ZrG71kLaawxwCLunagqjE8XBr+dSsjZXcRzDD5Z3+4h3lzaoljyipVcOiuaaCUJ j0RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711047486; x=1711652286; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j1RSbdCHe2fKV0Yk4hs6rwghyLM721fWE3T8qG0MI14=; b=hIcZiLRfFZdsRWO5LTiiFrst/hcHQF3yY/8vII+8sdHybtNMPmwsT7MFfXtaF+e9qP oZO70lHThHouwCA+bMRiIdADm+1QAxcFoaLVlLmqLuHY/tsw99PDuBOZr5B8S1T//iPJ Y6OVmBJGFRMkVbxVzkAVf7CWvKJpO1l5EMlwhy+XUn4nh5eYd6ifVA2NlTTXFEGWS4dw m/hyL83/gPEt3cOkh8IsIs7HeuhpfQsCuYmHRcX6g56xflW6RhrLEoDdKpKm+F1C+25V GjhSrI0Gd8mKJbeMm18u1BJNEMIHRaGbYcKfcaKqV1BzATOU3VpZnbmt5CEaUukpIFXJ vGkw== X-Forwarded-Encrypted: i=1; AJvYcCUCeFRfKOb+SsEabkgMc5FahsQkgn4gbEDhxFfmgHZsPGN6oXvbNSca2ZZ5JOItpwxvaCcSVRd8D2XiFejGocy661M= X-Gm-Message-State: AOJu0YxdbzhebW+09NUobvbCydGk3HZbhEjNPu2k3/NLsbGeLygbRYKO yesfTTy/T83o1FoNHRHo/rOVfvXbY11Vyl23v2G7hjb4dCXujHqnyes868aQwjY= X-Google-Smtp-Source: AGHT+IHaqKnPjbeF9DkE8OAIMrQn/yg3h/qvNhnVka/p03SEAhYE5s3kETq0WcRaXPXz6KfiExc3Vg== X-Received: by 2002:a05:620a:990:b0:789:d140:5ab7 with SMTP id x16-20020a05620a099000b00789d1405ab7mr65798qkx.11.1711047485844; Thu, 21 Mar 2024 11:58:05 -0700 (PDT) Received: from localhost ([2620:10d:c091:400::5:6036]) by smtp.gmail.com with ESMTPSA id a6-20020a05620a102600b00789e2961225sm145765qkk.61.2024.03.21.11.58.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Mar 2024 11:58:05 -0700 (PDT) Date: Thu, 21 Mar 2024 14:58:04 -0400 From: Johannes Weiner To: Andrew Morton Cc: Kent Overstreet , Chengming Zhou , Nhat Pham , Yosry Ahmed , linux-mm@kvack.org, linux-kernel@vger.kernel.org, =?iso-8859-1?B?Suly9G1l?= Poulin Subject: Re: [PATCH] mm: zswap: fix writeback shinker GFP_NOIO/GFP_NOFS recursion Message-ID: <20240321185804.GA3154@cmpxchg.org> References: <20240321182532.60000-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240321182532.60000-1-hannes@cmpxchg.org> X-Rspamd-Queue-Id: E3F0740009 X-Rspam-User: X-Stat-Signature: tj5yji7b7juea46iksi9y8ndoazng8yf X-Rspamd-Server: rspam01 X-HE-Tag: 1711047486-194071 X-HE-Meta: U2FsdGVkX1/1vdxSVMa52d7DHMb76AZAjkJ/HHIToAosuQqEsHB7UNyFD+X1OSe/CAe77G4RU7uQMxAckhiBkx23Q07pikd4Yhxb3uk2MHKYAaE/gulZcsANwIRXC06vKqqQheZ45ToE5wePy/+Td3HHhFu4zPqluOnlcH4ZMfSsm2wxxuELBagfW+BdbF59d9YsoOr/058H9y76eaREVmVNkoWigTKhnz8Hb4SbX4xoxUFpTGnDAeoILm/ObtZHZqcvioGLxZTiXnH4z7thyou9KqjGfKiWZBbz0JVjgyfkGVzDxudZFPsuMdN5fbhv+dK2p14F/ZGnRyG56EC7V9rZlgn63OrBqOJz1DxL7dkiMQNd3xP/2qAoNA/wc3jFP7HLg0oRnGrnpW5dEjMwScZbkxiOTkAkW5eIYsNFsqy69UueNrT9GNWgTDjUjgK1xGe0cx5wMmqKsU7VgQz56o2BNt/9xhMq5z5S3cnJcgeamuvJgouqTvi6TJ0btmhpfkpdkJ5QSnGlu+NaPfQa0dsE0p698wzM2zcUAio0PCv4EWwvz0j2Ku6VKiDGV5YOYmYdGLq4SQtcQ5WVXptiK7gBtc5l8Yodc1bochGktRROb4LqhS2puXxlmPj3laRDxaWdprtF7lSKoSg5bVpKgejmao3jpcXNNO7cIQZXukQkxo6pqYZ0/+4zMyGIr8+N1g80dItn4z6yWnBnamXqiZlyYWd+4qFO+w9syBEWwM7iq/kQzn2OVHURuoTxIoICUImFXqbKw9XlUxowZhzPd+55VyFHiEOsqrdgnUmZfJG7HBY2XrMuFCd5V3ruFHp+VQwbde4ifV1wfqymz3iJD4E9prDaxwWa8PnnwXodglrjSh9vJmdBUsNaTajUhGYn0F3ZZaM6pkFaE/XzZUH/sUHYU3KDatVAlKg0WOLqBlWoPgUpdJL0xQRX+LHehlcMsFy9TJQJ+CEEPKhqSfK C/uF4w9N 7xC+M/hmJA1Euqp7a2GHlTH8e+oUTF6HvSlvMPrZUxrzg0YVABU2L8x69engTWms2H76i4/uJ85AW3Z02CMxNHBVAA7cEkWgZVNRW4GO9+vNHE6OhWszKI6IHhsWCJfaTMxYHQ6ZfQ3hIwJJsnmdPegmjvL3dYpovEQE+hppAD6Nvqa1MeqdIt2+hPcy1bIXgM4x3uF6b9FiZrqJH5ms/GWW39ZF+iOeR3e2hAvb1wCUVH7EXozsSgDNhn5JmbzmScObAJ1lpZooasAyhkyoFXNFIzOKtBwwOYpYefz9QeMCdrFcu5TYdDY8D74PFhyHLjGLtSvMm11VIJIedDUM/eSHNyutCsZyYiGsJwIdtgd8ANWKx/sA5aQvvxUtCNO0YvUOLhZ9c8ppw2ovN+01gQuCOHOnFn9brTCS56/JouvxRW2kSP51IYFVesR868QuOFVsK/T8iVOqt/+17k2taMXT01a7sNXkGLdybRbielPB7LJqrrKBLVH2liik7NQJ1Ieq5vSjf4kw9LDrksqLdX47TqSkyOfX1EaaSw3wXLJZFG+RwafzVCBbE3EnYPz71s0fVjTK1c90NaOtjCJU+AwDyxM9SAwRZokukRLOf31m8B3gA7iQnpHw3mjHmNF6AKz/X0l/syaXARI4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.011769, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 21, 2024 at 02:25:32PM -0400, Johannes Weiner wrote: > Kent forwards this bug report of zswap re-entering the block layer > from an IO request allocation and locking up: > > [10264.128242] sysrq: Show Blocked State > [10264.128268] task:kworker/20:0H state:D stack:0 pid:143 tgid:143 ppid:2 flags:0x00004000 > [10264.128271] Workqueue: bcachefs_io btree_write_submit [bcachefs] > [10264.128295] Call Trace: > [10264.128295] > [10264.128297] __schedule+0x3e6/0x1520 > [10264.128303] schedule+0x32/0xd0 > [10264.128304] schedule_timeout+0x98/0x160 > [10264.128308] io_schedule_timeout+0x50/0x80 > [10264.128309] wait_for_completion_io_timeout+0x7f/0x180 > [10264.128310] submit_bio_wait+0x78/0xb0 > [10264.128313] swap_writepage_bdev_sync+0xf6/0x150 > [10264.128317] zswap_writeback_entry+0xf2/0x180 > [10264.128319] shrink_memcg_cb+0xe7/0x2f0 > [10264.128322] __list_lru_walk_one+0xb9/0x1d0 > [10264.128325] list_lru_walk_one+0x5d/0x90 > [10264.128326] zswap_shrinker_scan+0xc4/0x130 > [10264.128327] do_shrink_slab+0x13f/0x360 > [10264.128328] shrink_slab+0x28e/0x3c0 > [10264.128329] shrink_one+0x123/0x1b0 > [10264.128331] shrink_node+0x97e/0xbc0 > [10264.128332] do_try_to_free_pages+0xe7/0x5b0 > [10264.128333] try_to_free_pages+0xe1/0x200 > [10264.128334] __alloc_pages_slowpath.constprop.0+0x343/0xde0 > [10264.128337] __alloc_pages+0x32d/0x350 > [10264.128338] allocate_slab+0x400/0x460 > [10264.128339] ___slab_alloc+0x40d/0xa40 > [10264.128345] kmem_cache_alloc+0x2e7/0x330 > [10264.128348] mempool_alloc+0x86/0x1b0 > [10264.128349] bio_alloc_bioset+0x200/0x4f0 > [10264.128352] bio_alloc_clone+0x23/0x60 > [10264.128354] alloc_io+0x26/0xf0 [dm_mod 7e9e6b44df4927f93fb3e4b5c782767396f58382] > [10264.128361] dm_submit_bio+0xb8/0x580 [dm_mod 7e9e6b44df4927f93fb3e4b5c782767396f58382] > [10264.128366] __submit_bio+0xb0/0x170 > [10264.128367] submit_bio_noacct_nocheck+0x159/0x370 > [10264.128368] bch2_submit_wbio_replicas+0x21c/0x3a0 [bcachefs 85f1b9a7a824f272eff794653a06dde1a94439f2] > [10264.128391] btree_write_submit+0x1cf/0x220 [bcachefs 85f1b9a7a824f272eff794653a06dde1a94439f2] > [10264.128406] process_one_work+0x178/0x350 > [10264.128408] worker_thread+0x30f/0x450 > [10264.128409] kthread+0xe5/0x120 > > The zswap shrinker resumes the swap_writepage()s that were intercepted > by the zswap store. This will enter the block layer, and may even > enter the filesystem depending on the swap backing file. > > Make it respect GFP_NOIO and GFP_NOFS. > > Link: https://lore.kernel.org/linux-mm/rc4pk2r42oyvjo4dc62z6sovquyllq56i5cdgcaqbd7wy3hfzr@n4nbxido3fme/ > Reported-by: Kent Overstreet Andrew can you please also add: Reported-by: Jérôme Poulin Thanks