From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE359C6FD1F for ; Thu, 21 Mar 2024 18:07:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 519F86B0088; Thu, 21 Mar 2024 14:07:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A2786B0089; Thu, 21 Mar 2024 14:07:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CEAD6B008A; Thu, 21 Mar 2024 14:07:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 16F746B0088 for ; Thu, 21 Mar 2024 14:07:10 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9F5E8A1FD2 for ; Thu, 21 Mar 2024 18:07:09 +0000 (UTC) X-FDA: 81921827778.17.A8E761F Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf08.hostedemail.com (Postfix) with ESMTP id 4A84C160016 for ; Thu, 21 Mar 2024 18:07:06 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qSTXFzpH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jyrZiQTK; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qSTXFzpH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jyrZiQTK; spf=pass (imf08.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711044426; a=rsa-sha256; cv=none; b=gF/L1f9X46Ekm6t7QMUQodXmBQxRg0OtN2iNfs5laxtI52IdCde9/vGQeyPg24zv83SoXI axmCVfJ7tCCPy3Ty01uW1BfyGcRjSTFjKoLvRwNUtV4NLUIkjsJru5VTl6UpbAdGCVZJGI yAWVOj2ShKK2JLJGcPwpIkyiCw5Vk98= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qSTXFzpH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jyrZiQTK; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qSTXFzpH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jyrZiQTK; spf=pass (imf08.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711044426; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Er0BQY9yyhShKISjQxXgJJ4fPACRuENnuK7t6pwKzT4=; b=ITbiW3NdD9kx4lB4dOMtqGjhBlhIHsWPQIUASJBGbwGcg69qT9ikAserK1825vYgLlpech d+8Ycgc/Rr48lV8XRzQT5xQs+/lQKZ0dAEdQcECy2ntS06g1gUkFJaUw6+p+II7bcTymbq 6h4hi0YsuEgjQC3fhmyumQcUBwsirpE= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A5EA35D2A6; Thu, 21 Mar 2024 18:07:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1711044424; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Er0BQY9yyhShKISjQxXgJJ4fPACRuENnuK7t6pwKzT4=; b=qSTXFzpHwuoVCvOZ3GNS+UgUHoMukzlTJ1tfGZc9Jr7tJURCmH13hi3dn0E7x5zdcIphWo qE0h5rGLe4h4RhuHex8TtU2gAEUO3Wa444zNqNphBj4BbfFOpbQYGSna8jPdk4+pzaKzR7 O0Bny7FMVslcvK0cQBh18/xXp7z+ffU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1711044424; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Er0BQY9yyhShKISjQxXgJJ4fPACRuENnuK7t6pwKzT4=; b=jyrZiQTKOf1qUFHF6itTgEhgh9ek+6yvFInS0FE2apXbvmFgIRXstV9T5cToIhWeLvF5YV m7lzsrlNrV0o78AA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1711044424; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Er0BQY9yyhShKISjQxXgJJ4fPACRuENnuK7t6pwKzT4=; b=qSTXFzpHwuoVCvOZ3GNS+UgUHoMukzlTJ1tfGZc9Jr7tJURCmH13hi3dn0E7x5zdcIphWo qE0h5rGLe4h4RhuHex8TtU2gAEUO3Wa444zNqNphBj4BbfFOpbQYGSna8jPdk4+pzaKzR7 O0Bny7FMVslcvK0cQBh18/xXp7z+ffU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1711044424; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Er0BQY9yyhShKISjQxXgJJ4fPACRuENnuK7t6pwKzT4=; b=jyrZiQTKOf1qUFHF6itTgEhgh9ek+6yvFInS0FE2apXbvmFgIRXstV9T5cToIhWeLvF5YV m7lzsrlNrV0o78AA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9B7D5138A1; Thu, 21 Mar 2024 18:07:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id rgb8JUh3/GXaOQAAD6G6ig (envelope-from ); Thu, 21 Mar 2024 18:07:04 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 422C6A0806; Thu, 21 Mar 2024 19:07:04 +0100 (CET) Date: Thu, 21 Mar 2024 19:07:04 +0100 From: Jan Kara To: Kemeng Shi Cc: Jan Kara , akpm@linux-foundation.org, tj@kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, willy@infradead.org, bfoster@redhat.com, dsterba@suse.com, mjguzik@gmail.com, dhowells@redhat.com, peterz@infradead.org Subject: Re: [PATCH 0/6] Improve visibility of writeback Message-ID: <20240321180704.lqmtdmd5tzsbuyyu@quack3> References: <20240320110222.6564-1-shikemeng@huaweicloud.com> <20240320172240.7buswiv7zj2m5odg@quack3> <44e3b910-8b52-5583-f8a9-37105bf5e5b6@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44e3b910-8b52-5583-f8a9-37105bf5e5b6@huaweicloud.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4A84C160016 X-Stat-Signature: oj5mddtif8giwjnau1y6696q5ochkmow X-Rspam-User: X-HE-Tag: 1711044426-999803 X-HE-Meta: U2FsdGVkX19Up2I+GOYmNYb3XSdjasnYKYgNeRkI6PIQP19M5yuHh69obesugMxkvW/5UHz5UtI0fDC7baKnY3sJhG17h1QdyNvncRnbGv/1/iYt4VfXn0RiIEo5m0MEAc5x6t9mz6EkQHMba4K1H/M0WB9vXxma9ZlPkgpPlzU66BIxQicxNb2AcJFFxsSact3CywsWk05yMGsbFGJUl4+g2FlLtgRO+XUFUPnTJKHSmV4SiUwpOnBE4b+txyRo4bX8fKXhJqb/T5SrLUCJDNJJkN38Bg4vPuOBhjplvcsHIBYbqbkv5j5dsEFOyUolSPg9NTP6b0N8OUOYJRbcHa/SoFSjN0ei2zfOwBmaRvX2kwfOoaZKqH1wWbHmMX1pYxeoLDDHzmjja25wWjC3MzpUPANTw7XLehPHJjABGIr6QVdQNrk0f9Ex66JNCWFlk0leREGP2+cRXXRoXTQvQSXoVH32SF0SDIOaiosjz2t3y7eVdE4G+Ds3Y//ZXpoQY/i4flgkGqfdaqt1b1wEN+T8TFRweGaqR3jRsQDvQnubH+1QLMwVLOpIpFL9Wpt69cMTg3tp6qb+6CybuECvF2zutkX4C1GhfXkcQt5ovvblG/p2bUqr2ZfAHV9qfNMhCml1ZsiC6hAm0pmlZfClS1oBbwz0Aj/CLdCe9cS5hlH9H0yuuA0eRfPUwmwRNq9v/iLlyG/06eBMINA4EJfqAW5K/X9vuClZuFq5PcdnclCwRYio+6dOn7TlPWAVsCiQSoEWnlmJO5zajX7WrvlwdHdswA+zizGn6+BxlR83tTUMouXEoZJki9WkuywY5B3JT3FjvCU4QgSMvpPQ2tc2Lnu0vqRCegh3kza8F+ph1EIIy7yliMqjWyecjZOVsPAipRqH2LNOpwbqCfiYQk53gAxvzEoJrbzpSEGHP1X1+9d5QTrC29GhUz+3idgjfucvIvHmICsaF8HBz7KbyJ9 d5QCmrQr 0zb03dq1V/tzoH6Yos8x/qObyFjf2/zWh+MPqGtuhWxOWr6wKfKxgYKS/Yn3oGVCUxWF2PpSfTQ4gEaEuWfkco1SuZdIOct9h6+uPGWZICIHuzgz1b8eheaKcR9VXs6RNiHI6K/hTIB5k/BSRDY5effJeUijYV2B5eVUU9/eiYe/1hXdfaZut7YNLS57SkZfx67eFm4YU8RiyiDSKeyKcPTBKHNTvg+6B3xZ+Mw6G1ixv0s9GiHVoD6TWrmR14yVpVuhRvTTbVMN/0JOe51FH6VseLg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 21-03-24 16:12:52, Kemeng Shi wrote: > on 3/21/2024 1:22 AM, Jan Kara wrote: > > On Wed 20-03-24 19:02:16, Kemeng Shi wrote: > >> This series tries to improve visilibity of writeback. Patch 1 make > >> /sys/kernel/debug/bdi/xxx/stats show writeback info of whole bdi > >> instead of only writeback info in root cgroup. Patch 2 add a new > >> debug file /sys/kernel/debug/bdi/xxx/wb_stats to show per wb writeback > >> info. Patch 4 add wb_monitor.py to monitor basic writeback info > >> of running system, more info could be added on demand. Rest patches > >> are some random cleanups. More details can be found in respective > >> patches. Thanks! > >> > >> Following domain hierarchy is tested: > >> global domain (320G) > >> / \ > >> cgroup domain1(10G) cgroup domain2(10G) > >> | | > >> bdi wb1 wb2 > >> > >> /* all writeback info of bdi is successfully collected */ > >> # cat /sys/kernel/debug/bdi/252:16/stats: > >> BdiWriteback: 448 kB > >> BdiReclaimable: 1303904 kB > >> BdiDirtyThresh: 189914124 kB > >> DirtyThresh: 195337564 kB > >> BackgroundThresh: 32516508 kB > >> BdiDirtied: 3591392 kB > >> BdiWritten: 2287488 kB > >> BdiWriteBandwidth: 322248 kBps > >> b_dirty: 0 > >> b_io: 0 > >> b_more_io: 2 > >> b_dirty_time: 0 > >> bdi_list: 1 > >> state: 1 > >> > >> /* per wb writeback info is collected */ > >> # cat /sys/kernel/debug/bdi/252:16/wb_stats: > >> cat wb_stats > >> WbCgIno: 1 > >> WbWriteback: 0 kB > >> WbReclaimable: 0 kB > >> WbDirtyThresh: 0 kB > >> WbDirtied: 0 kB > >> WbWritten: 0 kB > >> WbWriteBandwidth: 102400 kBps > >> b_dirty: 0 > >> b_io: 0 > >> b_more_io: 0 > >> b_dirty_time: 0 > >> state: 1 > >> WbCgIno: 4284 > >> WbWriteback: 448 kB > >> WbReclaimable: 818944 kB > >> WbDirtyThresh: 3096524 kB > >> WbDirtied: 2266880 kB > >> WbWritten: 1447936 kB > >> WbWriteBandwidth: 214036 kBps > >> b_dirty: 0 > >> b_io: 0 > >> b_more_io: 1 > >> b_dirty_time: 0 > >> state: 5 > >> WbCgIno: 4325 > >> WbWriteback: 224 kB > >> WbReclaimable: 819392 kB > >> WbDirtyThresh: 2920088 kB > >> WbDirtied: 2551808 kB > >> WbWritten: 1732416 kB > >> WbWriteBandwidth: 201832 kBps > >> b_dirty: 0 > >> b_io: 0 > >> b_more_io: 1 > >> b_dirty_time: 0 > >> state: 5 > >> > >> /* monitor writeback info */ > >> # ./wb_monitor.py 252:16 -c > >> writeback reclaimable dirtied written avg_bw > >> 252:16_1 0 0 0 0 102400 > >> 252:16_4284 672 820064 9230368 8410304 685612 > >> 252:16_4325 896 819840 10491264 9671648 652348 > >> 252:16 1568 1639904 19721632 18081952 1440360 > >> > >> > >> writeback reclaimable dirtied written avg_bw > >> 252:16_1 0 0 0 0 102400 > >> 252:16_4284 672 820064 9230368 8410304 685612 > >> 252:16_4325 896 819840 10491264 9671648 652348 > >> 252:16 1568 1639904 19721632 18081952 1440360 > >> ... > > > > So I'm wondering: Are you implementing this just because this looks > > interesting or do you have a real need for the functionality? Why? > Hi Jan, I added debug files to test change in [1] which changes the way how > dirty background threshold of wb is calculated. Without debug files, we could > only monitor writeback to imply that threshold is corrected. > In current patchset, debug info has not included dirty background threshold yet, > I will add it when discution of calculation of dirty background threshold in [1] > is done. > The wb_monitor.py is suggested by Tejun in [2] to improve visibility of writeback. > The script is more convenient than trace to monitor writeback behavior of the running > system. Thanks for the pointer. OK, I agree this is useful so let's have a look into the code :) Honza -- Jan Kara SUSE Labs, CR