From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1329DC6FD1F for ; Thu, 21 Mar 2024 23:29:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 745516B0089; Thu, 21 Mar 2024 19:29:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F2B16B008A; Thu, 21 Mar 2024 19:29:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E22F6B008C; Thu, 21 Mar 2024 19:29:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4F8BE6B0089 for ; Thu, 21 Mar 2024 19:29:26 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 217311C1706 for ; Thu, 21 Mar 2024 23:29:26 +0000 (UTC) X-FDA: 81922639932.25.FE85959 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 52AED1C0016 for ; Thu, 21 Mar 2024 23:29:24 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ZZo0gcLM; dmarc=none; spf=pass (imf20.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711063764; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LN6XuTgfAuUNzwS7TJygCe5MttmY3Wrqz6++Y6QTLzY=; b=g8q1YP3sGMUmPqhqdqGXDqJmdAYNRwNBnFqiF9fcYbBylmgBMAshRoE3H+PBq2ikhk1Gc0 D9CVE6fOMaVxRepR4f9IGj2aK2dbudzBi0sRMa7sDlfh4Y/RbrJgiOjXMh7tf5833gHopD PNRg4sgy9OczP0aoCvn3/pjwtuqwm80= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ZZo0gcLM; dmarc=none; spf=pass (imf20.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711063764; a=rsa-sha256; cv=none; b=ugAhNN1gZjnls3QtlfDN324bfUCrSxLUeTTbzlkbkkiMksYYzQukBS79qkCA535TO5bxSQ 82Z6o1J/iLyfBd1xLCbX3cPKSDLaZFX8iFVJJzR7tER0bZiZEHDwfbSAILWgmFhIT7Yol0 ZnZoFGE9ax+YK8lq+l+73kwNF+ZpF2s= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5147C6115A; Thu, 21 Mar 2024 23:29:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BFF20C433F1; Thu, 21 Mar 2024 23:29:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1711063763; bh=2Pz8cF8MDfEMzcs0iw7P4Cuhg9qBQUWj10/JCOJ8j6A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZZo0gcLMk2YbSDlpvEQUevexiFASvpAWLaSETqlXlV95OeKlj+KzcsKdDuGt48SJZ /5wLcMeYudg2R9TiX7dn3k5nf6Aqq5XNB3vE5e2n4oU5lV5RXk6EUjghRl2SQXYC5Z NqK7l5VCclC4GWCu7ANbyx4WckGlW2S59lrmfs+g= Date: Thu, 21 Mar 2024 16:29:22 -0700 From: Andrew Morton To: Edward Liaw Cc: linux-kernel@vger.kernel.org, Shuah Khan , linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-mm@kvack.org, Peter Xu Subject: Re: [PATCH v1] selftests/mm: sigbus-wp test requires UFFD_FEATURE_WP_HUGETLBFS_SHMEM Message-Id: <20240321162922.172db3abb3a9aa4aca36afb6@linux-foundation.org> In-Reply-To: <20240321232023.2064975-1-edliaw@google.com> References: <20240321232023.2064975-1-edliaw@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 52AED1C0016 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: jj8ozxdg57cuou3bwzdow667h7f69ekz X-HE-Tag: 1711063764-174659 X-HE-Meta: U2FsdGVkX1/dn/6+joRwQP99JUndAN8rNhvHrFqwhTKfsUVl/AOdCbHgz59RfLlO8Djx1YFzJ/8JWdGWl518Bp7N31fiuyx5/WlTdHMCyTHS/U+gjQaV75kEvQNcWBxmIb4y5JBO3k2KoPED9BWdybPlT+cfxPD3mTcizsjEkEBJbUIozpJnbuFIULbJmnjkd4DMEkLMpdo78ho6St70HCZ1QAuLXZ3ksRCkK3qCO+R9TmfpHkTotyD3J+cSwxlrDHgFmFfQQbMj73q/8MaF9BDL1S76yN+nubuL4HJBGv/xxQKISCZ+AcqMtnPDOHpV+kV/tYPZcI5Jkj/fe2Odq6Alc6ydRSQwZBNQmLoONePHvB/R5RiCcw9hA4NXu5Zdfuwn724+oLFxrWSCaDO8nufC2hVth0d8Ou3HTDZ6/fli72CtGufvoHlRwhxdENGNrhsFw8+Sp7yG8c6XkT/17Kg8eAcgCYATr4H9GG07HBHaOsJmzSYnxGvPCJBaQ/9ZjeaGNGwQosDDtQdr4RlJmAP0KIe3/zqjgZv89iTixsT3M70MExsFv5dz8D1QweDShvIBxlCDyQxgkCuiFjh5jj+RDh/jEatuVsDZvxenHXKm2FQKDIth2l3PwBLoTc1AfBALc1/B6JS+BbOvI3AVRa6AR4Fz8qP0roZf0UncwJo314ZV6F/jSIgSkUjDf/MNDtzfcBlUndhs6exgrqsYeYGCTcjyD/EZZyCdCBfTWdG9UyOtDVM+l8Kr5+qdwlOM6Mji70jIpztYwlJ2fdaY7ZgBO0jsIuk04B0aD5SlklyvQvUXgIXz7x7Q1yEZugF/BNUcXBTyz9HMGbETzR5P5zx3Q16vECVUBItq+V+GjOqKc6+q4fv0XfflMBheFVP9twimO/6Q57DvjcNh7e9BXf5bG9JZk3vjC77YTyf7sxI2Fp7czrM3qMkFP5tXVjTWArySsRL4Lyk6pL9Wla0 NjhYoaUD KeitMycvWyJ6BHivhUZ03EkKGqLMaJl9C2wy99HUNDYCp0NkFaqVhZ59WY8QvS6/5jR98f9obUy+EBUUNqjxAljF3KHAcoornXpAlr/xgclefi+Q64yFMPd+kasn3G9H33uuPhwa9o3EW2K9E9scK32AbmkFVhDAoadp5zI6ozR9fUrxtLoTpE9431ZIQbAqifFFucIVJrMzQU4qsDkIL0twNHlQ856XTDt/F9V4EUAejmMZv4sJl4B7hSp5nch5NP0eg87FXsjemeTwE9vGnQx+jftOBYmaZHm8sxGGKTGGbYDRJU4XAIIVImbgo3pNhp4gpKWlNMdoJMIUA/bC6taoVhhOu390u8CFL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 21 Mar 2024 23:20:21 +0000 Edward Liaw wrote: > The sigbus-wp test requires the UFFD_FEATURE_WP_HUGETLBFS_SHMEM flag for > shmem and hugetlb targets. Otherwise it is not backwards compatible > with kernels <5.19 and fails with EINVAL. > > ... > > --- a/tools/testing/selftests/mm/uffd-unit-tests.c > +++ b/tools/testing/selftests/mm/uffd-unit-tests.c > @@ -1437,7 +1437,8 @@ uffd_test_case_t uffd_tests[] = { > .uffd_fn = uffd_sigbus_wp_test, > .mem_targets = MEM_ALL, > .uffd_feature_required = UFFD_FEATURE_SIGBUS | > - UFFD_FEATURE_EVENT_FORK | UFFD_FEATURE_PAGEFAULT_FLAG_WP, > + UFFD_FEATURE_EVENT_FORK | UFFD_FEATURE_PAGEFAULT_FLAG_WP | > + UFFD_FEATURE_WP_HUGETLBFS_SHMEM, > }, > { > .name = "events", Thanks, I'll add Fixes: 73c1ea939b65 ("selftests/mm: move uffd sig/events tests into uffd unit tests") Cc: