From: Andrew Morton <akpm@linux-foundation.org>
To: Edward Liaw <edliaw@google.com>
Cc: linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, kernel-team@android.com,
linux-mm@kvack.org, Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH v1] selftests/mm: sigbus-wp test requires UFFD_FEATURE_WP_HUGETLBFS_SHMEM
Date: Thu, 21 Mar 2024 16:29:22 -0700 [thread overview]
Message-ID: <20240321162922.172db3abb3a9aa4aca36afb6@linux-foundation.org> (raw)
In-Reply-To: <20240321232023.2064975-1-edliaw@google.com>
On Thu, 21 Mar 2024 23:20:21 +0000 Edward Liaw <edliaw@google.com> wrote:
> The sigbus-wp test requires the UFFD_FEATURE_WP_HUGETLBFS_SHMEM flag for
> shmem and hugetlb targets. Otherwise it is not backwards compatible
> with kernels <5.19 and fails with EINVAL.
>
> ...
>
> --- a/tools/testing/selftests/mm/uffd-unit-tests.c
> +++ b/tools/testing/selftests/mm/uffd-unit-tests.c
> @@ -1437,7 +1437,8 @@ uffd_test_case_t uffd_tests[] = {
> .uffd_fn = uffd_sigbus_wp_test,
> .mem_targets = MEM_ALL,
> .uffd_feature_required = UFFD_FEATURE_SIGBUS |
> - UFFD_FEATURE_EVENT_FORK | UFFD_FEATURE_PAGEFAULT_FLAG_WP,
> + UFFD_FEATURE_EVENT_FORK | UFFD_FEATURE_PAGEFAULT_FLAG_WP |
> + UFFD_FEATURE_WP_HUGETLBFS_SHMEM,
> },
> {
> .name = "events",
Thanks, I'll add
Fixes: 73c1ea939b65 ("selftests/mm: move uffd sig/events tests into uffd unit tests")
Cc: <stable@vger.kernel.org>
prev parent reply other threads:[~2024-03-21 23:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 23:20 Edward Liaw
2024-03-21 23:29 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240321162922.172db3abb3a9aa4aca36afb6@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=edliaw@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox