From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5A04C6FD1F for ; Thu, 21 Mar 2024 22:09:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AFFB6B0089; Thu, 21 Mar 2024 18:09:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 336F16B00AB; Thu, 21 Mar 2024 18:09:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B1016B00AC; Thu, 21 Mar 2024 18:09:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 052A76B0089 for ; Thu, 21 Mar 2024 18:09:14 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B71501404A9 for ; Thu, 21 Mar 2024 22:09:13 +0000 (UTC) X-FDA: 81922437786.08.012ABFF Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id F3ED31C001F for ; Thu, 21 Mar 2024 22:09:11 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=y9CgARli; dmarc=none; spf=pass (imf20.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711058952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HRQb5YRTVlNIAXd0VIxCSMS0uNvlXeeI/wipFWf3bZA=; b=604t8/4/zRee+Ji2H+SdyqMYaxeSVrgZUFAGnxdY2JktBPTnss/7VfgWA0GSNZp+6kE/RR vXlVxbbX82OEoN7IIY/0zVi80Eq3TY2JTX6qnVvfR4lDy3CUITAah6wXggN3b2jPe/pMxE 6JfTZ0N/xTOXabT0slczC6zA/SOJkAM= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=y9CgARli; dmarc=none; spf=pass (imf20.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711058952; a=rsa-sha256; cv=none; b=57OsLqAEcCCM3UE2FkebjTY1WPy4KsTba5Ww3p0IMi1d20C41gMpE0vw+RgGNmJz2P0fxa mPqGOYcySYJEE9iDecns000Hp7hXn4CCK3xroAxmKu6ezh2F53wF/wm5chwPP9e8i0xWYf DQ8F4iH3+hSlnqa8UECG1+it7kUl1L4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E955C61248; Thu, 21 Mar 2024 22:09:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C8F3C433F1; Thu, 21 Mar 2024 22:09:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1711058950; bh=VhxyuJAKDJdilw9zvcdHtFTt3LX+RMm+Bp/Q9DPpRW4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=y9CgARliGxUh9un0RWq77BvUsv8icetsXjNRrb37j5AgzbQBVxWvl7EmT5MW08zRV KzT97X78s64BZpndmQKS2jPFO2FuiZ8PVKbsoWOrRh5ggd9KkdNWmNHqmu7KFgTu0n YLx1MsVpgD+D82vQMtv34P1DpdyVeCQmlYlP4sz4= Date: Thu, 21 Mar 2024 15:09:08 -0700 From: Andrew Morton To: Kent Overstreet Cc: Suren Baghdasaryan , mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Alexander Viro Subject: Re: [PATCH v6 05/37] fs: Convert alloc_inode_sb() to a macro Message-Id: <20240321150908.48283ba55a6c786dee273ec3@linux-foundation.org> In-Reply-To: References: <20240321163705.3067592-1-surenb@google.com> <20240321163705.3067592-6-surenb@google.com> <20240321133147.6d05af5744f9d4da88234fb4@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 86in99x48pgtf6fnrd97nqqj5xwoh84r X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: F3ED31C001F X-HE-Tag: 1711058951-725457 X-HE-Meta: U2FsdGVkX187xNaEhiS05EcqAjz/eIN9fWBoFnTRmGN5XpgTiCZO06Sfnm1SqTDnEfWjNGjBBScjQ+SBLrZoZVdNmhI94m4Vrd1HcqWvaSheMKeEXvmQSTbQZrA97P57XxKA5p9cpGT6bpf6EUscHK00xwpMIhfPyh9UVHlt9XUs7VarJsfwCmzQAiuGmr1elep0tQ3Y8aYknHxFMpRQJPvfEJV2OC8lrOqYm6ugKymI8gYzjt1w9u8ac+lBG5Ct+vXq9yuUk3dsY8rg9bfG+gatxUSAqjqJfxmX0+3VivAdUP/EJHTGDyLi+KLJBbp1fOLfvPnXQMS77Zi2fwhbzNApHn9VQCyQWwiP2kOjcdWJcuT+sKnU2GaAyihNsCiOiIZdSo8VUbWx52RQfysGoqVSbhCJ3RWRgvgH2LAwkYi1vNQ2zcgKg8Y9XBHJ7ZEDG9M4VZKJcjRo+dkejf7J+GMjtz0mHR65XgotcO+LYVABzFua0o0eTD1q43ij/hknS0A82GZVc4Rz5rzmmbkxPzOUuDVJ+VRNC8iiFP+hipBYK3o/Cufxy1HHQF83FJ2+H6jgGLM4iYZuIQ4Es0Htjk10F6pq430za7Nl37iV7AzrdlpedTX1S1cjgwiJzAJZA6/CeWLvNejEK4p5jA8W/53QQzXNveV71blvwhv1b7Rmuz1N6Zr9Z4Zgdqfv5CpDPeBQwoBh9/4DzWKQmuizcDytsYgxsvqqQGtN6ju/2hgGbERlPr+Qsxdw/mjyKqrfSy7LXFUz9Sh7WM0d1mcD6o965DNlb/IznItX65M5BYKZJPN7ceGSM0j5VnAl+MPFyAEPndTJOVuWXL4v94so5uxdwVK77pPolEBJZfN93ON9PVKKkjvNos7WhotXOqOgsu+anXQ8UPB597p8mmz/sN7b64QWQqSiJ9g8nP/qKJfaGXG1WRGQk2qppjvX4jDAwtCAxTRdBLxYz9gkuo9 Cf2jzm7w 8m3hxQoz0hJT8/Ynx1hq71bJFxcmHDLPdX8b4F5W6g0iJf8C6vuqevFEFMWBiEHJmD4kofEi4M12FKMOASNYlcjfcgnvG17bS+dLzS0TCMrvUDTovyCTGEkeHgLw+Vz86yZxToGNSYDSJ2abGu8bvKicAHEPTbJgHlLpQDqnynJekQ71sMgCedXz2gu21aaszEXa/wlEDmB+cVPSNkJwCNO3VHBRalgz6YaRZ3ZMyUiRPJ+g55uX96gwjc31K1+b+NPpU9K+5rwx4oWA/LfxvyzEh6sfSNN559xq3IqbQPZurfgnZBEsEB5L9a4Q3IYe1FXZGRcK6vSsCqXyxME7IBmqXBGOWbH6UVA9Mp4cOjQCoTZG5m+DdBk1mIw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 21 Mar 2024 17:15:39 -0400 Kent Overstreet wrote: > On Thu, Mar 21, 2024 at 01:31:47PM -0700, Andrew Morton wrote: > > On Thu, 21 Mar 2024 09:36:27 -0700 Suren Baghdasaryan wrote: > > > > > From: Kent Overstreet > > > > > > We're introducing alloc tagging, which tracks memory allocations by > > > callsite. Converting alloc_inode_sb() to a macro means allocations will > > > be tracked by its caller, which is a bit more useful. > > > > I'd have thought that there would be many similar > > inlines-which-allocate-memory. Such as, I dunno, jbd2_alloc_inode(). > > Do we have to go converting things to macros as people report > > misleading or less useful results, or is there some more general > > solution to this? > > No, this is just what we have to do. Well, this is something we strike in other contexts - kallsyms gives us an inlined function and it's rarely what we wanted. I think kallsyms has all the data which is needed to fix this - how hard can it be to figure out that a particular function address lies within an outer function? I haven't looked...