From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98F63CD11BF for ; Thu, 21 Mar 2024 03:29:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7BFB66B009B; Wed, 20 Mar 2024 23:29:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 721786B00A3; Wed, 20 Mar 2024 23:29:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 526796B009C; Wed, 20 Mar 2024 23:29:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3423E6B00A3 for ; Wed, 20 Mar 2024 23:29:00 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 12630121542 for ; Thu, 21 Mar 2024 03:29:00 +0000 (UTC) X-FDA: 81919614840.06.D39A0C2 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf15.hostedemail.com (Postfix) with ESMTP id 8F5DFA0005; Thu, 21 Mar 2024 03:28:56 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710991738; a=rsa-sha256; cv=none; b=4szQvPPbXdIwopEjGzR/LjQiaN7an8/d4NemxCJpjEx1z+dT8vWykOSAjEZvglqocbGYRX TQhORz9mxxkBnp6FShrKp/6XVtWzSPpTu8/YQnUdjmUz9rI/mQaUm+5MKItj8+TBmjr+7V 7SvBXZt0vpvi2uQnme+7+dimGKdGix0= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710991738; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uU0wCRSDtpiRD3wqvB/V+4kSM9hSK9pmnRHpR6N/xFM=; b=AyNUzQvh7/xu5Cw13ule7A8HuZvuB5vIfxDfM9rA6LPLxkwqgIZUv9KOhzaESdUUnn2Xz3 9SJCNZOje5mG9uLYPvFP7t+DwSAgdMhRfcLpYHKLuDHny8qlrY99hCdUJuSxjr/X8Lhg9I TwKNVU2J0cXMzkJnip5QhaFmv5ChEi4= Received: from mail.maildlp.com (unknown [172.19.163.44]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4V0W8C5CFkz1h2Sq; Thu, 21 Mar 2024 11:26:19 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 8DB961400CB; Thu, 21 Mar 2024 11:28:53 +0800 (CST) Received: from localhost.localdomain (10.175.112.125) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 21 Mar 2024 11:28:52 +0800 From: Kefeng Wang To: Andrew Morton , CC: Tony Luck , Naoya Horiguchi , Miaohe Lin , Matthew Wilcox , David Hildenbrand , Muchun Song , Benjamin LaHaise , , , , Zi Yan , Jiaqi Yan , Hugh Dickins , Kefeng Wang Subject: [PATCH v1 08/11] mm: migrate: support poisoned recover from migrate folio Date: Thu, 21 Mar 2024 11:27:44 +0800 Message-ID: <20240321032747.87694-9-wangkefeng.wang@huawei.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20240321032747.87694-1-wangkefeng.wang@huawei.com> References: <20240321032747.87694-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8F5DFA0005 X-Stat-Signature: 5oeqy8kg94znfxpbqwzztnx54ftt3hu9 X-HE-Tag: 1710991736-265138 X-HE-Meta: U2FsdGVkX1/5VPOPgI9gDrvGwIRdHEUwjKxlKLVpHWSXLntphVIZxfSiGpZAoSAQKm1LKFnSHL8CbDpHHUKQJUcmh8KF0MFCoFAMz59GQ4/l20JOqSgWO9Y/BoSBQ+xfL5qOFehymo0BIUwK7ZHeFMzcFCCCDUH3dFB7fvCpKmZaFE243rqfwYQNLnOBPAHnWuNZgCarmHOa0a5CoX5p60H7ZUUvMtcROJqB3wYAMDbMSJw5vdsI6HGCRLBWpUbehh7c409Avz019hBWOKYUzzoE+ZXoj0nwC4DcvM/IRDUvQhv1KExotfFXIPIdSS5KzsnGpBuc+urSvN4R/tuJ8PZH1IHD0EHvnwLvAoxcFjGciD4lPBjAdwDB9ENXwAPDqAbZr+2pDLnaosKmq+/fc8y8pCbs6/aovCOXMjVGH3GWpGR/g4auSDjYlQt8Oj7avVsb+Mu4JC8Lgs3FTgJoKLSc8TUeyTTPqoQV463RQC2qJV+Oi33ywtbbPiUdpl+N+KYcidEM6xyd0HD0gP12cZpAJVbJWbIgCnIAnI7w0DA1F3KQKjl8ObrIv77+mQRjbuZVLK8NtcfC8kW6tov3QZuFh7qUDyKRVrtWjA50/YNYXkKnbSSxGPbRUDEFSeci49pM1C2aRUXn+sg7/cqSZdd1t4+APvEAYX87ouJZHiM5MZpEH8ZDzqyng5aLAom1FSUrA1lmdXbi6QhKhO0v49DTJL6IOVN5M9kHP/VpS6KtKNIqOMMcNmJu3aVmGgz9QOkyPnO/WHm708bQ6JRIkDr0K3qWDB6UbjYRwKwgF7+QlChV0SoSDClegSuSqd1cJ/lf1fut9+j8cDgB+jESOTKC27lA3KwgYkr4r5ekFLzWRgqn152ChXKiak/15U6OdkYTCkoQq4IkJdHxlW1q+M5hbE2EyQw+QJiWzb9bcCRUb91+KQp8lxVT0nS4ZyIL6oS8B1sXwKXJ/Cjb7YV /sBbxli6 9kwaPRVQzXeo45yKnpPFyUNbHkBRpw1dfllAYhabFCa5pFV322ttTnu0hecrKC0YFMk5s5BedlAV6GKCxZBZZ2aSLywgTEOW73v0FQ5nvXyt+I2W4Ptz4V3MgsI0lTf89POlvzFo+osK6JiE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The folio migration is widely used in kernel, memory compaction, memory hotplug, soft offline page, numa balance, memory demote/promotion, etc, but once access a poisoned source folio when migrating, the kerenl will panic. There is a mechanism in the kernel to recover from uncorrectable memory errors, ARCH_HAS_COPY_MC, which is already used in other core-mm paths, eg, CoW, khugepaged, coredump, ksm copy, see copy_mc_to_{user,kernel}, copy_mc_{user_}highpage callers. In order to support poisoned folio copy recover from migrate folio, we chose to make folio migration tolerant of memory failures and return error for folio migration, because folio migration is no guarantee of success, this could avoid the similar panic shown below. CPU: 1 PID: 88343 Comm: test_softofflin Kdump: loaded Not tainted 6.6.0 pc : copy_page+0x10/0xc0 lr : copy_highpage+0x38/0x50 ... Call trace: copy_page+0x10/0xc0 folio_copy+0x78/0x90 migrate_folio_extra+0x54/0xa0 move_to_new_folio+0xd8/0x1f0 migrate_folio_move+0xb8/0x300 migrate_pages_batch+0x528/0x788 migrate_pages_sync+0x8c/0x258 migrate_pages+0x440/0x528 soft_offline_in_use_page+0x2ec/0x3c0 soft_offline_page+0x238/0x310 soft_offline_page_store+0x6c/0xc0 dev_attr_store+0x20/0x40 sysfs_kf_write+0x4c/0x68 kernfs_fop_write_iter+0x130/0x1c8 new_sync_write+0xa4/0x138 vfs_write+0x238/0x2d8 ksys_write+0x74/0x110 Signed-off-by: Kefeng Wang --- mm/migrate.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/mm/migrate.c b/mm/migrate.c index 59c7d66aacba..a31dd2cfc646 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -672,16 +672,25 @@ static int __migrate_folio(struct address_space *mapping, struct folio *dst, struct folio *src, void *src_private, enum migrate_mode mode) { - int rc; + int rc, expected_cnt = folio_expected_refs(mapping, src); - rc = folio_migrate_mapping(mapping, dst, src, 0); - if (rc != MIGRATEPAGE_SUCCESS) + rc = folio_refs_check_and_freeze(mapping, src, expected_cnt); + if (rc) return rc; + rc = folio_mc_copy(dst, src); + if (rc) { + if (mapping) + folio_ref_unfreeze(src, expected_cnt); + return rc; + } + + folio_replace_mapping_and_unfreeze(mapping, dst, src, expected_cnt); + if (src_private) folio_attach_private(dst, folio_detach_private(src)); - folio_migrate_copy(dst, src); + folio_migrate_flags(dst, src); return MIGRATEPAGE_SUCCESS; } -- 2.27.0