From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2A32C54E58 for ; Wed, 20 Mar 2024 23:45:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B43A6B0089; Wed, 20 Mar 2024 19:45:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13D886B008A; Wed, 20 Mar 2024 19:45:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1FBA6B008C; Wed, 20 Mar 2024 19:45:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DE7246B0089 for ; Wed, 20 Mar 2024 19:45:26 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 71405805F9 for ; Wed, 20 Mar 2024 23:45:26 +0000 (UTC) X-FDA: 81919051452.04.B51CB75 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) by imf18.hostedemail.com (Postfix) with ESMTP id 548D31C0004 for ; Wed, 20 Mar 2024 23:45:24 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=S8Scsa1V; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf18.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.171 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710978324; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AXioFYbquIvXXAo9owl/PKnQvce3YPzjBFfKMVoD2Ro=; b=nirGBnK/anZyBUq43DOA57gGWl0tFC6y13jBVmAnSNcEezgD5DqK24YgRDLYRU+N+KNXxu rAtkNspQrL32sqVZvRAMUOBQ1v5mwIEDKkwTIrqfy0SPFfhu8R3hSX36zcF6r1KZUDYc/3 /ufEjlFREku5BGFeFqD8uz5+U5g8AZk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=S8Scsa1V; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf18.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.171 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710978324; a=rsa-sha256; cv=none; b=gKCSdP35Kw166+zl+CUv8GTfLKCaUhguHn8MhWQXJv4H6cNel7PuV/ibQNZruXCjKbTQk5 N7XBx+CQmxT71T0pmr9YOXmqObej4T0PNCo2NfU4uyLAgjRKEnCd+jd15r9pbNwBfw1WBd X7K4AsLUMKJ9TZALLGmn4NxXSH1AkOY= Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-789e2bf854dso26317685a.3 for ; Wed, 20 Mar 2024 16:45:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1710978318; x=1711583118; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AXioFYbquIvXXAo9owl/PKnQvce3YPzjBFfKMVoD2Ro=; b=S8Scsa1VWZz3cfiCX7toi3ohN/g5IrIGNzgqGImJFUWDTlBGgdLn4Ua2ORx1mpA9BN 9SzbhwlMd6VCF8Tj5arm61DwtCv5gBoz8jvYRFV+2UY8s5YejF6jfRMUyaHGzHGKTd/f imW/7rR22jmpbvLj5rZRvO7pNNxc2AB+GfJ8ig1JfJtTtX9RLwJh74cS51pyIOdL66LC 2/SiHzWo8B/PuMhBmmOXQ5vlhJjMLx0O/Rp8AEVVsGCt8CSaLfYNJkNwzlVj7fx0J8l2 3DPiU+cWsJ1EVFxyY07HW/CiiTWqsPivukZ8u9ux7zGZkIxO1G8SCxuMYKDPHyFpgW2Y x6cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710978318; x=1711583118; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AXioFYbquIvXXAo9owl/PKnQvce3YPzjBFfKMVoD2Ro=; b=bcXologkXfs0rJZTQSvUCtPJy5pcdlaDS88d7jOZE+PY/cTVBpcib2nQULx8Qwi+RJ 2Kaxi1n0yQvP2tnC64E6CZkPUoHqNFq1pO08HkHksxvUi/hj7X9ZxlRtFi27aogKJIIn kPsyxVgPR6oDITT7QprTotg4Q3vcoMVvyUUox+rfZHbhgGoIdedQ146lnhI6NSSkqciM KmXWhqrKc79Sa4s4f0rIfsVXHwnGEl8oFRIMBbuszFsVNP/FyfPc9/dZp6UwG/qnTLTx YAhPfpJZCnUHBjuRdqCS56WXykV/AxYZoIJHhr0JE5az0IJPmp3iFyeUMASS9KF7vuw2 yxJg== X-Forwarded-Encrypted: i=1; AJvYcCUwM7sBYx2eYpjnizTuKmQnepdosoufCUZWUFpxxUPoizPLEtpilhsx2R42FhYPkgs9TM5rIchF6xmxJAcl2snPPJg= X-Gm-Message-State: AOJu0YxDTbq6IGgoJYB2CkKsQlvQnDi5XhNT1EsPLDxejWhTSfy54zw+ kkwyXmBVQu/YuzKLaF/o0IhXpLfVF+3TsLb2wKzIA0/sNVd1QMbUF3jIvOebh1Q= X-Google-Smtp-Source: AGHT+IFKPEjwfmOFjIX+g2ga1vxv+5xqkzUDeuvdTBScQ+ysDjM/7ZelybMetyrobl2ORzIKlZmDsA== X-Received: by 2002:a05:620a:578c:b0:789:f574:e511 with SMTP id wk12-20020a05620a578c00b00789f574e511mr7281092qkn.70.1710978318222; Wed, 20 Mar 2024 16:45:18 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-da5e-d3ff-fee7-26e7.res6.spectrum.com. [2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id b10-20020a05620a126a00b00789ea123bd5sm4975476qkl.59.2024.03.20.16.45.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 16:45:17 -0700 (PDT) Date: Wed, 20 Mar 2024 19:45:16 -0400 From: Johannes Weiner To: Roman Gushchin Cc: Andrew Morton , Michal Hocko , Shakeel Butt , Muchun Song , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: remove CONFIG_MEMCG_KMEM Message-ID: <20240320234516.GJ294822@cmpxchg.org> References: <20240320202745.740843-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 548D31C0004 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: gyo8eu6a1q4r41i7n8djxohftfxnu3ny X-HE-Tag: 1710978324-924247 X-HE-Meta: U2FsdGVkX18MZDQimP0jDiUA6DLmvHRqO3u0v+fRb9ovJC/FVmxOHVThgc0gNd6DDoyWYVx9879MvsbgqegRbVc8py2uoEWSZrEPC9nobtTz2b8G9uPSNicOsWWC5tlGer1L396Crajb2o4DmlVXpsqqWTfc7569cCJFvGFsvxEOihXcr2bLVb0893oXWqtuZBgtiDZAkJjMxEMDjnzxulxlZRvLBaY7U0YS99uk/6FRbKMYQQkTphG/lf1rQYSoqLH8sCBekvTexBNKs9jzE7+nd5B9NyYQnKa5b1MQ34SblCv+rzQbVI9LwgFZ+DGxyu+kyyF+lSmKMSJHDyN3q7sSNB3sVLwdH39GSZRN2/EiofJqslcitCVn8U4oIfyt09CQ+KUDr6MnYTma/0gR4V0sbgFUKnRwWsI3qWG/nrlzcAmGPGGBVNVGL+Do6GEPtN4KY+crZx8UH5IFsI59GNJNzVbwHPm1FLy0Be4JWEIgvqnZOvHnYX47XvwLBDRizW9h2C49rNoqQP3wzOww5yo4uVsO30iqFDF9tpyvRu4n/pNCYBZgzkUFKrzwVqW0ca5aMtLJOuTVgN3SMCrx0xTFRlAnD8vlJ/28CXer9zf3RmIOnyPCwc6KOvg6V4trwe/RlVYnN9c7Rl+0povkluAngpfUrN8M+1jv7fGXGqNvMRUAFP4i5ag2iJvD5oIF9URQ+DykMHCDp/PKC4awBoDqD0o0tbQ4NksuQpAlr8zsqFWktS7U46Hrsmxjjf6/lb3DnofIo17MnRtwRWhPcjhprpGXWCA7z+8FbFHR9YVcr3DpjViBqdwOAy+IWCCXVagIK6tJKwerobEVAGCUtYiHy6KakBrILISK6WfLVFi0M32so5L4r92gQBo3FL1pYBWr7OZXJPFiWw/LHpIu3CJ17bjfNYQWQFsmqfWeNx3A+iHQnBOoqUwmGSH9IogkSQAYlFsHnOxCNCQhqud F84nwHoS uwRJ60yxcd6CE82Kon70d/OaNe+M/+9svOff+N0WQv16F9S/v/GNA27Qf65ETuYWtr23X+SNtrcFOdOYUkCZr6bgwoBfAUpy+j5E0joRkHibz08PmavX1akVUwOoHt15NX3ZOjapOPWXzaPn6bxL9Ldy5OGMTgOAiHbZ39kkTGfjWxChXoA92Pxdj0WcNrWJfZ68msVLG3MoMxvK12IkGVmkbSJ5+rZrLZPk3PTKwMxN5uQL2V6LQkT/N/MfkxD03WLxTfYYDi5Z/8ad1yvZM/Oc84x94+RzjUXHAKpK+Yz+x8vGAyxcjoPK85Q1APHitjKRLq6H3VtLW1FHAsJLcPn9t80w/i5nm4Ysn5MNdHo3bgSHRVwXr0VbiGd25bbzsUzlbUZdhfc9+3cdnvxwweRV4mSL+b4rAdDc77YuIBVo56bwayH5hcHFtVxP+kjVQaIZ0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 20, 2024 at 03:36:14PM -0700, Roman Gushchin wrote: > On Wed, Mar 20, 2024 at 04:27:45PM -0400, Johannes Weiner wrote: > > CONFIG_MEMCG_KMEM used to be a user-visible option for whether slab > > tracking is enabled. It has been default-enabled and equivalent to > > CONFIG_MEMCG for almost a decade. We've only grown more kernel memory > > accounting sites since, and there is no imaginable cgroup usecase > > going forward that wants to track user pages but not the multitude of > > user-drivable kernel allocations. > > I totally support it. I believe one of the reasons for it to exist > was SLOB, which hasn't been supporting the slab memory accounting. > No such reasons anymore. Yeah. The funny thing is, if you had slob selected, it would also disable all the other kernel memory accounting covered by that option that had nothing to do with the slab allocator. This patch certainly got a much more simpler without slob around. > Acked-by: Roman Gushchin Thanks :)