From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7407C54E67 for ; Wed, 20 Mar 2024 21:19:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2534A6B008A; Wed, 20 Mar 2024 17:19:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 203746B008C; Wed, 20 Mar 2024 17:19:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CB766B0092; Wed, 20 Mar 2024 17:19:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F1D996B008A for ; Wed, 20 Mar 2024 17:19:53 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CB2D5120434 for ; Wed, 20 Mar 2024 21:19:53 +0000 (UTC) X-FDA: 81918684666.26.5AF7304 Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by imf05.hostedemail.com (Postfix) with ESMTP id D4709100024 for ; Wed, 20 Mar 2024 21:19:51 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=u+oBi2AR; spf=pass (imf05.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.180 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710969592; a=rsa-sha256; cv=none; b=Zd8Xvs8QV+YwAUD6Ov1LaipWOLS5M2W31uWxIFHpbuc2W/NzJJa7p+bV9SV7QTJSLflUQe wWsWuBnsZv+xBl9qmgJTyayGrImpiaNX0x4+AcU7z9zRN97e26CX9vUet1tL6jiwcjUH3+ iXwULHnP6EI/eZc40iJER1VhJBKqZWY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=u+oBi2AR; spf=pass (imf05.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.180 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710969592; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=db9FFoVzu+3zjz8uiG+jdZpkVxC0Fa89T/HYz/Y2T9k=; b=BVC0cjhPrmmYDUNSkfQYyngfQR/x3M3swqGflMPvqJQSCVsV+BjIzug8S9Bu7agyqFrqjC ANZL8ekvVi2yKCZ+ZC2GPM6m193yOuWMzktA0hF940UXF7sxhYmZ/EapcQBZjlZU5KuXMx eIdkDZ+g5lxyKjhnl5Jhi9ieHZ/cWY0= Received: by mail-yb1-f180.google.com with SMTP id 3f1490d57ef6-dcd9e34430cso283076276.1 for ; Wed, 20 Mar 2024 14:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1710969591; x=1711574391; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=db9FFoVzu+3zjz8uiG+jdZpkVxC0Fa89T/HYz/Y2T9k=; b=u+oBi2ARj/AJmDdQW+vI63r0qDSOdSzsGqB/r8rxZl3O1h7hfy7iqsxHv3qmx7Jhuq j5UxoG6JGmwydIV/YlNMhnhq7Cdq6ljOw014LJCsYaroC1A6mqjRk/HW9ENxd13n8p4f aP5Sf30pUkHRS2SupyorKjH7uGgoRExGDhZMCc3bRMIv7+MrGa0zsv4u6qHDMogn6BdU jV+3OxWmasHAWOx9zcfxw28ERh2sV/t03AkeI50asoMo/f0X0x8NK08179f8NaUyXTYK fEHolGtqOM+VmKnTDn/DWRszkkr/PNHld8zOxKFKz8HkwaJXWTDaEm5ZqWx12/RxQIt1 ne7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710969591; x=1711574391; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=db9FFoVzu+3zjz8uiG+jdZpkVxC0Fa89T/HYz/Y2T9k=; b=BjCbXXtL2JO2UcNygjbnMW/d3wWMH69MH/35ZZ+7pR/NdcA2vpltYuD7KIR00DLaVb bAQ4EU8oTd5SaDWLthmm992Q+zY6jUZ6L83HK5dfweXg/pXhpL8Qql+336Yc+gwK2d+b 9JZS+aUIefr+C7ZX0BAh4tf/fwiI2vy3g+16XnIsuRsnzvID5eYOI8eJ0KTxTJ1SQ+TX Ppq4jaTtxi6L5E3KtJdAWvJzD+iciYcGbm7ytnHuNZN5SEzILLMnul3o/RXCQ/oGxah+ 2xD2/Ek+SCUpDZLXxIQtsVCGpxNVKLs6oCcZkrmlJGdShJqHxwvoNKAyQivsjdwOnzP/ COfA== X-Forwarded-Encrypted: i=1; AJvYcCVokeZtdLtxuEPx8oU2d+f6pdqMa/l+Eifb2LyrnnpCJkFT4mFWxpKka45Wdp/zvhyQ9QlfMJNmwYkOI3w0qGn2W9U= X-Gm-Message-State: AOJu0YxZmfkz8ptbJW1+f4hGBC66eq9LdPIG8nSCbFcNmBNEaJfJZzNy M36zfwYYO4z06Wb3BlDKigXALcONkPEvZ1KHMErYShxjFuMjz2KQW/8asIKajhg= X-Google-Smtp-Source: AGHT+IEw4flHA2m08I9Le4jLS0tFo8dUEOPtZeOH+nXQmfBmWVCFlfy9TASWHRen47mck6OwVIm1zQ== X-Received: by 2002:a25:4f46:0:b0:dcf:c7ef:e4e0 with SMTP id d67-20020a254f46000000b00dcfc7efe4e0mr17023112ybb.1.1710969590712; Wed, 20 Mar 2024 14:19:50 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-da5e-d3ff-fee7-26e7.res6.spectrum.com. [2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id fc22-20020a05622a489600b00430eb19dd06sm2300228qtb.91.2024.03.20.14.19.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Mar 2024 14:19:50 -0700 (PDT) Date: Wed, 20 Mar 2024 17:19:45 -0400 From: Johannes Weiner To: Yosry Ahmed Cc: Nhat Pham , Chengming Zhou , Chris Li , Linux-MM Subject: Re: [RFC] Storing same-filled pages without a zswap_entry Message-ID: <20240320211945.GI294822@cmpxchg.org> References: <20240320210716.GH294822@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240320210716.GH294822@cmpxchg.org> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D4709100024 X-Stat-Signature: y3pdqrxwmrxh1btajn5sgtrmoe9kx9o5 X-Rspam-User: X-HE-Tag: 1710969591-989095 X-HE-Meta: U2FsdGVkX1/xrisgQt8O1Rt/Q+S0vUtI4YdNJTRKRcJcD1Cox1/7pv/hQQ5P9C+OLEOjHKH/ngP6pHf575l5YNC3fP8obOm69hzUt2YgoxGnQ80ZfqnDbmaR+fc36kvTONxJdIBeELglOvqNUM+7MTfRyWY+3uHayUiKubrit2U3SNOczgt8x9vApxWsk19wHD+vIgr5tQm6A+4M+sDuAE9edC/qWJBp3FhNcm9CxHB3+n478xQZ/yWzbWlGhNTCyVXkt/tMuvuJg1/JFjqeynP7AmN5cKAGKYf0WTejzQ5/dzHAvaBcvcAf1n/mNo/PsaDcVPKROyIVCn/R1Y97srFn6Izp1ypJNeER703FEN3BP0LJkCGE1KQN70AVxWWJyUZztdYN3VGbUwQ8kwY8N8wlfkHP7w986oJ9VKG4ZA4Y0rtQhQF3VzEy2eF+voqxTUFth3Pa1st6I/xfWxQMMBEeEI9T78c1zni0gUAPlXZ/830ggZ3izL4SqMLSJUjyMdfrbhrdMpb5+vF4gs1qliIJ7zEVoNH1nAf3x/d28Y0uW2ZnUtflTQGHlhPZy0rlfTz1hPlhDeT16LtLtYSWLS4VK/ruvFczefegqZ8pxyz52YM5OeqjjgZFzjGeKxNCjV7qQy2d4lkzcdwTesunpdZAlfR1eVu8L5YjVMtQ1CNQwZ8M6jT1t32tY+BVM1xFZ/q8w3HrNv3MfCV0zpBMggqWy4mPPSdxD0ZixFH+h6LenpLQomtGlPM9+H8wJEBLjheE0dTUlUfXNlolWiBuSmTWW6huMqgkR6mk0DamB+DIwdpSf1Yx6C/4/ilZO9HGvYJ2RcXOY4SXBIC0RAGJE+98VJCGjqIicIPz1wH0696+V8mCMUtNGmv0icRJyojxj/nrNaYZRCfOdrUjJmzte6S+V0qCFk6AWkql+qPS7GChXNwDCTgIy9ag+6u13fELZIEQcKTOgNlmBeyUHLv WZp8mul4 i7D0xws+8DSxrDor5+ytGsyXzN4MKAYzHCqHTLzfdCgPqNUe8epIeN4gumo67mnIu48ieUeyRaLMH62yResZJoC9HRoRKv0QsneEpDGGSLojo/6HiTsdkWq/jdBw/Ichl1JCnQMWz510IKNMNjIO/HgVJpTUw8tLCaqFP/CXCCYP3GTq1QtGNMIjFb6MpqGakqx2hHRlI+dHfFRsBd+TNOLmMnmXupT/tyH9RHHEjrIITZmxIF6iE3LpiQpC5X3+7KiQ0UkxdjYl9/mJsjU6/RPKbmk8+T1Co2krR2nZJUiZ9CNj5MBiN82JkbXi+LRWuJii1oi9aUoyGMDKJ6buD5KKTJJEarPc3cEMipFvWZk62cOjGx1xqGu9Av5kbR1o+lQNwltI2eisHDxzd8LBZC8N8GQHgPBS5mzfmNm4TKpw9+Ww761oFWOa8EQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 20, 2024 at 05:07:21PM -0400, Johannes Weiner wrote: > On Wed, Mar 20, 2024 at 01:49:17PM -0700, Yosry Ahmed wrote: > > Hey folks, > > > > I was looking at cleaning up the same-filled handling code in zswap, > > when it hit me that after the xarray conversion, the only member of > > struct zwap_entry that is relevant to same-filled pages is now the > > objcg pointer. > > > > The xarray allows a pointer to be tagged by up to two tags (1 and 3), > > so we can completely avoid allocating a zswap_entry for same-filled > > pages by storing a tagged objcg pointer directly in the xarray > > instead. > > > > Basically the xarray would then either have a pointer to struct > > zswap_entry or struct obj_cgroup, where the latter is tagged as > > SAME_FILLED_ONE or SAME_FILLED_ZERO. > > > > There are two benefits of this: > > - Saving some memory (precisely 64 bytes per same-filled entry). > > - Further separating handling of same-filled pages from compressed > > pages, which results in some nice cleanups (especially in > > zswap_store()). It also makes further improvements easier (e.g. > > skipping limit checking for same-filled entries). > > This sounds interesting. > > Where would you store the byte value it's filled with? Or would you > limit it to zero-filled only? The dumb thing about objcg is that for same-filled entries we really only need it for bumping ZSWPIN. Nothing else. entry->length is 0 for them, so even though we call the charge function, it doesn't actually do anything. Loading them is cheap and doesn't involve decompression. An argument could be made to exclude them from ZSWPOUT and ZSWPIN entirely. Or cheat a little and bump ZSWPIN for current->objcg instead - probably good enough to make excessive thrashing discoverable by the workload that's directly affected. Then you could get rid of the objcg pointer and use the xarray slot for whatever else you'd want.