From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41E35C54E5D for ; Sat, 16 Mar 2024 13:00:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 424B46B0081; Sat, 16 Mar 2024 09:00:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D4848015F; Sat, 16 Mar 2024 09:00:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29E6D6B0082; Sat, 16 Mar 2024 09:00:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1D46E8015F for ; Sat, 16 Mar 2024 09:00:04 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 67DEF8030F for ; Sat, 16 Mar 2024 13:00:03 +0000 (UTC) X-FDA: 81902909886.08.637B4EB Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf26.hostedemail.com (Postfix) with ESMTP id 829B1140011 for ; Sat, 16 Mar 2024 13:00:00 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=jC29SWJn; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf26.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.169 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710594000; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M6JBV1o4tFTfWcpNa8PqFJZZHeTUvsNQYMGRSklUsd4=; b=I9YpVpJpDejxyGCe/Wk/lrUQZITt5LIdOvFdOBsG4w9OZ92IUhMbVGVcALRuY2ZtJBl40Z GaenlEHKyLvg1LhdzfCu254j/UgFtIU0TnyBOjFb6UFfS2E274hfG6ARtd5FgFD0TU079v gx5The3C3EcX8goUYyoiKjMVauM1iBw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=jC29SWJn; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf26.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.169 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710594000; a=rsa-sha256; cv=none; b=3135Ks35S/XX2kF104ghlYPW9+SXhKyynRaV7lDl7yBiPdD2A7OG5CkxV7acgt+v0mLCFQ OuadTly/WppNsuAZ2YCnWLoDNGGpN9t+F4vqkLv9P9x3yB/NQc3QiIki8dxsK714gbNMyR gWlbOUUWFSkt1VCeb61yP5KMVWroo7g= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-430b7b22b17so7489311cf.2 for ; Sat, 16 Mar 2024 06:00:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1710593999; x=1711198799; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=M6JBV1o4tFTfWcpNa8PqFJZZHeTUvsNQYMGRSklUsd4=; b=jC29SWJnEeiqx6rsZkkdfb5FdFIAOIk+BFGXjWuEfUp7QZxeKCdkNr3Z9yW1Ok6u7P DHHosx7YDNgXzU0JZe6JyQhjJu4OAJ1cTM1IivyfmrOKrKaunPD6D4DhO3skKCwoauZO BMglSOHFIMdYqodOuUM90diKxv4dFguXeTo9CzyC8yYFNkVfdjIJmADNuusQ9KNKzaah Xu9uDGNFrU91RFPkCmhX7kkvQvoL0MaNlx0TRaVHxOuDQPdt8lRGkO4AIa89M0wiYkug tlRxBCaI+FEcNi3rjTkKpHPlkKs/UMe7KYviDY5JWzi21zPMdp99FIVlaI7jbx8aL3Fq njzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710593999; x=1711198799; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=M6JBV1o4tFTfWcpNa8PqFJZZHeTUvsNQYMGRSklUsd4=; b=Nobn53R+ZkAVlGS2ZT2Fa6FuMINPATwUhdTw68XSmUtgLLNh6MqAmEV4g2JV358XWd Zik4rZD3E1ph/V7wd4LlsXnfNalTAODMFVCPKQT3yVG+42NHqUpdLba+fgvWf/flhnhc DxRM7NdUmhKm5eUbIbTO7iF3MDTwLFYe25BaLquYPcS6Ybn29oxArC1WHa/uJYnHD2kq 1opVtv+rbW8VcMcDoG8abdz9azdRcA2EUv4QjY+GCvFEnCp2eZdS6bPPjYanWbkLpUPV aNcQBohkaywYT0dkEs4GnUUtrWztl2VfswTLIzjVGGzgFsmU1eeFR/AiNXVf7A1tvC6x uNwg== X-Forwarded-Encrypted: i=1; AJvYcCXJpHqHwUc1b8oMAxGAheiXlPL2g3fWuNygaA4lBVSPpeoqX58sWr+cAuUsxQMLPre+3rDKl+g1LEOXLBTANlMDTUQ= X-Gm-Message-State: AOJu0YwayaqCw3T5XRq+pWLHlyG/7X+AW8D8sK2aEVV92lEYVoUVoeOU lf+BcvjNjAEju96kzgj4Xclc3igufIrq1djBFVLjnEobjlty+6R0HrRINgYyGxk= X-Google-Smtp-Source: AGHT+IHpbFzgEKXjojU4Ggg7u9Z9cA1BJvuMtFASRZGmdq/PZOEzx9uD7HWVPRTzb2D1RTSJhIHPPQ== X-Received: by 2002:a05:622a:1b1d:b0:430:ad8b:6138 with SMTP id bb29-20020a05622a1b1d00b00430ad8b6138mr6934246qtb.29.1710593999390; Sat, 16 Mar 2024 05:59:59 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-da5e-d3ff-fee7-26e7.res6.spectrum.com. [2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id k20-20020ac86054000000b0042f43a486c9sm2661625qtm.77.2024.03.16.05.59.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Mar 2024 05:59:58 -0700 (PDT) Date: Sat, 16 Mar 2024 08:59:57 -0400 From: Johannes Weiner To: Yosry Ahmed Cc: Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memcg: add NULL check to obj_cgroup_put() Message-ID: <20240316125957.GA372017@cmpxchg.org> References: <20240316015803.2777252-1-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240316015803.2777252-1-yosryahmed@google.com> X-Rspamd-Queue-Id: 829B1140011 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: fefdck7xihjjtpqqfq5zpfp81q9ymp5b X-HE-Tag: 1710594000-656572 X-HE-Meta: U2FsdGVkX1/53CpNWit2BV5Hxx/1UFdSmW0o+LBY66f8qcmR3GzCIT0MbbWYIVSBdCya+5jznP6PCRKE8OgCKbaSLeDtG7Lc888eddPYl3XLoW3xmjXdq4vMxRckNDQWJGjNoU8psE+D7JHczptljyMYcasYvK0PXtF4VSUaR4k9Qgx/lXyWN74M09ChInLlKp5iJ9dePe0EdWzxdZTcJWm6p0X50uexhjWsOvOjF5+nWywoGgi/4JAdzrAZuHwe36DjHwcO01qafnIz5HBEDglZNj4FHBVSrwBVOwp6QadB2IjSDxbdU2nVM8XeiRt7gjuvOovDmpyWILdRmfT2YbSZl+5Ldz8JZ4vrf6Bc0bi1KWYgAShzdXpUinrTv5bNVwzrVT22seD9i9NdpF8yXcXotZdipdwKFuu0DVapbG74sbcde6D5A6AgCwG1Uz6RO80ynwyUGBCyhHtPacEmrVtsmV7UtCnHlzyNcc/lyT/5awDWdNOpzing6cBvFdDt6kcISFGOfkny9SGrU3Ia+X8nIbe+4VaqgsDSZw53o//Yjm6I8+hwH/veaSksjnvRvU/25DdW7CzZRLiO5MR9ty8mUsL6Furj1aOvfBBtHB2Fx0/CakNxjc3BlKctvOsgNnTtfhvcN/FwcCoJHRbT1ZaeEhO+uKWpv9luNgTp7XytLdrInSuif6Dhb+ZrUBzXAzTqL8oEFvodYdup/RJTvd5EWaX8sWmBkJmbigjvTL5PcHz544rgchBpL2jIeHHgQEJCn9EUzDILdSVtvUANF5DPHAXiNb/HNcgBy0mjKLdE/eGjkZOR4rhiJFjN6MxE5nG6Q7C/iNWnNXCR6dIJCIQrFdfQ/dXLkh4I3zhJZQSfKpziEN/laCbY9o6pos7ovZprHB4tbed9sI2AqT6azCT2UaBVxaNw8hABpXRoJwlnymtz5gDv6E4NCGMDfTE5Kpz1z6/yr2qpqVJR25f 4HxoE3iy DpUau0GGudB9bLgPyWOgy8rZeSTUlXgAel5g3952w+uP4VMaIoLBt4KUWKvKatghO0k4nMsDJdLW2/lco6ZtwMa+7pFTNJ2wkhOq89Bdpw35DfmXxv3LOwdtboLczh0kKFbnxQviY3NteH0z4m+Y8+YX32x48YqnprXCpa69MckPmtsdCsQ/GDSD7BTsqbo6v3BWBjlGc3hWC0sHJrvE9tZgo+1bNT7hY+No3lnlbMSw/UGIsjqh0qNlIzX6F44pUu2IfdC3PSz4IWNAynlh0W73cbOEFLlO0hR8BamW1HdxQ8tbOndMh3MwYxSf5e+E6HR52D5klFGmhPLWvFf6VRP0ftXlMDX4RUxQdA5IJOHkRdaXVYaOmS/y10rQxReaT7JUdBhtSWOjvkjhLIb0AEE2XYvKkWWtFGQmlweNiCuPYDqvbwUcklAQBniYk/t2xQdHohkdhd1XtN8s32UpWBvPEFM3ZrwSPyuIOLCbXav6zQDgOZ3OW5Yp6yDcLDHnGDrxkMJTKPU1Re1xWSQxQERMRwYi5j8OOSAimNqgO3r0c/UU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Mar 16, 2024 at 01:58:03AM +0000, Yosry Ahmed wrote: > 9 out of 16 callers perform a NULL check before calling > obj_cgroup_put(). Move the NULL check in the function, similar to > mem_cgroup_put(). The unlikely() NULL check in current_objcg_update() > was left alone to avoid dropping the unlikey() annotation as this a fast > path. > > Signed-off-by: Yosry Ahmed Acked-by: Johannes Weiner