From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFC9EC54E58 for ; Fri, 15 Mar 2024 13:03:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3011D80128; Fri, 15 Mar 2024 09:03:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B114800B4; Fri, 15 Mar 2024 09:03:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 153DA80128; Fri, 15 Mar 2024 09:03:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 03495800B4 for ; Fri, 15 Mar 2024 09:03:40 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9C57314132D for ; Fri, 15 Mar 2024 13:03:39 +0000 (UTC) X-FDA: 81899290158.19.10A2DB8 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by imf14.hostedemail.com (Postfix) with ESMTP id DC53A100005 for ; Fri, 15 Mar 2024 13:03:27 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ln6Jalgt; spf=pass (imf14.hostedemail.com: domain of lkp@intel.com designates 198.175.65.19 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710507808; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6Ai35Z/kYwb1CatRVkacFCfCXYkrgmeUBN3pY1fbL0A=; b=7BW1Vdgsgdq6p0ltM5M2k9ISnqyamg+nvJeoE8appnsgLANzBUYBmkBw1+qzDN4cwxKaFE RH2aezxZDaI/Pd5B8fcozKbQKRviUk8uH3njBA6u+KmlpkuKVsRHrL8bqMVBeFzwtTrUBo 72LAqoXLaQVpNC31F0h5tos9eboZ2iY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710507808; a=rsa-sha256; cv=none; b=j5IJvI8eBL/oUfQd2+CPyeWtfexLpQ3cxicsqBXvORHA5MSUnSkurfusAu2XfKBvVAIQNJ KNDt3BtSt70LkeNYuLW/DJQ8f+SdImx9LHoilUux/5g0At7If8tZspfnHGXch/LnXy0ec6 if3kSmQ6JPowUTXLv1QGqyC2siMA1iQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ln6Jalgt; spf=pass (imf14.hostedemail.com: domain of lkp@intel.com designates 198.175.65.19 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710507808; x=1742043808; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ara5mPb1l4pRKoFUqGzmnoTbO47MBQwiFpYzhwnLMXo=; b=ln6JalgtfER2ylkwmBL5ToYlCuAjwOYpNPnDkJB5trdVCeTeKxCvFOWV 7QP6Jr7OZTlYnz2lCi1cCgefSs8fUJF/skHqhTMzYOC0PQKLZwy7q4K4p 3nStmLTTAjm8l8XpL9uVcAkr9eqVGsVVxdiDe1Q9bjzug9tKvJQe7sSd4 MWTiiilvZy52pqngwAN7gyNFsdHWEJC5oeNniBqcEjQ1Nu4FJha3lAQTu YqvFWSvXncTuAXNiWFhCKlI5YKxuNz/vhjWwINozWf1LHqNvvKCjKxPw6 q5PvOyCucN+lb4bPcxYK2XNcD6cs4Th1HX+Qorne/SH8UEi0B4Rplxvyb A==; X-IronPort-AV: E=McAfee;i="6600,9927,11013"; a="5240230" X-IronPort-AV: E=Sophos;i="6.07,128,1708416000"; d="scan'208";a="5240230" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2024 06:00:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,128,1708416000"; d="scan'208";a="35791084" Received: from lkp-server01.sh.intel.com (HELO b21307750695) ([10.239.97.150]) by fmviesa002.fm.intel.com with ESMTP; 15 Mar 2024 06:00:08 -0700 Received: from kbuild by b21307750695 with local (Exim 4.96) (envelope-from ) id 1rl7AM-000ERh-0w; Fri, 15 Mar 2024 13:00:06 +0000 Date: Fri, 15 Mar 2024 20:59:16 +0800 From: kernel test robot To: Vignesh Balasubramanian , linux-kernel@vger.kernel.org, linux-toolchains@vger.kernel.org Cc: oe-kbuild-all@lists.linux.dev, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, aneesh.kumar@kernel.org, naveen.n.rao@linux.ibm.com, ebiederm@xmission.com, keescook@chromium.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, bpetkov@amd.com, jinisusan.george@amd.com, matz@suse.de, binutils@sourceware.org, jhb@freebsd.org, felix.willgerodt@intel.com, Vignesh Balasubramanian Subject: Re: [PATCH 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files Message-ID: <202403152037.J6Fn7uiP-lkp@intel.com> References: <20240314112359.50713-2-vigbalas@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240314112359.50713-2-vigbalas@amd.com> X-Stat-Signature: ci4au7f58q6emxe1ug7q7rr1ndufq37f X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: DC53A100005 X-Rspam-User: X-HE-Tag: 1710507807-203270 X-HE-Meta: U2FsdGVkX1+OJtDB0vFjqDyEw8FrMppSXs5+VyvFdgZpYU/ZGFrMJp+UXEDxCZz175ZYir/aNGgC5uJ5LDgxxRNoQr5APV8DfWHIWjbAsYvPnJ0S6XH/pBktt6DD0pfQhfgcnOCeD9euYozJDXVHgG2oJgj+KByB8b74XUG6sUQpkczNlmmG35bqhefF0thFj4YKx+88ZpQOvrKMpBdr+iIGe876JiZxWHObCj5q07wCJgHi41WldObmyg1zU1gdok9D4TVopjdcP8EhuqZTP+sDAcOjWcbm19S+8C670dLyh+PUoY+wFI6oPQ5tzK2snpg34UaKF9ftsfT8ha4E4s7rNsZewav7Yoz6TOVVq6FClBo3DWty93rQ0GATLFq9qX9bdgti4QmyD8TZSeS56U450jZQqN5fNz5bnuCWQI1708yCPp9Hr6+borSmJPXnS+fS/nnZGnWO1o1baE92yrB1i7sp3DH+QqCMs+VPIhWAMG68yrUEmS7nabEp+e0KQSvWXIvaO0/ttZoN62aIqZJr3j/AiK/Cgo384UkluPKG5p0Aru2dv4JlcS/2RKYEVeLIZmE4Md36eo0RTjgN/u4CtNTXLAGqA1DKSvv2QsnycTwNRvJvejEVPxxol/OXH1hbBll2Qeq6LdZ1FwFCQ21edf6Bs5cZfToYjhOvqEKMiN+UkRAOM6rWn3Vv2uo7z7pMrFPpW3lQ4n2LpfBgUYoLYtXe8yPgdd7P0ldf2hL2LMiELt9l54f+bPumrs2TgBHTcJ0stclOtGsxvrSsEHesPVe/Dls6gwrzYajuFgGak2BlYP4EDcKCuR8VazqsRWG3dEEGuhL5CHiD1zHu/5t8eLKAOhlYlspKdhVASDdp6qiDkUjpDUvfnpxnOK6n/rUAFCjGrUpEcGxNWrWCoQXB7uAetgtvjtPgedLrK6ANo1cUTlwvzUTWZgnkm0xYJsLoyfhQqYO/qKCI9fi 99zuKlwu G+/AH5j2YXo3OfPBUTP3ezbwCj23wyGaIY1JkpYIYPPopCpfN4Jtpjlo36Va72+mnkFQb+iSTWSzdEyTqBbcgeS5TPsGzD75M8vQYE1MHnBQab04EZnOv6mzZ3fiJfYtcRg41TrhB16kWP8wI6Fz7Ft3bW1X+A1j72nThsAwKEL2L1mbob5Waf8EM4xmaXkh8yaPcpCGBaQuaLz2hK22ASeAEGqCDEyUKLul+NaUb/T9ahP8D+64VSP6fwHDrWrbZNMpJVnm0XN8iQAj4jK06BSahkYkUVwVFcYQNX4g0yRjPSf6wZM5KVjNbMcQkKQX/pQsO6MwzpweeJ7vjIVgSJ+3qMLWsaMjmp73o+Z20Nr+Q2ECYWm9dBZW4RujogDUphPPyRabopsE8H/pqxnZH4m8n11A3tcIoCf+w913LzuS0Ips= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Vignesh, kernel test robot noticed the following build errors: [auto build test ERROR on linus/master] [also build test ERROR on v6.8 next-20240315] [cannot apply to kees/for-next/execve tip/x86/core powerpc/next powerpc/fixes] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Vignesh-Balasubramanian/x86-elf-Add-a-new-note-section-containing-Xfeatures-information-to-x86-core-files/20240314-192650 base: linus/master patch link: https://lore.kernel.org/r/20240314112359.50713-2-vigbalas%40amd.com patch subject: [PATCH 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files config: x86_64-randconfig-122-20240315 (https://download.01.org/0day-ci/archive/20240315/202403152037.J6Fn7uiP-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240315/202403152037.J6Fn7uiP-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202403152037.J6Fn7uiP-lkp@intel.com/ All errors (new ones prefixed by >>): arch/x86/kernel/fpu/xstate.c: In function 'dump_xsave_layout_desc': >> arch/x86/kernel/fpu/xstate.c:1858:22: error: implicit declaration of function 'dump_emit'; did you mean 'dir_emit'? [-Werror=implicit-function-declaration] 1858 | if (!dump_emit(cprm, &xc, sizeof(struct xfeat_component))) | ^~~~~~~~~ | dir_emit arch/x86/kernel/fpu/xstate.c: In function 'elf_coredump_extra_notes_write': >> arch/x86/kernel/fpu/xstate.c:1903:14: error: implicit declaration of function 'dump_align'; did you mean 'dump_mapping'? [-Werror=implicit-function-declaration] 1903 | if (!dump_align(cprm, 4)) | ^~~~~~~~~~ | dump_mapping cc1: some warnings being treated as errors vim +1858 arch/x86/kernel/fpu/xstate.c 1846 1847 struct xfeat_component xc; 1848 int num_records = 0; 1849 int i; 1850 1851 /* XFEATURE_FPU and XFEATURE_SSE, both are fixed legacy states. */ 1852 for (i = 0; i < FIRST_EXTENDED_XFEATURE; i++) { 1853 xc.xfeat_type = i; 1854 xc.xfeat_sz = xstate_sizes[i]; 1855 xc.xfeat_off = xstate_offsets[i]; 1856 xc.xfeat_flags = xstate_flags[i]; 1857 > 1858 if (!dump_emit(cprm, &xc, sizeof(struct xfeat_component))) 1859 return 0; 1860 num_records++; 1861 } 1862 1863 for_each_extended_xfeature(i, fpu_user_cfg.max_features) { 1864 xc.xfeat_type = i; 1865 xc.xfeat_sz = xstate_sizes[i]; 1866 xc.xfeat_off = xstate_offsets[i]; 1867 xc.xfeat_flags = xstate_flags[i]; 1868 1869 if (!dump_emit(cprm, &xc, sizeof(struct xfeat_component))) 1870 return 0; 1871 num_records++; 1872 } 1873 1874 return num_records; 1875 } 1876 1877 static int get_xsave_desc_size(void) 1878 { 1879 /* XFEATURE_FP and XFEATURE_SSE, both are fixed legacy states */ 1880 int xfeatures_count = 2; 1881 int i; 1882 1883 for_each_extended_xfeature(i, fpu_user_cfg.max_features) 1884 xfeatures_count++; 1885 1886 return xfeatures_count * (sizeof(struct xfeat_component)); 1887 } 1888 1889 int elf_coredump_extra_notes_write(struct coredump_params *cprm) 1890 { 1891 const char *owner_name = "LINUX"; 1892 int num_records = 0; 1893 struct elf_note en; 1894 1895 en.n_namesz = strlen(owner_name) + 1; 1896 en.n_descsz = get_xsave_desc_size(); 1897 en.n_type = NT_X86_XSAVE_LAYOUT; 1898 1899 if (!dump_emit(cprm, &en, sizeof(en))) 1900 return 1; 1901 if (!dump_emit(cprm, owner_name, en.n_namesz)) 1902 return 1; > 1903 if (!dump_align(cprm, 4)) 1904 return 1; 1905 1906 num_records = dump_xsave_layout_desc(cprm); 1907 if (!num_records) { 1908 pr_warn("Error adding XSTATE layout ELF note. XSTATE buffer in the core file will be unparseable."); 1909 return 1; 1910 } 1911 1912 /* Total size should be equal to the number of records */ 1913 if ((sizeof(struct xfeat_component) * num_records) != en.n_descsz) { 1914 pr_warn("Error adding XSTATE layout ELF note. The size of the .note section does not match with the total size of the records."); 1915 return 1; 1916 } 1917 1918 if (!dump_align(cprm, 4)) 1919 return 1; 1920 1921 return 0; 1922 } 1923 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki