From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09567C54E58 for ; Fri, 15 Mar 2024 05:50:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64C47800FD; Fri, 15 Mar 2024 01:50:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F9D8800B4; Fri, 15 Mar 2024 01:50:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49ACB800FD; Fri, 15 Mar 2024 01:50:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3950E800B4 for ; Fri, 15 Mar 2024 01:50:30 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D0618801C9 for ; Fri, 15 Mar 2024 05:50:29 +0000 (UTC) X-FDA: 81898198578.05.4DCE758 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf04.hostedemail.com (Postfix) with ESMTP id 06C3540009 for ; Fri, 15 Mar 2024 05:50:27 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="iu/DbzCa"; spf=pass (imf04.hostedemail.com: domain of viresh.kumar@linaro.org designates 209.85.215.172 as permitted sender) smtp.mailfrom=viresh.kumar@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710481828; a=rsa-sha256; cv=none; b=X41aK4EqM+E3kOgMJi9xrOB5oETFCBi8PJS75PWF7qFQZAukUmQHjNFe7A/eZhuOKLKbEv ZFeB7+QSx9NtGdWf4e/663kkXIvjekytHJ4nx84xObgXZz+T+oQvC/2K8nhLMFNFe8HIqf 5gU02CiJuIpNKhXERa27u0g5RRE4G5s= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="iu/DbzCa"; spf=pass (imf04.hostedemail.com: domain of viresh.kumar@linaro.org designates 209.85.215.172 as permitted sender) smtp.mailfrom=viresh.kumar@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710481828; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VmeqZQFsfILznkSe1TDD/d0MuJKx0Lhu/2GiKczhwds=; b=qxLaQgEHRaeTHQugh7lNwBNiVfbc+9wNv2ilXaxotRJjAztWslBSQvRcwzihBoY5InR/LD 4ttE2fg09AQwL8iHQde818DXJqQgiEtUkdsqePnLKoPsPOmbBkE5aS4HjE5ScL/4eLwtSf mwpRfYLjzt8QAsyhxYnMuVaW2tfH7/I= Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-5dbcfa0eb5dso1448319a12.3 for ; Thu, 14 Mar 2024 22:50:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710481827; x=1711086627; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VmeqZQFsfILznkSe1TDD/d0MuJKx0Lhu/2GiKczhwds=; b=iu/DbzCaDD28roxAdCV+jQzaoGn52sCmeloOSCWsl72E4DRBJW2l+Uo4hNv6RGDWuL 40/zZHed/KooDnyKoJO0uUgzbJG/GqWH4r85pQ9ILrfxREc3UlrmSoue6ufOeV5WK+P0 D872cjh7T4xUH/bGqhy1xLzxcu3yzgh8tICyOKlfABpH+5IHtxTSjnZtccy/U79K6Le2 370hJbuGQ6VIR+EiSxymOnmNbhyhOPqCW56SJoTktqts8ymw2fISAmMocOI1FB5Nk9dG m0HKHX9bMtskS7566gM38weT7eSo+DaJQbbiMqGELPDDjVPwaf9ei9ETjS8HAgG/eWtb Vp/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710481827; x=1711086627; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VmeqZQFsfILznkSe1TDD/d0MuJKx0Lhu/2GiKczhwds=; b=bEs8r6g7hDmonO86tGtS1ni+H2z1tLWVMCKfyWOSVCRZ7athqtYi8FDYea3xUYOOqe invxePkXO8xjgG4PlqV/DnNOGQfcbKmpH5IkuFYNT67PDNqS8JtPa+a+dcGuxTphTk9g NAM/8CiHS4U/Tcu8CxwPsCXq265GazrJrmDRpl9xJsr4lx8UGiikdFewzSXlS7uU8MWI wTxCgTy05qQxlgOvScWKlcIIJqRLc5sE8wd73ZlHhOKtuRFtjD9PDLr+iJ1tl8oPNQ/c YXlhw8ex5SzgM2tgZJ/eZFkG+qNuHIre96/nz7+jAZTofeEPpjAmJiB8l9R5Wf8lKVZs wWhQ== X-Forwarded-Encrypted: i=1; AJvYcCW72G+uwuKmVIsM0L6bwOyDqItchWoIIx5+3ELf4GRN6GN55mwsUat/YaArufT7Qa9XKjur2n4Y8yqktAXMHhABnxk= X-Gm-Message-State: AOJu0Yx3V2dga/ztZn/i6Vf3/oZ3CKbdG8SjgwwSf2RsEvk05DdMqRS0 7Ki8zo6R3n1eYxEzKs3lTdfNWdVdCV957NcydoTHyILRvyNLudiXbbAnYfIg1bA= X-Google-Smtp-Source: AGHT+IGfYH1h68xEMnxaFPv1hFUKOr5YSQLITq8lOAM9Fw+k62f3AwJ0HdbWBTJZFkUgfCmfapPMfg== X-Received: by 2002:a05:6a20:9d94:b0:1a3:2f5e:6126 with SMTP id mu20-20020a056a209d9400b001a32f5e6126mr4304199pzb.22.1710481826596; Thu, 14 Mar 2024 22:50:26 -0700 (PDT) Received: from localhost ([122.172.85.206]) by smtp.gmail.com with ESMTPSA id le13-20020a170902fb0d00b001dcc2951c02sm2823712plb.286.2024.03.14.22.50.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Mar 2024 22:50:26 -0700 (PDT) Date: Fri, 15 Mar 2024 11:20:24 +0530 From: Viresh Kumar To: Marek Szyprowski Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, "Rafael J. Wysocki" , Stephan Gerhold , Catalin Marinas , Russell King , Christoph Lameter , Mark Rutland , Sudeep Holla , Will Deacon , stable@vger.kernel.org Subject: Re: [PATCH] cpufreq: dt: always allocate zeroed cpumask Message-ID: <20240315055024.bm7vvznq3nzhfsno@vireshk-i7> References: <20240314125457.186678-1-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240314125457.186678-1-m.szyprowski@samsung.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 06C3540009 X-Stat-Signature: qq48xo1i8c9zxar3qfqqtswfd691g3f5 X-Rspam-User: X-HE-Tag: 1710481827-821730 X-HE-Meta: U2FsdGVkX18kbwToEbMG9i8c61XIcspEVAmltZsh339U7IXVbik1NNKKPiHwq0CinWU8t/GqBERXJLUcjdi+Y5Hu5oSwrKm/4kLB3bEfYjwaE3xWlL3r1w80LkVKOUXdPpGKE+RZkVFCCpckjIm98ZiLPN7HXy1zCBZZbLOpWlnBJ+pRGMNrsYa4LshXWv/Ed6fsTO+bV6vD/vXU6esk2JXH9mcLwRWq3CpsBPSh+wZERG4bWiZq8Gjs2KSQOHJWUZrJtCD7Stb0KxYnUPkQLHX7S8YQPJSEIKJDy9v9VI6vl5HsAZJq3NW106rCbSTKugSUAfjdC0s6qoxmRpsWu4AuE4SzJcQRVWg0WVWvqJXAUE6pseATy8MzUkdISETNSgo1JKQPQ6n4xh9jfoCgi/hHwkUkJdgygooRlkq519IjD7Jr6bljF+iZ6Kj9uV3gsFayNfHXNDa40HvSqu7HdmZ4D4evLm2ZYeUCFng52bN+qpypMzzNU8FjesG0ak/C5izi/TSFZd+NKg9ulZhXY80XsVoZr0UANRaPP1P+20FXknLcK1ifp0WprKi9/PxGyC24t/vhvLCjIu6AMRMGeod2uBo14bARdFhopDWdINsf79j0iJ4L2TIzdhbNvj3+ysiPmMgP8JuUL2ESiTQ/79siCPR1KcdbqrXWBagDOXHMtsaHKdPn5lsTL8vQzxS78g8TIqHI7r89SxI5Pt4Q4b1wyNxAKzOHsZSMtmMQ9hn7tR95wR5rD/ySzXM+sBMGHh4l2nR/dlsUnY07Mg2iz7v7sELzURInGgJqix8RPuvnRjZjfN6gR5QMFppgHMVlDgkPRwbLX1lX9oBjYAnLhsS8WhCqzou62lTGaVCnUWupvUAZJD7HqcjRWbTGTMaXuAbVWd+2J34AOI0wytoGlxGdl9RwHcY0e5o0V6g+FPxrU0o7MykN/R07az5wJt7gs7G+FatJDVO0C/LIWHJ VAWkBm2e HAmlVweZpmZ/hWC71tSK0LT+SoeMn/bKhXp9T7YiN170Eb9CpAuL3r0D4jHy6KqHTdv5JbvJuAwptXon8xfqh0lozJ/1BkqyoEMIIMEyM2eK7MWdWil9qQT89wh8vAID/66zofZiMXKHmuTj60VZnKpwc1zJcfTgREseNt1uyJ0sXFcEYyL3vMbFpWQ6m5nYprEyaI5WWSDDmZoq0mGib/2UZGEid5xSV8NCYVoKFJFNVVGLhu99VbZN/8oO5RXtdsD7wPwZHK7dKdeCK14eVodULLB4FijTqDn2Xx3dQTxTxWNJWtAiyGjtJgzHH9EjTNVcwHBxlVyzGwC2IdETo/BeZB8F/kedZBlAukcm/vo7lx1g+5HmgaGgBtbNOoqU0Dgxs+wOhzZXaB39B++ZBF1OkYlgGxDjt0gPCtCHDCsBBRYk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14-03-24, 13:54, Marek Szyprowski wrote: > Commit 0499a78369ad ("ARM64: Dynamically allocate cpumasks and increase > supported CPUs to 512") changed the handling of cpumasks on ARM 64bit, > what resulted in the strange issues and warnings during cpufreq-dt > initialization on some big.LITTLE platforms. > > This was caused by mixing OPPs between big and LITTLE cores, because > OPP-sharing information between big and LITTLE cores is computed on > cpumask, which in turn was not zeroed on allocation. Fix this by > switching to zalloc_cpumask_var() call. > > Fixes: dc279ac6e5b4 ("cpufreq: dt: Refactor initialization to handle probe deferral properly") > CC: stable@vger.kernel.org # v5.10+ > Signed-off-by: Marek Szyprowski > --- > drivers/cpufreq/cpufreq-dt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c > index 8bd6e5e8f121..2d83bbc65dd0 100644 > --- a/drivers/cpufreq/cpufreq-dt.c > +++ b/drivers/cpufreq/cpufreq-dt.c > @@ -208,7 +208,7 @@ static int dt_cpufreq_early_init(struct device *dev, int cpu) > if (!priv) > return -ENOMEM; > > - if (!alloc_cpumask_var(&priv->cpus, GFP_KERNEL)) > + if (!zalloc_cpumask_var(&priv->cpus, GFP_KERNEL)) > return -ENOMEM; > > cpumask_set_cpu(cpu, priv->cpus); Applied. Thanks. -- viresh