From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6273AC54E58 for ; Fri, 15 Mar 2024 05:28:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38157800FB; Fri, 15 Mar 2024 01:28:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 330D4800B4; Fri, 15 Mar 2024 01:28:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F8C8800FB; Fri, 15 Mar 2024 01:28:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0EDCD800B4 for ; Fri, 15 Mar 2024 01:28:34 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5FAE01C0CDC for ; Fri, 15 Mar 2024 05:28:33 +0000 (UTC) X-FDA: 81898143306.25.F040F5A Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by imf17.hostedemail.com (Postfix) with ESMTP id 3C76440005 for ; Fri, 15 Mar 2024 05:28:31 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=ti.com header.s=ti-com-17Q1 header.b="fQb/pU1N"; spf=pass (imf17.hostedemail.com: domain of d-gole@ti.com designates 198.47.23.249 as permitted sender) smtp.mailfrom=d-gole@ti.com; dmarc=pass (policy=quarantine) header.from=ti.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710480511; a=rsa-sha256; cv=none; b=vxfjeuJ5SYE2FFfDqpo56Sfh2s6oBw419nZZDa/9LGpXCor7NbSHN0M3kxZMJjujAaU3Jv qPjsLFZowJJIjBnPDFmKKRTeY65Xg4M2TnnGYSVbVkK3Cqo7FHGRnS7t/HA9LXl8gkbQcj ztGpkAWQqVnoJI1CghrLNnASaNsJMC8= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=ti.com header.s=ti-com-17Q1 header.b="fQb/pU1N"; spf=pass (imf17.hostedemail.com: domain of d-gole@ti.com designates 198.47.23.249 as permitted sender) smtp.mailfrom=d-gole@ti.com; dmarc=pass (policy=quarantine) header.from=ti.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710480511; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/6G2n4e8p7C1eVE+gmMKGmm9QowQsFFL9iknvi5QMHI=; b=PDVbYOsONbEEydzHfbPX65yYyhC7QMHd1am/da/1lorppdUF5KYa+OwMf99JlGl1meTGT0 vhk6tLGs3nFft5B8ZFl/WDWfOsuKXfagFOTkZJAb1jk63jKmTS9xGIJZmxXNXnjgAhRnsF MKNvkz0VlkzZA5q8eSjECvl2CpetBSQ= Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 42F5Rwhl009845; Fri, 15 Mar 2024 00:27:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1710480478; bh=/6G2n4e8p7C1eVE+gmMKGmm9QowQsFFL9iknvi5QMHI=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=fQb/pU1NAsoTLsgzpPTYk2XWYXulJ99R6WCw3e34GECDrhUBQ6BO49OWv5qEJGnjA SpQtQ5nSGo3YFBtNzRyvsu7DhL90Kc2PkXerMTJ9y0PLuKclkcg/wkWxdvSc/jYCjC et51MitlsDTSiRv1gYorkmu0FUDm0MjMG9kM8MCo= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 42F5Rw58005758 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 15 Mar 2024 00:27:58 -0500 Received: from DFLE103.ent.ti.com (10.64.6.24) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 15 Mar 2024 00:27:57 -0500 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 15 Mar 2024 00:27:58 -0500 Received: from localhost (dhruva.dhcp.ti.com [172.24.227.68]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 42F5RvAV037118; Fri, 15 Mar 2024 00:27:57 -0500 Date: Fri, 15 Mar 2024 10:57:56 +0530 From: Dhruva Gole To: Marek Szyprowski CC: , , , , "Rafael J. Wysocki" , Viresh Kumar , Stephan Gerhold , Catalin Marinas , Russell King , Christoph Lameter , Mark Rutland , Sudeep Holla , Will Deacon , Subject: Re: [PATCH] cpufreq: dt: always allocate zeroed cpumask Message-ID: <20240315052756.5w4zizrod3w7kzzn@dhruva> References: <20240314125457.186678-1-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240314125457.186678-1-m.szyprowski@samsung.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3C76440005 X-Stat-Signature: hn6q5mubbfbpn1x8zdshweima71fb743 X-Rspam-User: X-HE-Tag: 1710480511-376362 X-HE-Meta: U2FsdGVkX19G8m9TfUyQ9QY2OUeulp6p97TvBAORCfdp8QrGUy0XXaP3SyBqTE6X8UVh15E+rBrdFCmGhuJJUQB+n7603ClkhZSRyULYmcZEaT7XdxXp4u5HgwLf6GVULPoaJp2gmxyqeOpPpg0wt453qdNp0R/y60q0sJ8JWflXsECllDcQ8SBYbCP9R7UZv60ZIDa4fKbIFmGN5u6eP5cqpCz9mQcYun4NqGvDRKJfh9CCjJ3m/5JkdkvVCMB/kU+ZN3/Bl7n1VmTScGDEF47gLW1cQc+GPOvB1tDBJuYna7HF6KzXtixPIqs3zGUXBQzijAcYpz/O2NjIyYL7kHda3Aw413lVd17jtSV4UDmvSDnExm2afcOSqridxM3AlbcqVaWtaPj2FYnKQG4xFzRRwv5XN6QjwBRpD1X/pcWe4rkpAT1jzs0UA13dWfNxodV4p7XKNDSTu5aPXNf/U4ppFXvkxSWQh7iIgtrMo2ZSJ1fC70MC00pgnTZ9Ml8a4hfBQ+UNHJJDfZ/AZn5Z1K0J5a/0zv0W003rqoAJvZqnf0/5/xU+ZjiUbMChVWoRhQ9wyZLull3SQaR4hQH+QzrI836QUmKA+lY+VUFTTd8fThXasH3vkfYwiXJJPDf1Em7BzBAdc1yQgneyFvvm5fAgtd1zmtaj40x5HQLXa2a5BiqovFPfbjKsjL8U/ClEedGPr4XigBOeAv66dHo7FD2N9lvQzXTrsz8Aymj7lRwRZWQB+B8UAUTbgZHWxq6QORTAZzS/UBviZFkPnuh+kAyl10eFddauK9HGWR5182iOBqWPGllzxbAljpmKx4Z70fPovoMRIbCr89mXFID2ajlxn9v2tBoxSf6NwAWUrtdZ0MXK4zoRQEsicaSI7MLU5U4XbKLmOci2uQgmRQtC94c82+vpw5tP/HE2PxszCvf52kieP5bQQngIwqa07tyQfw1A5ldpziK14Q+sjEi AmMc9h8C Vz3H7cMP3jnPz7rQ7MhFpixMrYRHJuFPtOQa9iiBR26JVZwn3Y3q9UbnKzEr4WIf/lBVwNy+sLy1OQSlM8oIggc+YSyKD0vVPb3ghz53PFmI+R6traHQwOz+yIwZ6kDS0nd1mxdvs1/L2Q1+z5mC06X20s3jhDefeBKlz1AVCKTEA2ywDJbzUEtZylamfViebMZoj6yCH0jGX9tJ2PTJAciCUp/LhOM+D0Zk+HtX10SK53yUG6A2/dRoJ9hMhmiJMD5sCRq2z/voGjbA0adtKLu9x3MLe5sSSPkl6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mar 14, 2024 at 13:54:57 +0100, Marek Szyprowski wrote: > Commit 0499a78369ad ("ARM64: Dynamically allocate cpumasks and increase > supported CPUs to 512") changed the handling of cpumasks on ARM 64bit, > what resulted in the strange issues and warnings during cpufreq-dt > initialization on some big.LITTLE platforms. > > This was caused by mixing OPPs between big and LITTLE cores, because > OPP-sharing information between big and LITTLE cores is computed on > cpumask, which in turn was not zeroed on allocation. Fix this by > switching to zalloc_cpumask_var() call. > > Fixes: dc279ac6e5b4 ("cpufreq: dt: Refactor initialization to handle probe deferral properly") > CC: stable@vger.kernel.org # v5.10+ > Signed-off-by: Marek Szyprowski > --- > drivers/cpufreq/cpufreq-dt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c > index 8bd6e5e8f121..2d83bbc65dd0 100644 > --- a/drivers/cpufreq/cpufreq-dt.c > +++ b/drivers/cpufreq/cpufreq-dt.c > @@ -208,7 +208,7 @@ static int dt_cpufreq_early_init(struct device *dev, int cpu) > if (!priv) > return -ENOMEM; > > - if (!alloc_cpumask_var(&priv->cpus, GFP_KERNEL)) > + if (!zalloc_cpumask_var(&priv->cpus, GFP_KERNEL)) > return -ENOMEM; Good catch! Reviewed-by: Dhruva Gole -- Best regards, Dhruva