From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABF0FC54E60 for ; Thu, 14 Mar 2024 16:34:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2046C800C4; Thu, 14 Mar 2024 12:34:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BFEE800B4; Thu, 14 Mar 2024 12:34:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFC57800C4; Thu, 14 Mar 2024 12:34:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DCAB0800B4 for ; Thu, 14 Mar 2024 12:34:11 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id ADBC81415C2 for ; Thu, 14 Mar 2024 16:34:11 +0000 (UTC) X-FDA: 81896191902.28.2987369 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf04.hostedemail.com (Postfix) with ESMTP id BB30940022 for ; Thu, 14 Mar 2024 16:34:09 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=JSAM8cgc; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf04.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710434050; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GGF0W7br1YH0ZUlowMCaPMKKH8Q1iNP76Vr0o+a0Qno=; b=GEMVt5itcfrtcMZsV9To4bK7tRCCxDGOa/+6hCL1IkO4pCOAZWUYrr/X0LnwfmQp29IARG ch3IDaroQDOWEtMXbyrFX4SRVlHjuZs6n4Re8wt0ohwLnZ4ynE8of4BsyVH0mZw7Qmvgpe MLkobvQ53+LlwTgc9uj4J5RfYv2PaKI= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=JSAM8cgc; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf04.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710434050; a=rsa-sha256; cv=none; b=WvSNmvNkig+pIT87x3D6WMRaHU8i0+vTa2gBmipcAhgDRZLJeExQylZkgwaiY590DVfxKz SQspTa1fOjkA2RoEUlcf5zxjq+Qc0XJAkGDTSZEZqBMaImAI4nWc8aPK/WA0NRZpFp/ewF zL/lFrepwEFEb4W/63dNNqYgBio2704= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 9E10940E0196; Thu, 14 Mar 2024 16:34:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 8u331dPGBT4t; Thu, 14 Mar 2024 16:34:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1710434044; bh=GGF0W7br1YH0ZUlowMCaPMKKH8Q1iNP76Vr0o+a0Qno=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JSAM8cgcbWNcgxL5xkU6azEPrkz//J+mlQKFJ/7VqRuZZv+Uwu2dVlcW7GpSsD8K1 jGurAjPDQXcf0lNcGO20/AXzsa+stfPbYHuY6Zr47bNGeYgqfq8LjQHc+hQqwMV5NT P8ilKqJBqq+JAxMMIY/54tgtojeeOlTXp/u4t2simmbbg/zsJlmxfcxCXf9f1GJhvx y4n6MLLdHSNcYzkQ49D/xrkolApNRt9UIh8a5MwLKKUxS8gETCwWi2NFhGuSjz42uK xJ+M3I4YiPyVe8gvYa8ghAYu9gv9PiTIk+KoyNx3I6UTev0DBFJJuUT9waQKrv9T+K Z4hasRC9L8UjFNa7tyKaj+EDdUJnEBTlWB1RnIO3pQNWIhy50KKlW8sUFZc71xMva0 gdg6livm0X7k1KxPJjo2droDcfx7XCayZX1JIE5OLjYYC5AVd4uAbXMqBfeDoB6qJk EFZQAzxSV+rxEU4h+RkxuerWIwJIXdVJi0Z2MNIIOhz8YwnOzlo73fN05fsNk0pGj6 yGGOlMYUFxWB8gtuBxXnc4uLS4uWZkLTgmNEvcrcPRcC9mR9PR/Wby5EXFWNEugTfi fkQqkSSMFAV3KW/SqtHEEVg2mircpzHLR/bcvrRK7nb9q1Acu2ttVHZpHjYC2glhrd nIXWKv4LaCeAHb3Mzt/TL/ak= Received: from zn.tnic (pd953021b.dip0.t-ipconnect.de [217.83.2.27]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 3C91240E016B; Thu, 14 Mar 2024 16:33:46 +0000 (UTC) Date: Thu, 14 Mar 2024 17:33:45 +0100 From: Borislav Petkov To: "Willgerodt, Felix" Cc: Vignesh Balasubramanian , "linux-kernel@vger.kernel.org" , "linux-toolchains@vger.kernel.org" , "mpe@ellerman.id.au" , "npiggin@gmail.com" , "christophe.leroy@csgroup.eu" , "aneesh.kumar@kernel.org" , "naveen.n.rao@linux.ibm.com" , "ebiederm@xmission.com" , "keescook@chromium.org" , "x86@kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-mm@kvack.org" , "jinisusan.george@amd.com" , "matz@suse.de" , "binutils@sourceware.org" , "jhb@FreeBSD.org" Subject: Re: [PATCH 0/1] Add XSAVE layout description to Core files for debuggers to support varying XSAVE layouts Message-ID: <20240314163345.GBZfMm6Ve5QMY_xPjl@fat_crate.local> References: <20240314112359.50713-1-vigbalas@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: BB30940022 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: rwocnbbm1jmfbmtceopt1e6d3rgi5sx6 X-HE-Tag: 1710434049-587296 X-HE-Meta: U2FsdGVkX1+5MspqOqth5wviRfQXkWj1f2QrYviMcb6h40k0ue2ZTcKG7MCmOF+VkIExip/0UuonSetANhj9YlPy/9lByde4RXdn3JFiSInURkj25iprXVNy6ytynmBNb2pljQ6rRUAtF8dBepq0uliIrZy2YKMm8XpITuOfCFQZuFRvjQBHgiwzSCBvocSz9EWAb8rvhEtYjoh1xGz6dnTl2wAv6LzEW7fhew91ZgRqQtRZC/GD+HotNeMDluy03rlTWB87xZ9aX/9fFAS820+PDAI0CuJ+HO7bwkgk486vQtSehdp5tWKQ0nMRMIw/1A3ZmB9k31FHXjA+KUqGmMV68ZSbmdxZ2JTzQlRhsBdARjGLF02aWyCw6wn0JzjsCvrqcVQ0Wx6oY202eRKHY94A8SphWfzf9up72UWlopDTErtum08Q+VW5bUOJTUUWZU/hvqp5oPo3V1FXpEtx/hx/vXbMiwLICBG0lrX5Yu8bImpzfoXxiy/+LKOFjMl4x7e2bhiRuau3MBVj/x1fEapCaR7gBCqMHG7mxiFUMrI5zSeRffUdidS5x0EvQL1CWvumAUfIJuIwbJl3efpWdzQm3V1NJTNJbaHukANbjaj7ni/KKOf8dH33PnZK9iCkZ+mnY8VYywu2FoO+O/yCv+wKUQgWaxBGoZ+surYBGwVxEUxuqc4ieKljUL3QZZ/NII4qX4lAP7WbltJJpamWE7PTWW9DFyxHqzFqv+kmgRGU3BhKpNnOy35KmZPxqlfV8lyVi5ydyJJYaQtNFZU2u6JyctfGrLLZOj+DZLX4N+hPWqbkBMZ55NNqpm30vZudOAxDw/UXMuVvQdtqqfWhVr6F1m7j2qql8RDlC2Ag+ITOcaVfqRZLdPRIYNfQ7BbRF9Go9r1Vm4pD0FQUByu2y7QVY1l3LuIGY6LgHrdjfe6pvuEbdpcwF7lLSm3fSbzpXyZy7JV3uSQW2xMjvW6 0LVZthNh lpTLTxDKeTPeJ71yjP3IMJl4NbKjImZsYkIMS2ovPJFcOGVyTAJSnBIIIeqZ6d4G2HwUkjScrgzD/DYZnpsUwPmLWYv9cwpvLyyeBBgHW7nHawBzdPSdZ7aDO6y4sdpDlnRpEzkc+2RzFJ6t9gPNJFMWXMD+5gEZSNn2R/3n/+B6B4Bo0QNUfN5S/SbwGlr7CyNiLCu9EKMKnu5CSoKnegAJ9HTE/h0tYQ/fHS1vRfeKeoigCWHr0ynpOGw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 14, 2024 at 04:25:44PM +0000, Willgerodt, Felix wrote: > I am wondering if it wouldn't be easier for everyone if corefiles would just > contain space for all possible XSAVE components? You mean we should shuffle out from the kernel 8K of AMX state even if nothing uses it or the machine doesn't even support it? That's silly. Please have a look at this: +struct xfeat_component { + u32 xfeat_type; + u32 xfeat_sz; + u32 xfeat_off; + u32 xfeat_flags; +} __packed; What is wrong with having a blob of such xfeat_component things describing the XSTATE buffer and parsing it in gdb? Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette