From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C352C54E60 for ; Thu, 14 Mar 2024 16:30:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B2CB800C3; Thu, 14 Mar 2024 12:30:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 162FD800B4; Thu, 14 Mar 2024 12:30:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02A19800C3; Thu, 14 Mar 2024 12:30:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E5E44800B4 for ; Thu, 14 Mar 2024 12:30:26 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id ADA3AA1E53 for ; Thu, 14 Mar 2024 16:30:26 +0000 (UTC) X-FDA: 81896182452.15.ABD27D8 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf27.hostedemail.com (Postfix) with ESMTP id 87C3840016 for ; Thu, 14 Mar 2024 16:30:23 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=ddlCZvhK; spf=pass (imf27.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710433823; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TDNTVQ6N/4Ma+VE1wv9KFMROi1UWZqALylRp98/G0mU=; b=g0ONw4RbaoMv/1cDryltpk3qAvMC7U3mD2+DYtq8Ufdk0MY5s4XdPWL3GEJUMbR/Z7hINF f6vOLXALrLt4jx76mNJ0YJCsADdIZh6tPcxGow7G/lS+wjTOMBjvoFAhR4vEM5VQKXRd/n aPA9wrONHc24O2lFQzNilKyqylHuhsY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710433823; a=rsa-sha256; cv=none; b=hKJbQRZmpQud0A06sDZPdrop2bkPZ4HOqSa1qh8lzr/Uro/Di0J4Tet5SP6jay5xo80DCT WJ1s0YJL4cCc1SKtvAz7/e4myP0UKSLbqSvlY2ZHD80rKLMZF2leeE1hEJEhEOGK1SG7FI PcmwlOjmzEi4qveGuz2I0wtVuxGJ170= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=ddlCZvhK; spf=pass (imf27.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 7B2F840E0174; Thu, 14 Mar 2024 16:30:20 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id co3JfxzjaIvC; Thu, 14 Mar 2024 16:30:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1710433818; bh=TDNTVQ6N/4Ma+VE1wv9KFMROi1UWZqALylRp98/G0mU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ddlCZvhK2bva1wkCFISPWhSgA7oIf8S2dPWHppglYZqtz2vSxx8HWA+RSdmHdKToP OXiDCpFXON42bb3RABzcGuvB1VcNP+f46sdsuckHwDSIGgbzUfxd2sW7VA45U7YhIY zKGAvZ2OsSZrlyo2UNQNOAnwT3d6RBb8y3L/G/4yPBqpQXrINgbYSoCXWF6d9IrIu8 uJviBtaXalfqUB+yQlT6brtKj8nY0vqkvoYeSyoYRcYvm+04ai8X4NBVX/jGJ+hew+ dsMNF2MHZyedo8t1y17yeo+d6xZHxKm7ufX97aqPVNYq41tpTncoXBicw2r50mUTab Y4wNs/ovE3xZVjvzgyAEUg6yZFVua6Fu9WByko2XBA9PFBaQbG7yZekZ23pq+K4wDY aFgxfQyTkKc8iNPSfuZoVynMtbBCaVJIV9sAiMdWw8iqFQcXtRI3kYZpu00yHs9Q4W 6UmIy+mT3JGW8uuvS6LAMEFBS6pwCeeCkkFAKrK+e7UuPvDcf+qXmARG2CkCym2cH3 dYYYwQntIQfkZPc0hf9tjG7WLVcILOT2TUw0TebHm/cIgFKLNTpwdEPDbTZBikrpzx boTN8C5W0q/AR9R7VsUiKow4otv0wXPMKJjbw1ZeycSxcXSns3SGs0P1gthQAv0Kpv TMQv0SmS6/g1mehnnlDUuNsE= Received: from zn.tnic (pd953021b.dip0.t-ipconnect.de [217.83.2.27]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 27BBC40E016B; Thu, 14 Mar 2024 16:29:59 +0000 (UTC) Date: Thu, 14 Mar 2024 17:29:54 +0100 From: Borislav Petkov To: Dave Hansen Cc: Vignesh Balasubramanian , linux-kernel@vger.kernel.org, linux-toolchains@vger.kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, aneesh.kumar@kernel.org, naveen.n.rao@linux.ibm.com, ebiederm@xmission.com, keescook@chromium.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, jinisusan.george@amd.com, matz@suse.de, binutils@sourceware.org, jhb@freebsd.org, felix.willgerodt@intel.com Subject: Re: [PATCH 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files Message-ID: <20240314162954.GAZfMmAnYQoRjRbRzc@fat_crate.local> References: <20240314112359.50713-1-vigbalas@amd.com> <20240314112359.50713-2-vigbalas@amd.com> <20240314160824.GDZfMg-J1VOyjxIMiV@fat_crate.local> <6ce6aa20-25d2-4784-823f-2a18f592e002@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6ce6aa20-25d2-4784-823f-2a18f592e002@intel.com> X-Rspamd-Queue-Id: 87C3840016 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 8zswns56x39fuiuqjgz3j1jmqttknonz X-HE-Tag: 1710433823-80288 X-HE-Meta: U2FsdGVkX1+WQ26gXO3JVHdRIDaGiPcv+cm6YmuqO9M67Dqp3acs5wc21CWO9dVoMoojP3KFWMeJVNwbs28mfKsViaH54NAwsdGFH3pWRvAdqKVVB1Kp8oitS2uT7Rh9asDDUWmPsAF27t1mkTNdH6P+B80GfAaXDK/ILyJbYCB5Qm5mWtVpnv+05xC1PjkB3K0NDyaZFzuYskNZHd05m1TMCUeOV7AEGoUhBRza4v+jWNmJjkW5jzc2IfMnbY4Kery0hxH5cfBFEq/w6V0Xfz6pkxmXfGuwDQWaO26USRBp6ztokYICjoz04WWeK0H/khv3HhKIwi3goLMzjzktezl7khNUmRJBhAOBxpLX7t3iXGimP579yo2bpKVsU1OmKoOavJfWo+dsnYKece/BIrxUUVSpgreyZy939wlVlfx0osOsK14RwvqspdkwxDjZhALaHcABS443vW75jS6uzcXbOboW0HfNA02Y/b4CHHbPVkqytx+j3ovVGmHqEvFyB3t3NZA88CJ0puaXEK5h7EFjXDB2hVuO1mDkNohn5jjgwkOc8sjECJlW3ytlcGJfCQGgtdTEQvho1Vhm3fplYvOdcbJm7uXTvDmxgp7Kv8vb9EQVMAUwJPaaXXcJR/UxblPNPaEicFdWGJZpX2MNAmJTJyIUwZvmZ375o0YZ3wMjsFC2ezaGK7vNgJxKBcQefJTJHm/ouIX9QbrAZnyD1z8/xjztwyn4zVEhannXdIuRB+CMSY/y/1dBMJdGJogf3lAZfZfftX1rMT7LUD7Ngmf6vQbOizbLDaM50SPjERJ2P2GpycfZt+YVgqckB9MwLfem86B09B0GL6sAezWGWv+055LoCwGMUheYwNU5BtrDmyAnGVSps81XAtkTN7EZHB/wH5MbLqYhlvyWCmbGY7gO9l9ugtJOcptoJS54l71qycugCv8qmS74wcsKvJZNUhXCg0Vq5iYal31K5Fj PZqAC3Ll TauWvEi3L1v/J/zMXuHknGc+DsqfbaM8GH9mULGMvffQd0OdnytdzJCnfBD0dwt72GNmVdScNah6HsoGX3fGWqpaD/pYqwUS0nLrECi1/wAX6UYMsFn6ONxkpqQAAfO0gmPo0HGzShJP7ZatsRiv8BTY7c+FQe+/BoMwrDlPX2bT6cgrERhmICWGqlvetWMVf7hOmIW3q/P2du4Jca0emG2VoHobYUAqrY52XwnCIm1YNoI1bE5WEi5Svqm4cVi6awDPnExbSwoghyjY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 14, 2024 at 09:19:15AM -0700, Dave Hansen wrote: > Are you envisioning an *XSAVE* state component that's not described by > CPUID? I want to be prepared. You can imagine some of the short cuts and corners cutting hw guys would do so I'd want to be prepared there and not tie this to CPUID. > Or some _other_ (non-XSAVE) component in a core dump that isn't > described by CPUID? Yes, that too. Since the format of this buffer is so simple and machine-independent, it can be extended as needed without issues. > That argument breaks down a bit on the flags though: > > xc.xfeat_flags = xstate_flags[i]; > > Because it comes _directly_ from CPUID with zero filtering: > > cpuid_count(XSTATE_CPUID, i, &eax, &ebx, &ecx, &edx); > ... > xstate_flags[i] = ecx; > > So this layout is quite dependent on what's in x86's CPUID. Yeah, no, this should not be copying CPUID flags - those flags should be *translated* to independently defined flags which describe those buffers. This is even more important if we change our xstate_flags[] machinery. This buffer should not use any kernel-internal definitions and structures but be completely self-describing. Vignesh, pls fix that. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette