From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24DA2C54E58 for ; Wed, 13 Mar 2024 09:21:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C4DA80017; Wed, 13 Mar 2024 05:21:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 94DB9940010; Wed, 13 Mar 2024 05:21:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 778EC80017; Wed, 13 Mar 2024 05:21:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6229D940010 for ; Wed, 13 Mar 2024 05:21:01 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 31B68407BB for ; Wed, 13 Mar 2024 09:21:01 +0000 (UTC) X-FDA: 81891471522.28.A2B22C7 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by imf02.hostedemail.com (Postfix) with ESMTP id 8A3AD80005 for ; Wed, 13 Mar 2024 09:20:57 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=VNY9u517; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf02.hostedemail.com: domain of quic_svaddagi@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_svaddagi@quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710321657; a=rsa-sha256; cv=none; b=sS4KUZj/+z8rAJL46YfCMYZJSnbGgRPQPzK9DFtSfUGlU9oy1YnjmBmcfJC3UUGQPQSuk2 KIQbuR9rgA3GftJc2sRJ+oMJ2u2ymhHFxmF/o3GbDjln/PdeVlTBPPxiXTUvG+X28JRRoZ FJ60tCm4no1MIIIxKlbySMO2yErnIBo= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=VNY9u517; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf02.hostedemail.com: domain of quic_svaddagi@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_svaddagi@quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710321657; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xP66IhxbwHSzo3BS0aAaFRWAp/ZD5ZoLJGqOG2l+yeQ=; b=wR2sb7//HC91II28T6pMDgTXK8b+jIWPe2KC6y9MhCod4rsdhapChgzrdq5atqOkro4Rtk MPEjwoMxwNsmYMlvKTGct6dXBPC88mEHOj8VroZciwV1C0ew7kdJjduJKRHxX1Q5Nnc0Kz pyWeUvfvbsL7p3TRzVbuo/OGDbx+Ngk= Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 42D8Z0OJ006689; Wed, 13 Mar 2024 09:20:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-type:in-reply-to; s=qcppdkim1; bh=xP66Ihxb wHSzo3BS0aAaFRWAp/ZD5ZoLJGqOG2l+yeQ=; b=VNY9u5179yOH9zQvMevWSnz/ RM1NRqncsGQ5WIRIZj6vZX97OjI58Ks4mLEIM1H9v/xGvV/4w/WOiz8U0FEU8mY2 /V02Hwo10yptTQU9UhbOLdx3P1bmhDDtZgHk+L5E4eRRMBLi8+ZQy2czpUGUw9zv Iw+rsgM2eTzwweBMA9kK2L2yuqQmwQyDIqVGn2jeamrSAk9CLubDbY/uvWqaXieU Yojw1lzC6dviUlpzOTZNrzjkFU1XvYHawAZFiUbY8SG4OvE1SFsr55Y0Y4hsve8s ZDEi+8F0F9z9zOMAY8yq+PUmEiRCvZkyGeHSWIop2Phx4G+hvJmkgL4OgLkOEg== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3wtug01r5j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Mar 2024 09:20:50 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 42D9Knk9005016 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Mar 2024 09:20:49 GMT Received: from quicinc.com (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 13 Mar 2024 02:20:41 -0700 Date: Wed, 13 Mar 2024 14:50:37 +0530 From: Srivatsa Vaddagiri To: Elliot Berman CC: Alex Elder , Srinivas Kandagatla , Murali Nalajal , Trilok Soni , Carl van Schaik , Philip Derrin , Prakruthi Deepak Heragu , Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , Konrad Dybcio , Bjorn Andersson , Dmitry Baryshkov , "Fuad Tabba" , Sean Christopherson , "Andrew Morton" , , , , , , Subject: Re: [PATCH v17 13/35] gunyah: vm_mgr: Add framework for VM Functions Message-ID: <20240313092037.GO440762@quicinc.com> Reply-To: Srivatsa Vaddagiri References: <20240222-gunyah-v17-0-1e9da6763d38@quicinc.com> <20240222-gunyah-v17-13-1e9da6763d38@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline In-Reply-To: <20240222-gunyah-v17-13-1e9da6763d38@quicinc.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: W3OLSKAGZJ5FEm8fdz8CXglbYAd8OJN2 X-Proofpoint-ORIG-GUID: W3OLSKAGZJ5FEm8fdz8CXglbYAd8OJN2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-13_07,2024-03-12_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 mlxlogscore=807 adultscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 mlxscore=0 malwarescore=0 clxscore=1015 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2402120000 definitions=main-2403130068 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8A3AD80005 X-Stat-Signature: ownkwmeesbrxfzdtmxr3tka7rxspani7 X-HE-Tag: 1710321657-984705 X-HE-Meta: U2FsdGVkX199prdMvPsL4rtwi/M8anWJ54YD+wfEge1CldpMM40D83wlGzmT0UKYKw3Mh4tdvA8lE/ZGetJsfgF0hR04iJDDF2/2iftDYECp/Hj9zJclgt9ecVsoTAPsEcWXJvto9rezexN3emOs7WVrfsmpdQvzpu5m+FjGwTSAbBLxatxc7/ZrN/XcWIExtxbAhDEOw1ztGwi+XTeA9YZcEB7xjYk6E8chQvJpaMyp23yKuoYJEKi0Gu0kHUDftz0VziZBXJU3p1BRuT2+tG6gQHNTyYb1y0Ziwn917tUEDtzgYmu3Q23cbtUPMbA2l0S1E+t6iaaexqSfq++mqK346Ypt0vJ+cdlSWeoOnvW0rkNunPIoazIvPyyAqn9Yn6h6Ip0Jlu/9UpKx51a9azp9OoK7pXqymu6/GmFg5X8+r35E5CxBKvWzgHS0S2m5JI6gsBIHxSFqA5ipyColTsWAQXpcYo2HHJQV27zXvmTRQzP4f667Lka1QlT2utZrS+OxRK4W3xZicM3tw80BRl0Wmfq6BfZy/mV1p3O95QtO4wLQ9ocUNeFF9275m+p8tAp8JGLUmgML+btbgQxBYq9iiKrF31neylt0oVpZPOprxgbS+GMncPQCkAzvQiNclK4QbvX2HcrvmQJf4zVp/2SY0oThGPIdrRVUf9Ot2AitNlj7gCr+vpx6rgwVVsPmmb2s7L9xwePBeWsEefIWMAPBfvKs7kawBv6LLyK4wkWn3xUv0Lwve0AbtTvv8Un5E9TU7gXnj+pO7NSF5AVlQIJUVkDnvlUqH6J/TgZcfc+vZ/AgsY34qd9D3oGfCPQ3j1W0oLtydnn/tPjWa5HXqiEgP9QoalS8pERryYmMreXPFIl3OTaHSMAdWJTylOwl4gjdw2F4Btsb6eaY4vz/FAMklj2YCOP2VYoirlz33iwJRHW0HdyTA2fa9U92R2VDMEOKc0P5X1PQDSMCmJF t3GLqpWj 7YSE2xXtm9y631rlr+mOjXH93aUKeMCq9KkwNzsFq0+imXedPbVcG7ORLe5dD9UsVQ6w6KP4yWaL+GXGcWrjzSgJDDWvDHUSwuJfwfADWloFgDMb+OhPgrJqu/Ihcdtjdgv3r X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Elliot Berman [2024-02-22 15:16:36]: > Introduce a framework for Gunyah userspace to install VM functions. VM > functions are optional interfaces to the virtual machine. vCPUs, > ioeventfs, and irqfds are examples of such VM functions and are > implemented in subsequent patches. > > A generic framework is implemented instead of individual ioctls to > create vCPUs, irqfds, etc., in order to simplify the VM manager core > implementation and allow dynamic loading of VM function modules. > > Signed-off-by: Elliot Berman Minor nit below. LGTM otherwise Reviewed-by: Srivatsa Vaddagiri > +static struct gunyah_vm_function *gunyah_vm_get_function(u32 type) > +{ > + struct gunyah_vm_function *fn; > + > + fn = xa_load(&gunyah_vm_functions, type); > + if (!fn) { > + request_module("ghfunc:%d", type); s/%d/%u > + > + fn = xa_load(&gunyah_vm_functions, type); > + } > + > + if (!fn || !try_module_get(fn->mod)) > + fn = ERR_PTR(-ENOENT); > + > + return fn; > +}