From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBBF3C54E5D for ; Tue, 12 Mar 2024 22:29:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 489258E0025; Tue, 12 Mar 2024 18:29:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 416198E0011; Tue, 12 Mar 2024 18:29:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2049C8E0026; Tue, 12 Mar 2024 18:29:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DDA888E0011 for ; Tue, 12 Mar 2024 18:29:10 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BB1D1A077E for ; Tue, 12 Mar 2024 22:29:10 +0000 (UTC) X-FDA: 81889828860.11.2F2A4E7 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by imf11.hostedemail.com (Postfix) with ESMTP id DAEC54000C for ; Tue, 12 Mar 2024 22:29:08 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Vhif4jw7; spf=pass (imf11.hostedemail.com: domain of rick.p.edgecombe@intel.com designates 192.198.163.15 as permitted sender) smtp.mailfrom=rick.p.edgecombe@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710282549; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=580Q3nTRFYFTa5dZ8BPFsAQbl4MD0TdYDfsVAzzY0+o=; b=3K90CHBbdcRJe3vAJTEaop/AVap/YYrg0yHe2R72OfasKmvpf2tshqozNX8ws/TI5hwUMT 0sf+rwqJfaoNmG303d6KN3IJsFCBZWjK5ew8+tSRIefgsyLfrkIpK7sH9O8b6FIP99UuHJ 2/+wk5A75PjZgAxe162HKqykz09ho84= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710282549; a=rsa-sha256; cv=none; b=gDucYBAvCjPVgZ0FTq8rD3hgqMIrsSOcqZSKWPwxG49CIiwyOhFdtJ6p+MrTshFSLFkR/g 0sXkjaNhBrCuIeP+6OlEHD4+sfWyEboaGPuBedIfKQHDTF9zub5GfyM11PCEMAABE+VVw5 J6bRz3R30wcXr5Cs5hl88lhForbjTCs= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Vhif4jw7; spf=pass (imf11.hostedemail.com: domain of rick.p.edgecombe@intel.com designates 192.198.163.15 as permitted sender) smtp.mailfrom=rick.p.edgecombe@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710282549; x=1741818549; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0AXtXC2QsVELXP+nYGygIha/dj1Cad9y2eG6v/oGLtg=; b=Vhif4jw7od/UzuRmOMQvHKfxiDh5rCuQmcX8XoTqGTxBgLdn4Hui1SvZ IGryfRdtbliQ9Ubs7k2kqt26aJlH7PiFF2rDFN8R95RtzrVEoHnOC3g/Z w60g00GYiANFWRSLyUZ5kfqayTV05voIaxcKLV6+mecOa8pNnarlbxxNn KWM1nsx6Ix8C6oWy2OYkAjv0qkgLswu93tOZWMnWChD19c2l3HI8cLeOo T5wsA7MEYm91tXgH+ZoqNT083gZ01HN+pYNu4DcuhwoX2KuD9lI5o52pp 0+SJnTqIq57jKJU5y0FOinmRq6OJKXFJ7KQ2/VgmKGSYT88WJXqyTkYvr A==; X-IronPort-AV: E=McAfee;i="6600,9927,11011"; a="5191983" X-IronPort-AV: E=Sophos;i="6.07,119,1708416000"; d="scan'208";a="5191983" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2024 15:29:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,119,1708416000"; d="scan'208";a="16356855" Received: from gargayus-mobl1.amr.corp.intel.com (HELO rpedgeco-desk4.intel.com) ([10.255.231.196]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2024 15:29:03 -0700 From: Rick Edgecombe To: Liam.Howlett@oracle.com, akpm@linux-foundation.org, bp@alien8.de, broonie@kernel.org, dave.hansen@linux.intel.com, debug@rivosinc.com, hpa@zytor.com, keescook@chromium.org, kirill.shutemov@linux.intel.com, luto@kernel.org, mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de, x86@kernel.org, christophe.leroy@csgroup.eu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, rick.p.edgecombe@intel.com, Helge Deller , "James E.J. Bottomley" , linux-parisc@vger.kernel.org Subject: [PATCH v3 06/12] parisc: Use initializer for struct vm_unmapped_area_info Date: Tue, 12 Mar 2024 15:28:37 -0700 Message-Id: <20240312222843.2505560-7-rick.p.edgecombe@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240312222843.2505560-1-rick.p.edgecombe@intel.com> References: <20240312222843.2505560-1-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: DAEC54000C X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 5pzhhkb7jtx3ogsa48qj6nakio6ffw8n X-HE-Tag: 1710282548-579992 X-HE-Meta: U2FsdGVkX18k9jS7QFnCP54L26CcC6ycOkUJpndFyn2AgXRv/uk1X63+EWwxxPGvx/RgkNGNg//JWvBmwN0Jdr3pxSZXJq5I9RGfeQhbuwfI+/LBS1BJFPMTB7LEiFK3oeeVpp39MuZb8q7ejI1pIrdmoCQMfPruoD0wgZnTmm3nljc9T/ZrI3HDfmkS97VaTmR4PAtVN/jL24rwRKNt5XsxUBEM4tVccehZdXyuXe/KmacJJb9WaCuiAdT/wDVwmFW4jOTVaRLlYYreYMCgK44TjJlD8p9AoUbEXrSSd9iBTevIWw62e/ycCFyOen2wb382IVVyJQffrgVVIl0Sd5yLP7MG7h8oiWNd0i1NM3D0WiZT3gD5MZi+x3bNGipl9I835AEhBJTKlJSYmE3DKfvle9ByqbkhLOvDwiSkt96c2vVyZfFTGSdBdI8cAl5kYU5beTfuONWxSZ2WRtmz5/H3BRxhhB3udubCU2ZeUCif3XAlSv0Ohc/IzGjGJ8y42ntEhfry5RKQezAZ4S7f7wGm+oWRbxpClh4o1M2f6KLoLbL24k8M60UKOCZN41uG0flT/Z7Nf9AAOwXwdljbdXW/e0rj57ElzyL7bDu1UCxlt6bhMU9tw/M9YwzpQqrFk9c5DIhNhrHMLckaDoTV6oZsdvHQkr5zK3NUiKH8Jx7VVnNgMk/k8MGB/NBVHKae3YYIeGvZve6sqgFtG6R9MF2CmV9dr73qurlljr4cqtUAdoqwjBx8777t+pdSwIjpwIyOjXyeXyc0I6eHpSQU0SccameTCJrncoQn2QjiPbW6SjP1F/eRMHl25Lt1zXfOdV8VEGh3O2ANE92s4GMaqRWucB9Sr4JdTIjn2HNiXEH3ST6fAeI+YvP0Y5n81b7VrPASCVb3kTImtu+vxr6r6Tgj0nCPAD/wvteURVU3hNkBirjt3iDWCQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Future changes will need to add a new member to struct vm_unmapped_area_info. This would cause trouble for any call site that doesn't initialize the struct. Currently every caller sets each member manually, so if new members are added they will be uninitialized and the core code parsing the struct will see garbage in the new member. It could be possible to initialize the new member manually to 0 at each call site. This and a couple other options were discussed, and a working consensus (see links) was that in general the best way to accomplish this would be via static initialization with designated member initiators. Having some struct vm_unmapped_area_info instances not zero initialized will put those sites at risk of feeding garbage into vm_unmapped_area() if the convention is to zero initialize the struct and any new member addition misses a call site that initializes each member manually. It could be possible to leave the code mostly untouched, and just change the line: struct vm_unmapped_area_info info to: struct vm_unmapped_area_info info = {}; However, that would leave cleanup for the members that are manually set to zero, as it would no longer be required. So to be reduce the chance of bugs via uninitialized members, instead simply continue the process to initialize the struct this way tree wide. This will zero any unspecified members. Move the member initializers to the struct declaration when they are known at that time. Leave the members out that were manually initialized to zero, as this would be redundant for designated initializers. Signed-off-by: Rick Edgecombe Acked-by: Helge Deller Cc: "James E.J. Bottomley" Cc: Helge Deller Cc: linux-parisc@vger.kernel.org Link: https://lore.kernel.org/lkml/202402280912.33AEE7A9CF@keescook/#t Link: https://lore.kernel.org/lkml/j7bfvig3gew3qruouxrh7z7ehjjafrgkbcmg6tcghhfh3rhmzi@wzlcoecgy5rs/ --- v3: - Fixed spelling errors in log - Be consistent about field vs member in log Hi, This patch was split and refactored out of a tree-wide change [0] to just zero-init each struct vm_unmapped_area_info. The overall goal of the series is to help shadow stack guard gaps. Currently, there is only one arch with shadow stacks, but two more are in progress. It is compile tested only. There was further discussion that this method of initializing the structs while nice in some ways has a greater risk of introducing bugs in some of the more complicated callers. Since this version was reviewed my arch maintainers already, leave it as was already acknowledged. Thanks, Rick [0] https://lore.kernel.org/lkml/20240226190951.3240433-6-rick.p.edgecombe@intel.com/ --- arch/parisc/kernel/sys_parisc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/parisc/kernel/sys_parisc.c b/arch/parisc/kernel/sys_parisc.c index 98af719d5f85..f7722451276e 100644 --- a/arch/parisc/kernel/sys_parisc.c +++ b/arch/parisc/kernel/sys_parisc.c @@ -104,7 +104,9 @@ static unsigned long arch_get_unmapped_area_common(struct file *filp, struct vm_area_struct *vma, *prev; unsigned long filp_pgoff; int do_color_align; - struct vm_unmapped_area_info info; + struct vm_unmapped_area_info info = { + .length = len + }; if (unlikely(len > TASK_SIZE)) return -ENOMEM; @@ -139,7 +141,6 @@ static unsigned long arch_get_unmapped_area_common(struct file *filp, return addr; } - info.length = len; info.align_mask = do_color_align ? (PAGE_MASK & (SHM_COLOUR - 1)) : 0; info.align_offset = shared_align_offset(filp_pgoff, pgoff); @@ -160,7 +161,6 @@ static unsigned long arch_get_unmapped_area_common(struct file *filp, */ } - info.flags = 0; info.low_limit = mm->mmap_base; info.high_limit = mmap_upper_limit(NULL); return vm_unmapped_area(&info); -- 2.34.1