From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED63EC54E5D for ; Wed, 13 Mar 2024 03:18:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 705928E0034; Tue, 12 Mar 2024 23:18:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B5EC8E0011; Tue, 12 Mar 2024 23:18:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 555E28E0034; Tue, 12 Mar 2024 23:18:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 434848E0011 for ; Tue, 12 Mar 2024 23:18:36 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D3C1C121110 for ; Wed, 13 Mar 2024 03:18:35 +0000 (UTC) X-FDA: 81890558190.09.700DA3F Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf21.hostedemail.com (Postfix) with ESMTP id 389771C0008 for ; Wed, 13 Mar 2024 03:18:33 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=cMcPk2Dr; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf21.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.174 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710299913; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ErBpDoChwJS3Dz9w/fXRIf25+ofQNHhqhOBTpwuSEJ8=; b=OaTuG7Sb1nLEuBg3CdR/Io3tGUHLetnKMapAtL9WNd3GQE4NtFqtSd1nqxHMADSWIHRLKV uhkriwBiYSiXbyUVnx+wTnREwadv6okxl4/px/jAsE+Wrc3rgdbs0CblujvjvpyHjC67HV sG65k1ouYQj95Qj21U618XGo42G/x74= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=cMcPk2Dr; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf21.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.174 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710299913; a=rsa-sha256; cv=none; b=eIFvb6PMHik6Y/jNoM6KVuhZ+hw0MTTvQ5tqi52R0MDzNMzKKp7BS7oOzUuMPCqW8oVrDT 4k6Q+qHA/kGWq1F4eAhZjzXcWLe557kxpCH+enX8zEKSvljkA/Sc91RVoUVyCx314/TrXA zPPp5gLQ6I0ckXbTM0DIT1bhW92a1is= Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-6e6adf257fdso1067765b3a.0 for ; Tue, 12 Mar 2024 20:18:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1710299912; x=1710904712; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ErBpDoChwJS3Dz9w/fXRIf25+ofQNHhqhOBTpwuSEJ8=; b=cMcPk2DrN1Zz3mQIRkJTEek4UeJN4jp25ajso8tUIdVm6VEt9QIUR0cbS0I6mZuB+/ PofAs9M7iPsLBuJJyVxtRqe5ibr+C4BTVRWrlNMaDZRay6z2156f7JkvENZD6jojEIOT BhqaRuH8IqeSLU4E0ZGjZ3LH7jkAnKgvpSRZA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710299912; x=1710904712; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ErBpDoChwJS3Dz9w/fXRIf25+ofQNHhqhOBTpwuSEJ8=; b=iBUpdkAJhswF8BE9rS4EW4c6n32bUiO+FKDc7KWkzc8QKVX5KmYgR0qhkcw+p9Dts3 E8fXR/zNaZYqh3JBN445YfuBgLVkXrQfsLtXTRCsMVruV3O7ytonpFNiAf3tbZdlcyCg QYbnqWnOZbV6TJhPsdIBvMWRkz2BecqZ9GnGjoIbblA9mqOXtgz35JeyGiuLPjxnCjw0 pZKk/+wMDpbC02gTi/RGyAjglmN4VL4Z68wUjQGY/fn6YT7/OXxHtfyA/lkUoINBbLpd +rukV2J24gcgxn4f5EtLqp0m0j4WqLsrdpsXLaHPTgPMIJtfXPMV/+B6GzmeHv/M6Fy0 moPw== X-Forwarded-Encrypted: i=1; AJvYcCVCLVvDjQEHNKKEzZJbC9GAE0gxon2XwzMT7a7WeEFRgMaHZQecG6SuyIh8yBKvFfaDikGIiP3+AOzTAJHHfz5/Zmc= X-Gm-Message-State: AOJu0YymqBx6ahc5etbN5hw1rmfxspqQPK2vVyBBxMnSneqb6XzmxSwY AN0DADP/kOgZwx1RHTFyFDx1wxvV4YDlTCeQYPWMR0F9L852Z6Pu0TkgO+D8lw== X-Google-Smtp-Source: AGHT+IFroIThZzohrORMRyBf4q2SfGniRe6Qp1geTDUSL9THSEZPoi4A4hryzimt0s4DNs3AfM3qQw== X-Received: by 2002:a05:6a00:181d:b0:6e5:d3b9:2d06 with SMTP id y29-20020a056a00181d00b006e5d3b92d06mr1621988pfa.21.1710299912048; Tue, 12 Mar 2024 20:18:32 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id c1-20020aa78c01000000b006e697bd5285sm3892427pfd.203.2024.03.12.20.18.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 20:18:31 -0700 (PDT) Date: Tue, 12 Mar 2024 20:18:31 -0700 From: Kees Cook To: Rick Edgecombe Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, bp@alien8.de, broonie@kernel.org, dave.hansen@linux.intel.com, debug@rivosinc.com, hpa@zytor.com, kirill.shutemov@linux.intel.com, luto@kernel.org, mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de, x86@kernel.org, christophe.leroy@csgroup.eu, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v3 08/12] treewide: Use initializer for struct vm_unmapped_area_info Message-ID: <202403122018.DCCE1E000@keescook> References: <20240312222843.2505560-1-rick.p.edgecombe@intel.com> <20240312222843.2505560-9-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240312222843.2505560-9-rick.p.edgecombe@intel.com> X-Rspamd-Queue-Id: 389771C0008 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 6grcanebswkton693gob6apy7m9wftkh X-HE-Tag: 1710299913-950438 X-HE-Meta: U2FsdGVkX19SObQ/svPWXAyW7c4P5tQIqfXEmImuOd/nUrIlNXSVZVaeBACzx80dsHvrtodEiFX4L/Hyj0faRZ69oAufwBdAuyFiHlDDko/T/a0ZGSYZ18lZGpamlc7Uzjf+LK9gNEECR8NA9TRLzPThnVikFCxnYh79i0EbERH4fUgf+Jydg5q9Zsg/HS/TDLhaetpb6n8MCFTro9yICGibvGVzbV9VygatbvdxwaCB8StBiWSM2gxnInAtfhsn3n5yZ8GDmEJs2dRF7JhlMx5xJdmCuoDHfsSsEyoSk/Tif3h52nTndLDkV7Ncz7jHEYxSArnGAXmcse5Xw2xF1NT/gObyn2xR4K4ef6XKcpc4ojfTQopkNe6HOUVXKLDXOFB0c0feXWgC80T+MD4WqHb+gtDoLuPKP4bSDApSmWNg6Z5s72BV51M1gqh5R89DgbI6Si9WR/kufWcZTbYe+VRhe7Wtiy2qtPsahQt1EMx3wdM8jiiGj7DvTHyY3hUSd/DNYRQ+poYS/l0PpMJ4PsgP/rtoK3nPBYF1COXcSRC2AWkjodKNr/Gnl5O8MNu54InLsW3E91b+Row50xs7LAEgq3WkKse1yQEN14NZaLBEz20yF5oe+KNoreU6i/93jeZELPhLhQkrDYJkjYIgMpE+AaS5ACifCkF6RiJwY9RmlAN6ixwyeom7yYX/PJM1+NYV83qVKICQ8MoyZTIIR64YK4GeHObY+H/BlBRyNmpNQxHkirC61maYGhO63+/IYT1NMJ8wNLrirlS331mfws/4u5OXE8/dM1jRsDPhOiGxh3uU0DFACORVf9qk/cXasEj7TBYDM37D3QfqCe/TH7kuyErhw6CpNb8vozCbEa/KIYRmzIS6Gs01YqUwLLzAYDTIW2GsUU6Hhnk1bWk7jzCRMc6Ij5SMc/gychd5yyZGqWngHEqf5WPLskcPsiH7hscEMo2CYAbnaXtWrxq +g2Ix9+G DJ22Km1SqZmx3gbsxt/7vtE7Fi4HwtSlN/8PnRFgsdWTBg3tFdLrqmKLvLRJFMiBVX5FDQeW/FsbZXRL7QYXgiVT+COoEIlEia3Ewr2yFajuY1PsncfzDrjXA6sdESZdtT9tLbRbZh+bsozIfhCMnoPNMZa7w2MFJUFEOSwS9uHA5LDQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000026, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 12, 2024 at 03:28:39PM -0700, Rick Edgecombe wrote: > So to be reduce the chance of bugs via uninitialized fields, perform a > tree wide change using the consensus for the best general way to do this > change. Use C99 static initializing to zero the struct and remove and > statements that simply set members to zero. > > Signed-off-by: Rick Edgecombe Thanks! This looks to do exactly what it describes. :) Reviewed-by: Kees Cook -- Kees Cook