From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA104C54E5D for ; Tue, 12 Mar 2024 19:17:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46C578E0007; Tue, 12 Mar 2024 15:17:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 41C4E8D0057; Tue, 12 Mar 2024 15:17:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E3B28E0007; Tue, 12 Mar 2024 15:17:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1FAD08D0057 for ; Tue, 12 Mar 2024 15:17:28 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D0460A09CE for ; Tue, 12 Mar 2024 19:17:27 +0000 (UTC) X-FDA: 81889345734.27.458ADD9 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) by imf28.hostedemail.com (Postfix) with ESMTP id B8758C001A for ; Tue, 12 Mar 2024 19:17:25 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=y2G32Rgc; spf=pass (imf28.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.179 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710271046; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3E+KvORFMKvDm1+B07pZtngBNS1kRcXmmHOQGV6v/ns=; b=nnMZDfGm8n+G93VkoIvy+zoHxXZENvjvf0v575APxB4icMZNIqEO4IA31focQ65XFq0ZyC NmOpCHYHOK9pIzjdr01KRYQ0+9JFPaP16PIy7Y0wB2Gv+48fB9I6UOusIw1nSZVaz0Cn7s EEBXxWPFQ3WtHUki/oUrYTgLHI09pWE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710271046; a=rsa-sha256; cv=none; b=OPW7iNOOWPBgscqI+0K+k2s9JsCTDpOvXezQAxvl2K83xsM1WXu4ElfoUn69Abw0mvfe4x 7VUb63d3UW+796SavZ0REG+JlaS3v6GQ84t8RSve9m/eFceLcoOuYwOYkLYpPqpktn5qK6 41ttMMVMNwycljgMkmK5YtiGc9r8PQI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=y2G32Rgc; spf=pass (imf28.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.179 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-78873ff0895so100817085a.1 for ; Tue, 12 Mar 2024 12:17:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1710271045; x=1710875845; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3E+KvORFMKvDm1+B07pZtngBNS1kRcXmmHOQGV6v/ns=; b=y2G32RgcNpoHvOzqqAPXzHQhGENUW4O33BzyreLUFnRdPu6XYxlsVH0FsbLlVnIB38 iKTDZhCJI4pqcTqzCi9NMnTlxoPq30LhtQhlLuspQVxsbMo2eP/+rVHZhm/SStJdSz+Y EirIeu5F7P39WGqwsCrE02NReFdP5xy3gAd/RAIvQBRgiKg3Z9wM6rad7Y4/Jh4cv+Ql HDapFKJaAydCSAH8+5OfgNYdJwZB9LriTF7m/XTvvg22S1ELSqVo1TxSBXI3+pGSyrX4 Gky3whO4Xu+a+8JkvD5vMPmS1ARGYIsch8T94VFeOgRilK1GijHTxtmxINX4kQKr/6d4 CqJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710271045; x=1710875845; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3E+KvORFMKvDm1+B07pZtngBNS1kRcXmmHOQGV6v/ns=; b=tBjNwTcwrswEOlk6K9CTQOX2ak+1yJD1DOhTkeWZjJuaJ0bXLR0rAndqCJ7PTrfCS2 jRtb3nsY8NqR4pjZR5cKPD6ypoe27Cn8zj5B21za/dxOlSoadsoRtza5IaHTVYFXdS17 DqAue+bhTjOHzD0Vl7SyxSi5ZI8EEVbLBiL8Z5druhbuTeLZxRDgqv60ixjC4lfXbSc8 G/dqmPGKLXUKyd9TmTjouNpm6MujHmTg7uSc+8Tj+hDTivwuyHIvkqym+vMdRxf7PSQ/ yC/c3MYqxmoh9McQA16vWcI998EpddJpyEFij0w24O+SaoEzo0sWe6bGQBH68zcyD/ME 1tJw== X-Forwarded-Encrypted: i=1; AJvYcCUTk6D7Jze8opSF48EXML6BCODuUMGRA7C0gkrLENBPn/DNTo5PXypLV0cqPdRQ6AneuJNlMc8Ul873iMl751cGLeI= X-Gm-Message-State: AOJu0YwvyVjL4vLZJ3rFz/zdGEcioA89vFqSL6ZfdkKT9JV9JMJNuHvo 1YiIcpFi1xleBbSDn/8A0jNf3WBSReHDGUQfjJO5Ad1GHvsE3WnBSCJ3dtCbFA8= X-Google-Smtp-Source: AGHT+IENwreDIWA7OOCMBwF+IoqLwS54xXW8Y4tliviDGJXugYUc3z/69YEWyHnVBSzsnrdNhej3sQ== X-Received: by 2002:a05:620a:2906:b0:789:4844:a229 with SMTP id m6-20020a05620a290600b007894844a229mr2679493qkp.8.1710271044743; Tue, 12 Mar 2024 12:17:24 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-da5e-d3ff-fee7-26e7.res6.spectrum.com. [2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id vw23-20020a05620a565700b0078830d4ef5bsm3935321qkn.107.2024.03.12.12.17.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 12:17:24 -0700 (PDT) Date: Tue, 12 Mar 2024 15:17:23 -0400 From: Johannes Weiner To: Yosry Ahmed Cc: Andrew Morton , Nhat Pham , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: zswap: remove unnecessary check in zswap_find_zpool() Message-ID: <20240312191723.GA65481@cmpxchg.org> References: <20240311235210.2937484-1-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240311235210.2937484-1-yosryahmed@google.com> X-Stat-Signature: 5mjw5ucrcsq5z4ag5cjogkkxphyrii4s X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B8758C001A X-Rspam-User: X-HE-Tag: 1710271045-295359 X-HE-Meta: U2FsdGVkX1/92mof7VbFSQc5HK8Zk4GzAtctgUFqiu21ECPz97DowYJUZ2b0ju8TWYR7nZOd2wSTLHKqujQTS25ecknqA4XhcqT3eKOxv/b5gOkehTH3I3QMMI7AA9MD6POWR13+Fqz5oi8NI45ArD1/ybM7bw8G7NRePjBGgLtryTGHvmo2jKHzvcxqAsUSjyMu43PBG/CxLj38cVHRUdGJ3SO182i7ouRe8N2R8Ley42R6E3lr1EwdkWLUV6oY/6UrZEfhxivIG5ejffe6XBoeUSDIp3NcDs4+DfoaXAJCCUQdKRNd7fEXbr8lpCi6lbM/+gVnsPNFJ3QBuueFr0MG6o1Ft0LbaYDj1xef7H5Vj5u9ZccOcNasvVeB6wQeoS1JRcIGOrHt0qNYjY5k/qy9HHHW7QuXxSQblScsBVuqlUbjMgjiz5E+U7W0G5hkUQKnxflLzhhodYc0B4XGkWQjQx5YHmsOyOc8mAgkXTHM7paOG37TW3kVRZmZqdd/EjIxs4J6fKYr9UhKdepUQWWwKRbqDftt8deQfdtx6I5BNsmkNhQS/vycpNYJ1RdqZgV8ESBgsGWwJN0YGCc1khTyAOfaXalW3XdCkrp4gvcelrNJg1XprHi9AnSRzGmuvTk00qyjVYxCSVPJ8MjaWMzpEGmcNVLveTn8/v/W9P+8NWnZhnT5vHU5nNm6gB+7JMR1qcEhguFoaDucsP0+09l32YP3NnHbNKT712L2DNSAqwZfb73VX2cwEqPa/kFmP1ssCFDtJKTlV5jFplGUAJAPb5Lf8a8BgYtAZyiSLswtAMkqh4FhND4t1B3J2uXdFrwhx1z//k9wJV4bM87ZIWlzM/7kq7MSKJ05nbnMVgnD42NCc3qH76Kzo9KJGcQb5WPqcFbVRET3l+s6KCAd0cDWA+V/rJpAbTz83DGtOgQmnNlIbIBy8HgtjtObwdDvhR4fZ5lUvYOziOAtclE SSSz56jN 2+/6+FjNsePvzdWv8/SAeCZIbUsycOSppU5Zhz7zT9jyjk1/DXcT8dlMP5bkpvVhpiIBpgBt23GrQKLgITJxcbD8Q0v/gxkDPtH7kJHJLSreo5BQVeXRVLpL16qtKuB1qkbQ4v02gis8ce0OhHBSTKUtRgGwa5cilYpryL/g35EYlFgnZ399mNFSzDVLG2x46/lPHhdvvSU/u9frY0NeNhiwyHx7WJtb2priTzhzkCpN88gaT6p9O4BWOuNhPBsJIWjxlLc+HOAfat3NYmPHldN3yl9oPNs4C6mOISpQid/La/MM6vAlSJIEmK4/aqmXl5na+GFwos6WfInCJkkGreCA63oBljYnBN4VA8Qvqf1BKcp9o+j8X3xSmIqV1YO6z7jMZBePDTfKTJnziuFA5l5FwmQgrO5ewvrQwSxCg9o10OXwCO3/Eb+tZ+/jM43qAjvRkxb6MEc4TuovLqWhc/vpgzPFVGZpkEcyjbA6SrfiIUrEX/AjpcGIs1YgZ+0xrMwkHbmjgHvCw2Bo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 11, 2024 at 11:52:10PM +0000, Yosry Ahmed wrote: > zswap_find_zpool() checks if ZSWAP_NR_ZPOOLS > 1, which is always true. > This is a remnant from a patch version that had ZSWAP_NR_ZPOOLS as a > config option and never made it upstream. Remove the unnecessary check. > > Signed-off-by: Yosry Ahmed Acked-by: Johannes Weiner