From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE48EC54E60 for ; Tue, 12 Mar 2024 12:07:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 546366B019B; Tue, 12 Mar 2024 08:07:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CF896B019D; Tue, 12 Mar 2024 08:07:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 322316B019C; Tue, 12 Mar 2024 08:07:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1CF756B0248 for ; Tue, 12 Mar 2024 08:07:04 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C6A921204FA for ; Tue, 12 Mar 2024 12:07:03 +0000 (UTC) X-FDA: 81888261126.09.829DDA9 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf14.hostedemail.com (Postfix) with ESMTP id 67B81100016 for ; Tue, 12 Mar 2024 12:07:01 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BlDW88C6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="a5Ox/Bbz"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BlDW88C6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="a5Ox/Bbz"; dmarc=none; spf=pass (imf14.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710245221; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WJfjWeNXVPT/qepjRfaCmAM72afs7cwXQz/2lur6DYY=; b=AK0IeBkVs4IOe87JW2ABcZ8RRcNmw9SEOYPZtWugN53S/OG0O6KKQn1S/4WzeSGNieS3r8 I+njqOKXPT6QZJltAa9p/ZDkD3rhxsa8zN225F8uo+c79WqlVB77YbZEj+r9hnpghoKhZX Hgsoalkt955vfRE/dAGsnjbJtowaOPg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BlDW88C6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="a5Ox/Bbz"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BlDW88C6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="a5Ox/Bbz"; dmarc=none; spf=pass (imf14.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710245221; a=rsa-sha256; cv=none; b=p9iXsNCTPH7o42H92+Gsxyq4yQ8K7lIlq5VHQUW0/rF3VPdkGibOYTlcPuGNBcEYoW36P6 Hvjxz/sga3HgE02X4E3v+C3RrcsBPorB1zo5wUpPTc3byCJxLma5SQZ/xlA7JdXfVh69Q4 2BKdl+VucYTagvg3KE9mz1VSe/6GBbk= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 602D73764C; Tue, 12 Mar 2024 12:06:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1710245219; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WJfjWeNXVPT/qepjRfaCmAM72afs7cwXQz/2lur6DYY=; b=BlDW88C6qDW8qPI/qYyjqlBqqSLuNnkovQpSqeHwBysb3v9cWTufR5lsAqU1AevnBVz65A Kek+OEtJyldQ+vbMju6DtoAv4uNM1YlqIIzPkrywRkkF1ULVUPCmnl0aWCIBb0VXO2ksMw tkrM9B2htN768A16b6mz5jsieoLHrlE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1710245219; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WJfjWeNXVPT/qepjRfaCmAM72afs7cwXQz/2lur6DYY=; b=a5Ox/BbzrR2BrYKPI19Ym7yP6y8MmBpiRq2brGEBZZqZprkD4SWnzBYLUix1ZBNMC2Thmw B94217bIe5ZIEUCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1710245219; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WJfjWeNXVPT/qepjRfaCmAM72afs7cwXQz/2lur6DYY=; b=BlDW88C6qDW8qPI/qYyjqlBqqSLuNnkovQpSqeHwBysb3v9cWTufR5lsAqU1AevnBVz65A Kek+OEtJyldQ+vbMju6DtoAv4uNM1YlqIIzPkrywRkkF1ULVUPCmnl0aWCIBb0VXO2ksMw tkrM9B2htN768A16b6mz5jsieoLHrlE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1710245219; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WJfjWeNXVPT/qepjRfaCmAM72afs7cwXQz/2lur6DYY=; b=a5Ox/BbzrR2BrYKPI19Ym7yP6y8MmBpiRq2brGEBZZqZprkD4SWnzBYLUix1ZBNMC2Thmw B94217bIe5ZIEUCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5357B1379A; Tue, 12 Mar 2024 12:06:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id dJ5UFGNF8GVzbQAAD6G6ig (envelope-from ); Tue, 12 Mar 2024 12:06:59 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 05BFDA07D9; Tue, 12 Mar 2024 13:06:58 +0100 (CET) Date: Tue, 12 Mar 2024 13:06:58 +0100 From: Jan Kara To: Mateusz Guzik Cc: Jan Kara , syzbot , almaz.alexandrovich@paragon-software.com, anton@tuxera.com, axboe@kernel.dk, brauner@kernel.org, ebiederm@xmission.com, keescook@chromium.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, syzkaller-bugs@googlegroups.com, tytso@mit.edu, viro@zeniv.linux.org.uk, willy@infradead.org Subject: Re: [syzbot] [ntfs3?] WARNING in do_open_execat Message-ID: <20240312120658.os72hvnk5jedwbaw@quack3> References: <000000000000c74d44060334d476@google.com> <000000000000f67b790613665d7a@google.com> <20240311184800.d7nuzahhz36rlxpg@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spamd-Bar: / X-Rspamd-Queue-Id: 67B81100016 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: rr9ramra6uzpbb9sgn6b4ufzkqc1359e X-HE-Tag: 1710245221-755994 X-HE-Meta: U2FsdGVkX1+UuPbzzIrUP27IMYMHadTWSvf7xUq8wH0AqS1XNg/wCIOs20LnyMte4WtyLgqNSNcjDHpULSiV/OmMz0vRwkDFTS9kLFt5Pwo1b+kYPwPvHbIugWSRapO1BsRoBn7vCqte3hZ32shDsgqIfoHjY3fKpCe6W/VloI0ZAxzoXe8cnBmonJXQHRRblQuFulDfwgXeWS02XOJb9tvTf0saxp1y0eja/IrBHWO8fCJJH6LDdRt0y8fzqTsP4uoJFdXOQjn6twxwGAP1ETamtZQD2+fgBw66/qDAkzQkNIsEUJEliTO82K+8QkUT7/kKRg2GngAbxmX9+7XzCNIaujMGcVdLRiwaphrVKnKpHN/sfdF9b0SGYMySgvy+7EnIBFF/X03+Ua/qX3O9865k8MZ3PFglCmcyu87Ukt1IMrqLaRoLzGOUrEoreyLZA/oZqh3i8QbpWUvyEm076lJ1cf2mW7LFugAbcy2xp2wScjFjPyZGR990O5p+AM5vYjctoBkfBc1TYN4ANt8ks/Ys98vItFmeOIbVUAHrMbvICCo/Fy7z6bBcBcWFmxHV2PweKjnBECwgffoXpgYSF8m8fPVpewSvlBf/3aU3/4RalGV8D6Mp8hoRZS1LT/eYPogyCylQOoDxDiDcwf2fBMyG5fGmozIfT0zIDYQZt9n5KvLbDEZhONOVEm/o/8VfhyNFTcjM82a4iBKWpfKQZqTCbD157hW6boA0p/tDs+LPV9jVtBIIXJ3LNP2PyBm3pazXVFFLsktE4hulcFGP8YIR7B7w9PZsAlSSyIu3S8sHiGd0mZdg40n3snfZVdQ1BgnMUMPAcgl/6fcUt5fhi1ChJEy13RRL41MTOyXDAd4xBSODfgRjbYMMuPAYW0b3iOZWvp/EkjvzPDjmfr8ZU+uT8YVCmcrKUUkC6ycO7MBTWeFf5JljRBvmbNnvGz/MVLa/7EzBu/F/CzJj0V4 TWUXLpDK wJkRfCaSRGEbpW86nUfcBw9xRrUeGP/tEHZ2RWA6ZjZBuj0koc0+ILLhjJYcKH2izWzJ5n3Zq4ETDH6E55vJEiVaRZ9OSEGsRhBJ5OZ+KHghAX+Do+PmkXGbTA18VgKRifbjCr9HzfKP03wRXlLtJ/LH1UpzUAHLctUhL+RRWvCwARek+h3CFizFOKdkAdaBPhx8HS/PTUbby/hZfdDEHKw/tHF881wfEHngT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 11-03-24 20:01:14, Mateusz Guzik wrote: > On 3/11/24, Jan Kara wrote: > > On Mon 11-03-24 11:04:04, syzbot wrote: > >> syzbot suspects this issue was fixed by commit: > >> > >> commit 6f861765464f43a71462d52026fbddfc858239a5 > >> Author: Jan Kara > >> Date: Wed Nov 1 17:43:10 2023 +0000 > >> > >> fs: Block writes to mounted block devices > >> > >> bisection log: > >> https://syzkaller.appspot.com/x/bisect.txt?x=17e3f58e180000 > >> start commit: eb3479bc23fa Merge tag 'kbuild-fixes-v6.7' of > >> git://git.ke.. > >> git tree: upstream > >> kernel config: > >> https://syzkaller.appspot.com/x/.config?x=bdf178b2f20f99b0 > >> dashboard link: > >> https://syzkaller.appspot.com/bug?extid=6ec38f7a8db3b3fb1002 > >> syz repro: > >> https://syzkaller.appspot.com/x/repro.syz?x=15073fd4e80000 > >> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17b20b8f680000 > >> > >> If the result looks correct, please mark the issue as fixed by replying > >> with: > > > > #syz fix: fs: Block writes to mounted block devices > > > > I don't think that's correct. > > The bug is ntfs instantiating an inode with bogus type (based on an > intentionally corrupted filesystem), violating the api contract with > vfs, which in turn results in the warning way later. > > It may be someone sorted out ntfs doing this in the meantime, I have > not checked. > > With this in mind I don't believe your patch fixed it, at best it > happened to neuter the reproducer. OK, I didn't dig deep into the bug. I've just seen there are no working reproducers and given this is ntfs3 which doesn't really have great maintenance effort put into it, I've opted for closing the bug. If there's a way to tickle the bug without writing to mounted block device, syzbot should eventually find it and create a new issue... But if you want to look into this feel free to :) Thanks for sharing the info. Honza -- Jan Kara SUSE Labs, CR