From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69BADC5475B for ; Tue, 12 Mar 2024 00:59:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A852B6B016F; Mon, 11 Mar 2024 20:59:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A349E6B0170; Mon, 11 Mar 2024 20:59:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FC876B0171; Mon, 11 Mar 2024 20:59:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7AE5B6B016F for ; Mon, 11 Mar 2024 20:59:37 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4FAF91C0CB7 for ; Tue, 12 Mar 2024 00:59:37 +0000 (UTC) X-FDA: 81886579194.20.57E4BDE Received: from sgoci-sdnproxy-4.icoremail.net (sgoci-sdnproxy-4.icoremail.net [129.150.39.64]) by imf18.hostedemail.com (Postfix) with ESMTP id DC2BD1C0002 for ; Tue, 12 Mar 2024 00:59:31 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of duoming@zju.edu.cn designates 129.150.39.64 as permitted sender) smtp.mailfrom=duoming@zju.edu.cn; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710205174; a=rsa-sha256; cv=none; b=bFWbyagM9NjRcNovo0rYLfQtUYOqq4gUlldlzmpuOyAKZn/1XJWiykestnS3bk9reTmp8l ie/iGiTSYEpuePcYAqsYgjKo6JsG45186okz4EpQpgzqP2ROclNk9LyhHL2v9j5iZ+2wK1 GVe15gWRxVT7McXZat+EHVtYSwyBEr4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of duoming@zju.edu.cn designates 129.150.39.64 as permitted sender) smtp.mailfrom=duoming@zju.edu.cn; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710205174; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=Ny6mtLebs8WALtuAPWLPEJ4Z3ykmNbP/FoTQppHRcuo=; b=WVKVelnwRvgilw15WfT59c88DtbOKkgVN8WcZgC08HUcKjwyT7nSSlwItaCZXjV193ox67 sN8zzlOGsn+jWiD2UigHX9aG89oGxK0xLFccKuW0D2cqVYgEvcBOcQ8ovN+Sm2dkOxdG9r uhao7tcNfv44Mk5FqesMBg/Uhg0UsrY= Received: from ubuntu.localdomain (unknown [218.12.16.65]) by mail-app2 (Coremail) with SMTP id by_KCgBHjI7cqO9l9WJWAA--.23030S2; Tue, 12 Mar 2024 08:59:20 +0800 (CST) From: Duoming Zhou To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, jglisse@redhat.com, akpm@linux-foundation.org, Duoming Zhou Subject: [PATCH] lib/test_hmm.c: handle src_pfns and dst_pfns allocation failure Date: Tue, 12 Mar 2024 08:59:05 +0800 Message-Id: <20240312005905.9939-1-duoming@zju.edu.cn> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID:by_KCgBHjI7cqO9l9WJWAA--.23030S2 X-Coremail-Antispam: 1UD129KBjvJXoW7uw4xJw1fur17WFWkCw1kGrg_yoW8AF4rpF W8Ga4YyryUA34j9FyUXF10kr42kan8Aa1akrsFv3s3uFs8JFyxJ3yfAryrWF10v397AFs2 vFW5ta4DXF1UJw7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkl14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4U JVW0owA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCY1x0262kKe7AKxVWU AVWUtwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14 v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkG c2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4U MIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7VUjuHq7UUUU U== X-CM-SenderInfo: qssqjiasttq6lmxovvfxof0/1tbiAwMSAWXvDBcFrQAGss X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: DC2BD1C0002 X-Stat-Signature: xxukhd7is3x4mayfcp5xkwu4sq1ofb9j X-HE-Tag: 1710205171-996686 X-HE-Meta: U2FsdGVkX1++JyouCjEmFyAdJ2eTECu+C7rmv0ezTUo+h62gL2PcG9nhkWnRhXdr87J62pb6O7cp9ynR5Z3xJucEYtWj5RGESRfRNEysq0mpRE79tcMfMElbbf6c3XF32rWHd9/AIo0hR0laOn0VTTw8nplJZ3gyNg/fqT/t7ybrPLtSEbSBpzbnnJpGKQpCkzwaYfO4yYyg5n+tMhSrD8+083teGKPETJFzEoOGTjaUVHprr5mROMeH3kIqRbqVm5GWWn60sn+ZlEcW20MG43f2vK1Dml4KQmJdFqvwmkD4hA+ltt88FAhAc1zjRIJLQLYeMbYUIisrboPkBrvTR8gQMe8WctWWR+7Uu/nkxczgfTaD8uVmnD+qMYCDsDk9hCOihOcPQ+snF+SqsbpJWJWOzz85HgbCFrfNJ1W58lnqkgrvgTt+6X2ShNF5A0YuEMcxNb//eCoys0rgGDPrfBmr7zDp3+9/zxsyia7pFo6M8Hk3yjO9EkCxdhhxdi4OxViBF2nndxbIqOx6Do17aCbDUjWJloM0EajcBvZjBmJ65sTIi41AHeqlWLtnyZI84TKsTZ6fghi+p8ut0MCgadjpL1SQ5yFyq1TdTiko4Ew2rmJ4HKb8atefnPNexdCbNJHXYByrY/HFz4FlPNP1RxmANRCgL4gBBHwjPDqSMutEZniJFIdn6wK6M++ftX6dHaPgs88JSLuRmupO5bstDFkA4crWgzkqDl3MnQXaZAZvMFKwKjL72ZycRj9IyGkxcdZmWbVd4r70ecUgGVOr3FQZf9hx5wvqBHVgj0LGR5ievFDQFQaMa6bVA0V9fWSdbVvKicYrb4KoSPe9e5208wUu5hn1tScsGyZgaYGwNfAFN7r3ZBfvALgOAxDTNFZ4GQ6HgLneG/PNM/S8Is3doHaRCCdzV85u9Y3fSHE9mjcCVW3FgFKJ3XZMnepWLygeBOXWbNceJRBunmcmxqs qQmN1o1k l07ketnl08wL1TwxCQrKIuNoVOGzTr+Dp7ypHsvPW7PuNRr4fvH/qhuxuzdfuQ5E+iDAEzhCspWbtqH2GsnvFFqUxv3pVZQEBORAJqGGbQfUyhbC59bqhSMQNYTzeyKtCDz8zemAKY0+cMdetKElk56GGW3ZC+S3kpYV3LasZ5m571d5r2CJ8Vus8p4aUDQKwciGT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The kcalloc() in dmirror_device_evict_chunk() will return null if the physical memory has run out. As a result, if src_pfns or dst_pfns is dereferenced, the null pointer dereference bug will happen. Moreover, the device is going away. If the kcalloc() fails, the pages mapping a chunk could not be evicted. So add a __GFP_NOFAIL flag in kcalloc(). Finally, as there is no need to have physically contiguous memory, Switch kcalloc() to kvcalloc() in order to avoid failing allocations. Fixes: b2ef9f5a5cb3 ("mm/hmm/test: add selftest driver for HMM") Signed-off-by: Duoming Zhou --- lib/test_hmm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/test_hmm.c b/lib/test_hmm.c index 717dcb83012..b823ba7cb6a 100644 --- a/lib/test_hmm.c +++ b/lib/test_hmm.c @@ -1226,8 +1226,8 @@ static void dmirror_device_evict_chunk(struct dmirror_chunk *chunk) unsigned long *src_pfns; unsigned long *dst_pfns; - src_pfns = kcalloc(npages, sizeof(*src_pfns), GFP_KERNEL); - dst_pfns = kcalloc(npages, sizeof(*dst_pfns), GFP_KERNEL); + src_pfns = kvcalloc(npages, sizeof(*src_pfns), GFP_KERNEL | __GFP_NOFAIL); + dst_pfns = kvcalloc(npages, sizeof(*dst_pfns), GFP_KERNEL | __GFP_NOFAIL); migrate_device_range(src_pfns, start_pfn, npages); for (i = 0; i < npages; i++) { @@ -1250,8 +1250,8 @@ static void dmirror_device_evict_chunk(struct dmirror_chunk *chunk) } migrate_device_pages(src_pfns, dst_pfns, npages); migrate_device_finalize(src_pfns, dst_pfns, npages); - kfree(src_pfns); - kfree(dst_pfns); + kvfree(src_pfns); + kvfree(dst_pfns); } /* Removes free pages from the free list so they can't be re-allocated */ -- 2.17.1