From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7F3CC54E58 for ; Mon, 11 Mar 2024 17:19:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F1E56B00B7; Mon, 11 Mar 2024 13:19:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A1436B00BB; Mon, 11 Mar 2024 13:19:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F4436B00BD; Mon, 11 Mar 2024 13:19:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0A4886B00B7 for ; Mon, 11 Mar 2024 13:19:57 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A322E14089A for ; Mon, 11 Mar 2024 17:19:56 +0000 (UTC) X-FDA: 81885420792.13.D711395 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by imf28.hostedemail.com (Postfix) with ESMTP id 1FEB8C0022 for ; Mon, 11 Mar 2024 17:19:53 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=LoNd7a1L; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf28.hostedemail.com: domain of quic_eberman@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_eberman@quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710177594; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WWyuMjMTY1FvQzmp5VylyD/JLzCDxHXDW87OYD0aoaA=; b=8mfsau3xGp3ZNLy+xnHRHsYcz1fpjbnjjwZdCxk+6zEy2tfIW2cwlbzIL/Zp1NeGF+FcZq A412ERkJrW4MyKoyiMDZDns5GqSmtufqtSJu0eNPV0ozlITUydKRXXoln0g5LaH7LJGHjn oQtQuy2801DN4JHMlItomUXgtZfHqsU= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=LoNd7a1L; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf28.hostedemail.com: domain of quic_eberman@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_eberman@quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710177594; a=rsa-sha256; cv=none; b=vN0CVKSGENyzLSzu0q6JZsdX0XkxwfdFoWskR++QRWsaghRkx6k+4PA+irtw1cqEZ7KYYE 30scaHctfS5X4BAEVExTKLIw8vmNE4XNxBtTjGTpKQfFm/ad2XS2ypReqfZOJaOWv/bpLd cq7TrtP3EG0BN8ogpz/MK+d6Bq0w7FA= Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 42B7wlVJ015645; Mon, 11 Mar 2024 17:19:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=qcppdkim1; bh=WWyuMjMTY1FvQzmp5Vyly D/JLzCDxHXDW87OYD0aoaA=; b=LoNd7a1LEfO5YPrzFNm3OGkbXryXJnqKK41ph YeIxm/3KwN772o8oyPTkPH2Fb48/BiJx7/ueDPHYtVK3IEd3GFurQRL6OuW4tj4m Ue3gkuS8Rh1niug38eQ8iC72+7qdwlW4Ndc4pAYUdfIedj5ADzKgG5uihULj7Yk5 KQd3ZVUTUZfaf7YfwyX2p9x9cMoWNYM9QM4a7GV+UpkoMvirpGp0rKuGZi/SDaL0 3B590DbveV5pQLEEryX2L05e1RYBZH+ab6WJykOznStL6TCSupfbdTHi/NyQYWnQ 2pPqOBVjCPDYy85wEgkU0KcqAt1XDT0EQWAHqf3JFEmLkceBg== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3wsv209rn5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Mar 2024 17:19:41 +0000 (GMT) Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 42BHJeuC012055 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Mar 2024 17:19:40 GMT Received: from hu-eberman-lv.qualcomm.com (10.49.16.6) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Mon, 11 Mar 2024 10:19:39 -0700 Date: Mon, 11 Mar 2024 10:19:39 -0700 From: Elliot Berman To: Srivatsa Vaddagiri CC: Alex Elder , Srinivas Kandagatla , Murali Nalajal , Trilok Soni , Carl van Schaik , Philip Derrin , Prakruthi Deepak Heragu , Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , Konrad Dybcio , Bjorn Andersson , Dmitry Baryshkov , "Fuad Tabba" , Sean Christopherson , "Andrew Morton" , , , , , , Subject: Re: Re: [PATCH v17 11/35] virt: gunyah: Translate gh_rm_hyp_resource into gunyah_resource Message-ID: <20240311101433139-0700.eberman@hu-eberman-lv.qualcomm.com> Mail-Followup-To: Srivatsa Vaddagiri , Alex Elder , Srinivas Kandagatla , Murali Nalajal , Trilok Soni , Carl van Schaik , Philip Derrin , Prakruthi Deepak Heragu , Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , Konrad Dybcio , Bjorn Andersson , Dmitry Baryshkov , Fuad Tabba , Sean Christopherson , Andrew Morton , linux-arm-msm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org References: <20240222-gunyah-v17-0-1e9da6763d38@quicinc.com> <20240222-gunyah-v17-11-1e9da6763d38@quicinc.com> <20240311053905.GN440762@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240311053905.GN440762@quicinc.com> X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01c.na.qualcomm.com (10.47.97.35) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: JI12OXthCOMKMmTkBgAekRJxQYN4-_Nj X-Proofpoint-ORIG-GUID: JI12OXthCOMKMmTkBgAekRJxQYN4-_Nj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-11_10,2024-03-11_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0 impostorscore=0 bulkscore=0 mlxlogscore=695 spamscore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2402120000 definitions=main-2403110131 X-Rspamd-Queue-Id: 1FEB8C0022 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 7qt94ekc3sg9u3wjc837hkk46f4dd4ad X-HE-Tag: 1710177593-404573 X-HE-Meta: U2FsdGVkX19I8CfNT1u7nJfRyQd5IseCKQsjwkvSmV6XkJGwAa786Nv63M6mEQrkzWNT3FJWvnfsU8sxZJ7/Nz9sfUy2ABdpFoQJkque15URqlHPVDscKXknbF3HVHQeu7wofKzyh0fzqsi5RC0pp3TyOqkHeZXTaXKFxiz/D/8BnT347xgVXfQ26UpQXH381c73/Kwndnr3i6aj/uy0xwslJ2CseXykCuiHqyRsFeHG/7ZRVUsh1pPZwYnFIwVhcMzaaK27r7sELde0iW8KXnF+b/jayYiZ7Q0VJeBZwDV6dxSPgAxxB/8JhXJJLXKZIe/fQJidka9EGTcDfWGs7piHnUweY0M1AyarP9CZETan4anHcjyijxA3X4gVFocp5cScYGAFKz0rtVp62r/I5GCGNisDdO20XSJ0sg5AbEn8DrRdGgdSxRGFh0RuNasyiWEBEubT0NcT7eXx2XD2DyqI9EmzhI2P5CikNR9HWPBU1ndPCSfJwa57RLMHKZmT5ctqs0QdP9ODDB5RxpEnXFBmmXmNP0Y7kffiRG2zkvTi2+CFW7mz92GCGuUhIIgHr252jmIvev71Oxn8FL4x9Pb/hhYw62AEdE51+yLk60J2NV0nKcz+1J9o7FVXKJjnnrT4Ik4oeZWEcN7BKHAY40pVc10kbKQyGogOClYrK+dEEOMfNFq/j/APSnHVBC8CvnjMPkenKDdnOZJLeq7p2qZNMJYx40HtNrIFHmS/YUq+4Usco3pPka/bNEuEZHbKNdzIKh6p9nlNPst1zawWc6EsNwuQQ/Sx8uUNi+fzZOCFFn5DylNO3VxsaBbOZNNmqxv0VPPmIzuZ4pHGplsZF5HFXhYMjZPwU59pUvP1eRPXfiYBPQKP3Bhn35fxUlb4oIXIHDPQdE7zGXPibUoaJbyL7Ttgzk6ekqNOT0dva4oExLjjHk5ZXo9Ialrd3SzmEIEpN6lfL4ndmi15/jJ WuED+wPb 0cYS+TJ1D9H9GAvD+L4xjGQS2sKAsBF4T9dL2ZjDXFTp+eDjcp28rfQlK2UiE2luVMvJviBHomKvWROqhQK1ecEnoQZKKCPkJkYV7tLYhJ8vQCfrDjW0EpgHSJT6oPv5ds19kLMvsaW+uBdqR3ff9P/r7P0cfwkvtsGYcHu7Fbzt9l4BQ8VqIIEkbG4mGHiosGj+lZhGGM9CwRZ/CZDMALGchhmKhjvdDRgiI/+AxBIGe65jKdkJbV4OFpPHUQF2Rcqnp6ljeXP4u8LJ5+7GUwaIgOrmEXJpynAbrKb09Ce5eb65Ee8oy+2NdPy49hNLSMmIxeLRO3TzFAGemKDbaUD/5dlnG/usPdL+5yhWx6HbY4G2s9jBDoPgNx0LQxATwWb5ITphWuNFSpVe+5rEU3y096vHw4iH5LL9V X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 11, 2024 at 11:09:05AM +0530, Srivatsa Vaddagiri wrote: > * Elliot Berman [2024-02-22 15:16:34]: > > > When booting a Gunyah virtual machine, the host VM may gain capabilities > > to interact with resources for the guest virtual machine. Examples of > > such resources are vCPUs or message queues. To use those resources, we > > need to translate the RM response into a gunyah_resource structure which > > are useful to Linux drivers. Presently, Linux drivers need only to know > > the type of resource, the capability ID, and an interrupt. > > > > On ARM64 systems, the interrupt reported by Gunyah is the GIC interrupt > > ID number and always a SPI or extended SPI. > > > > Signed-off-by: Elliot Berman > > Minor nit below. LGTM otherwise > > Reviewed-by: Srivatsa Vaddagiri > > > +struct gunyah_resource * > > +gunyah_rm_alloc_resource(struct gunyah_rm *rm, > > + struct gunyah_rm_hyp_resource *hyp_resource) > > +{ > > + struct gunyah_resource *ghrsc; > > + int ret; > > + > > + ghrsc = kzalloc(sizeof(*ghrsc), GFP_KERNEL); > > + if (!ghrsc) > > + return NULL; > > + > > + ghrsc->type = hyp_resource->type; > > + ghrsc->capid = le64_to_cpu(hyp_resource->cap_id); > > + ghrsc->irq = IRQ_NOTCONNECTED; > > + ghrsc->rm_label = le32_to_cpu(hyp_resource->resource_label); > > + if (hyp_resource->virq) { > > + struct irq_fwspec fwspec; > > + > > + > > + fwspec.fwnode = rm->parent_fwnode; > > + ret = arch_gunyah_fill_irq_fwspec_params(le32_to_cpu(hyp_resource->virq), &fwspec); > > + if (ret) { > > + dev_err(rm->dev, > > + "Failed to translate interrupt for resource %d label: %d: %d\n", > > + ghrsc->type, ghrsc->rm_label, ret); > > Not bailing on error here appears wrong. Can you check? > Ah, yes. I'll return ghrsc here. I think it's better than returning NULL because user of resource might be able to cope without the interrupt and can let us get a more helpful kernel log messages because the higher level VM function will complain. > > + } > > + > > + ret = irq_create_fwspec_mapping(&fwspec); > > + if (ret < 0) { > > + dev_err(rm->dev, > > + "Failed to allocate interrupt for resource %d label: %d: %d\n", > > + ghrsc->type, ghrsc->rm_label, ret); > > + kfree(ghrsc); > > + return NULL; > > + } > > + ghrsc->irq = ret; > > + } > > + > > + return ghrsc; > > +}