From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A17BEC54798 for ; Sat, 9 Mar 2024 04:43:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2EE676B0075; Fri, 8 Mar 2024 23:43:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 277B36B0078; Fri, 8 Mar 2024 23:43:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 118D96B007B; Fri, 8 Mar 2024 23:43:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F150E6B0075 for ; Fri, 8 Mar 2024 23:43:00 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C21BDA1336 for ; Sat, 9 Mar 2024 04:43:00 +0000 (UTC) X-FDA: 81876255720.18.4B5F892 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf15.hostedemail.com (Postfix) with ESMTP id AE69CA0005 for ; Sat, 9 Mar 2024 04:42:58 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=kQaZep7D; dmarc=none; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709959379; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Cner6UTvu0VXqAa1clOWJdQEbhljetNE9LoKk0VJeVg=; b=YFxO1kbtz4hSRpwTmpAl/MohrAdKXINe2lmw6IhMoRoP9ZgbzbhLwm+3R/i8W9S/6xYP43 cEtHKMLCEUBpSDobTpxcZVY0FYJN9mYM8ZuCtBc4Q0RRv7Ewv+ZNR06rTq6MPtdDE6TIly g/GF66MWCr6qpxFARDFA8iog5JqNjxg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=kQaZep7D; dmarc=none; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709959379; a=rsa-sha256; cv=none; b=eHaFcqhEVqfCKArlOqvJJ4E9RIqNuyh/wjPMD6bhDiPxrhrZdzH3Cy5hVa2ERmpfPauVle QRW1ugf1PxjlFvBdLCErPywZ/Na4ThSSE+CoPZub8BJTUSvRBCF7jfOADNUvD2GXAa4wcM ru4asS6IS2C8Uw+RAdk4kGDsuKMzRqg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id F2EE3CE2A9A; Sat, 9 Mar 2024 04:42:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C07A0C433C7; Sat, 9 Mar 2024 04:42:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1709959373; bh=MhaUZkR+zHT+hBRKhEA6jXqVicUXERiCJ4v3T85N63k=; h=Date:From:To:Subject:In-Reply-To:References:From; b=kQaZep7DufDlD4TcCEwxPHIQAMTa96bO79yptDpP3N5v3iWWZkxor+tfKJuIWEekj MqtI70ZJA8OPobCIyL9ihOxfANdsavmfcDv2heioEqCnMReivT2VVU8Yhex+QxGJj4 yXXitd/67pxge9M4JKqsp62/DnEX2x86iUVcIdRQ= Date: Fri, 8 Mar 2024 20:42:51 -0800 From: Andrew Morton To: Barry Song <21cnbao@gmail.com>, herbert@gondor.apana.org.au, chriscli@google.com, chrisl@kernel.org, ddstreet@ieee.org, linux-kernel@vger.kernel.org, sjenning@redhat.com, vitaly.wool@konsulko.com, Barry Song , davem@davemloft.net, hannes@cmpxchg.org, linux-crypto@vger.kernel.org, linux-mm@kvack.org, zhouchengming@bytedance.com, nphamcs@gmail.com, yosryahmed@google.com Subject: Re: [PATCH v6 0/2] zswap: remove the memcpy if acomp is not sleepable Message-Id: <20240308204251.43d7e518ba95fb4ce22f8d4d@linux-foundation.org> In-Reply-To: <20240308203641.7fbe7e939b3483bd83b9769d@linux-foundation.org> References: <20240222081135.173040-1-21cnbao@gmail.com> <20240308192334.845b27504a663ec8af4f2aad@linux-foundation.org> <20240308203641.7fbe7e939b3483bd83b9769d@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: AE69CA0005 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 43ozbmso9bqmu6789ucwrnfixccyyj3u X-HE-Tag: 1709959378-689989 X-HE-Meta: U2FsdGVkX1/S12q5465bAC+I/U07oB4z1tYOueDDlc3cJnArpKVIpZPoOQ1gSIEbhXyE/JJigiHsXL2nDCojKf+/AXGIJxGL+14fvj+a/2huwpK5znRJipHAem2qNsJ+eKq4N8tlEkahRNVVLNSnQs733bI6Icx+Xn8j2us8fr/h+mr6/FGyZI+aCN/1FkK3XrEDMi+HCP2XxoSBS8qrr3OfT8ch8SGUt/+a5HZRdh+XqNH29lCFfoBwYzdhZjVXVUi4QYXgVuDW6CeKO/x9S79rsATIRbzB1J26wk7eDptNSEQCFKXiXUNcfl//NCr17PYiE5aEEdA4QX4yyR56eAYk/uUfbO3XGZ33pZY/SQ/+VPisL1KouF04fm7FN8G7j4FcbD6A+LDNTwtFp8E0A3fsMauwwZOy/0xBU964G2x+mq1JZMkN1ss+sj62TvyZQ4OagYa4AwX27qpN6Pys/WNwpAQy414KExOPi4uwYA7AUUyZNNZFPKB/9wyoWmA+e0EEnh8vUZakV7Wr8qtlZGeZFFGeuWd6qU6KeXVKsRimuBXeidSXw6hgA4hiOelg/YbsQ5al+JMcidjTxBfg9Zq/eONMq5hCmTJ4EA70Pjdx8Esz9OsXGiRfK8q+HLEZ+IpLUO6XuqGZUgTzQpixiHjF0E9mumFHGbVqtCNfztlfi2XaVuKD5wROO/A+ef/qXOTgpxz+VKQQCxGGcAFe4GkKlzTI/y+9sPsBTSZAjp8IUVr74qr3SzeIoN0ilct+xo0SY6hLk/VDedexbQtzl/A1QVohfgwcA+/Acd9e0mT+Tkb4SpLgN6vqNq+Vh02miLIRb3dF9bUTIbAs29d1Z57ApexO35bIk3bVuJAea4WuZZgmEfYUb3uEWtUf0GjDQwJfHQuCWWdari9ZGsb1cZgk29wzzTtlBSlAG90CKYxxcJ1eTMXbSGRvjLX6L7I/MkA6rXUNIYDm5hSZdNh czOb9nXH LHRwEvWS1+NXHVKpt8T2VY9ArXL6z3WY5ZD9LvxCarBQI8PAy9jdk9FMmEoxOV3xLCMvYkqnBKf3dnGTzLsW7vRjo6hssP4Gu+xpBX36FjB33eLbIw9+hcfVQKg3JpccSzqCX73YbNCWBW4WHcCpido/crUtv3MGMDpdq3VgQfYfy1fEABTbsq/FB7qGQIX1r6MspJPoRCw0zVCl4hsAWp0DCOBsK6N1XJwD7vGmC6BNDK+nQc3IeZ5VVrB9OmiZZ9sdd91S/HvdGnaPnSuoRKX36bZxh+J4adcjJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 8 Mar 2024 20:36:41 -0800 Andrew Morton wrote: > > Okay, I understand. Since this patch improves zswap's performance, I wanted > > it to be integrated sooner to contribute. However, I'm perfectly willing to > > respect your concerns and adhere to the community's best practices. > > > > OK. I very much doubt if anyone is running those drivers on mm.git, so > adding it now isn't likely to hurt. > > So I'll merge it now and shall aim to get it upstream very late in the > next merge window. Nope. mm.git won't build without acomp_is_async(). We can merge the zswap patch via the crypto tree. Acked-by: me. Or please just resend the zswap change after 6.9-rc1 is released.