From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9780DC54798 for ; Sat, 9 Mar 2024 04:36:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02DC56B0074; Fri, 8 Mar 2024 23:36:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F1E8A6B0075; Fri, 8 Mar 2024 23:36:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0D936B0078; Fri, 8 Mar 2024 23:36:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D11BC6B0074 for ; Fri, 8 Mar 2024 23:36:45 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6E2111414E1 for ; Sat, 9 Mar 2024 04:36:45 +0000 (UTC) X-FDA: 81876239970.02.4685F78 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id B4A13100007 for ; Sat, 9 Mar 2024 04:36:43 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=OUKjhYfo; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709959003; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZMM8IQ9mGcgWoakWXosf7EPiyu3eJ/Yyf7DgBCdrbeg=; b=UzkG4zUIsEnNavjWHtfpdW8tPmlvAqPs+JbV8zcFFyYlGcNErwwQNaqQG58qkMYopSJzWy teb2hx6qVe6UY6X8d3gXikQ9o+KnG69Tzap51KZb9iVr/Rg4ABgCeHr66219j2HjwHwdxE d4Tf2kdWMoisuun67IBannlNxzh93gI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709959003; a=rsa-sha256; cv=none; b=sH+JNSVeFtxUR2EsjXfCTTjIW3PnB+hxEEfoGOgC6Q1oPdAmK3tQmoeo3jyhKKZrAclqSU FE91wJAPRRDyjTjC2j233OH3QigSmYoBaDJtu7PKTGkf8WnaxhJ6WXq151PTmGPTpVvA/2 uCphA0podELZkbEXDXHIl27rl43u/CE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=OUKjhYfo; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D41FB60C84; Sat, 9 Mar 2024 04:36:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C3EEC433F1; Sat, 9 Mar 2024 04:36:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1709959002; bh=i0OAAR81212W4woDBe/PQ8uKcxC/93Z5iRmjo8Evf0s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OUKjhYfoqkhazCLlSOcQ5sAPFfiGlfOEe/6b6hODcZr1w8kJH60KN+GpUlwsrUCuP toG0QwbzNc0R/HA/CbygibGknOWjLzMa44zmSHf7m0gkupcFCDrA/UmXXI0YL++00o XPdtjYna8bJJp8KYNZD0IJT7H8xZ8N1JLHuPeikU= Date: Fri, 8 Mar 2024 20:36:41 -0800 From: Andrew Morton To: Barry Song <21cnbao@gmail.com> Cc: herbert@gondor.apana.org.au, chriscli@google.com, chrisl@kernel.org, ddstreet@ieee.org, linux-kernel@vger.kernel.org, sjenning@redhat.com, vitaly.wool@konsulko.com, Barry Song , davem@davemloft.net, hannes@cmpxchg.org, linux-crypto@vger.kernel.org, linux-mm@kvack.org, zhouchengming@bytedance.com, nphamcs@gmail.com, yosryahmed@google.com Subject: Re: [PATCH v6 0/2] zswap: remove the memcpy if acomp is not sleepable Message-Id: <20240308203641.7fbe7e939b3483bd83b9769d@linux-foundation.org> In-Reply-To: References: <20240222081135.173040-1-21cnbao@gmail.com> <20240308192334.845b27504a663ec8af4f2aad@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B4A13100007 X-Rspam-User: X-Stat-Signature: fbptzozcazmusgco7b69s97gre11uupn X-Rspamd-Server: rspam03 X-HE-Tag: 1709959003-818133 X-HE-Meta: U2FsdGVkX19xEbsyhSe354dMuU42cl38TwrK3A914beg/agyhCiitfJKdUALU/zkdBoydomgwMGvzOdpZCKW1p6dPeNMxn0tNvP1399HqMvEO90SYFKgUn0S4EOM10IHtW6BSDVHdkW7CzXOo3iVBxgzJ9Ct9wiPhxuiTKFw7VLH2us5MR9dlWuQiYMc0+E4Ip57h7noL2d0quXud+2c2XWIaxQl87dXvoTbAZ97d6QwGSSlpEK8IAPh+8JLf3EBKpNahEm4ZfWlyYLh5HhUk3L4Cc3lfzcgv3M2E9PgXyKvUzAGKgCFLe2qctNA50Vo77dEMkW2KiyvlLjvZrDNBOhCSMAH9JRT/A5h6212ucFxG+8Hkt3Z2vi5zTqb7XyBHYegT0VWTauPCJCFk5HNCqPB31fbYSc92vLbvlby5iijOhiOAnOKoAQ3ZUcFCSYiaE22oVSADWeIbWG3wAHQGUYPhrcB5/5ZsJuqLzMt+MQGRYgxMMmvkzUbMwDCfxchEAZU7czBIR3DHR/K7PjMg5dEaZIY6BGsCLZiguhcInyrpsjSVaxT0bqog9mpZu7xTAvDBwU8tHDE8AoQX7d4uxVECbyiY+DbeE99wWiJST42xm1IvIwPKBSaJ55ClYnKT79Osdb/e/1iynwd5bkCRXPvHpxydFNjxj9v8y3PzPygpj2wpVWOgv1pgXwnVhI8JbfWACCbFkeVlYtnX8iC13S3hsbfZxyjo3xbxeMSu1FBoDC72Xbx92veC3YQw0Mc8LCBx6EyFPqhAKvLOhogbOuWuEr+kqQkqM6Aq7vezgy3T7+Sut1JyPzFHo/aZEOKWlPKIISf+zaEpiBigTdzFXV1KGlAaE2H7KkpjQxRkm33GDiFsen9kVT+J+cDyevqKn/Si4Axq4CN5FFHCqxz6Z2zES/s/kSeyFbLXu7QD3sch6ZFQNV63Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 9 Mar 2024 11:58:39 +0800 Barry Song <21cnbao@gmail.com> wrote: > > > > > > So it should be quite safe to pull this series into mm-tree now. > > > > But this zswap chage requires the presence of the other patches, yes? > > As far as I understand, we rely on two driver fixes because those drivers didn't > set the correct cra_flags needed by our patch1. Without those fixes implemented, > two platforms might encounter issues: Intel with IAA (Intel Analytics > Accelerator) > and Hisilicon with ZIP. Other platforms should be unaffected. > > The two driver fixes have been merged into the crypto tree. > > > > > So the mm.git tree alone will be buggy? And if mm.git merges ahead of > > the other trees, there will be a window where mainline will be buggy? > > Before 6.9-rc1, there might be issues if mm enters Linus' tree before Herbert's > crypto tree. However, by 6.9-rc1, everything should be fine. > > > > > If so, I think it wuold be better to merge the zswap patch in the next > > merge window. > > > > Okay, I understand. Since this patch improves zswap's performance, I wanted > it to be integrated sooner to contribute. However, I'm perfectly willing to > respect your concerns and adhere to the community's best practices. > OK. I very much doubt if anyone is running those drivers on mm.git, so adding it now isn't likely to hurt. So I'll merge it now and shall aim to get it upstream very late in the next merge window.