linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Barry Song <21cnbao@gmail.com>
Cc: herbert@gondor.apana.org.au, chriscli@google.com,
	chrisl@kernel.org, ddstreet@ieee.org,
	linux-kernel@vger.kernel.org, sjenning@redhat.com,
	vitaly.wool@konsulko.com, Barry Song <v-songbaohua@oppo.com>,
	davem@davemloft.net, hannes@cmpxchg.org,
	linux-crypto@vger.kernel.org, linux-mm@kvack.org,
	zhouchengming@bytedance.com, nphamcs@gmail.com,
	yosryahmed@google.com
Subject: Re: [PATCH v6 0/2] zswap: remove the memcpy if acomp is not sleepable
Date: Fri, 8 Mar 2024 20:36:41 -0800	[thread overview]
Message-ID: <20240308203641.7fbe7e939b3483bd83b9769d@linux-foundation.org> (raw)
In-Reply-To: <CAGsJ_4xSwNZmHN5GvipS-1kELX2NBwHxoGE=aG4sekm1LcYVPw@mail.gmail.com>

On Sat, 9 Mar 2024 11:58:39 +0800 Barry Song <21cnbao@gmail.com> wrote:

> > >
> > > So it should be quite safe to pull this series into mm-tree now.
> >
> > But this zswap chage requires the presence of the other patches, yes?
> 
> As far as I understand, we rely on two driver fixes because those drivers didn't
> set the correct cra_flags needed by our patch1. Without those fixes implemented,
> two platforms might encounter issues: Intel with IAA (Intel Analytics
> Accelerator)
> and Hisilicon with ZIP. Other platforms should be unaffected.
> 
> The two driver fixes have been merged into the crypto tree.
> 
> >
> > So the mm.git tree alone will be buggy?  And if mm.git merges ahead of
> > the other trees, there will be a window where mainline will be buggy?
> 
> Before 6.9-rc1, there might be issues if mm enters Linus' tree before Herbert's
> crypto tree. However, by 6.9-rc1, everything should be fine.
> 
> >
> > If so, I think it wuold be better to merge the zswap patch in the next
> > merge window.
> >
> 
> Okay, I understand. Since this patch improves zswap's performance, I wanted
> it to be integrated sooner to contribute. However, I'm perfectly willing to
> respect your concerns and adhere to the community's best practices.
> 

OK.  I very much doubt if anyone is running those drivers on mm.git, so
adding it now isn't likely to hurt.

So I'll merge it now and shall aim to get it upstream very late in the
next merge window.


  reply	other threads:[~2024-03-09  4:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22  8:11 Barry Song
2024-02-22  8:11 ` [PATCH v6 1/2] crypto: introduce: acomp_is_async to expose if comp drivers might sleep Barry Song
2024-02-24 16:52   ` Chris Li
2024-02-22  8:11 ` [PATCH v6 2/2] mm/zswap: remove the memcpy if acomp is not sleepable Barry Song
2024-02-24 16:53   ` Chris Li
2024-03-08 11:57 ` [PATCH v6 0/2] zswap: " Barry Song
2024-03-09  3:23   ` Andrew Morton
2024-03-09  3:58     ` Barry Song
2024-03-09  4:36       ` Andrew Morton [this message]
2024-03-09  4:42         ` Andrew Morton
2024-03-09  4:56           ` Barry Song
2024-03-09  5:08             ` Barry Song
2024-03-08 12:11 ` Johannes Weiner
2024-03-19 11:00   ` Barry Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240308203641.7fbe7e939b3483bd83b9769d@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=21cnbao@gmail.com \
    --cc=chriscli@google.com \
    --cc=chrisl@kernel.org \
    --cc=davem@davemloft.net \
    --cc=ddstreet@ieee.org \
    --cc=hannes@cmpxchg.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nphamcs@gmail.com \
    --cc=sjenning@redhat.com \
    --cc=v-songbaohua@oppo.com \
    --cc=vitaly.wool@konsulko.com \
    --cc=yosryahmed@google.com \
    --cc=zhouchengming@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox