From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9432C5475B for ; Fri, 8 Mar 2024 10:44:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DB036B036A; Fri, 8 Mar 2024 05:44:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 58C4D6B036B; Fri, 8 Mar 2024 05:44:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 454EB6B036C; Fri, 8 Mar 2024 05:44:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 33C2C6B036A for ; Fri, 8 Mar 2024 05:44:03 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B8D894159A for ; Fri, 8 Mar 2024 10:44:02 +0000 (UTC) X-FDA: 81873536724.17.D693163 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by imf02.hostedemail.com (Postfix) with ESMTP id 6727E8000A for ; Fri, 8 Mar 2024 10:44:00 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=hTF389BS; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf02.hostedemail.com: domain of lkp@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709894641; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=360CIX3zAkzbtgV0WsZDdDV9PMfFMxZ3evWkMz0A/PE=; b=oGwNSqfYPFTReDB29FwiTDbB7pyiuE/bYMqIn8tHAWacxTwiBAdfy19SQyhVtjS0JOLiVP mBxyQ2WXZ3AwpCM/uCc0FOPqPkzCD1bLkUqUsgpGpyA4X3iEk2eBuN5JHOtEvmlV8Obmoh VqXv/PscgE3+v1XyBgLujk/E3U3Aqg0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=hTF389BS; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf02.hostedemail.com: domain of lkp@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709894641; a=rsa-sha256; cv=none; b=oHDbRn1Rj10VmNAAqTnnG1BwmLOVSOnK2SgntSJij2Cp8Rbbs2BlIa3Xu1Xc7XXbMAClsq 4ZTMtsiPDra/BjorLh76hYggOYzrerlmCEweu98r9QwOtqvQyoUGuSNw4GxAFj5tz+AuG5 5TbtXllb9zfAZOwKKaXLWuSgsRoZ9og= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709894641; x=1741430641; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=IaAaj7Tsi92YD//SZUxnQaYxfr+Kq1MmRFiJG/TyF0c=; b=hTF389BSyal6dKhAtPVNJ+zuwU6UfmD/o+ol6acVbpUPDNnWtqu8moCP JttR9PdrqDneU/5XjRY2Wl26T3DO8UYSMVp+TPrb2xRmKi8KgzLOzk1vd EeFY4rq5PuR5HaapQkrQeF7uRf4T2u+1q+qcBF50A365vn/6e/cu5mGD5 ix/NfKm0nwztTxv/bbAWwBpoahNnyOOeP2AVpwegDlWnx3yWY2/Jr3ZpW DT1vvgkrACT0bydd1QU3mx7BKk/6g89yJB6jRmNMm/18lY8o0K2cTfoZk alDHs9YBOnA1IXvDRxNiXq11+YlMB30hn7tYaipYFECEbhqOP4yUYO7tw w==; X-IronPort-AV: E=McAfee;i="6600,9927,11006"; a="4537017" X-IronPort-AV: E=Sophos;i="6.07,109,1708416000"; d="scan'208";a="4537017" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2024 02:43:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,109,1708416000"; d="scan'208";a="10439511" Received: from lkp-server01.sh.intel.com (HELO b21307750695) ([10.239.97.150]) by orviesa010.jf.intel.com with ESMTP; 08 Mar 2024 02:43:48 -0800 Received: from kbuild by b21307750695 with local (Exim 4.96) (envelope-from ) id 1riXhZ-0006Id-0a; Fri, 08 Mar 2024 10:43:45 +0000 Date: Fri, 8 Mar 2024 18:42:51 +0800 From: kernel test robot To: Steven Rostedt , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: oe-kbuild-all@lists.linux.dev, Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Linux Memory Management List , Vincent Donnefort , Joel Fernandes , Daniel Bristot de Oliveira , Ingo Molnar , Peter Zijlstra , suleiman@google.com, Thomas Gleixner , Vineeth Pillai , Youssef Esmat , Beau Belgrave , Alexander Graf , Baoquan He , Borislav Petkov , "Paul E. McKenney" , David Howells Subject: Re: [PATCH 5/8] ring-buffer: Add ring_buffer_meta data Message-ID: <202403081831.EWSQPo2a-lkp@intel.com> References: <20240306020006.100449500@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240306020006.100449500@goodmis.org> X-Rspam-User: X-Stat-Signature: 7mabe5txrxdrsohpwt86faxgisf7bncz X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6727E8000A X-HE-Tag: 1709894640-559680 X-HE-Meta: U2FsdGVkX19ZAAOhXKRkpf/1TBm682KWExgLp3b0Sdgju3icW2m7aOzvD6rrV+ip4rc3avMRufzOfb+J6avCaJE2NVO1E6vlmztWiFICcOOKsvKyXuX3lh2gbQowfBSGDdNf4QaTxwfp0jn5xmdhlsA86bioH7TB21IU/+fBrBa7hYwHvPzgJOdEq3hVoGVcEKRJEfle+UtPOVG8pZ8ndzKrGO+XedDgwNTq54pzYNmqLbMldSQGgc2MuWuMVTmmnqMwgEMkABwNVjdYDSR1Pd/w3KaFxJMPVALlMOnoq2zmykVCiV5pVh8ThGdiz29QzexnOsXV//Gt+XCdRU8mw2K2MpJXcyFA6WmNNvevBN9dkzWJPjJ9IdFsLWxKTgM57ey7MxvtvHvuD6UYU+hAne2f9Ba4AgW3tP/ilTskZLqqyrclGgcAcd+LYxQsO7Z2m+82upZWGknNoRCQmbgkiJrBAL4qaLHTcr30iIaFgRwrO6mbompJ88/qcWn69/cAhxV80hWUT6wfTLOp+RLRc1I0ocLPlz+pyTzQZSN4BgqRpX+qXcRqmI9XKrbLI1Be/+vK2gGVMXYlnXo9u8Lqpj8jbqj8bkFAexBid93ve3aA3vSH6yJzQUOD5W0RotfnwUrKeOESBQDTlFJ0vOQgpb5JMEORPwsqkMYrN0SEk8eaafymR3tfLXsd1iHV5Epq0D0XHdVqqkBTrYZauuR+ji6YeMPx2diN0i6ds5ns5GuBBuatdB1o8fYSaiQG2Y1Vgsut7L2LCvUWE7SPuWMOt4f9+0DEs19fw9q7/g+CkTG40FWcM4RjWXOt2g7C3PPoVtUXj/PaTIvhvZWVTqrjRwbaNcV+ZM4R3N3HaJznqaBvjZyOt/KHx3VZ8IzYuyxVDKTdxWAwgBc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Steven, kernel test robot noticed the following build warnings: [auto build test WARNING on next-20240305] [cannot apply to tip/x86/core akpm-mm/mm-everything linus/master v6.8-rc7 v6.8-rc6 v6.8-rc5 v6.8-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Steven-Rostedt/ring-buffer-Allow-mapped-field-to-be-set-without-mapping/20240306-100047 base: next-20240305 patch link: https://lore.kernel.org/r/20240306020006.100449500%40goodmis.org patch subject: [PATCH 5/8] ring-buffer: Add ring_buffer_meta data config: sh-defconfig (https://download.01.org/0day-ci/archive/20240308/202403081831.EWSQPo2a-lkp@intel.com/config) compiler: sh4-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240308/202403081831.EWSQPo2a-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202403081831.EWSQPo2a-lkp@intel.com/ All warnings (new ones prefixed by >>): kernel/trace/ring_buffer.c: In function 'rb_set_commit_to_write': >> kernel/trace/ring_buffer.c:3224:45: warning: assignment to 'long unsigned int' from 'struct buffer_data_page *' makes integer from pointer without a cast [-Wint-conversion] 3224 | meta->commit_buffer = cpu_buffer->commit_page->page; | ^ vim +3224 kernel/trace/ring_buffer.c 3192 3193 static __always_inline void 3194 rb_set_commit_to_write(struct ring_buffer_per_cpu *cpu_buffer) 3195 { 3196 unsigned long max_count; 3197 3198 /* 3199 * We only race with interrupts and NMIs on this CPU. 3200 * If we own the commit event, then we can commit 3201 * all others that interrupted us, since the interruptions 3202 * are in stack format (they finish before they come 3203 * back to us). This allows us to do a simple loop to 3204 * assign the commit to the tail. 3205 */ 3206 again: 3207 max_count = cpu_buffer->nr_pages * 100; 3208 3209 while (cpu_buffer->commit_page != READ_ONCE(cpu_buffer->tail_page)) { 3210 if (RB_WARN_ON(cpu_buffer, !(--max_count))) 3211 return; 3212 if (RB_WARN_ON(cpu_buffer, 3213 rb_is_reader_page(cpu_buffer->tail_page))) 3214 return; 3215 /* 3216 * No need for a memory barrier here, as the update 3217 * of the tail_page did it for this page. 3218 */ 3219 local_set(&cpu_buffer->commit_page->page->commit, 3220 rb_page_write(cpu_buffer->commit_page)); 3221 rb_inc_page(&cpu_buffer->commit_page); 3222 if (cpu_buffer->ring_meta) { 3223 struct ring_buffer_meta *meta = cpu_buffer->ring_meta; > 3224 meta->commit_buffer = cpu_buffer->commit_page->page; 3225 } 3226 /* add barrier to keep gcc from optimizing too much */ 3227 barrier(); 3228 } 3229 while (rb_commit_index(cpu_buffer) != 3230 rb_page_write(cpu_buffer->commit_page)) { 3231 3232 /* Make sure the readers see the content of what is committed. */ 3233 smp_wmb(); 3234 local_set(&cpu_buffer->commit_page->page->commit, 3235 rb_page_write(cpu_buffer->commit_page)); 3236 RB_WARN_ON(cpu_buffer, 3237 local_read(&cpu_buffer->commit_page->page->commit) & 3238 ~RB_WRITE_MASK); 3239 barrier(); 3240 } 3241 3242 /* again, keep gcc from optimizing */ 3243 barrier(); 3244 3245 /* 3246 * If an interrupt came in just after the first while loop 3247 * and pushed the tail page forward, we will be left with 3248 * a dangling commit that will never go forward. 3249 */ 3250 if (unlikely(cpu_buffer->commit_page != READ_ONCE(cpu_buffer->tail_page))) 3251 goto again; 3252 } 3253 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki