From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C08EC54E4A for ; Fri, 8 Mar 2024 12:11:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CD706B037C; Fri, 8 Mar 2024 07:11:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 97E856B037D; Fri, 8 Mar 2024 07:11:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84F9D6B037E; Fri, 8 Mar 2024 07:11:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 75F996B037C for ; Fri, 8 Mar 2024 07:11:44 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4E7EA1A15EC for ; Fri, 8 Mar 2024 12:11:44 +0000 (UTC) X-FDA: 81873757728.17.559C693 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) by imf19.hostedemail.com (Postfix) with ESMTP id 4CE581A000B for ; Fri, 8 Mar 2024 12:11:42 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=SXCMxUU+; spf=pass (imf19.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.172 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709899902; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LFWHyOgkTFQ1yJTh6kQ8rZCjVUuuePKTHTw1zfzOKuU=; b=ctoJe7RgziYoJfKH1BYsbi6JYVe8NTCYt0ZuBdGUtya5ei/1pomv75TDdsxZAKrp12+D2D 7dzhBxGXFNtqvv/7lIj+f1XBxn0ikTd9x8DQ40eO9bvc4AmEYlPofwodHS3aB2r3Q8zHMn gG4+m19eAT+zRwdVJCBTdaP7IEyoHgw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709899902; a=rsa-sha256; cv=none; b=O5qxLi+mxyyOP/pwV2fM9it51ozkKO9fu10rz0Z5hKacXOqbSgvwF5EqXcVVZUA/UwIEFP HI4A4iqc3zlkglauJUzQzgz7YIHA6lln5KGcRg0x46AaRdbA0/fs/XQbSoAVp7uhymFHw8 hxxRryto0g8S5QkShy/E5LF8zcXdpgo= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=SXCMxUU+; spf=pass (imf19.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.172 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-7883e1e01daso84930085a.3 for ; Fri, 08 Mar 2024 04:11:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1709899901; x=1710504701; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LFWHyOgkTFQ1yJTh6kQ8rZCjVUuuePKTHTw1zfzOKuU=; b=SXCMxUU+sB0R/n+y/bkP2yXYc4EOS+ODQzgQrPl3lCzB5+jBFXY1G0GlFHGb7v6zGD PzuyXb4SficYcuSvFTrevXqEhWtCIoXiR/ExO7ipMcXIuAshHvTT7n3pALEYjvtkcuUK a7Mez9kZYkAegiNvE/WDPPV0c+aWuEcCTZiKC5RrbNHXsqNKHwLZia1FgZYB53ShMElg CK4XNCaTZ9wsAkcJfKShrWZNZfXEWQ30boUZHeLz2j5Dd4SGuRPKDTujMcvVntgHRbPG O6fSRqKxsS9KSV9VSXbpz7K/qrSCLKrlb1b3ryalzAr/o7X6Sr6/BX6nrZgd8o+K3qpI 0vRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709899901; x=1710504701; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LFWHyOgkTFQ1yJTh6kQ8rZCjVUuuePKTHTw1zfzOKuU=; b=JXf7bLYAZUBVfDJAM7Pd4K5YCftwIC/6Os7U39OSERWpHDOQ+86yxbYhL9YRKtsh6k QrrkXrham2GMB/3yeH3agibbMgFVcYlM5/ll7OJqROZzO/1WOzBQwUyr89eDZ4QAzHYC B/nDRAxCFNDXr2b/CHOvwof75FibxeawrhCHAFdI9WlHUgjoiCnEbTeXIRXgs1Q5KsTJ uU0venN2o/+iD5hGOwoAUdFSkCjRqH3TNyHdmLLWpM91j1HzsgB0+6FyWN2QlRt/GIGr k1DCNKML6nVtAsbDoIf7PDp8E7vgmj3ZGJess/6Xc55aWc2SYq9jba99vT7RAsfSTu7D 9Gow== X-Forwarded-Encrypted: i=1; AJvYcCW4IPu+FZU/YSFKGUZsFUhOroBU8h3WK5qh+5E0ldS6aSjvd4lZJzc7nYGBbZmSGyVD/9t49TnkdjG0GlbIQEkbrSE= X-Gm-Message-State: AOJu0Yyw+aoET7MfWlS2w8rZEZgN77v5THDrdbGBuvo0Wi5brS6M8yTj YfruY21/VmfPVZiOzYixzhq16sEhDvCEY2zEvVOTOMgKb72lImNH4V1ZmVsFUno= X-Google-Smtp-Source: AGHT+IEzxOxVKkJMR57UwDLb3/yh3+LCr6bD0C5SHDj0C+YHgMECjWjVL0bqStieUxK8nnlRvm1EGA== X-Received: by 2002:a05:620a:1265:b0:788:1dbd:efe6 with SMTP id b5-20020a05620a126500b007881dbdefe6mr10872949qkl.55.1709899901345; Fri, 08 Mar 2024 04:11:41 -0800 (PST) Received: from localhost (2603-7000-0c01-2716-da5e-d3ff-fee7-26e7.res6.spectrum.com. [2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id s18-20020ae9f712000000b007882b33f6d5sm4969471qkg.114.2024.03.08.04.11.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 04:11:40 -0800 (PST) Date: Fri, 8 Mar 2024 07:11:39 -0500 From: Johannes Weiner To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, davem@davemloft.net, herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, linux-mm@kvack.org, nphamcs@gmail.com, yosryahmed@google.com, zhouchengming@bytedance.com, chriscli@google.com, chrisl@kernel.org, ddstreet@ieee.org, linux-kernel@vger.kernel.org, sjenning@redhat.com, vitaly.wool@konsulko.com, Barry Song Subject: Re: [PATCH v6 0/2] zswap: remove the memcpy if acomp is not sleepable Message-ID: <20240308121139.GA116548@cmpxchg.org> References: <20240222081135.173040-1-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240222081135.173040-1-21cnbao@gmail.com> X-Rspamd-Queue-Id: 4CE581A000B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 4dad14u56rk3ynbq3fdccypt5cm35qm9 X-HE-Tag: 1709899902-160385 X-HE-Meta: U2FsdGVkX19avq/YKPUGGt2o4jMcMwFCV7DUaUnzjQZkv2dmsvKbgjfloBIXljMybLkTcszwEx8LoFpPfveMFjmN4PLci38h7ikV/Q0nOJ4pkgC/4TK4LyRuLdXxmCFNTIBd2r6DQ8dPcQycGyh8bQvwC58p6kUNRV9zq/ooBJrIDOPprmb0miVKUHyxntZrZ3WcUvwbUyDclQ27Uyar7s8RzHglZ6Awuhlklzqn/AEJT5nHTKQO7iWtET1laNuwkCHrXj1VrqaTjvm+mdgjecbq/ryDiCgr3EBtEu/dNCOPd6wp8J1ZNgWPA2OAWxDXVAtNnOo5KBYpZLrwNHDskNCvTsnHjT5zYkrdzynJQNJm9gRhp44LIaaUVp5+v27bhCHhq7r2Rr6GuisWrCePKLtW00NJozwFhUyVATpexO3O7il+WknrHNJXq+rtU0nryfbmVGHjMSo116NiYeg2ZFs6hQztqzwCxQGD85aGsmRKjGhQ7C7NK2DUPi4IzyLJ92bc855Qmvsg9/k+neO4tRawaJe1cqrR75bTSX95E0JVal8HKLCJIUB2VLfdVR6DXyJEUgNfhxHAL3c6Z/1BTjjOCuamFVCVpJnNClrZUbJAd0MhuTwbmjOQtACu6beq24iaEyWpytRvWubmkx/dEMtzkVR/5mFrw5pLWyPpIzdjG7L7fXrPF597AfXXasuBp/+f98sqxMnhQ5irIuMXQnDUAU889+g2szGsPF5AxCly7E7rCIPZeVl2DbaeYbrRYy7pqeAqTeXZAKV3fRV4EvXVI7nJn85+rGuEtA6BkMpcqHAGSra+EltXK10/VOaU6l2TX5tXFcw3pgbh+hx0peLZN21GwUnt27uBDcR0WX5ki/09+ciwSwe/dyjQSxN3JRYd4mGxsyIEsWqvaUGO4JTHASl5lWUA5VWlHbfZwx/VLkYJN2eVp4WnwBeGtw10dcAjVpbi0ubmXiLtJoJ zWAqsXod OOgAVxkdO3VnOGuEoyTL3nGRBahmvja3zqsGYPiZlbAFxSc3IoIOzXDg7Bdj2Fn9ibXgKFTpbg3CVrj59r+qRBO7wFCtAKeUe06zJ2rQtRIfJjDi8mfXHpJmblW114NMPPLtW6yTNyzxxuHw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 22, 2024 at 09:11:33PM +1300, Barry Song wrote: > From: Barry Song > > In zswap, if we use zsmalloc, we cannot sleep while we map the > compressed memory, so we copy it to a temporary buffer. By > knowing the alg won't sleep can help zswap to avoid the > memcpy. > Thus we introduce an API in crypto to expose if acomp is async, > and zswap can use it to decide if it can remove copying to the > tmp buffer. > > -v6: > * add acked-by of Herbert, Thanks! > * remove patch 3/3 from the series, as that one will go > through crypto > > Barry Song (2): > crypto: introduce: acomp_is_async to expose if comp drivers might > sleep > mm/zswap: remove the memcpy if acomp is not sleepable > > include/crypto/acompress.h | 6 ++++++ > mm/zswap.c | 6 ++++-- > 2 files changed, 10 insertions(+), 2 deletions(-) Acked-by: Johannes Weiner Looks good to me. One small question: why cache is_sleepable in zswap instead of checking acomp_is_async() directly? It doesn't look expensive.