From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E3A1C5475B for ; Fri, 8 Mar 2024 10:48:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF70F6B036C; Fri, 8 Mar 2024 05:48:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D80BC6B036D; Fri, 8 Mar 2024 05:48:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C20F26B036E; Fri, 8 Mar 2024 05:48:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id ACF626B036C for ; Fri, 8 Mar 2024 05:48:25 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3989381591 for ; Fri, 8 Mar 2024 10:48:25 +0000 (UTC) X-FDA: 81873547770.16.15C9DB7 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf15.hostedemail.com (Postfix) with ESMTP id 46BECA0011 for ; Fri, 8 Mar 2024 10:48:22 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=o7OSDGYQ; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf15.hostedemail.com: domain of manivannan.sadhasivam@linaro.org designates 209.85.214.171 as permitted sender) smtp.mailfrom=manivannan.sadhasivam@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709894902; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=26hAEq53OJfxkgYSi/GiWOaFJ9O8E1BfJnbrW6c9mKE=; b=zKoIj0ftTPyvHEqYYZN3+M0FmgUQkWSFw0Bgx5nQ3F9hLmtHY3bUZz5D6zUAwn1mBoOFx/ ra85rsnVIoSeHiHQKlIIvfomcbB+/Ilun4ooAvqBqj3R8qLi7F6kIJTAXFMzEDQdmKP+IC 4QWAZDCaft3frUT6ucbXa91l7F21kNA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=o7OSDGYQ; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf15.hostedemail.com: domain of manivannan.sadhasivam@linaro.org designates 209.85.214.171 as permitted sender) smtp.mailfrom=manivannan.sadhasivam@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709894902; a=rsa-sha256; cv=none; b=bj6/3aUktMS7yBdcOcHcY29/D4/rJQMWfz6WqyI5FNK6CZKsWiofj2xM62R7bZx/jH6LJ1 8jussTcvp0D5Sw46M3FdRRrHOqzrwEMuYQtUT+Stb8poGVfL23ue+2o+HIEjkTAvyTKR6j r0CwU5un0CcYaduXLqKWpuC/RZiUy38= Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1dcc7f4717fso5699275ad.0 for ; Fri, 08 Mar 2024 02:48:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709894901; x=1710499701; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=26hAEq53OJfxkgYSi/GiWOaFJ9O8E1BfJnbrW6c9mKE=; b=o7OSDGYQu5E+xYGqvM9if1Xuxqylpnuy1BmvVkY8dQ5IwcBgeEI1HMpxuA+OSoCHns HCUERLGRkhDaqXaIE/sNOzvBFhoThnYjbjRnOeQWXl8zLbyQ4NgS8rutZ8upuRn9ICwN Dp66LJn1qU/wbjcEvC034A49vIYj4axJv8kar2YjHfwqK5lBADbiSkJCNXEShPDEy0TX Bv4rihp9kccK4gYs9IiYiZsC0Pe0Pkgel2PhSPUvfTTCFzxFWs7bU1acUgXOf1y6hoN7 QhlGCR/zCNFRfJPBc9lwjbylkVd676QWVGiKFiWdLhPPwwImJcSw1a5GvQLUy6Yi+ngv 3Cpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709894901; x=1710499701; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=26hAEq53OJfxkgYSi/GiWOaFJ9O8E1BfJnbrW6c9mKE=; b=g11ZGdK2ABJxc6P92WFQ01+QyvyGeccs9sUBTt9ySUTDikzIFQvvGECCafb8md3OkV ZLH9hYyBXqPM2drlwf+NcfpV7MPpAecx6uBVlkZk6ft2hJjbv7ZnfeZN53FyQzL70lzW h6D7dRdBEhz7dzhBSNEkpikxqNV3hwlClLOVLQi0FlEt8AC/0nmbdvQO06AhyRQl8YFW UBLam0gFeKuLs6Bu2UYw7xLppZPWtCKma+elN3WQ0B1YNvtLc9Ohg9TjQjNVE9QT+0bK tizzk5IXwHLn0V2tsM4dTFgWADI8bBlyPw8MlBDPiViTwlXxg/ejlZAsJTmhvGHSE7X0 NUIQ== X-Forwarded-Encrypted: i=1; AJvYcCX0uMaMTjA+Hz6rZvN0Wxxot3AbkalksDGuQyXV9UYIUVQlccDwi4EGKd+tM2C6PM8k7j50/aoiTMhPjQJf2DpReW8= X-Gm-Message-State: AOJu0Yx+Caenp8SiEEH5UABwBd18JUCnxpnT6lxG0ae9maM9GZJJni1p D0/zOxxuyTfA3L8NY31yL/iH1HOia8IwMTIWRSWWsg257ZURzDse8pKKVsm8Qg== X-Google-Smtp-Source: AGHT+IGTZSiRBTMWUdaBO1vqD4dWLINeszuACZPHN9xahf3y7wMBHlVvLuZk7dXkbF83IM4NNHUGtA== X-Received: by 2002:a17:903:2443:b0:1dc:ca1b:279b with SMTP id l3-20020a170903244300b001dcca1b279bmr13328124pls.1.1709894900832; Fri, 08 Mar 2024 02:48:20 -0800 (PST) Received: from thinkpad ([117.217.183.232]) by smtp.gmail.com with ESMTPSA id cp12-20020a170902e78c00b001dd3bee3cd6sm4853039plb.219.2024.03.08.02.48.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 02:48:20 -0800 (PST) Date: Fri, 8 Mar 2024 16:18:11 +0530 From: Manivannan Sadhasivam To: Alexei Starovoitov Cc: Miguel Ojeda , Christoph Hellwig , Linus Torvalds , linux-mm , Andrew Morton , Catalin Marinas , Will Deacon , Linux ARM , Daniel Borkmann , bpf , Bjorn Helgaas , linux-pci@vger.kernel.org Subject: Re: vm_area at addr ffffffffc0800000 is not marked as VM_IOREMAP Message-ID: <20240308104811.GA53064@thinkpad> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 46BECA0011 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: jynxaieeo66r989x5sregqouhjwijour X-HE-Tag: 1709894902-2737 X-HE-Meta: U2FsdGVkX1+rmrXM7Ucdy2o9yY1xxaQ7FLDThc7jQkcIlgTFtVXyNyydEGCE++2FeEyhusWQA93xgZLoIiE9dT5gClbtJPxBdYZuWM/r4XW72GmO7IVq5sBEe9DU2E59/GRa3/WxHBRLZIRbUJPR2MBEkusWKiizf9JCnxDSISP1z69xgXBL2p4ell+zk0QUn4mo1Y4m4jn9SUjs4jkyMQcoSUzpgiK2EWaiscOP+eEa18j0w/O8x90IY31Qzf1hZ7hvW0lI//uh2Jy3YuNfCI9qXxILz3uilykPl7q5+QPj5iTirusVDzoNgJ8vI6hIKmUBzKkfaOnSVEhScpX3Z7qXKjVM7Daj1uV294YVukWhtRJ5msNG4/nFY2x3GlIQdDlS0hx3j3Hkj9elUV2cHKKpnlUjjAKTas7opz5mL47hSLkKTC4ViZcIVb4Tg5ppo7+z9F2J5cbk4xAY5Sxggp5sdYbR3tV1IQ2OlzqujujLbrsgSHfL9iWp0yl0FWVCeYFXSKrCg/wj2Ow3PiCOVNhuSO/ZhomyQJwTz2NfOzlUy+43O1gsu9koTPlKn7TCzDOmE9TqXE6qB+fdQSgercUiYH960eKEwYfrt+bMNOlP7ao+Bi3DGKI/wgu09K+9AdrUbFqocan4cQeEJ5091pFfSk+JGzi4czU8FTyhcwGlM5Lqa/b4Ts18nDsI3xbqApH4lT5rc9eKHRNULKn+TPqhN0lzxUWA7pJAUfDQLiKS6iMvnWuWLippIsCgD8mITCjTkpUN9a5l5X0FERv62A+daJ7icPDJRli/2LkniDSt+8eHjT2BSifN31RpH5thAlFGfbJosfVMbP8Ir5YpBcFTG2DU3KGVV2nI7Jy9ck/2yurm191qtNUiV4QWY+v8pwB4bz4oOFe0y83brCABmTzcrlu3lWUOCzN6jASKkgbGWIfDh05Hz7gja35cXBrW/xZ8vmimvTTEPDmU0LA m6BV1SEf ZKJuz72vqG8R6RDvYrCDBwlaaIU2XgjAhx5HueZVRrD1sNJLHZC2ZkSSlaSZeTxVEvGLKZwN24Yu5d09KoTB5NwUwTiUCCF57MsCm3TH8QMjhFL1T69FVZVHbIUOLNOLi32vsSvqsiJCKTMigL4QZfTcXgx4QF5lNybqXTGX+YLYQp46QL4ENwKU4ywdcvX8aCxiynPbCFqej1+1YvsmWbStjFp02kT9235T0GyNjO059W3Xh8hxaUdpdzTbuqEaT4fTKfOAIM5Xt6nxKLvhCRIWiEqY8wrAH8+OETL0wuPMxMvDq+hZsvnDImxShbyJ8SkjUCvDNVQNCOE7zAhd/NqMJBl7g4vca5qtwXxvzrsoxCYmBezLiKBMfGhUzM5zV8nuLcsnoBQgLLg5nafYoCr/2v7LgoWFlWPGL38g3m5j2N5+I9xIljXsI9EYcuATcjiTPW/6UWugJ0pSsBEgmn8a/kPxKEYOqZfGUHx9bKbDqN8OE96DDQQUqstRvCubFZ+sR9XW1v8P0ZN7UeTuu9Lj8rksygwMLWOwzXvu42T4jss2AeRhj5Ueq0p6TwGeA88NK9yJ9KJ0gJJj53vZLTfVTP+Q/Wbm8l0zU1eawU3UCACNrWMR1lAiT+A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 07, 2024 at 07:49:16PM -0800, Alexei Starovoitov wrote: > On Thu, Mar 7, 2024 at 9:54 AM Alexei Starovoitov > wrote: > > > > On Thu, Mar 7, 2024 at 9:42 AM Miguel Ojeda > > wrote: > > > > > > Hi arm64/bpf/pci, > > > > > > In today's next-20240307 with a defconfig LLVM=1 I am seeing [1] under > > > QEMU virt, i.e. from > > > https://lore.kernel.org/all/20240305030516.41519-2-alexei.starovoitov@gmail.com/ > > > applied to the bpf-next tree. > > > > > > Cheers, > > > Miguel > > > > > > [1] > > > > > > [ 0.425177] pci-host-generic 4010000000.pcie: host bridge > > > /pcie@10000000 ranges: > > > [ 0.425886] pci-host-generic 4010000000.pcie: IO > > > 0x003eff0000..0x003effffff -> 0x0000000000 > > > [ 0.426534] pci-host-generic 4010000000.pcie: MEM > > > 0x0010000000..0x003efeffff -> 0x0010000000 > > > [ 0.426764] pci-host-generic 4010000000.pcie: MEM > > > 0x8000000000..0xffffffffff -> 0x8000000000 > > > [ 0.427324] ------------[ cut here ]------------ > > > [ 0.427456] vm_area at addr ffffffffc0800000 is not marked as VM_IOREMAP > > > [ 0.427944] WARNING: CPU: 0 PID: 1 at mm/vmalloc.c:315 > > > ioremap_page_range+0x25c/0x2bc > > > > Great. Thanks for flagging. > > Looks like this check found some misuse of ioremap_page_range. > > > > Note that without marking the address range as VM_IOREMAP > > the vread_iter() will be bulk reading over IO and might > > cause hard hangs and what not. > > pci drivers need to mark their range as VM_IOREMAP. > > That was the reason for the warning. > > > > I'll try to figure out which piece of code missed passing > > VM_IOREMAP into vm_area. > > I'm not familiar with pci, so help is greatly appreciated. > > Ok. I think I figured it out. > Please try the attached patch. I tested the attached patch on Qcom SDM845 based dev board and it fixes the issue. So, Tested-by: Manivannan Sadhasivam On a side note, PCI is the only driver making use of this API. If I'm making such an API change, I would've made sure that the callers are unaffected by the change. - Mani -- மணிவண்ணன் சதாசிவம்