From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD351C54798 for ; Thu, 7 Mar 2024 19:06:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 699CF6B0274; Thu, 7 Mar 2024 14:06:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 64A176B0276; Thu, 7 Mar 2024 14:06:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 511BB6B0277; Thu, 7 Mar 2024 14:06:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3DFA56B0274 for ; Thu, 7 Mar 2024 14:06:02 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EDCBBC11DB for ; Thu, 7 Mar 2024 19:06:01 +0000 (UTC) X-FDA: 81871172922.28.AD1D855 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 2740B1C001D for ; Thu, 7 Mar 2024 19:05:59 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BUzIkxFa; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of longman@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=longman@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709838360; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X7P8UeQpeEQEOjxcmff4v9+LPAL41neHMZQcXXo7jRE=; b=lSr788ee/vwDCIDz2G6SY/bwv5+OwtFvbZIhnResFUrNCCJNnpU2Pff6Bh/Ra04tujAljw 68BALdPXJvDh3d6r6Pseez6Cn1s/HVtUbTrkHU5Iu419Eu6LZMDuErDdCR3zSq+dwC6mVV lS3A8oWZuUj2oSS3D7rAIXH65GGZPIY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BUzIkxFa; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of longman@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=longman@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709838360; a=rsa-sha256; cv=none; b=nnJdr8/XdeLQSueSd8CWxrutWBntnrfIiNLZklD2mhRNFVNBYlIsDBA9j1KjXwsGSp81B3 9cjaI5O4U7sgFzytnrtvSCYH1miyj2HFWjMjjLZyDbpogXg844iW7XfJqDclmEzbAOGGmk s0yeW8Dyl0nkzm9ZKZecocwJKdu69lw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709838359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X7P8UeQpeEQEOjxcmff4v9+LPAL41neHMZQcXXo7jRE=; b=BUzIkxFa3KYWd4cup0utmzFrChTGuIHByq3/V7sK/aBHXTT4EyqguwrSjzewu54xMI7eZl MZSOdC6m1owpQE0JdpFCd/Io2mrbTs1M89pN1sUH1YkD1dIlKKfLBTUH7SMPzS0yRBuPQA YB4RI5me/DbH2f41c22sTz2B31j1Mls= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-341-Xf1BggqGN1iqaD3Ogzjweg-1; Thu, 07 Mar 2024 14:05:56 -0500 X-MC-Unique: Xf1BggqGN1iqaD3Ogzjweg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AD95B1C00B8B; Thu, 7 Mar 2024 19:05:55 +0000 (UTC) Received: from llong.com (unknown [10.22.17.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2CF7C2166AF0; Thu, 7 Mar 2024 19:05:55 +0000 (UTC) From: Waiman Long To: Catalin Marinas , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Waiman Long Subject: [PATCH 1/2] mm/kmemleak: Compact kmemleak_object further Date: Thu, 7 Mar 2024 14:05:47 -0500 Message-Id: <20240307190548.963626-2-longman@redhat.com> In-Reply-To: <20240307190548.963626-1-longman@redhat.com> References: <20240307190548.963626-1-longman@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Rspamd-Queue-Id: 2740B1C001D X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: tskwjm6fusus954urymyi1pb3j76t5d9 X-HE-Tag: 1709838359-577938 X-HE-Meta: U2FsdGVkX19ICvsQPiEbyvZWLhoue1GhGe6HcPJ1sCn8twrqKfo7l0MLrBx98Lt75sljV8SWW7To7b2cINNfSnkv5HAJdQkT74EB3bUKYDO1r6031qKs88gnKsgv8RnsRM1ruCatUzBYxb4BFLeBZUOM/yS8u+RNq+Kt29Jv+EWOHhzZRCWMKdcs6cKvY5xN7aoDJi3hnnkqh70hse8IKRNeNGfgOcJboAvzYzwSbusjMCMm6wW4O4+mD12gpTzkSfG7v7YDBnIZgQvshRMD5qJCb/VMUXjBlKpcD1OoKTbCDl8AZRxEU6BLAglqSe3Usx1AlRC5o+xr615RTSmnv8z+h0kVm0sAJvdeLOGMtJrVtNOYWplR+Kia6ICmozH5jRcQmjSwoxBUu9HZXdoryBS7LOZC2+7b2GIO6z8PmdRSuZ7T0cFTltPfehJ7niMzB9vO6r6wojYhzowmjsxieVc0gENZNHNZQirh0ahYHwAePQBnTsukZqe+zUlB6baqUklQPvHi8BMVGszQoCL52rb6JTZLyyiAtABuvJ9gNJ5aWeqZYOUY6NgmTisJ1boYTUnca6TwQP8qjfTydtW04HLp8gkx4lchxrT3qFN1FSdI+4nk7UUcAH+8CpBzcmTLjAjeIk3y9roPgWvbVyAMH7yeqJ8bnKVtQlFE+eT/B+k9NKO7f4P9B8anRO7alJGNu1ucpNFRwA6Q8a+6fVrGg8F4lssbQCluKqCdunMHtUX8p+VMMrkSMrjQs2v+6dmYUiN+QDNraHn5jpXxb+JYPVxAYULnzBXCB6jk59+GAK8QW5yzyUxLQ/JMNAKWPwXDUa6RUYmv1ORy1rLIbDd+2yMgBAo9eQtQOHRKbkqaOUpYjpMto5cQsOI9aj9UxTCiH0BVzPTkaZtJykXahaSb4tTSwU1qTP2GydLqnBHjuLfvWoR5G5sQubz3u68tO7Cn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: With commit 56a61617dd22 ("mm: use stack_depot for recording kmemleak's backtrace"), the size of kmemleak_object has been reduced by 128 bytes for 64-bit arches. The replacement "depot_stack_handle_t trace_handle" is actually just 4 bytes long leaving a hole of 4 bytes. By moving up trace_handle to another existing 4-byte hold, we can save 8 more bytes from kmemleak_object reducing its overall size from 248 to 240 bytes. Signed-off-by: Waiman Long --- mm/kmemleak.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/kmemleak.c b/mm/kmemleak.c index 4f58f6170cdf..0114a694e520 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c @@ -158,9 +158,9 @@ struct kmemleak_object { int count; /* checksum for detecting modified objects */ u32 checksum; + depot_stack_handle_t trace_handle; /* memory ranges to be scanned inside an object (empty for all) */ struct hlist_head area_list; - depot_stack_handle_t trace_handle; unsigned long jiffies; /* creation timestamp */ pid_t pid; /* pid of the current task */ char comm[TASK_COMM_LEN]; /* executable name */ -- 2.39.3