From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 998C5C54E49 for ; Thu, 7 Mar 2024 08:09:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17AA26B011E; Thu, 7 Mar 2024 03:09:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 103C96B0120; Thu, 7 Mar 2024 03:09:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBF6E6B0121; Thu, 7 Mar 2024 03:09:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D66B46B011E for ; Thu, 7 Mar 2024 03:09:04 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5D696C0C0C for ; Thu, 7 Mar 2024 08:09:04 +0000 (UTC) X-FDA: 81869517408.17.8E76DBA Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by imf11.hostedemail.com (Postfix) with ESMTP id 1987C4001B for ; Thu, 7 Mar 2024 08:09:00 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JgVL3TsE; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf11.hostedemail.com: domain of lkp@intel.com designates 192.198.163.10 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709798942; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+tcI1dSxM/CRN3e2gpHiKL/gy+hKPypxa5AbC5bSO7Y=; b=k30MrkL+vpcaEaO90ZUcJRG1iSnnrlgweCEilrLilyq0XkwmaDroql8eWguWU+RK/t80d/ SNfCY2U0S/ldo6todSWeC1/tNKQOTwBDqH76EQnZ+TFwTRa8h29LfxVs36IcqCTobIdmHL 4WsaAy7SsfD52p50sq7QpTpFYbz1c0w= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JgVL3TsE; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf11.hostedemail.com: domain of lkp@intel.com designates 192.198.163.10 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709798942; a=rsa-sha256; cv=none; b=YpuoIt/5r9/LsS7z5yehxybXqdxg362SI/trOWd9plCSZSjA7VeoP1gV04U8jiCzfzzbuw XXOqLwLvjd1GA7fZ3m2cUM+yTi6tBs7HNUCcUhSmRSWz0eKjrQRzt7K0BOf4UNFzhx5Shp RTNVJDh/+/3Gqw5OU4Rnt7n+IOzy7sM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709798942; x=1741334942; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HVF1QL6dIrEmmMOhlW6bZs0Fosep5KDcBrH9OkjV5KQ=; b=JgVL3TsEf2sc5BR0o/eTqjMEY5ihxpO3BPWwtbkDNdWHdA+i2kaU+FyY OSH5CqfQVJ2/8aJ+HRkyupm3C3PC/QB0KqmzkMfoV3tkTX8tD17CyhvSB KogvFCmKvIvlsyRKorEgjvYPYx/D4sFI/6g/tw/vjWCnERUVli8Bh6a6r JsvoCGPhGJMHxlOI/PVeDT1VHjoFnbksnOyEL3h3UGRrSUe2ThL3Ex5IO BhSCBKTnnM4CHn9SQG9gDqkVxZ4otSlxXa3NVCdU88AV+xHND6RVAfErc Noaw8jHdzntyhpVlDG71qdKf74E5bmZPQ+3BbuHdPpv2eemtZZhcaBQry Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11005"; a="15863029" X-IronPort-AV: E=Sophos;i="6.06,210,1705392000"; d="scan'208";a="15863029" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2024 00:07:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,210,1705392000"; d="scan'208";a="41012691" Received: from lkp-server01.sh.intel.com (HELO b21307750695) ([10.239.97.150]) by fmviesa001.fm.intel.com with ESMTP; 07 Mar 2024 00:07:50 -0800 Received: from kbuild by b21307750695 with local (Exim 4.96) (envelope-from ) id 1ri8n5-0004yj-2O; Thu, 07 Mar 2024 08:07:47 +0000 Date: Thu, 7 Mar 2024 16:07:09 +0800 From: kernel test robot To: Li Zhijian , linux-kernel@vger.kernel.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, y-goto@fujitsu.com, Alison Schofield , Andrew Morton , Linux Memory Management List , Baoquan He , Borislav Petkov , Dan Williams , Dave Hansen , Dave Jiang , Greg Kroah-Hartman , hpa@zytor.com, Ingo Molnar , Ira Weiny , Thomas Gleixner , Vishal Verma , linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev, x86@kernel.org, kexec@lists.infradead.org, Li Zhijian Subject: Re: [PATCH v3 3/7] nvdimm: pmem: assign a parent resource for vmemmap region for the fsdax Message-ID: <202403071558.83GY9NwT-lkp@intel.com> References: <20240306102846.1020868-4-lizhijian@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240306102846.1020868-4-lizhijian@fujitsu.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 1987C4001B X-Stat-Signature: g74b9wrqru768qpw93jr4et7xkotdxqt X-Rspam-User: X-HE-Tag: 1709798940-98677 X-HE-Meta: U2FsdGVkX19qC2GJcZtIe0c1F4ku8NBNV77u3WweZ5vXAlZGI/dry6XxN1lQdlGYbS/9x1O81iJwrtUFsoy9x0JVV60EM+KOG8EXDoaX8bhbFnys0C9HD9I7yuOijOK4f2zf/gx888sZinTmqYCCry47JrbyF/ovu3kqzg8lgcC8uRZepbqn1RYSd9U8BoGBD3/+iJAWgF0WMtF8oClJeZgoRxR3sbM832AmKGkMK1a01F0kZOgV3QurHWVJiy9GYaiuHFfSf8tTwZSF4gXMiaLJ1fSlRERhi4RVaoRWCHToHW9LgVsthJdNnmVcTmZDc2ryXVpPkEoiXs7yUUf1d/xdO741TVIyleyyVH3cBG4LWrQ0PoeMZq1u2gXmXdApSjWVH72ll5mgiJXFHfWp/egqlYEFBwR86sRnID2cJD83+4puLKeRzNiwJNiIFIgB8i4iDNKw+Z64cQydtS9aGT/8gJgM/gSVHU2BYZusxs1ejJh6V4ZNJwkpmYfcavFcowvtsE7eo80Mnen+BvmBxQR/hovhJXEPOJb0J7CJA8BJadiUx/Gg9/VmIdb0YL51iTK+6OjZmjzMxMgI4LW+InDGGdG1yLIEvuEffXgU3rsGvL1ZvuJUBdhbMljfGXpGURP3ir6EBhV9gbtGw+eCMCchNBatK44piWuT7HZvWJ1/gw5cYUIrY8x+TcUNdCZydjpE01FGlbxu34rrGe+QN91tDiqsPIHdRvFdJNSahxdbP3UTJX47IsRtzA3cBYDRkgjHgKGbAmnxpjeyLECoQT2EpdxG3zEmouIQ5TP2qy7DBWmZJOKjv6Y4lRHvaZEcGhkuYrd4yH17ZQJ6SLeuZfGjrfTqpiOh0Q2KX9/oGQ267SHH1Cp6iPbwQtu1R+b49LTWmR8m6mG26JfEHH0VG0PHtIsu3tcH05Elz7n+fNBOjGXEurRcEgPz1Hf0ppMqOE0sD0ADKpJoBC0+AgH lEQ85YIV NgfRHk1spIv8EFwUVMsXujEswAlLAyaTx+UGtRvq5V1WQkMNxDZ/yjf6SYFcUGvZpDT/qaNop0qKGtHAUsorWA9khFGDZFmyGYZwpY8hre8Ycm9SIjY43C0krs7sxKtBZJC78VO4zaLQnzxvVUtk1hxoDuHJZHO+8dA3clXSRXxBE0v0/286uCl2yN1XaDlmBZyPH0jkaG6Vh+jweEoVh23whGcucVjQfR52zew2zJW8FChbHJvRjRcMQ+U5AtxZC/air9FOYM0nRN3UacBCHPO66LshZfzqc+2YHFcNaYOEE1b2G8iZPw9SGo+B9HfJDxRQXB2to2NnQwDWoJOkChNNsinMbWz9bU26g1UR5BqFRWHzMpOQ4kUSVxtwbP6qfRWUFZ9DWXeKgwUw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Li, kernel test robot noticed the following build errors: [auto build test ERROR on nvdimm/libnvdimm-for-next] [also build test ERROR on tip/x86/core linus/master v6.8-rc7] [cannot apply to akpm-mm/mm-everything nvdimm/dax-misc next-20240306] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Li-Zhijian/mm-memremap-register-unregister-altmap-region-to-a-separate-resource/20240306-183118 base: https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git libnvdimm-for-next patch link: https://lore.kernel.org/r/20240306102846.1020868-4-lizhijian%40fujitsu.com patch subject: [PATCH v3 3/7] nvdimm: pmem: assign a parent resource for vmemmap region for the fsdax config: riscv-defconfig (https://download.01.org/0day-ci/archive/20240307/202403071558.83GY9NwT-lkp@intel.com/config) compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 325f51237252e6dab8e4e1ea1fa7acbb4faee1cd) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240307/202403071558.83GY9NwT-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202403071558.83GY9NwT-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from drivers/nvdimm/pmem.c:10: In file included from include/linux/blkdev.h:9: In file included from include/linux/blk_types.h:10: In file included from include/linux/bvec.h:10: In file included from include/linux/highmem.h:8: In file included from include/linux/cacheflush.h:5: In file included from arch/riscv/include/asm/cacheflush.h:9: In file included from include/linux/mm.h:2188: include/linux/vmstat.h:522:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 522 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ >> drivers/nvdimm/pmem.c:501:2: error: call to undeclared function 'pgmap_parent_resource'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 501 | pgmap_parent_resource(&pmem->pgmap, parent); | ^ 1 warning and 1 error generated. vim +/pgmap_parent_resource +501 drivers/nvdimm/pmem.c 448 449 static int pmem_attach_disk(struct device *dev, 450 struct nd_namespace_common *ndns) 451 { 452 struct nd_namespace_io *nsio = to_nd_namespace_io(&ndns->dev); 453 struct nd_region *nd_region = to_nd_region(dev->parent); 454 int nid = dev_to_node(dev), fua; 455 struct resource *res = &nsio->res, *parent; 456 struct range bb_range; 457 struct nd_pfn *nd_pfn = NULL; 458 struct dax_device *dax_dev; 459 struct nd_pfn_sb *pfn_sb; 460 struct pmem_device *pmem; 461 struct request_queue *q; 462 struct gendisk *disk; 463 void *addr; 464 int rc; 465 466 pmem = devm_kzalloc(dev, sizeof(*pmem), GFP_KERNEL); 467 if (!pmem) 468 return -ENOMEM; 469 470 rc = devm_namespace_enable(dev, ndns, nd_info_block_reserve()); 471 if (rc) 472 return rc; 473 474 /* while nsio_rw_bytes is active, parse a pfn info block if present */ 475 if (is_nd_pfn(dev)) { 476 nd_pfn = to_nd_pfn(dev); 477 rc = nvdimm_setup_pfn(nd_pfn, &pmem->pgmap); 478 if (rc) 479 return rc; 480 } 481 482 /* we're attaching a block device, disable raw namespace access */ 483 devm_namespace_disable(dev, ndns); 484 485 dev_set_drvdata(dev, pmem); 486 pmem->phys_addr = res->start; 487 pmem->size = resource_size(res); 488 fua = nvdimm_has_flush(nd_region); 489 if (!IS_ENABLED(CONFIG_ARCH_HAS_UACCESS_FLUSHCACHE) || fua < 0) { 490 dev_warn(dev, "unable to guarantee persistence of writes\n"); 491 fua = 0; 492 } 493 494 parent = devm_request_mem_region(dev, res->start, resource_size(res), 495 dev_name(&ndns->dev)); 496 if (!res) { 497 dev_warn(dev, "could not reserve region %pR\n", res); 498 return -EBUSY; 499 } 500 > 501 pgmap_parent_resource(&pmem->pgmap, parent); 502 503 disk = blk_alloc_disk(nid); 504 if (!disk) 505 return -ENOMEM; 506 q = disk->queue; 507 508 pmem->disk = disk; 509 pmem->pgmap.owner = pmem; 510 pmem->pfn_flags = PFN_DEV; 511 if (is_nd_pfn(dev)) { 512 pmem->pgmap.type = MEMORY_DEVICE_FS_DAX; 513 pmem->pgmap.ops = &fsdax_pagemap_ops; 514 addr = devm_memremap_pages(dev, &pmem->pgmap); 515 pfn_sb = nd_pfn->pfn_sb; 516 pmem->data_offset = le64_to_cpu(pfn_sb->dataoff); 517 pmem->pfn_pad = resource_size(res) - 518 range_len(&pmem->pgmap.range); 519 pmem->pfn_flags |= PFN_MAP; 520 bb_range = pmem->pgmap.range; 521 bb_range.start += pmem->data_offset; 522 } else if (pmem_should_map_pages(dev)) { 523 pmem->pgmap.range.start = res->start; 524 pmem->pgmap.range.end = res->end; 525 pmem->pgmap.nr_range = 1; 526 pmem->pgmap.type = MEMORY_DEVICE_FS_DAX; 527 pmem->pgmap.ops = &fsdax_pagemap_ops; 528 addr = devm_memremap_pages(dev, &pmem->pgmap); 529 pmem->pfn_flags |= PFN_MAP; 530 bb_range = pmem->pgmap.range; 531 } else { 532 addr = devm_memremap(dev, pmem->phys_addr, 533 pmem->size, ARCH_MEMREMAP_PMEM); 534 bb_range.start = res->start; 535 bb_range.end = res->end; 536 } 537 538 if (IS_ERR(addr)) { 539 rc = PTR_ERR(addr); 540 goto out; 541 } 542 pmem->virt_addr = addr; 543 544 blk_queue_write_cache(q, true, fua); 545 blk_queue_physical_block_size(q, PAGE_SIZE); 546 blk_queue_logical_block_size(q, pmem_sector_size(ndns)); 547 blk_queue_max_hw_sectors(q, UINT_MAX); 548 blk_queue_flag_set(QUEUE_FLAG_NONROT, q); 549 blk_queue_flag_set(QUEUE_FLAG_SYNCHRONOUS, q); 550 if (pmem->pfn_flags & PFN_MAP) 551 blk_queue_flag_set(QUEUE_FLAG_DAX, q); 552 553 disk->fops = &pmem_fops; 554 disk->private_data = pmem; 555 nvdimm_namespace_disk_name(ndns, disk->disk_name); 556 set_capacity(disk, (pmem->size - pmem->pfn_pad - pmem->data_offset) 557 / 512); 558 if (devm_init_badblocks(dev, &pmem->bb)) 559 return -ENOMEM; 560 nvdimm_badblocks_populate(nd_region, &pmem->bb, &bb_range); 561 disk->bb = &pmem->bb; 562 563 dax_dev = alloc_dax(pmem, &pmem_dax_ops); 564 if (IS_ERR(dax_dev)) { 565 rc = PTR_ERR(dax_dev); 566 goto out; 567 } 568 set_dax_nocache(dax_dev); 569 set_dax_nomc(dax_dev); 570 if (is_nvdimm_sync(nd_region)) 571 set_dax_synchronous(dax_dev); 572 rc = dax_add_host(dax_dev, disk); 573 if (rc) 574 goto out_cleanup_dax; 575 dax_write_cache(dax_dev, nvdimm_has_cache(nd_region)); 576 pmem->dax_dev = dax_dev; 577 578 rc = device_add_disk(dev, disk, pmem_attribute_groups); 579 if (rc) 580 goto out_remove_host; 581 if (devm_add_action_or_reset(dev, pmem_release_disk, pmem)) 582 return -ENOMEM; 583 584 nvdimm_check_and_set_ro(disk); 585 586 pmem->bb_state = sysfs_get_dirent(disk_to_dev(disk)->kobj.sd, 587 "badblocks"); 588 if (!pmem->bb_state) 589 dev_warn(dev, "'badblocks' notification disabled\n"); 590 return 0; 591 592 out_remove_host: 593 dax_remove_host(pmem->disk); 594 out_cleanup_dax: 595 kill_dax(pmem->dax_dev); 596 put_dax(pmem->dax_dev); 597 out: 598 put_disk(pmem->disk); 599 return rc; 600 } 601 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki