From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F520C54798 for ; Thu, 7 Mar 2024 20:02:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5FEC6B028B; Thu, 7 Mar 2024 15:02:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D121D6B028C; Thu, 7 Mar 2024 15:02:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD78D6B028D; Thu, 7 Mar 2024 15:02:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AF1606B028B for ; Thu, 7 Mar 2024 15:02:29 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 82EB3A198C for ; Thu, 7 Mar 2024 20:02:29 +0000 (UTC) X-FDA: 81871315218.16.318A08C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id C51EC10001A for ; Thu, 7 Mar 2024 20:02:26 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=wnsVQwjI; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709841747; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L17XNvtm+LiYlPtwYfs/WUz7kHzwagvb9jk0vVfGjME=; b=8ccJroNr3YWeS/PC7lAW60g+YKzMMCFoHwrPSbb6I7VCSh7KgTg+9GD7E2BEGlyMnW/Gye 0wYBEOGrlX4JFu1P/LlumZSZkP+mDwsUHj5pEx629y31+NxUgFEeX04TRDdce3iXQyo9Fr P99f5NFxCUonOyf9LML4NqEv0P3hPDg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=wnsVQwjI; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709841747; a=rsa-sha256; cv=none; b=ttLXXFMJ7MaaJOA62dfKylKEPm+7JsfBpYeoigKl1Dfm77icYBNsOkP2RkNuC7RdDTloNY QbZHfUtXEYjWufdfffcMuh+S4I8lqQWq/aqY9ugDqfli8dZVIPF4fDEjOx8urj/eYym1/J mpr+ZhPRldzJv5A8M8QLY/COwEIHQJ8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 08615611F5; Thu, 7 Mar 2024 20:02:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B6AFC433C7; Thu, 7 Mar 2024 20:02:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1709841745; bh=QbobZIm6vzGL9mxcMfH8aT0PgqTNhtb1r9nMruHiV+s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=wnsVQwjISTY26rsce3Mp51KQ9qVjmObeUi7hVcXKuWEu+cPGKv153v4mf+bBGr7qd knIISBKOVKQxMviHSCqE1UoUndxCJqzPDBfx7h3VuAMpmubswxI0u58JUi8tWPg1o2 mGb337V5oD3l6TjJNsWMcdYue0YK+Kis9Rht+Nlo= Date: Thu, 7 Mar 2024 12:02:24 -0800 From: Andrew Morton To: Zi Yan Cc: Zi Yan , linux-mm@kvack.org, Dan Carpenter , "Pankaj Raghav (Samsung)" , "Matthew Wilcox (Oracle)" , David Hildenbrand , Yang Shi , Yu Zhao , "Kirill A . Shutemov" , Ryan Roberts , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm/huge_memory: check new folio order when split a folio Message-Id: <20240307120224.0e627784a13cff1121048ae4@linux-foundation.org> In-Reply-To: <20240307181854.138928-1-zi.yan@sent.com> References: <20240307181854.138928-1-zi.yan@sent.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C51EC10001A X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: eb84g4mq3h7hf71xicqiq8janjbb76wt X-HE-Tag: 1709841746-70382 X-HE-Meta: U2FsdGVkX18+v95JoBb4sYxs9F8Jj9QIwgpRqj7sl9Z2RwseM16xK5Qz74E8u9XofMBAl4YJAPuUvG5LugvVbvBs36eLLzM4bxVw7TRNZ4iF/eTp5El9pzEFM2Mx5BF/Q7lPp4yd0kMFftt55PP0Y2dIW2A46tMwLjz7PtGkemuUBA8BaXqWPtG99t6Ypj2/5RFtt9zxSWtMAFaEDGKPsyoKabRwFr+YjwsdKsu+bvfKl+55nosJzxCUJq2BCx33Zw641CEEDFi+M4RGu2BPVTIRyJyR1UHXgn1fLeTu5InGST3bEVjBdTKBQ79tkZTsFxFyCp5m/4vl+jVkxncw7blVL7sRW6CwuAfgW1MOgtMCAIKGNG723hbWRe3isFn1JORX8bw1iDGOcmUTyQhENM4/BN332GL6dy/SI8I5VhBfVIsJIIJqg1rNA1313zjvtK6VD/Cd2WVVEecYkaKyrkuEYx2Ue04nB4GG9GRNzn3/AJVddaaekfSx7F0wvgxfVcpfhlpN3hsZdUxHPehR5NYDRfe06XVX7pcRwD4LeTdKa2xSPR/01MxakgGhHi7IDrP0fj/MqQDCMnaMhNTdAvYrpGV4s65jNBYqG13uZY8y4mSSxdXWpjrdBrGfm9RbVGzgUp1gRpGTH7h25jpZWxT7wTdjmLx7tk4GvYUx327nYOlazld1xV8Rd/cjLbahuAq2Wnx80kEjXoLj2EOLZPPCryxeCSe400r13TLKzDa5RRTolmX5kEIOzsGczHJR3Pwc7aYLfFQDZrLBUkI3szlJ4JMbaSLYKOqhMX04ZNAsjj37B+xCuYQbnLrGbU5TMHk/UJ1UpZcGLZXAV/BXbIHL/GBOBXuFOojlkCTIA/M+pjx+p4KgExJ5qDTf+3Tc1CKU5gz4sP11iNrqeXpFbhtjGWodhcT+mVouj8HVS2z948hq9a2xvD7EmjvkYV/ZBjCaUI6w/tYYwy/kRcw Bbb7c443 pRuQ7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 7 Mar 2024 13:18:53 -0500 Zi Yan wrote: > From: Zi Yan > > A folio can only be split into lower orders. Check new_order to make sure > it is smaller than input folio order. It isn't clear what's being fixed here. Presumably something is passing in such folios, but what and where and why and what are the effects? Might it be that these folios are being caused by the debugfs interface? Or something else? So I'll add it, but I do think more information and context would improve the patch, please. Suitable Reported-by:, Closes: and Link: tags, perhaps.