From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60347C5475B for ; Wed, 6 Mar 2024 21:59:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5B726B0098; Wed, 6 Mar 2024 16:59:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E0C186B0099; Wed, 6 Mar 2024 16:59:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFB356B009A; Wed, 6 Mar 2024 16:59:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C15626B0098 for ; Wed, 6 Mar 2024 16:59:32 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8F7D6161019 for ; Wed, 6 Mar 2024 21:59:32 +0000 (UTC) X-FDA: 81867981384.20.89041A5 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf24.hostedemail.com (Postfix) with ESMTP id 9A6F9180020 for ; Wed, 6 Mar 2024 21:59:30 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=0hhtvdkL; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709762371; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Qm4M6HCTt+I/Girf60e2bQsEyrN+USbl/voPXK0jos8=; b=OAL7n/TVNCCmXhVD/9qmw0zWP6I1G5dp9gITQpkTmMVUdbRZHS0BGjSJS2YFu1UfNrmtXi hd+XBZdJ47TnXUN73vSv+UABSLaNLvLEXFLb2dYt7jMbNKGwzrNXSiU4vZk6eVdbq8LRyy zjmnoJvc0aEqT8cPZvt7VdmM/TB9ukg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=0hhtvdkL; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709762371; a=rsa-sha256; cv=none; b=h7IxLZtICEyvkBkPNGviGMDSft1HyT0fjKnJAk9S1MjjxuPW3Hils1bsyN49ITe+4FjA/v ZXmUjXTaQ7ixnzEyRi3jdE1o0a56E6Ky1tTRU5OoHNRfWqzgSQjh2m1UT1Kvf4WnBPeI3+ 5JZ8ANbtVL2rgiLHnriwMIx1oNqIF8I= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id DC8BCCE21B7; Wed, 6 Mar 2024 21:59:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09943C433C7; Wed, 6 Mar 2024 21:59:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1709762366; bh=gp2xCOAKEjA82VU643tEokSk/uKz8A/M87cqI/x72yw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0hhtvdkLzmn9XKE8ZvJaOm8Mj8oF42o9gkfFv7pH+L/Zh6Om5z4b19JQoiaqbvQGI 4lKrwBQIQKjaA9Lsp+dWhD0P7Tw9agNiNGGAeZyIdllXjaMEm1BOrgBs3PU/R9F/um SwtjaBRaIVc/IA2wK00MSL1pMwEJ7be0TNBc8Fmw= Date: Wed, 6 Mar 2024 13:59:25 -0800 From: Andrew Morton To: Matthew Wilcox Cc: linux-mm@kvack.org, "Borah, Chaitanya Kumar" Subject: Re: [PATCH] mm: Fix list corruption in put_pages_list Message-Id: <20240306135925.419a2320bfe98de9526b9e50@linux-foundation.org> In-Reply-To: References: <20240306212749.1823380-1-willy@infradead.org> <20240306134557.e14fad1abdf7a537e5d287d5@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: sszjws4fs4b8mwjooy5rejretk78mpmx X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9A6F9180020 X-HE-Tag: 1709762370-873853 X-HE-Meta: U2FsdGVkX1/L4zjQMpMWkiS5duEXpuvsFZk1iUlkSQl6E30j80cFDMuY4wcHGBw7IuTb4rtv+yUcs0iqy7fklpnwT6rjB9duGtW9qXYr0PjHRq+xtlP8E0rLKXqw66QJRzBCXfxiTueT+NRUJPibZz3FeKTP2WzGt5tmShEVj9RF16liTGSQo1RPkgpDyar6OrJLmiN4vwtlkyPf81ng/5VQdfUmi86mYzfdDqkKmLTHeU1mKZdeR4M5skyn+7o7jraZv29TnxgYyfi/j5gOnffQCMWOvHxINMWDenfkHb8keYreCC+2yR2aZ0sS5nBt+yFXmKRmDaikmg4iypiblwRMsnkFrIfZaDjhMJi+JLUAmvLpA11nS9OxrE5CYnHbFuKW6oPMXe4lNj6Psnbx+uewD+8vxAydWeVtcFCfwc8funbIeeJOG6teNWFgM/Y1RLgvG8U9ooWw69uK+rEwe+xmRYkmQrTDuvkZH59MakymtnTs01CkRe/hdw+2b4DFUvNw17LFQlOzAXyH8aUCYDgJ3U/Np/DFMGnrpyYa6XYxHwqvKhXd6nBvHiafGbF5bgbuTb20hlfqHRwm4B+rOfem0Dk0PmtuP7sQNkOJuVBBp97q+Ct31g5WhhE79Ahdk8IVjzZuOLwAwrl6OyI4CmRllONrQELnbayIPMBczAcSN+biqW0Fz8BOEHrcxlN+7DNPPZqbFGBGTwVP27zoUBlVw3AmvVx/MJ+DlAasqypzl54mZM1bJwNkvMhtWxXlwiUIrbu0TucGKbsJOT21Kp28Yg6/DO5w6ubHs/ITY+93nwiMlDUVsQ5koUmZZ8agCa8OwztvP3is+trXDBXNrI6TBE2A6Xmx9PBtzBLMMuAwGA5jINGZRyr/hQvRewIOh9GDG0q1DREj6ZLCdefCMImNC7nVoKUrAWlPxXwah2UY6J2WCZ+PZFYkTgwS5wZcrQRseIhYxRqlKt2nRro UJaF124x Yc0W9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 6 Mar 2024 21:47:35 +0000 Matthew Wilcox wrote: > On Wed, Mar 06, 2024 at 01:45:57PM -0800, Andrew Morton wrote: > > On Wed, 6 Mar 2024 21:27:30 +0000 "Matthew Wilcox (Oracle)" wrote: > > > > > My recent change to put_pages_list() dereferences folio->lru.next after > > > returning the folio to the page allocator. Usually this is now on the > > > pcp list with other free folios, so we try to free an already-free > > > folio. This only happens with lists that have more than 15 entries, so > > > it wasn't immediately discovered. Revert to using list_for_each_safe() > > > so we dereference lru.next before disposing of the folio. > > > > > > Reported-by: "Borah, Chaitanya Kumar" > > > > I'm unable to find the bug report on linux-mm. Help please? > > https://lore.kernel.org/intel-gfx/SJ1PR11MB61292145F3B79DA58ADDDA63B9232@SJ1PR11MB6129.namprd11.prod.outlook.com/ > > (wasn't cc'd to linux-mm) Ah, OK, thanks. I'll add that as a Closes: thingy.