From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66967C54798 for ; Tue, 5 Mar 2024 22:33:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C66ED6B0085; Tue, 5 Mar 2024 17:33:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C15616B0088; Tue, 5 Mar 2024 17:33:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B04D36B0089; Tue, 5 Mar 2024 17:33:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A10EE6B0085 for ; Tue, 5 Mar 2024 17:33:06 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 67985140D76 for ; Tue, 5 Mar 2024 22:33:06 +0000 (UTC) X-FDA: 81864437172.23.6596C68 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf05.hostedemail.com (Postfix) with ESMTP id 75FDC10001A for ; Tue, 5 Mar 2024 22:33:04 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=F91gqYFc; spf=pass (imf05.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709677985; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pez3B/t2FC05KC4aopGjPqL1tD3gms+eKuaE63+NAlY=; b=s7OH9r6MYxlSJvqFa8lkC30KLSJcmI7q4EzSMWEZMIIc9cszPRF2Od7CnohXufTDzjDvEe IpNeMzTIQiNHFyhzVYBI3ppk6kmEYrgdk2K+YSFHXmT9BuVZlnCAtTjmGuY+Mf/2KVvnrY 5NezCZbYcQAR9GHi/3gnTAve61LGN3k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709677985; a=rsa-sha256; cv=none; b=XOg7GiqEQloLQIybjin3ZrSEySqUSgIpgUT22jDDz8RrjNVmqUqoAgSwps1Lo1zZ3G4Cdz K2Cn91zefJnmC3SLybcuS1HxzSiBYU2XFiLJ5yg2lFOrZmmGpCKM6tQEmPy76nRKwC2TZc dQspIyWGN6znsT6uQ1zOyQ5D0yHaMGs= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=F91gqYFc; spf=pass (imf05.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id DADF8CE1CCF; Tue, 5 Mar 2024 22:32:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C58AEC433C7; Tue, 5 Mar 2024 22:32:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1709677979; bh=CR3apIHKxfx8CehRoKh2i7lKMiU0SaLTbaUmyqdA+lU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F91gqYFcbB+NZ1oJATQj2sH0ePOqbqdIR6LjQCUeSfBTk1flslPt6RRMp8EIaJxtn maBCtP8bemrhE7JPXbv4PSpGvkABMYJrhlften9LQsLLzpXMpVpGve3qWrIrF6/Z7/ 8hDwTeFTz4ae5Gg5qeBclkkqt8oJAFHlnbsqU0Rw= Date: Tue, 5 Mar 2024 22:32:56 +0000 From: Greg KH To: David Hildenbrand Cc: Zi Yan , stable@vger.kernel.org, linux-mm@kvack.org, Charan Teja Kalla , "Matthew Wilcox (Oracle)" , Andrew Morton , Huang Ying , Naoya Horiguchi Subject: Re: [PATCH STABLE v6.1.y] mm/migrate: set swap entry values of THP tail pages properly. Message-ID: <2024030527-footrest-cathedral-5e15@gregkh> References: <20240305161313.90954-1-zi.yan@sent.com> <2024030506-quotable-kerosene-6820@gregkh> <0910e8f0-5490-4d08-ac64-da4077a1e703@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0910e8f0-5490-4d08-ac64-da4077a1e703@redhat.com> X-Stat-Signature: 6c5n9s81ecmhkqq3f1bi7gdn9sm3cf3d X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 75FDC10001A X-Rspam-User: X-HE-Tag: 1709677984-718704 X-HE-Meta: U2FsdGVkX1+oq8MJj/+yrWnsbv0umP3xMSegiLiQPgjvOtWKYGErB3jYshUfKHnnzyjO7z2xzAnSEdo5zEVEtOyuMb9f9UaxFBV1LFFi82nDrFsQF7e2dbHssJg0Erbqsfslrz1ctwGwlXVkQjHV8ZdFG9bBhjMBJUd+rX+TOgbT0D56KL6c5rP7IwZbomBWzlPQHAcNnfOJrvWsSrrlj15a04HX9DO2sVmnMy6gV4AWroZQZx5wwR8J6zmoWiL24JB5Wo9LXVHSxe5ShQoef1Qo9Srgr27s43bQ5uMLRsYXDaztjFqbXvvZVMn5OcudpCE0EVVxNZVG5pYLxxUw4wphtRE75+sv+n63SAfsaVMFmiU4xb2HWCvBl73OwtGAiN648cd+p2cSQP75GjzufSWDGoVMkcyFz+qeVLIJ8Zpr8Vw3nfxZBPhNAbRQKWH5sF2Kww8cnI/1rEoHTex3Vzg1hmrvSM2y6pjNnQLHkHNAWewv6710YOsuGQGFu0Zz5/6WFud/gZ9j6PGFMCYVwvkY0sUONVHxvHLBZLT6H0cJkhixzTV3fHaUc5hmNOT8UN5D9wbHpd+b8k1jAfJPOAi/bhAziGjnOmATZY1kZ+uUS66gonrklKWpINsNQm0SzHiC566OukW8BcdmDlqXkmCZuqACMCx3S4O/RpmaCabniPSvOdDLDB2F6eWC111Pme8pc6SeAydGCKKea9vgpXGj1Al66q2MFYBNtHA4gDZ/e7zMl1OhRBnMJ6OIjf3nc8bASxLPSAFtNUYrqvaVOLYhisRRe/j2Lck0TxZAtx4k3UzAqzOviHMze7armEydYAz2hdoUn6n76CVU1Mn5o+VOIph29ORIFKuUQLwQDl0XHDOw/g+uSKa0v9jIakhd9vuztmp1tCgpyBPy3aTmRDILkxXvWuiO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 05, 2024 at 11:09:17PM +0100, David Hildenbrand wrote: > On 05.03.24 23:04, Greg KH wrote: > > On Tue, Mar 05, 2024 at 11:13:13AM -0500, Zi Yan wrote: > > > From: Zi Yan > > > > > > The tail pages in a THP can have swap entry information stored in their > > > private field. When migrating to a new page, all tail pages of the new > > > page need to update ->private to avoid future data corruption. > > > > > > Signed-off-by: Zi Yan > > > --- > > > mm/migrate.c | 6 +++++- > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > What is the git commit id of this change in Linus's tree? > > Unfortunately, we had to do stable-only versions, because the backport > of the "accidental" fix that removes the per-subpage "private" information > would be non-trivial, especially for pre-folio-converison times. > > The accidental fix is > > 07e09c483cbef2a252f75d95670755a0607288f5 None of that is obvious at all here, we need loads of documentation in the changelog text that says all of that please. thanks, greg k-h