From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0E24C54798 for ; Tue, 5 Mar 2024 14:33:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3824C6B0082; Tue, 5 Mar 2024 09:33:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 30B9C6B0085; Tue, 5 Mar 2024 09:33:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 184F26B0087; Tue, 5 Mar 2024 09:33:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 00BB06B0082 for ; Tue, 5 Mar 2024 09:33:14 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C7EE940F3C for ; Tue, 5 Mar 2024 14:33:14 +0000 (UTC) X-FDA: 81863227908.03.7C1A86E Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2052.outbound.protection.outlook.com [40.107.93.52]) by imf24.hostedemail.com (Postfix) with ESMTP id B79E3180028 for ; Tue, 5 Mar 2024 14:33:10 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b="J1BA/WcU"; spf=pass (imf24.hostedemail.com: domain of jgg@nvidia.com designates 40.107.93.52 as permitted sender) smtp.mailfrom=jgg@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709649190; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XjeRnNJXbQlipXi1ZJmRuedKAaTwAjrzBaLKfo5NbRg=; b=d4+pDOL+kZgbs3M1W109juSiefJUy4EUk8Oxx9bq7t95tZWdIzbopXFclZpqzOs+rNxaSU fWFBmh/9wX5ZZPARwoR1y2Kxa5bMoGyQZGITIpKEyiMlMnXT1h5S07em9zPzsvuC6/P0nQ 0HWJxhWq7BVv6zfZ24Lhff2gHPV6Ows= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1709649190; a=rsa-sha256; cv=pass; b=nMJMpVekjJaM2juxQt53mA74Yep9gRxF1ZApuYixLruaQc9FW2avafmttK1GOyXNmKaMco DmkuDMuW/k0sGVKEZCc96nIzq3ncaaWx4LuisqWhR6dcBF9vz5kfZsJ/vVr/2aWegApb+f sY8q3qOsFgHP15aWURQRZPiG4Fmf2+o= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b="J1BA/WcU"; spf=pass (imf24.hostedemail.com: domain of jgg@nvidia.com designates 40.107.93.52 as permitted sender) smtp.mailfrom=jgg@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BEKz1kt2xQfrTUWjKVO6Kb9ejJoEYfqbhCiNBvJYP6TbSI5FHwh4dHSDj/yy3VhIUNIpbNb7VHanegTaVV03HlEXzE0cXcvyz0C1nrMUDfLuJ2on9HEd5SMaST75zyv+VqWuKdHukdaQt93NGKu+9bh7Vl2RR0nD/11/2RuHv8dqFpjLr/cPScCSWzIFNRTGDG3HOe8bbME10FEV0KUigKo9upMLZMP0JJbO/gOvaixpJ48PSaZztdPvhrPk5gQKziYs1R+qHq++uIyE1WIS6jU5N98Zg+vgQjs9QYwEINelGaP0hBWuGdIH5IAFrO+uJux6/JeyOuI9GyAJujtDMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XjeRnNJXbQlipXi1ZJmRuedKAaTwAjrzBaLKfo5NbRg=; b=cTVQciXdmjx81/w0px20u0qKqr3tnhqKwfNI2GrKjWkKDCjKJokj9gWmMn/A7oOuOBhE1iy6SuiZWfCZouhmuTOEA0UPQyUB/jRnHHWIaIlev93Y0gElUtBsOfGqlPmiy0C1+G3yZJDEKB7lnM9H5xPoHfa2lUneM5zIfsbDS3IufZkngAXnYT/hu9BEhZEXfB4c474utp14TcB/g5m0l+ujbFY4viFYwC9YA2QZAsfdZUGYCbFWGcwPKTYkd/7vxWLMqB9ogfJk9qidlF90wRWIHb0IHlJHvqZlg0p2wQqJt4VknbH3d5t4AprOKIaedw0fQzJOncHXfdXFTcnWrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XjeRnNJXbQlipXi1ZJmRuedKAaTwAjrzBaLKfo5NbRg=; b=J1BA/WcUdZuHcBAlq1hrFJzWA27wmW57Sf8woOjWd9P37ErZlrAHblZDoHcF/QDUD+YtdSAMkFzUrUPR1PTT/2nbfeQM/+zU6SQMzax7EaiQ194xYzPXxpePj/GTQD+ihkzcnMII499N9/jPKih+cni1lUAV2ggz4rfSLs/rf7Da89i5mDRu5FAMrS7O6E0qq64t1Fm6FQd6o6kSmjOu3GELyLeNd9lE9ivRt26ncHAJzrxxVnFU/KVyOTmaobZrRRcT4IAe5qIB8XS0mjZIUnas8HW6onEc9buscdcrc2Jir8h/AgIZ0W3Z7HWV0v4WLsothcVkb7AJl0VHdVX/vQ== Received: from DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) by SJ0PR12MB6784.namprd12.prod.outlook.com (2603:10b6:a03:44f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.24; Tue, 5 Mar 2024 14:33:07 +0000 Received: from DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::c33c:18db:c570:33b3]) by DM6PR12MB3849.namprd12.prod.outlook.com ([fe80::c33c:18db:c570:33b3%5]) with mapi id 15.20.7339.035; Tue, 5 Mar 2024 14:33:07 +0000 Date: Tue, 5 Mar 2024 10:33:06 -0400 From: Jason Gunthorpe To: peterx@redhat.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christophe Leroy , x86@kernel.org, "Kirill A . Shutemov" , Yang Shi , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Muchun Song Subject: Re: [PATCH v3 10/10] mm/treewide: Align up pXd_leaf() retval across archs Message-ID: <20240305143306.GZ9179@nvidia.com> References: <20240305043750.93762-1-peterx@redhat.com> <20240305043750.93762-11-peterx@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240305043750.93762-11-peterx@redhat.com> X-ClientProxiedBy: MN2PR07CA0021.namprd07.prod.outlook.com (2603:10b6:208:1a0::31) To DM6PR12MB3849.namprd12.prod.outlook.com (2603:10b6:5:1c7::26) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB3849:EE_|SJ0PR12MB6784:EE_ X-MS-Office365-Filtering-Correlation-Id: f3bd94cc-2118-4432-f03a-08dc3d212cae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AAD/bJwYeTJb6NcXt1+1HP68woKbPHM6SzvHb41WFWg79FhSpvG2Ahy6VBh8WQrD+wy4eILEsvud2TUGNUvkepZYqWM851bG1AYjU6Q6QqStQ3qGMEA6M4emWQywuNH2unhsdJUXD86QlgmnyDbGNzPqYMFtBUzJ8Bd7Q1mB1fH7XKXjOOxqsHvo2P0mUejH+2+PXHDKIZI7PuHA1H5HWYMIWEzj/TvuvY/PJ+Eg1DcBh9C+iIxOzkDaswcoHajZejbx08IPip5mZ5z2Asu9c3zN0lYWYrLWYCAS/2XVY4TitvJm49HZNWcTFhEEbyd4nsImrM/zKofrk1jaGrZHvbULI2MGgFx3vIgrCzqVQkzOHiFhkNT9BWgggK39oRYSeTrtHCd1DAI4W8+xLqPDFR6Zwoc+A78bG52B24giLVzXI64k/nVhi0pZbEbPCNDNEKRtHxsmi/9bvw4d0rIYGehwry2FHFepVFz7QsyAz+vOQbvZvgxHqlk2dPhFtWICvsDqsyboqx+Fg+adafiB0rdZRvoMsxaOb9qRmSVKhWgS4dS2rN09SpoxGLDDeJq1qeoXZRC1Hu//M7pAGF7rCqfM6GFeWFtAQOyqegq7cHp8MuhEeLXqquxskYxWa9Q1I5WbkQp7d2AQ8OE04cd50BQyKzvSYbmKMMEekXGFWK4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB3849.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YcphlCYBpgIEgTSfr0jAKllH/O2GE8k32Ni2IItKezEcothMB+WGHJO7U00C?= =?us-ascii?Q?yvhU4K/4XhYg9VQuRSlsyJCGDyHyrsdbNUnd8Yb56HdbEjO9i9oRvbmCkG+F?= =?us-ascii?Q?3ec/AoAWyss1+X8DkokRE3nm+ZcdguN1PhVWe1xKJ7rHUwYlA6rYiaTDN58V?= =?us-ascii?Q?71xicl1u4RY23Eq7tBWzDW8fnorc49Jq8HWRsRvCmHIoJVJ7GsqlqGq0AuoM?= =?us-ascii?Q?J2Xup8LnoDRxScsA1I1wwHMk2OZfUiz66OArUwi8SJs7WA7Ve9JcWE7shxCU?= =?us-ascii?Q?KpLu2xVWvGO8auYbdVa5DcNGWtX/aU02fcg4T//4Lp4xb7wATqv7J68GmgQ9?= =?us-ascii?Q?BrDrnZESS4S5KPj5dw1Nj+oIwO20oom5gS7HMh212TNGMlQqes+QKYkomwd5?= =?us-ascii?Q?F/1VMChwW9bg+fsZ9gnSnyaRBHHSmt2Snp+rLp8r0LbLSlfhgE7/IyGffCNS?= =?us-ascii?Q?/vFTsLye7aBhJC147wq5DyC19UkMhuZV4OSArpzAb48SnkZZYWZA7DBlZU+Y?= =?us-ascii?Q?+nO6lV/RhdBLc2w/d7SUTUPXX6JXT0kOzToA2Gs8U2o1CII6heevn3MYX8Fu?= =?us-ascii?Q?odwbqk6XmxSjTb7jWMyWqTH3TLjhuj230UISXWoPwv9I48iPLV7fjJtCWGQV?= =?us-ascii?Q?n8Mhk8T7eQ5v6LX5rqjrnDv5EaUZ+ke/08uwQlWR6nOHLo3jCtiiZt/YvOOj?= =?us-ascii?Q?G8fHfFbu2UkLQcxJnYYitLri6GIaZDRh5aiPbxdto+s0JoxdVrDEUAeOZFGs?= =?us-ascii?Q?JfWc6jvb7A1jUCwj4R31ThpduETTXBHN0NxojHR7bTe/pjoWWot57acBJkbx?= =?us-ascii?Q?mCjDvonn/ntimTUhm47SREqO1rRG3uQ++xd97NM6a9PWTpV7sUH9WzIZngKi?= =?us-ascii?Q?SdwBJB9yJO0TNIrdjilw+DPBrPr5jmhnOtar+SYTG6+3ZeK2mJ3HUAc05Qd1?= =?us-ascii?Q?8pb/A6SDgfe2jKbgqKZYXpMhfOxxggSYECop1T5NWGb2WmLnq0rGDfyyWwHc?= =?us-ascii?Q?m8zTSgLTWceCsXBmZhHrrQ5WbgmAOWofHOqAeH1UFQAOrLPXTXDvAQlPFLSm?= =?us-ascii?Q?75+N0nG4HiuhPk15m8qUzqAyuQ5ALyfNGTQNmgrUvvRolJaU4qHAJwmiJ94q?= =?us-ascii?Q?fzDDCCSMYezruVRypyxCupZE6uLysiE10gwh4UKacoIFxfKgfrQinXu+xhlJ?= =?us-ascii?Q?YRfvP12GW7opWUo46CBluoJSvC91WJjDHl6hUNU1xeVnpVGk0LCcLqiIDmYA?= =?us-ascii?Q?zNDbe8if5HVXFKWNmrrDS8JTstJJq4aV5aGeZFUgI11lcNtNWAzWb+NdOCg0?= =?us-ascii?Q?o6amcrWA4dGZkkkk0CjIJsYYBDJ8Uv+q5Kg4Opuqm9aFPmWN1/a4pXJLiStv?= =?us-ascii?Q?EIewJHxih9izwA3amdDvNOMQxuwS1NqxdtVoq917Q4aNWtKGnZFPFmr7dHQH?= =?us-ascii?Q?6J+1TWVA+6hbGYCfRYJZvbsoGaBbD0ZgD2w5U9je0XGFIJwuxcDNqXyIlu7F?= =?us-ascii?Q?zqgDkG+dLpE6ICRSV9QFFcfIEOjUzFQuyQUKUUQ2a1Xxmqm6zPhX7B4riMSO?= =?us-ascii?Q?cAs1s1tfOjaYW/kgbIsu9gHCv1l1rKUTffzwmLaD?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3bd94cc-2118-4432-f03a-08dc3d212cae X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 14:33:07.4394 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3OOxcYidUDs9uw4w00blY6qVsoUnXhEcuUWxo04DxJ3oHwLn8qKH2NELIBP4kwaD X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6784 X-Rspamd-Queue-Id: B79E3180028 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 6ra1nqnct9c41sy3fh97cm6db89gzs74 X-HE-Tag: 1709649190-980670 X-HE-Meta: U2FsdGVkX196BFHp+hwGb0mklgzd7K0rbI5ZOCZwJbShDzicBhqVqgdcZPiaZ4tblp/I9vAXaJGCvcIJYhCgb23LTFMpElr1+5b9j/ZPpDXv1IUoLLXMx2XchbKqCBm8Vg9Rok/z+tX9KeoKX8kjmpUjctprayXegZ5gVP1Y8TTQTHoz9jtijpoEvOnx5ij2giNBi814/EhU6NsHg19INGb5flGdeTsS2jTtop5wdnsh+QQVZRnN7JkXxD8JK+gCzJ8Ql2mwTht2ED1uTOoKiO1zygNJ86gaXUFu0IG1bjrtP/guUj3b6vQzFJkkpQC/mlE5qtaLm7PxvfvNo357nQqlzcn7MKMM41aomcu/Gy/Mtm2+7E2ZHGAYnOqvRKlT+mI7nDn+lksgtnoit3rP1yMopZ3qve6dZPT5uK2iN2KSlyGN65eRxjWNZ6u1DsNYi5gWFvxBG4b3o+nIxMjNVDrpKk4shovCTkCBTnYWlW9JLGIGdcIkln5vQEmPl9S3BV6oIrl96c2C3I61p6DRnGqKg2tW9gHHO4brxbSRgPE5QCJFWtVUSp4SEJgM5S0BcmHyIiPY6hFUNeLSTYQrT1zytQes8LyP1DMRCDk7Gcb0P1nqSOEaTVJya1IpaNIjH9MQFMKHUZyC0oO9qpOYm3SmDckWW0p7VhGP3rdiRh37rUmDf+19ZHfgZ3vmVE+jHuK8rB4jkHS2Lj8XxJNkKYLCCWiTPE16ZNW23bv7s+7qBeLnxmlZIgPakgBw+NPXmRzMVnAADRNBrrcZPX7DU1PkNuV8mgn/lcXnqnMPu61pTv/mAf0MuLhwOyugsFttGzdvBXXv1ff+HVXvJVPKjyloGhx0qNQfd2af+VAf15xyfw3njbb2yQVQkyPaoe9PcaIPUHYoTMf3jIl9I+mQMR953spzcEOpvrvBVrlblpiZ3o5YPO5NoFZwhUsAyhOvsQH/TeCfGWlnb8/dQFP bcJ8GWoh c+zBH0t0RC/Qatkk1IkVO6BKEipOi50386zkkRM6W0eN5gs/ZxmeFN0zOXvOiJUzVg2Bh1sTUN1NK9+WHja5FIbmP4hE3k5o0hWRROuY6jAhw3ujBEZ2Go6wNfr4KNP0UnFHdJCr3xiD1Kz92+BsNbbO+b8hjdnj7HbkHVXgsMRuVGQSxtX3cm/eu8NOtEsxZ/H8krB1NkKB9eezfcPrefOcVlaWJ4lncs/ulS3xMzOnq1BfKWLgYN2MW90O/fG/RAHk6GhRadfnvcGDK5UtvJij13VY/m6LSEFOfSwmuMsHDE1U2yNrYJk0BOA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 05, 2024 at 12:37:50PM +0800, peterx@redhat.com wrote: > From: Peter Xu > > Even if pXd_leaf() API is defined globally, it's not clear on the retval, > and there are three types used (bool, int, unsigned log). > > Always return a boolean for pXd_leaf() APIs. > > Suggested-by: Jason Gunthorpe > Signed-off-by: Peter Xu > --- > arch/riscv/include/asm/pgtable-64.h | 2 +- > arch/riscv/include/asm/pgtable.h | 2 +- > arch/s390/include/asm/pgtable.h | 4 ++-- > arch/sparc/include/asm/pgtable_64.h | 4 ++-- > arch/x86/include/asm/pgtable.h | 8 ++++---- > include/linux/pgtable.h | 8 ++++---- > 6 files changed, 14 insertions(+), 14 deletions(-) Reviewed-by: Jason Gunthorpe Jason